Page MenuHomePhabricator

[backup-service] Improve blob client logging
ClosedPublic

Authored by bartek on Jan 25 2023, 2:35 AM.
Tags
None
Referenced Files
F3350230: D6387.diff
Fri, Nov 22, 9:27 PM
Unknown Object (File)
Sun, Nov 10, 2:00 PM
Unknown Object (File)
Fri, Nov 8, 5:02 AM
Unknown Object (File)
Fri, Nov 8, 4:52 AM
Unknown Object (File)
Fri, Nov 8, 3:06 AM
Unknown Object (File)
Fri, Nov 8, 3:06 AM
Unknown Object (File)
Fri, Nov 8, 3:06 AM
Unknown Object (File)
Fri, Nov 8, 3:06 AM
Subscribers

Details

Summary

Part of https://linear.app/comm/issue/ENG-2688/backup-service-reuse-single-blob-client-instance

Now these functions do not need to be async anymore. The connection errors are now handled inside the spawned Tokio task. I improved logging the connection error (it is now displayed immediately instead of finishing and waiting for the terminate() method to handle errors). Also, the start() signature can be simplified not to return Result

Depends on D6386

Test Plan

Ran backup service integration tests. Killed blob service. Ran tests again and checked if the erorr is handled as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable