Page MenuHomePhabricator

[web] Change import path and fix errors showing up when the typing is correct
ClosedPublic

Authored by inka on Feb 21 2023, 4:26 AM.
Tags
None
Referenced Files
F1441535: D6816.diff
Fri, Mar 29, 4:33 AM
Unknown Object (File)
Feb 21 2024, 12:47 PM
Unknown Object (File)
Feb 21 2024, 12:47 PM
Unknown Object (File)
Feb 21 2024, 12:47 PM
Unknown Object (File)
Feb 21 2024, 12:47 PM
Unknown Object (File)
Feb 21 2024, 12:47 PM
Unknown Object (File)
Feb 21 2024, 12:47 PM
Unknown Object (File)
Feb 20 2024, 3:34 PM
Subscribers

Details

Summary

As mentioned in D6812 the import has to be fixed. We use useSelector from web/redux/redux-utils.js on web, because it adds proper typing. This change broke this file, because we should not be
quering an object for a field it doesn't have. Thus the other changes.

Test Plan

Run web app, checked that Apps directory modal displays its items correclty.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 21 2023, 4:34 AM
Harbormaster failed remote builds in B16693: Diff 22826!
inka requested review of this revision.Feb 21 2023, 6:28 AM
This revision is now accepted and ready to land.Feb 24 2023, 2:25 AM
web/modals/apps/apps-directory-modal.react.js
40 ↗(On Diff #22938)

maybe I am missing context here but wondering we there is need to fix this that way, not eg. adding chat: true (because it's always enabled) to EnabledApps type, since chat is also an app?

web/modals/apps/apps-directory-modal.react.js
40 ↗(On Diff #22938)

Me and @tomek talked about this and inn result this task was created: https://linear.app/comm/issue/ENG-3061/discuss-making-redux-state-unaware-that-the-chat-tab-is-always-enabled

Generally we might want to add chat to the state, but maybe not as a true, but as a boolean, so that the redux doesn't know about the business-logic-specific fact - that the chat tab is always selected. But that also requires some more changes