Page MenuHomePhabricator

[web] Remove apps as a tab in code logic
ClosedPublic

Authored by inka on Feb 21 2023, 3:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 14, 2:55 AM
Unknown Object (File)
Mon, Mar 4, 11:55 AM
Unknown Object (File)
Wed, Feb 28, 12:45 PM
Unknown Object (File)
Feb 21 2024, 12:36 PM
Unknown Object (File)
Feb 21 2024, 12:36 PM
Unknown Object (File)
Feb 21 2024, 12:36 PM
Unknown Object (File)
Feb 21 2024, 12:36 PM
Unknown Object (File)
Feb 21 2024, 12:36 PM
Subscribers

Details

Summary

issue: https://linear.app/comm/issue/ENG-3044/change-apps-tab-to-be-a-modal
Since the apps tab is a modal (since D6812) the code logic that considers it a tab should be removed.
file lib/utils/url-utils.js was only used on web, so the changes don't influence native

Test Plan

Run flow check in web/. Searched for any occurences of 'apps' on web and checked that this is all that needs to be changed

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 21 2023, 4:02 AM
Harbormaster failed remote builds in B16691: Diff 22824!
This revision is now accepted and ready to land.Feb 22 2023, 5:33 AM