Page MenuHomePhabricator

[services][feature-flags] Parse feature flags response from DynamoDB
ClosedPublic

Authored by tomek on Feb 23 2023, 8:14 AM.
Tags
None
Referenced Files
F1432505: D6856.id23230.diff
Thu, Mar 28, 4:57 AM
F1432504: D6856.id23167.diff
Thu, Mar 28, 4:57 AM
F1432503: D6856.id23140.diff
Thu, Mar 28, 4:57 AM
F1432502: D6856.id23009.diff
Thu, Mar 28, 4:57 AM
F1432477: D6856.id.diff
Thu, Mar 28, 4:57 AM
F1432462: D6856.diff
Thu, Mar 28, 4:51 AM
Unknown Object (File)
Thu, Mar 28, 1:37 AM
Unknown Object (File)
Thu, Mar 7, 4:59 PM
Subscribers

Details

Summary

Parse the response into struct.

Depends on D6855

Test Plan

Tested with the next diffs.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek requested review of this revision.Feb 23 2023, 8:30 AM
services/feature-flags/src/database.rs
140 ↗(On Diff #23009)

IMO the underscore renames for _parse_xxx_attribute should be done in this diff because they're no longer unused. My motivation is to keep the number of underscores as minimal as possible for each diff.

Anyway I see they're renamed in the following diff and I'm OK with that too

This revision is now accepted and ready to land.Feb 24 2023, 2:00 AM
services/feature-flags/src/database.rs
140 ↗(On Diff #23009)

Never mind, I forgot that Rust displays warnings recursively for unused functions

services/feature-flags/src/database.rs
140 ↗(On Diff #23009)

That's correct - all the underscores were necessary. After introducing the shared lib, number of underscores was decreased, though.