Page MenuHomePhabricator

[native] render the rest of the user avatars
ClosedPublic

Authored by ginsu on Mar 14 2023, 2:03 PM.
Tags
None
Referenced Files
F1434061: D7069.id23945.diff
Thu, Mar 28, 8:18 AM
F1434060: D7069.id23940.diff
Thu, Mar 28, 8:18 AM
F1434059: D7069.id23899.diff
Thu, Mar 28, 8:18 AM
F1434058: D7069.id23851.diff
Thu, Mar 28, 8:18 AM
F1434056: D7069.id23738.diff
Thu, Mar 28, 8:18 AM
F1434012: D7069.id.diff
Thu, Mar 28, 8:17 AM
F1433988: D7069.diff
Thu, Mar 28, 8:13 AM
Unknown Object (File)
Fri, Mar 8, 1:34 AM
Subscribers

Details

Summary

Render the rest of the user avatars. Since the logic for rendering the remaining user avatars in our app was pretty similar, I decided to package it all in one diff


Depends on D7057

Linear Task: https://linear.app/comm/issue/ENG-3107/build-out-a-dummy-avatar-component-and-render-it-everywhere-we-will

Test Plan

Please look at the screenshots to see the changes I made:

Message reactions modal:

Screenshot 2023-03-14 at 5.07.33 PM.png (1×1 px, 795 KB)

Thread settings member:

Screenshot 2023-03-14 at 5.07.49 PM.png (1×1 px, 990 KB)

Typeahead tooltip:

Screenshot 2023-03-14 at 5.08.06 PM.png (1×1 px, 1 MB)

User list user:

Screenshot 2023-03-14 at 5.09.25 PM.png (1×1 px, 737 KB)

Screenshot 2023-03-14 at 5.08.50 PM.png (1×1 px, 745 KB)

Relationship list item:

Screenshot 2023-03-14 at 5.14.01 PM.png (1×1 px, 732 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu requested review of this revision.Mar 14 2023, 2:18 PM
This revision is now accepted and ready to land.Mar 15 2023, 1:53 PM

rebase after switching up diff stack order