[web-db] add metadata table operations
ClosedPublic
Actions

Authored by kamil on Mar 27 2023, 4:03 AM.

Details

Reviewers

michal
tomek
marcin
ashoat

Commits

rCOMM005ff6a137c5: [web-db] add metadata table operations

Summary

Native version: link;
On the web (for now) we will need this to set current_user_id - to somehow connect database with user, to decide when we should clear sensitive data.

NOTE: D7121 is not landed yet, and even so, my local environment is the only place where this code was executed so adding this without migration.

Depends on D7154

Test Plan

run tests D7181

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Mar 27 2023, 4:03 AM

kamil held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptMar 27 2023, 4:03 AM

fix query

kamil added a child revision: D7181: [web-db] add unit tests for metadata operations.Mar 27 2023, 4:15 AM

kamil edited the test plan for this revision. (Show Details)Mar 27 2023, 4:17 AM

Harbormaster completed remote builds in B17653: Diff 24160.Mar 27 2023, 4:19 AM

Harbormaster completed remote builds in B17654: Diff 24161.Mar 27 2023, 4:23 AM

kamil published this revision for review.Mar 27 2023, 5:02 AM

kamil added inline comments.

web/database/queries/metadata-queries.js
12 ↗	(On Diff #24161)	native version: link
25 ↗	(On Diff #24161)	native version: link
43 ↗	(On Diff #24161)	native version: link

ashoat accepted this revision.Mar 27 2023, 3:46 PM

ashoat added inline comments.

web/database/queries/metadata-queries.js
9 ↗	(On Diff #24161)	The question mark here means that either this is `{ name: string }` or `{ name: string, data: string }`, and that it CANNOT be `{ name: string, data: null }` (for instance) Other the other hand, if we said `data: ?string`, then it would be okay to be `{ name: string, data: null }`, but NOT okay to be `{ name: string }` Are you sure we're using the right one?
27 ↗	(On Diff #24161)	Nit: typically we give `FROM metadata` its own line

This revision is now accepted and ready to land.Mar 27 2023, 3:46 PM

fix type and query format

Harbormaster completed remote builds in B17805: Diff 24360.Mar 30 2023, 1:14 AM

kamil added inline comments.Mar 30 2023, 1:19 AM

web/database/queries/metadata-queries.js
9 ↗	(On Diff #24161)	I can not remember why the question mark is here so probably it's just a mistake. Based on the table definition in SQL the correct one is: type Metadata = { name: string, data: string, }