[identity] manage login state
ClosedPublic
Actions

Authored by varun on Apr 19 2023, 1:12 PM.

Details

Reviewers

• jon
bartek

Commits

rCOMMd5495172d5f8: [identity] manage login state

Summary

Updated the cache to handle both registration and login state

Depends on D7535

Test Plan

tested later with OPAQUE login workflow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Apr 19 2023, 1:12 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 19 2023, 1:12 PM

varun added a child revision: D7537: [identity] return user ID on login.Apr 19 2023, 1:15 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2023, 1:26 PM

Harbormaster failed remote builds in B18536: Diff 25400!

rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2023, 2:31 PM

Harbormaster failed remote builds in B18552: Diff 25417!

rebase

Harbormaster completed remote builds in B18585: Diff 25461.Apr 20 2023, 10:32 AM

varun requested review of this revision.Apr 20 2023, 10:32 AM

• jon requested changes to this revision.Apr 20 2023, 10:55 AM

• jon added inline comments.

services/identity/src/client_service.rs
40–50	Remove the middle-man?

This revision now requires changes to proceed.Apr 20 2023, 10:55 AM

Nevermind, the struct is used to also hold the login state later on.

This revision is now accepted and ready to land.Apr 20 2023, 10:58 AM

bartek accepted this revision.Apr 21 2023, 2:29 AM

bartek added inline comments.

services/identity/src/client_service.rs
40–50	I think the "middle-man" makes the code more "structured" and extensible in the future

Closed by commit rCOMMd5495172d5f8: [identity] manage login state (authored by varun). · Explain WhyApr 21 2023, 11:40 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMd5495172d5f8: [identity] manage login state.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

client_service.rs

31 lines

database.rs

36 lines

Diff 25461

View Options

services/identity/src/client_service.rs