Paths

Table of Contentst

Differential D7610

[Tunnelbroker] Add initial websocket connection support and connection map
ClosedPublic
Actions

Authored by • jon on Apr 25 2023, 8:56 AM.

Tags

None

Referenced Files

	F1584512: D7610.diff
	Fri, Apr 19, 3:10 AM

	Unknown Object (File)
	Thu, Apr 18, 1:22 AM

	Unknown Object (File)
	Tue, Apr 16, 1:23 PM

	Unknown Object (File)
	Mon, Apr 15, 5:48 PM

	Unknown Object (File)
	Mon, Apr 15, 12:57 AM

	Unknown Object (File)
	Sun, Apr 14, 7:58 AM

	Unknown Object (File)
	Sat, Apr 13, 11:56 PM

	Unknown Object (File)
	Sat, Apr 13, 1:15 AM

View All 82 Files

Subscribers

Details

Reviewers

varun
bartek

Commits

rCOMMd51b1f099fd1: [Tunnelbroker] Add initial websocket connection support and connection map

Summary

Add simple websocket implementation which can be used to easily onboard
keyserver support.

Part of:

Test Plan

cd services/tunnelbroker
cargo run

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Apr 25 2023, 8:56 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 25 2023, 8:56 AM

Harbormaster completed remote builds in B18742: Diff 25680.Apr 25 2023, 9:15 AM

• jon requested review of this revision.Apr 25 2023, 9:15 AM

bartek accepted this revision.Apr 26 2023, 6:20 AM

bartek added inline comments.

services/tunnelbroker/Cargo.toml
30–33 ↗	(On Diff #25680)	Nit: IIRC we agreed sometime ago to omit the patch version numbers and keep major.minor only (and most of the previous deps stick to this rule). However, due to Cargo resolution rules, I don't think it matters much. BTW. it would be nice to keep them sorted alphabetically ;)

This revision is now accepted and ready to land.Apr 26 2023, 6:20 AM

Use only major.minor for versions.

Alphabetize crates

• jon added a child revision: D7659: [Tunnelbroker] Remove references to cxx.Apr 27 2023, 7:07 AM

• jon marked an inline comment as done.

• jon added inline comments.

services/tunnelbroker/Cargo.toml
30–33 ↗	(On Diff #25680)	oh yea, `cargo add` does this behavior by default

Harbormaster completed remote builds in B18864: Diff 25833.Apr 27 2023, 7:19 AM

Closed by commit rCOMMd51b1f099fd1: [Tunnelbroker] Add initial websocket connection support and connection map (authored by • jon). · Explain WhyApr 27 2023, 8:59 AM

This revision was automatically updated to reflect the committed changes.

• jon marked an inline comment as done.

• jon added a commit: rCOMMd51b1f099fd1: [Tunnelbroker] Add initial websocket connection support and connection map.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

25 lines

src/

8 lines

websockets/

68 lines

shared/

tunnelbroker_messages/

src/

messages/

8 lines

Diff 25833

services/tunnelbroker/Cargo.lock

Loading...

services/tunnelbroker/Cargo.toml

Loading...

services/tunnelbroker/src/main.rs

Loading...

services/tunnelbroker/src/websockets/mod.rs

Loading...

shared/tunnelbroker_messages/src/messages/mod.rs

Loading...