Page MenuHomePhabricator
Differential D7694

[native] register user on native (rust changes)
ClosedPublic
Actions

Authored by varun on May 1 2023, 7:24 AM.
Tags
None
Referenced Files
F1587343: D7694.diff
Fri, Apr 19, 6:44 AM
Unknown Object (File)
Thu, Apr 4, 10:52 PM
Unknown Object (File)
Thu, Apr 4, 10:52 PM
Unknown Object (File)
Thu, Apr 4, 10:52 PM
Unknown Object (File)
Thu, Apr 4, 10:52 PM
Unknown Object (File)
Thu, Apr 4, 10:51 PM
Unknown Object (File)
Thu, Apr 4, 10:44 PM
Unknown Object (File)
Mar 5 2024, 8:26 AM
View All 40 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
• jon
bartek
Commits
rCOMMbf0a8c3d1ca3: [native] register user on native (rust changes)
Summary

add register_user function to native rust library

Test Plan

tested in subsequent diff

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.May 1 2023, 7:24 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 1 2023, 7:24 AM
Harbormaster completed remote builds in B18954: Diff 25964.May 1 2023, 7:42 AM
varun requested review of this revision.May 1 2023, 7:42 AM
varun added a child revision: D7695: [native] register user on native (C++ changes).May 1 2023, 7:46 AM
• jon requested changes to this revision.May 1 2023, 11:55 AM
• jon added inline comments.
native/native_rust_library/src/lib.rs
222 ↗(On Diff #25964)

please rebase, this should be content keys

This revision now requires changes to proceed.May 1 2023, 11:55 AM
varun updated this revision to Diff 26015.May 2 2023, 12:25 PM

rebase

varun updated this revision to Diff 26016.May 2 2023, 12:39 PM

rename identity -> content

Harbormaster completed remote builds in B18995: Diff 26015.May 2 2023, 12:45 PM
Harbormaster completed remote builds in B18996: Diff 26016.May 2 2023, 12:59 PM
• jon accepted this revision.May 2 2023, 5:40 PM
This revision is now accepted and ready to land.May 2 2023, 5:40 PM
Closed by commit rCOMMbf0a8c3d1ca3: [native] register user on native (rust changes) (authored by varun). · Explain WhyMay 3 2023, 2:02 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMbf0a8c3d1ca3: [native] register user on native (rust changes).

Revision Contents
Changeset List

PathSize
native/
native_rust_library/
2 lines
src/
16 lines
129 lines

Diff 26015

View Options

native/native_rust_library/Cargo.lock

Loading...
View Options

native/native_rust_library/Cargo.toml

Loading...
View Options

native/native_rust_library/src/identity_client.rs

Loading...
View Options

native/native_rust_library/src/lib.rs

Loading...