Page MenuHomePhabricator

[native] Add search button to chat header
ClosedPublic

Authored by inka on May 10 2023, 3:59 AM.
Tags
None
Referenced Files
F1430800: D7777.id.diff
Wed, Mar 27, 11:53 PM
Unknown Object (File)
Sat, Mar 16, 11:48 PM
Unknown Object (File)
Sun, Mar 3, 4:24 AM
Unknown Object (File)
Feb 18 2024, 5:30 AM
Unknown Object (File)
Feb 18 2024, 4:11 AM
Unknown Object (File)
Feb 18 2024, 3:50 AM
Unknown Object (File)
Feb 18 2024, 3:11 AM
Unknown Object (File)
Feb 18 2024, 3:06 AM
Subscribers

Details

Summary
Test Plan

Opened a chat, pressed on the button, checked that is navigates to the search screen

Diff Detail

Repository
rCOMM Comm
Branch
inka/search_backend
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka requested review of this revision.May 10 2023, 4:18 AM
native/chat/chat.react.js
238 ↗(On Diff #26334)

Is disabling lint here necessary?

Address review

native/chat/chat.react.js
240

@kuba is this better?

native/chat/chat.react.js
222

There is no reason to define a new version of this on every function invocation. Please move it outside of messageListOptions

Move headerRightStyle out

kamil added inline comments.
native/search/search-messages-button.react.js
22–28 ↗(On Diff #26507)

shouldn't we wrap this in React.useCallback?

This revision is now accepted and ready to land.May 17 2023, 3:43 AM