Page MenuHomePhabricator

[native] Add `enumCell` layout/styling to `CommunityConfiguration`
ClosedPublic

Authored by atul on May 24 2023, 12:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 5, 11:47 PM
Unknown Object (File)
Tue, Mar 5, 11:47 PM
Unknown Object (File)
Tue, Mar 5, 11:46 PM
Unknown Object (File)
Tue, Mar 5, 9:20 PM
Unknown Object (File)
Tue, Mar 5, 9:20 PM
Unknown Object (File)
Feb 20 2024, 5:05 AM
Unknown Object (File)
Feb 20 2024, 12:08 AM
Unknown Object (File)
Feb 19 2024, 10:54 PM
Subscribers

Details

Summary

We want something similar to EnumSettingsOption on web for native so we can use it in CommunityConfiguration to match designs: https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?type=design&node-id=11731-270974&t=FY25j6NZvAs5ly4w-4

For now we're just laying things out, the checkbox is not functional. Checkbox will be made functional in next diff. Will also probably pull out some sort of EnumSettingsOption equivalent for native.

Test Plan

Looks as expected:

Simulator Screenshot - Fresh iPhone 14 Pro - 2023-05-24 at 15.05.38.png (2×1 px, 137 KB)

Simulator Screenshot - Fresh iPhone 14 Pro - 2023-05-24 at 15.05.25.png (2×1 px, 138 KB)

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D7967 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul published this revision for review.May 24 2023, 12:18 PM
atul added a subscriber: ted.
atul added inline comments.
native/community-creation/community-configuration.react.js
173 ↗(On Diff #27013)

This doesn't look great in light mode (not enough contrast IMO), would be good to get @ted's feedback on this when he's back

native/community-creation/community-configuration.react.js
173 ↗(On Diff #27013)
This revision is now accepted and ready to land.May 24 2023, 4:08 PM