Page MenuHomePhabricator

[lib] extract local id field before sending report
ClosedPublic

Authored by kamil on May 22 2023, 6:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 20 2024, 12:11 AM
Unknown Object (File)
Feb 19 2024, 10:55 PM
Unknown Object (File)
Feb 19 2024, 9:28 PM
Unknown Object (File)
Feb 19 2024, 9:07 PM
Unknown Object (File)
Feb 19 2024, 5:25 PM
Unknown Object (File)
Feb 19 2024, 4:19 PM
Unknown Object (File)
Feb 19 2024, 12:41 PM
Unknown Object (File)
Jan 20 2024, 1:33 PM
Subscribers

Details

Summary

This field is needed only on client, also by this we're making sure that request validation on server will not fail.

Depends on D7909

Test Plan

Attach id field to report and try sending this and see if it's properly validated on keyserver.

Diff Detail

Repository
rCOMM Comm
Branch
land-rs
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.May 23 2023, 1:36 AM
tomek added inline comments.
lib/actions/report-actions.js
42–46 ↗(On Diff #26777)

Using term raw might be confusing, as it has a special meaning in our codebase. How about clientReport vs serverReport?

This revision is now accepted and ready to land.May 23 2023, 3:12 AM

rename variable

lib/actions/report-actions.js
42–46 ↗(On Diff #26777)

fair point

move code directly to migration