Page MenuHomePhabricator
Differential D8609

[lib/native/web] convert useInlineEngagementText to getInlineEngagmentSidebarText
ClosedPublic
Actions

Authored by ginsu on Jul 24 2023, 4:22 PM.
Tags
None
Referenced Files
F3388253: D8609.id28980.diff
Fri, Nov 29, 1:22 PM
F3388252: D8609.id29359.diff
Fri, Nov 29, 1:22 PM
F3388019: D8609.diff
Fri, Nov 29, 12:20 PM
Unknown Object (File)
Tue, Nov 26, 3:36 AM
Unknown Object (File)
Sat, Nov 23, 6:54 PM
Unknown Object (File)
Sat, Nov 23, 4:18 PM
Unknown Object (File)
Sat, Nov 23, 4:18 PM
Unknown Object (File)
Oct 28 2024, 5:36 AM
View All 82 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM9c5f41a61b9b: [lib/native/web] convert useInlineEngagementText to…
Summary

Small move/rename diff to convert this hook into a general function. This "hook" was not using any react features so this really should just be a function

Depends on D8600

Test Plan

flow and confirmed that native and web apps work fine

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Jul 24 2023, 4:22 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 24 2023, 4:22 PM
ginsu edited the summary of this revision. (Show Details)Jul 24 2023, 4:22 PM
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D8600: [native] show which reactions the viewer has already selected in the inline engagement.
ginsu edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B21158: Diff 28980.Jul 24 2023, 4:39 PM
ginsu requested review of this revision.Jul 24 2023, 4:39 PM
ginsu added a child revision: D8610: [native] introduce DummyInlineEngagementNode.Jul 24 2023, 7:44 PM
atul accepted this revision.Jul 24 2023, 11:11 PM

Looks straightforward

This revision is now accepted and ready to land.Jul 24 2023, 11:11 PM
ginsu updated this revision to Diff 29309.Jul 31 2023, 11:40 AM

rebase before landing

This revision was landed with ongoing or failed builds.Jul 31 2023, 1:19 PM
Closed by commit rCOMM9c5f41a61b9b: [lib/native/web] convert useInlineEngagementText to… (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM9c5f41a61b9b: [lib/native/web] convert useInlineEngagementText to….
Harbormaster completed remote builds in B21397: Diff 29309.Jul 31 2023, 2:33 PM

Revision Contents
Changeset List

PathSize
lib/
hooks/
shared/
hooks/
inline-engagement-utils.js
inline-engagement-text.react.js
4 lines
native/
chat/
4 lines
web/
chat/
4 lines

Diff 29359

View Options

lib/hooks/inline-engagement-text.react.js

Loading...
View Options

lib/shared/inline-engagement-utils.js

Loading...
View Options

native/chat/inline-engagement.react.js

Loading...
View Options

web/chat/inline-engagement.react.js

Loading...