[identity] helper functions to interact with nonces table
ClosedPublic
Actions

Authored by varun on Aug 15 2023, 8:49 PM.

Details

Reviewers

• jon
bartek

Commits

rCOMMcaa2afbd43be: [identity] helper functions to interact with nonces table

Summary

we need to be able to get and remove nonces from the nonces table.

Test Plan

added a nonce to the nonces table. then inspected it with the get method and deleted it with the remove method.

Diff Detail

Repository

rCOMM Comm

Branch

wallet_login (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Aug 15 2023, 8:49 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 15 2023, 8:49 PM

Harbormaster completed remote builds in B21778: Diff 29932.Aug 15 2023, 9:07 PM

varun requested review of this revision.Aug 15 2023, 9:07 PM

varun added a child revision: D8830: [identity] add ttl to nonces tables.Aug 16 2023, 12:20 AM

bartek accepted this revision.Aug 16 2023, 5:26 AM

bartek added inline comments.

services/identity/src/database.rs
829	Nit: I consider `impl Into<String>` a bit more flexible ;) Up to you
835	This is regarding above nit
840–843	Nit - we can do it this way too

This revision is now accepted and ready to land.Aug 16 2023, 5:26 AM

Closed by commit rCOMMcaa2afbd43be: [identity] helper functions to interact with nonces table (authored by varun). · Explain WhyAug 16 2023, 1:39 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMcaa2afbd43be: [identity] helper functions to interact with nonces table.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database.rs

53 lines

error.rs

2 lines

Diff 29932

View Options

services/identity/src/database.rs