Paths

Table of Contentst

[services-lib] Make DB attribute names non-static
ClosedPublic
Actions

Authored by bartek on Aug 10 2023, 3:33 PM.

Details

Reviewers

michal
• jon
varun

Commits

rCOMMff30037d57c5: [services-lib] Make DB attribute names non-static

Summary

Similiar to D8627 but in comm-services-lib. The difference is that I used impl Into<String> to add some flexibility

Test Plan

Following bash one-liner:

cd services
for r in "comm-services-lib" "backup" "blob" "feature-flags"; do pushd $r; cargo check --all-features; popd; done

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Aug 10 2023, 3:33 PM

bartek held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptAug 10 2023, 3:33 PM

Herald added subscribers: tomek, ashoat. · View Herald Transcript

bartek added a child revision: D8789: [services-lib] Add DDB Attribute conversion traits.Aug 10 2023, 3:41 PM

Harbormaster completed remote builds in B21705: Diff 29830.Aug 10 2023, 3:50 PM

bartek published this revision for review.Aug 11 2023, 2:21 AM

bartek added a reviewer: varun.

michal accepted this revision.Aug 11 2023, 4:12 AM

This revision is now accepted and ready to land.Aug 11 2023, 4:12 AM

Closed by commit rCOMMff30037d57c5: [services-lib] Make DB attribute names non-static (authored by bartek). · Explain WhyAug 16 2023, 7:25 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMff30037d57c5: [services-lib] Make DB attribute names non-static.

Revision Contents
Changeset List

Path

Size

services/

blob/

src/

database/

types.rs

2 lines

comm-services-lib/

src/

database.rs

49 lines

Diff 29958

View Options

services/blob/src/database/types.rs