Paths

Table of Contentst

Differential D8914

[native] introduce user profile component
ClosedPublic
Actions

Authored by ginsu on Aug 22 2023, 9:19 AM.

Tags

None

Referenced Files

	F3385197: D8914.id30446.diff
	Thu, Nov 28, 11:36 PM

	Unknown Object (File)
	Mon, Nov 25, 9:57 AM

	Unknown Object (File)
	Mon, Nov 25, 9:24 AM

	Unknown Object (File)
	Mon, Nov 25, 7:50 AM

	Unknown Object (File)
	Thu, Nov 21, 7:26 AM

	Unknown Object (File)
	Thu, Nov 21, 7:26 AM

	Unknown Object (File)
	Thu, Nov 21, 7:26 AM

	Unknown Object (File)
	Thu, Nov 21, 7:26 AM

View All 65 Files

Subscribers

Details

Reviewers

atul
inka

Commits

rCOMM1fe7cfc2a30b: [native] introduce user profile component

Summary

This diff introduces the barebones UserProfile component. Right now we only have the user avatar and the username, but in subsequent diffs we will be adding to this component with the various other parts needed for the profile.

Here is what the designs look like:

Screenshot 2023-08-22 at 12.26.37 PM.png (1×582 px, 97 KB)

Depends on D8914

Test Plan

Please see screenshot below

Screenshot 2023-08-22 at 12.22.28 PM.png (1×1 px, 780 KB)

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Aug 22 2023, 9:19 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 22 2023, 9:19 AM

ginsu edited the summary of this revision. (Show Details)Aug 22 2023, 9:24 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu added inline comments.

native/components/user-profile.react.js
13	This type will probably be updated in a subsequent diff, but using this as a placeholder for now until I get a better idea of what the final `UserProfile` component will look like

ginsu attached a referenced file: F703826: Screenshot 2023-08-22 at 12.22.28 PM.png. (Show Details)Aug 22 2023, 9:26 AM

ginsu edited the summary of this revision. (Show Details)

ginsu attached a referenced file: F703828: Screenshot 2023-08-22 at 12.26.37 PM.png. (Show Details)

Harbormaster completed remote builds in B22022: Diff 30235.Aug 22 2023, 9:37 AM

ginsu requested review of this revision.Aug 22 2023, 9:37 AM

ginsu added a child revision: D8915: [native] introduce copy username functionality to user profiles.Aug 22 2023, 9:39 AM

Looks clean

This revision is now accepted and ready to land.Aug 26 2023, 4:34 PM

rebase before landing

Harbormaster completed remote builds in B22175: Diff 30446.Aug 28 2023, 8:32 AM

Closed by commit rCOMM1fe7cfc2a30b: [native] introduce user profile component (authored by ginsu). · Explain WhyAug 28 2023, 9:05 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM1fe7cfc2a30b: [native] introduce user profile component.

Revision Contents
Changeset List

Path

Size

native/

components/

user-profile.react.js

78 lines

Diff 30235

native/components/user-profile.react.js

Loading...