Page MenuHomePhabricator

[lib] Add branching to `reduceThreadInfos` to accomodate `RawThreadInfos`
ClosedPublic

Authored by atul on Dec 8 2023, 12:43 PM.
Tags
None
Referenced Files
F3390950: D10274.id34668.diff
Sat, Nov 30, 1:40 AM
F3390778: D10274.diff
Sat, Nov 30, 12:59 AM
Unknown Object (File)
Tue, Nov 12, 6:07 PM
Unknown Object (File)
Wed, Nov 6, 2:39 PM
Unknown Object (File)
Tue, Nov 5, 9:51 PM
Unknown Object (File)
Tue, Nov 5, 9:45 PM
Unknown Object (File)
Oct 15 2024, 9:51 PM
Unknown Object (File)
Oct 15 2024, 9:51 PM
Subscribers
None

Details

Summary

Pretty straightforward branching on .minimallyEncoding to appease flow. The amount of cut/paste here is very excessive. I'm just trying to get to 0 flow issues first, and then will come back and refactor these as best as possible.

Probably won't land any diffs in this stack until all the flow branching has been tidied up as much as possible.

[skip-ci]


Depends on D10272

Test Plan

CI/flow/etc.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul requested review of this revision.Dec 8 2023, 12:43 PM
atul created this revision.
ashoat requested changes to this revision.Dec 11 2023, 8:48 PM
ashoat added inline comments.
lib/reducers/thread-reducer.js
173–226 ↗(On Diff #34453)

Most of this doesn't need to be copy-pasted

394–448 ↗(On Diff #34453)

I suspect same here

463–509 ↗(On Diff #34453)

And here

This revision now requires changes to proceed.Dec 11 2023, 8:48 PM

will address these flow refactors at the end of the stack.

totally realize it would be better to update diff where the change was introduced, but it's a little tricky here because we have flow issues at this part of the stack. it's easier to make these noop refactors at the end of the stack where we have 0 flow issues as a baseline.

initially tried making changes here, but unintentionally introduced flow issues that appeared later in the stack

Before landing, can you link the diff where it's addressed, or a Linear task that tracks it? (Linear task must make explicit mention of these diff comments)

This revision is now accepted and ready to land.Dec 14 2023, 9:45 AM

Before landing, can you link the diff where it's addressed, or a Linear task that tracks it? (Linear task must make explicit mention of these diff comments)

https://linear.app/comm/issue/ENG-6070/tidy-up-flow-branching-from-minimal-permissions-work