Paths

Table of Contentst

Differential D10562

[web] fix button tertiary colors
ClosedPublic
Actions

Authored by ginsu on Jan 7 2024, 11:43 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 3, 5:10 AM

	Unknown Object (File)
	Sun, Nov 3, 5:10 AM

	Unknown Object (File)
	Sun, Nov 3, 5:10 AM

	Unknown Object (File)
	Sun, Nov 3, 5:10 AM

	Unknown Object (File)
	Sun, Nov 3, 5:10 AM

	Unknown Object (File)
	Oct 19 2024, 6:09 AM

	Unknown Object (File)
	Oct 12 2024, 10:51 AM

	Unknown Object (File)
	Sep 14 2024, 11:02 PM

View All 55 Files

Subscribers

Details

Reviewers

atul
inka

Commits

rCOMM3a12b8fa709c: [web] fix button tertiary colors

Summary

I made some small errors with the button tertiary colors that got caught in D10549 and ENG-6353, where I created two identical color variables for --button-label-tertiary-default + --button-label-secondary-defaul and I misspelled tertiary for --button-background-tetirary-hover. This diff addresses both of those mistakes

Test Plan

flow + confirmed there were no regressions

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Jan 7 2024, 11:43 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 7 2024, 11:43 PM

ginsu edited the summary of this revision. (Show Details)Jan 7 2024, 11:46 PM

ginsu added reviewers: atul, inka.

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 8 2024, 12:11 AM

Harbormaster failed remote builds in B25570: Diff 35337!

will make sure ci passes before landing

inka accepted this revision.Jan 9 2024, 5:14 AM

This revision is now accepted and ready to land.Jan 9 2024, 5:14 AM

rebase to make sure ci passes before landing

Harbormaster completed remote builds in B25706: Diff 35547.Jan 11 2024, 10:29 AM

Closed by commit rCOMM3a12b8fa709c: [web] fix button tertiary colors (authored by ginsu). · Explain WhyJan 11 2024, 10:33 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM3a12b8fa709c: [web] fix button tertiary colors.

Revision Contents
Changeset List

Path

Size

web/

community-header/

community-header-button.css

4 lines

8 lines

Diff 35547

web/community-header/community-header-button.css

Loading...

web/theme.css

Loading...