Page MenuHomePhabricator

[lib] Allow getNamesForAddresses to be called without ReverseRecords smart contract
ClosedPublic

Authored by ashoat on Mar 29 2024, 7:39 PM.
Tags
None
Referenced Files
F3390827: D11487.id38568.diff
Sat, Nov 30, 1:05 AM
F3390302: D11487.diff
Fri, Nov 29, 11:13 PM
Unknown Object (File)
Wed, Nov 13, 12:45 AM
Unknown Object (File)
Tue, Nov 12, 10:55 PM
Unknown Object (File)
Fri, Nov 8, 10:51 AM
Unknown Object (File)
Fri, Nov 8, 9:00 AM
Unknown Object (File)
Oct 18 2024, 6:25 PM
Unknown Object (File)
Oct 18 2024, 6:25 PM
Subscribers

Details

Summary

The ReverseRecords smart contract is deployed on mainnet and on Goerli, but not on Sepolia.

As a result, we can no longer use it from our unit tests, which have to be moved from Goerli to Sepolia.

To make getNamesForAddresses still work for the unit tests, I added a fallback that just does multiple single-record lookups.

More details on alternatives I considered in part 3 of this task description.

Depends on D11486

Test Plan

In combination with the next diff, I manually ran ALCHEMY_API_KEY=key yarn test utils/ens-cache.test.js and confirmed no errors resulted

Note that Buildkite CI doesn't run this particular test because we never built the plumbing to have the ALCHEMY_API_KEY accessible from there. GitHub Actions CI does run this test

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage