Page MenuHomePhabricator

[lib] Switch to Sepolia for ENSCache unit tests
ClosedPublic

Authored by ashoat on Mar 29 2024, 7:38 PM.
Tags
None
Referenced Files
F3350130: D11486.diff
Fri, Nov 22, 8:53 PM
Unknown Object (File)
Wed, Nov 13, 6:52 AM
Unknown Object (File)
Wed, Nov 13, 5:28 AM
Unknown Object (File)
Tue, Nov 12, 10:08 PM
Unknown Object (File)
Oct 18 2024, 6:25 PM
Unknown Object (File)
Oct 18 2024, 6:25 PM
Unknown Object (File)
Oct 18 2024, 6:23 PM
Unknown Object (File)
Oct 11 2024, 10:34 AM
Subscribers

Details

Summary

In order to switch the tests, I actually had to recreate the same on-chain data in the Sepolia testnet that I had already created in the Goerli testnet.

I wasn't able to find a Sepolia NFT "faucet" similar to the one I had found for Goerli. I ended up having to use a slightly different one that created an NFT with an HTTP URL instead of an SVG URI.

After this change, some tests are still failing. They'll be fixed in the next diff.

Depends on D11485

Test Plan

In combination with the next diff, I manually ran ALCHEMY_API_KEY=key yarn test utils/ens-cache.test.js and confirmed no errors resulted

Note that Buildkite CI doesn't run this particular test because we never built the plumbing to have the ALCHEMY_API_KEY accessible from there. GitHub Actions CI does run this test

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 29 2024, 7:55 PM
Harbormaster failed remote builds in B27834: Diff 38567!

Looks like the Buildkite CI actually is running the ENSCache tests somehow? Anyways, the tests aren't supposed to pass until the next diff, and they do appear to be passing there

This revision is now accepted and ready to land.Apr 1 2024, 9:14 AM
This revision was landed with ongoing or failed builds.Apr 1 2024, 10:10 AM
This revision was automatically updated to reflect the committed changes.