[native] handle successful connection from connect farcaster bottom sheet
ClosedPublic
Actions

Authored by ginsu on Apr 9 2024, 10:04 AM.

Details

Reviewers

atul
inka

Commits

rCOMMd7827e8b38e1: [native] handle successful connection from connect farcaster bottom sheet

Summary

In this diff we handle successfully connecting to farcaster from the connect farcaster bottom sheet. The behavior for this is to set the fid in the fid context and then close the bottomsheet.

cc @will who is working on updating all FIDProvider usages with synced metadata store (https://linear.app/comm/issue/ENG-7590/replace-all-fidprovider-usages-with-synced-metadata-store)

Linear task: https://linear.app/comm/issue/ENG-7520/introduce-onpressconnectfarcastercallback

Depends on D11597

Test Plan

Please see the demo video below

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 9 2024, 10:04 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 9 2024, 10:04 AM

ginsu edited the summary of this revision. (Show Details)Apr 9 2024, 10:09 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D11597: [native] flip farcaster prompt based on fid prop instead of context.

ginsu attached a referenced file: F1505831: RPReplay_Final1712609452.MP4. (Show Details)

ginsu edited the summary of this revision. (Show Details)

ginsu added a subscriber: will.

ginsu added inline comments.Apr 9 2024, 10:14 AM

native/components/connect-farcaster-bottom-sheet.react.js
72 ↗	(On Diff #38949)	Calling the `close()` method for this bottomsheet in this `useEffect` is intentional. `onSuccessfulConnect` will be called immediately once the user still signs in, even if they are still on warpcast. This causes some janky animation where if the user is slow to going back to Comm the bottom sheet will all of a sudden disappear. This `useEffect` will ensure that the bottom sheet will only close as soon as the `fid` was successfully set AND the user has returned to Comm

ginsu attached a referenced file: F1505874: RPReplay_Final1712609509.MP4. (Show Details)Apr 9 2024, 10:14 AM

ginsu retitled this revision from handle successful connection from connect farcaster bottom sheet to [native] handle successful connection from connect farcaster bottom sheet.

ginsu added a child revision: D11567: [lib/native/web] introduce alert types.

Harbormaster completed remote builds in B28095: Diff 38949.Apr 9 2024, 10:19 AM

ginsu requested review of this revision.Apr 9 2024, 10:19 AM

atul accepted this revision.Apr 9 2024, 10:24 PM

This revision is now accepted and ready to land.Apr 9 2024, 10:24 PM

ashoat added inline comments.Apr 10 2024, 8:32 AM

native/components/connect-farcaster-bottom-sheet.react.js
61 ↗	(On Diff #38949)	What is the point of defining this callback?

ginsu added inline comments.Apr 10 2024, 10:09 AM

native/components/connect-farcaster-bottom-sheet.react.js
61 ↗	(On Diff #38949)	Thought it would be easier to read + easier to modify the logic if we ever wanted to extend this callback; however, can also just pass `setFID` directly into `FarcasterWebView` if that is what is preferred

ashoat added inline comments.Apr 10 2024, 10:17 AM

native/components/connect-farcaster-bottom-sheet.react.js
61 ↗	(On Diff #38949)	I'm okay either way, but would probably lean towards using `setFID` directly, unless you have plans to extend the callback already