Page MenuHomePhabricator

[native] Handle rendering "No messages" inside MessagePreview
ClosedPublic

Authored by ashoat on Wed, Oct 30, 11:43 AM.
Tags
None
Referenced Files
F3352153: D13825.diff
Sat, Nov 23, 4:48 AM
F3352021: D13825.id45540.diff
Sat, Nov 23, 4:24 AM
F3351532: D13825.diff
Sat, Nov 23, 2:18 AM
Unknown Object (File)
Thu, Nov 21, 12:16 PM
Unknown Object (File)
Thu, Nov 21, 12:15 PM
Unknown Object (File)
Sat, Nov 16, 6:29 AM
Unknown Object (File)
Thu, Nov 14, 7:00 PM
Unknown Object (File)
Thu, Nov 14, 6:45 PM
Subscribers
None

Details

Summary

This matches behavior on web and makes a later diff a bit cleaner.

Depends on D13824

Test Plan

Flow, and tested in combination with the rest of the stack:

  1. Make sure membership operations (user joining / leaving) don't appear in MessagePreview
  2. Make sure reactions to the viewer's messages still appear in MessagePreview
  3. Make sure reactions to other user's messages don't appear in MessagePreview
  4. Test fresh login to thread with only one message in the last 14 days, which is a reaction to a non-viewer message. Make sure the reaction initially appears in MessagePreview, but then is replaced after more messages are fetched by the client

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable