Details

Reviewers

Commits

rCOMM1490b842faf6: [keyserver] new fetchPrivilegedThreadInfos function

Summary

unlike fetchThreadInfos, this function does not filter out threads that are inaccessible to the given user

Depends on D13851

we need this function to get all the threadInfos for community root threads. we'll use this data on clients to populate a directory of communities for users to join

Test Plan

successfully got back threadInfos for all threads when calling responder in next diff

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Thu, Oct 31, 10:42 PM

Herald added a subscriber: tomek. · View Herald TranscriptThu, Oct 31, 10:42 PM

varun added a child revision: D13853: [keyserver] add know_of permission if viewer.isScriptViewer.Thu, Oct 31, 10:46 PM

Harbormaster completed remote builds in B32504: Diff 45568.Thu, Oct 31, 10:58 PM

varun requested review of this revision.Thu, Oct 31, 10:58 PM

This won't work without addressing the KNOW_OF issue

This revision now requires changes to proceed.Fri, Nov 1, 8:32 AM

new approach without using script viewer

make param read only

Harbormaster failed remote builds in B32681: Diff 45843!Fri, Nov 15, 10:25 AM

Don't love that we're artifically inserting a permission that doesn't exist. Is it truly necessary?

lib/shared/thread-utils.js
764 ↗	(On Diff #45843)	If my comment below makes sense, I think we should rename this to something like `dontFilterMissingKnowOf`, to make it clear that it affects the filtering behavior
887–889 ↗	(On Diff #45843)	Instead of artificially adding a `KNOW_OF` permission that doesn't exist, can't we just skip this check here?