Paths

Table of Contentst

Differential D13836

[backup-client] refactor `SIWEBackupData` type
ClosedPublic
Actions

Authored by kamil on Thu, Oct 31, 4:44 AM.

Tags

None

Referenced Files

	F3387814: D13836.id45667.diff
	Fri, Nov 29, 11:17 AM

	F3386929: D13836.id.diff
	Fri, Nov 29, 6:50 AM

	Unknown Object (File)
	Wed, Nov 27, 11:09 AM

	Unknown Object (File)
	Tue, Nov 26, 5:55 AM

	Unknown Object (File)
	Fri, Nov 22, 11:55 AM

	Unknown Object (File)
	Wed, Nov 20, 4:00 AM

	Unknown Object (File)
	Tue, Nov 12, 4:39 PM

	Unknown Object (File)
	Mon, Nov 11, 12:11 PM

View All 25 Files

Subscribers

Details

Reviewers

varun
bartek

Commits

rCOMM3aff4e035708: [backup-client] refactor `SIWEBackupData` type

Summary

Move retrieving SIWEBackupData to a util funtion - it will be needed later in the stack
Move types to proper places on JS side
Add comment keep types in sync
Add validation on JS side
Remove siwe_backup_msg - it's not needed

Test Plan

Test backup restore for Wallet user

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Thu, Oct 31, 4:44 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Oct 31, 4:44 AM

kamil mentioned this in D13837: [native_rust_library] implement method to retrieve latest backup info.Thu, Oct 31, 5:00 AM

Harbormaster completed remote builds in B32465: Diff 45498.Thu, Oct 31, 5:02 AM

kamil added a child revision: D13837: [native_rust_library] implement method to retrieve latest backup info.Thu, Oct 31, 5:08 AM

kamil published this revision for review.Thu, Oct 31, 8:46 AM

kamil added inline comments.

lib/types/backup-types.js
24 ↗	(On Diff #45498)	This is not needed, it's removed in D13850 to make CI pass

bartek accepted this revision.Mon, Nov 4, 11:20 PM

bartek added inline comments.

native/native_rust_library/src/backup.rs
253–272 ↗	(On Diff #45498)	Nit: to avoid nested `match` you could use `let-else` to unwrap `Some(siwe_backup_msg_value)` and then the inner `match get_siwe_backup_data_from_msg()` would not be nested

This revision is now accepted and ready to land.Mon, Nov 4, 11:20 PM

address nit

Harbormaster failed remote builds in B32565: Diff 45651!Thu, Nov 7, 2:03 AM

Harbormaster completed remote builds in B32565: Diff 45651.Thu, Nov 7, 2:31 AM

Closed by commit rCOMM3aff4e035708: [backup-client] refactor `SIWEBackupData` type (authored by kamil). · Explain WhyThu, Nov 7, 4:07 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM3aff4e035708: [backup-client] refactor `SIWEBackupData` type.

kamil mentioned this in rCOMM532c51fae374: [native_rust_library] implement method to retrieve latest backup info.

Revision Contents
Changeset List

Path

Size

lib/

types/

backup-types.js

16 lines

native/

backup/

use-client-backup.js

21 lines

native_rust_library/

src/

86 lines

Diff 45667

lib/types/backup-types.js

Loading...

native/backup/use-client-backup.js

Loading...

native/native_rust_library/src/backup.rs

Loading...