Rename types
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Today
Wonder if there's a way to catch this sort of thing with CI
rebase and land
rebase before landing
rebase before landing
rebase before landing
rebase before landing
rebase and land
rebase before landing
implemented atuls quick suggestion
rebase and land
I'm not sure, but I think we should bump buildToolsVersion as well
fix gates
In D7060#210983, @ashoat wrote:{F436096}
Putting it in scripts/ sounds like a good idea to me!
One last change
added avatar client feature gate to fetcher
This diff seems to call getAPNsNotificationTopic with two parameters, but the version of that function in master only takes one parameter. Can you please update this diff's dependencies so I can see the rest of your stack? Please always set diff dependencies!
Almost there!
improvements
Still need to fix chat bubble poking out (will timebox for 1-2hrs)
Looks good, but a couple notes in message-creator.js
looks good thanks for making the unit tests
Can you create a Linear task for handling this edge case and set it to Backlog?
Putting it in scripts/ sounds like a good idea to me!
address comments
fix typo
Update toggleMessagePinRequestInputValidator
Update ToggleMessagePinRequest
Simplify the migration
Introduce two columns in messages
Address Feedback
I haven't seen all call sites yet (only the key generation diff is up) so I can't really tell but maybe it's worth revisiting the types and function arguments to have this as clean and consistent as possible.
rebase
update types
Sequencing this diff towards the end of the diff stack (need to put up a few more diffs up first) but will update the relational revisions when I have a better idea