Page MenuHomePhabricator
Feed All Stories

Today

rohan added inline comments to D7110: [keyserver/lib] Add a fetchPinnedMessages method to retrieve all pinned messages for a thread.
Mon, Mar 20, 6:26 PM
rohan updated the diff for D7110: [keyserver/lib] Add a fetchPinnedMessages method to retrieve all pinned messages for a thread.

Rename types

Mon, Mar 20, 6:25 PM
atul added a comment to D7111: [lib] Fix `TUnion`/`TInterface` imports.

Wonder if there's a way to catch this sort of thing with CI

Mon, Mar 20, 4:55 PM
atul closed D7111: [lib] Fix `TUnion`/`TInterface` imports.
Mon, Mar 20, 4:52 PM
atul committed rCOMM4935b4875f60: [lib] Fix `TUnion`/`TInterface` imports (authored by atul).
[lib] Fix `TUnion`/`TInterface` imports
Mon, Mar 20, 4:52 PM
ginsu accepted D7111: [lib] Fix `TUnion`/`TInterface` imports.
Mon, Mar 20, 4:49 PM
ginsu published D7111: [lib] Fix `TUnion`/`TInterface` imports for review.
Mon, Mar 20, 4:49 PM
rohan requested review of D7110: [keyserver/lib] Add a fetchPinnedMessages method to retrieve all pinned messages for a thread.
Mon, Mar 20, 3:54 PM
atul closed D7109: [lib] Introduce `ClientAvatar` and introduce `avatar` field for `*UserInfo` types.
Mon, Mar 20, 3:48 PM
atul committed rCOMMbcb8e9e4126e: [lib] Introduce `ClientAvatar` and introduce `avatar` field for `*UserInfo`… (authored by atul).
[lib] Introduce `ClientAvatar` and introduce `avatar` field for `*UserInfo`…
Mon, Mar 20, 3:48 PM
atul updated the diff for D7109: [lib] Introduce `ClientAvatar` and introduce `avatar` field for `*UserInfo` types.

rebase and land

Mon, Mar 20, 3:45 PM
ginsu accepted D7109: [lib] Introduce `ClientAvatar` and introduce `avatar` field for `*UserInfo` types.
Mon, Mar 20, 3:45 PM
Harbormaster failed remote builds in B17445: Diff 23900 for D7099: [native] add feature flag to avatars render work!
Mon, Mar 20, 3:40 PM
Harbormaster failed remote builds in B17444: Diff 23899 for D7069: [native] render the rest of the user avatars!
Mon, Mar 20, 3:38 PM
Harbormaster failed remote builds in B17443: Diff 23898 for D7057: [native] render avatar in profile screen!
Mon, Mar 20, 3:38 PM
atul closed D7108: [keyserver] Introduce `updateUserAvatarResponder` endpoint scaffolding.
Mon, Mar 20, 3:26 PM
atul committed rCOMMe927714acf3f: [keyserver] Introduce `updateUserAvatarResponder` endpoint scaffolding (authored by atul).
[keyserver] Introduce `updateUserAvatarResponder` endpoint scaffolding
Mon, Mar 20, 3:26 PM
ginsu updated the diff for D7099: [native] add feature flag to avatars render work.

rebase before landing

Mon, Mar 20, 3:26 PM
ginsu updated the diff for D7069: [native] render the rest of the user avatars.

rebase before landing

Mon, Mar 20, 3:25 PM
ginsu updated the diff for D7057: [native] render avatar in profile screen.

rebase before landing

Mon, Mar 20, 3:24 PM
ginsu updated the diff for D7055: [native] introduce Avatar component.

rebase before landing

Mon, Mar 20, 3:23 PM
atul updated the diff for D7108: [keyserver] Introduce `updateUserAvatarResponder` endpoint scaffolding.

rebase and land

Mon, Mar 20, 3:23 PM
jon added a comment to D7087: [Comm-opaque2] Add wasm build to client.

feedback

Mon, Mar 20, 3:22 PM
ginsu updated the diff for D7053: [lib] introduce getAvatarForUser in avatar-utils.

rebase before landing

Mon, Mar 20, 3:21 PM
ginsu updated the diff for D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.

implemented atuls quick suggestion

Mon, Mar 20, 3:20 PM
atul closed D7107: [lib] Introduce `updateUserAvatarRequestValidator`.
Mon, Mar 20, 3:19 PM
atul committed rCOMM4c6ac988e277: [lib] Introduce `updateUserAvatarRequestValidator` (authored by atul).
[lib] Introduce `updateUserAvatarRequestValidator`
Mon, Mar 20, 3:19 PM
atul updated the diff for D7107: [lib] Introduce `updateUserAvatarRequestValidator`.

rebase and land

Mon, Mar 20, 3:17 PM
jon updated the diff for D7087: [Comm-opaque2] Add wasm build to client.

typo

Mon, Mar 20, 3:17 PM
ginsu added inline comments to D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
Mon, Mar 20, 3:17 PM
ginsu added inline comments to D7099: [native] add feature flag to avatars render work.
Mon, Mar 20, 3:15 PM
ashoat added inline comments to D7099: [native] add feature flag to avatars render work.
Mon, Mar 20, 3:11 PM
ginsu added inline comments to D7099: [native] add feature flag to avatars render work.
Mon, Mar 20, 3:11 PM
atul accepted D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
Mon, Mar 20, 3:10 PM
ashoat added a comment to D7060: [lib] Introduce superblock padding.

Test

Mon, Mar 20, 3:10 PM
ashoat accepted D7109: [lib] Introduce `ClientAvatar` and introduce `avatar` field for `*UserInfo` types.
Mon, Mar 20, 3:09 PM
ashoat requested changes to D7105: Build files set-up for Android 13.

I'm not sure, but I think we should bump buildToolsVersion as well

Mon, Mar 20, 3:08 PM
ginsu updated the diff for D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.

fix gates

Mon, Mar 20, 3:04 PM
atul resigned from D6928: [keyserver] Introduce a new thread permission for pinning / unpinning messages.
Mon, Mar 20, 2:50 PM
ashoat accepted D6928: [keyserver] Introduce a new thread permission for pinning / unpinning messages.
Mon, Mar 20, 2:49 PM
atul added a comment to D7060: [lib] Introduce superblock padding.

{F436096}

Putting it in scripts/ sounds like a good idea to me!

Mon, Mar 20, 2:48 PM
ashoat added inline comments to D7103: [web-db] add unit tests for `sql.js`.
Mon, Mar 20, 2:47 PM
atul requested changes to D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.

One last change

Mon, Mar 20, 2:46 PM
ginsu added inline comments to D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
Mon, Mar 20, 2:43 PM
ashoat accepted D7099: [native] add feature flag to avatars render work.
Mon, Mar 20, 2:43 PM
ginsu updated the diff for D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.

added avatar client feature gate to fetcher

Mon, Mar 20, 2:42 PM
ashoat added a comment to D7094: [keyserver] Send updateBadgeCount notifs to macOS.

This diff seems to call getAPNsNotificationTopic with two parameters, but the version of that function in master only takes one parameter. Can you please update this diff's dependencies so I can see the rest of your stack? Please always set diff dependencies!

Mon, Mar 20, 2:37 PM
atul added inline comments to D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
Mon, Mar 20, 2:33 PM
ashoat requested changes to D7076: [keyserver] Add search table to the db.

Almost there!

Mon, Mar 20, 2:30 PM
atul added 1 blocking reviewer(s) for D7109: [lib] Introduce `ClientAvatar` and introduce `avatar` field for `*UserInfo` types: ginsu.
Mon, Mar 20, 2:29 PM
atul published D7109: [lib] Introduce `ClientAvatar` and introduce `avatar` field for `*UserInfo` types for review.
Mon, Mar 20, 2:29 PM
ginsu updated the diff for D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.

improvements

Mon, Mar 20, 2:28 PM
ginsu planned changes to D7067: [native] render user avatars in chat screen.

Still need to fix chat bubble poking out (will timebox for 1-2hrs)

Mon, Mar 20, 2:17 PM
ginsu accepted D7108: [keyserver] Introduce `updateUserAvatarResponder` endpoint scaffolding.
Mon, Mar 20, 2:16 PM
ashoat requested changes to D7077: [keyserver] Process new messages for search.

Looks good, but a couple notes in message-creator.js

Mon, Mar 20, 2:14 PM
ginsu accepted D7107: [lib] Introduce `updateUserAvatarRequestValidator`.

looks good thanks for making the unit tests

Mon, Mar 20, 2:10 PM
ginsu added inline comments to D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
Mon, Mar 20, 2:08 PM
ashoat accepted D7095: [desktop] Stop checking for a new version after download.

Can you create a Linear task for handling this edge case and set it to Backlog?

Mon, Mar 20, 2:07 PM
ashoat added a comment to D7060: [lib] Introduce superblock padding.

Putting it in scripts/ sounds like a good idea to me!

Mon, Mar 20, 2:04 PM
ginsu updated the diff for D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.

address comments

Mon, Mar 20, 2:04 PM
atul accepted D7105: Build files set-up for Android 13.
Mon, Mar 20, 1:29 PM
atul updated the diff for D7108: [keyserver] Introduce `updateUserAvatarResponder` endpoint scaffolding.

fix typo

Mon, Mar 20, 1:28 PM
rohan updated the diff for D6930: [keyserver/lib] Set up responders, endpoints, and related functions to toggle a message pin.

Update toggleMessagePinRequestInputValidator

Mon, Mar 20, 1:25 PM
Harbormaster failed remote builds in B17428: Diff 23881 for D7108: [keyserver] Introduce `updateUserAvatarResponder` endpoint scaffolding!
Mon, Mar 20, 1:24 PM
rohan attached a referenced file: F436013: Screenshot 2023-03-20 at 4.09.42 PM.png.
Mon, Mar 20, 1:21 PM
rohan attached a referenced file: F436014: Screenshot 2023-03-20 at 4.09.56 PM.png.
Mon, Mar 20, 1:21 PM
rohan updated the test plan for D6930: [keyserver/lib] Set up responders, endpoints, and related functions to toggle a message pin.
Mon, Mar 20, 1:21 PM
rohan updated the diff for D6929: [keyserver] Add a function to toggle the pin status of a message.

Update ToggleMessagePinRequest

Mon, Mar 20, 1:19 PM
varun accepted D7087: [Comm-opaque2] Add wasm build to client.
Mon, Mar 20, 1:15 PM
ginsu closed D7088: [landing] remove abosh from the team page.
Mon, Mar 20, 1:12 PM
ginsu committed rCOMM2642ab9c7667: [landing] remove abosh from the team page (authored by ginsu).
[landing] remove abosh from the team page
Mon, Mar 20, 1:12 PM
atul published D7108: [keyserver] Introduce `updateUserAvatarResponder` endpoint scaffolding for review.
Mon, Mar 20, 1:08 PM
atul published D7107: [lib] Introduce `updateUserAvatarRequestValidator` for review.
Mon, Mar 20, 12:42 PM
rohan updated the summary of D6924: [keyserver] Introduce columns in messages table to support pinned messages.
Mon, Mar 20, 12:41 PM
rohan added inline comments to D6929: [keyserver] Add a function to toggle the pin status of a message.
Mon, Mar 20, 12:40 PM
marcin requested review of D7106: Native Java code to request notifications permissions from JS on Android 13.
Mon, Mar 20, 12:28 PM
marcin requested review of D7105: Build files set-up for Android 13.
Mon, Mar 20, 12:24 PM
rohan updated the summary of D6928: [keyserver] Introduce a new thread permission for pinning / unpinning messages.
Mon, Mar 20, 12:01 PM
rohan updated the summary of D6928: [keyserver] Introduce a new thread permission for pinning / unpinning messages.
Mon, Mar 20, 12:01 PM
rohan attached a referenced file: F435800: memberships.png.
Mon, Mar 20, 12:00 PM
rohan attached a referenced file: F435799: roles.png.
Mon, Mar 20, 12:00 PM
rohan attached a referenced file: F435798: migration.png.
Mon, Mar 20, 12:00 PM
rohan updated the summary of D6928: [keyserver] Introduce a new thread permission for pinning / unpinning messages.
Mon, Mar 20, 12:00 PM
rohan updated the diff for D6928: [keyserver] Introduce a new thread permission for pinning / unpinning messages.

Simplify the migration

Mon, Mar 20, 11:59 AM
rohan attached a referenced file: F435771: Screenshot 2023-03-20 at 2.58.02 PM.png.
Mon, Mar 20, 11:58 AM
rohan retitled D6924: [keyserver] Introduce columns in messages table to support pinned messages from [keyserver] Introduce a pinned_messages table to [keyserver] Introduce columns in messages table to support pinned messages.
Mon, Mar 20, 11:58 AM
rohan updated the diff for D6924: [keyserver] Introduce columns in messages table to support pinned messages.

Introduce two columns in messages

Mon, Mar 20, 11:56 AM
jon added inline comments to D7087: [Comm-opaque2] Add wasm build to client.
Mon, Mar 20, 10:03 AM
jon updated the diff for D7087: [Comm-opaque2] Add wasm build to client.

Address Feedback

Mon, Mar 20, 10:03 AM
kamil published D7104: [web-db] add unit tests for worker crypto utils for review.
Mon, Mar 20, 9:26 AM
kamil published D7103: [web-db] add unit tests for `sql.js` for review.
Mon, Mar 20, 9:26 AM
kamil published D7102: [web-db] implement function to get database version for review.
Mon, Mar 20, 9:25 AM
kamil published D7101: [web-db] add `sql.js` types for review.
Mon, Mar 20, 9:25 AM
kamil added a comment to D6995: [web-db] implement crypto functions.

I haven't seen all call sites yet (only the key generation diff is up) so I can't really tell but maybe it's worth revisiting the types and function arguments to have this as clean and consistent as possible.

Mon, Mar 20, 9:21 AM
kamil updated the diff for D6996: [web-db] generate `CryptoKey` and persist.

rebase

Mon, Mar 20, 9:05 AM
kamil updated the diff for D6995: [web-db] implement crypto functions.

update types

Mon, Mar 20, 9:04 AM
ginsu added a comment to D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.

Sequencing this diff towards the end of the diff stack (need to put up a few more diffs up first) but will update the relational revisions when I have a better idea

Mon, Mar 20, 7:52 AM
ginsu updated the summary of D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.
Mon, Mar 20, 7:50 AM
jon closed D6722: [Android] Reference Tools by CMake project.
Mon, Mar 20, 7:45 AM
jon committed rCOMM6f883b5879f0: [Android] Reference Tools by CMake project (authored by jon).
[Android] Reference Tools by CMake project
Mon, Mar 20, 7:45 AM