Page MenuHomePhabricator
Feed Advanced Search

Jul 21 2022

jacek updated the diff for D4462: [web] Implement callbacks modifying navigation from `ChatThreadComposer`.

Adress Tomek's and Atul's feedback

Jul 21 2022, 3:55 AM
jacek added inline comments to D4462: [web] Implement callbacks modifying navigation from `ChatThreadComposer`.
Jul 21 2022, 3:54 AM
jacek updated the diff for D4457: [web] Introduce `chat-creation` mode in `navInfo`.

Address Atul's suggestions

Jul 21 2022, 3:45 AM
jacek updated the test plan for D4443: [lib] Support pending threads in `URLInfo` calculation.
Jul 21 2022, 3:22 AM
jacek added inline comments to D4455: [web] Introduce pending thread creation in `websiteResponder` if it is missing.
Jul 21 2022, 3:17 AM
jacek requested review of D4446: [lib] Create util function for parsing locally unique thread ID.
Jul 21 2022, 3:08 AM
jacek updated the diff for D4446: [lib] Create util function for parsing locally unique thread ID.

Add more tests and checking if the whole string matches ID regex

Jul 21 2022, 3:07 AM
jacek added inline comments to D4446: [lib] Create util function for parsing locally unique thread ID.
Jul 21 2022, 3:04 AM
jacek requested review of D4443: [lib] Support pending threads in `URLInfo` calculation.
Jul 21 2022, 3:04 AM
jacek updated the diff for D4443: [lib] Support pending threads in `URLInfo` calculation.

Updated the Regex to prevent empty IDs between '+' chars.

Jul 21 2022, 2:59 AM

Jul 20 2022

atul renamed jacek from def-au1t to jacek.
Jul 20 2022, 11:31 AM
jacek added inline comments to D4446: [lib] Create util function for parsing locally unique thread ID.
Jul 20 2022, 10:18 AM
jacek updated the diff for D4461: [web] Introduce `ChatThreadComposer` component for selecting users to new thread.

rebase & remove redundant prop & follow Tomeks suggestion with separate memo

Jul 20 2022, 10:04 AM
jacek updated the diff for D4457: [web] Introduce `chat-creation` mode in `navInfo`.

rebase & follow review comments

Jul 20 2022, 9:57 AM
jacek retitled D4455: [web] Introduce pending thread creation in `websiteResponder` if it is missing from [web] Introduce pending thread creation in `navReducer` if it is missing to [web] Introduce pending thread creation in `websiteResponder` if it is missing.
Jul 20 2022, 7:18 AM
jacek updated the diff for D4455: [web] Introduce pending thread creation in `websiteResponder` if it is missing.

Move pending thread creation from navReducer to website Responder as Atul suggested

Jul 20 2022, 7:17 AM
jacek requested review of D4446: [lib] Create util function for parsing locally unique thread ID.
Jul 20 2022, 7:13 AM
jacek updated the diff for D4446: [lib] Create util function for parsing locally unique thread ID.

use pending thread ID regex in function to check if provided ID is valid.

Jul 20 2022, 7:11 AM
jacek closed D4574: [web] Hide "Users in parent channel" header for threads without parent in `AddMembersModal`.
Jul 20 2022, 6:57 AM
jacek committed rCOMM832036c9acb6: [web] Hide "Users in parent channel" header for threads without parent in… (authored by jacek).
[web] Hide "Users in parent channel" header for threads without parent in…
Jul 20 2022, 6:57 AM
jacek closed D4551: [web] Memoize `LeftLayoutAside` component.
Jul 20 2022, 6:54 AM
jacek committed rCOMM085cb4bdcf4c: [web] Memoize `LeftLayoutAside` component (authored by jacek).
[web] Memoize `LeftLayoutAside` component
Jul 20 2022, 6:54 AM
jacek updated the diff for D4443: [lib] Support pending threads in `URLInfo` calculation.

add comment in code as Tomek suggested

Jul 20 2022, 6:47 AM
jacek updated the diff for D4434: [web] Separate `ChatMessageListContainer` from `ChatMessageList`.

rebase & update after review comments

Jul 20 2022, 4:16 AM
jacek added inline comments to D4465: [web] Support chat creation in `ChatMessageListContainer`.
Jul 20 2022, 4:15 AM
jacek added inline comments to D4434: [web] Separate `ChatMessageListContainer` from `ChatMessageList`.
Jul 20 2022, 3:01 AM
jacek added inline comments to D4443: [lib] Support pending threads in `URLInfo` calculation.
Jul 20 2022, 12:55 AM

Jul 19 2022

jacek added inline comments to D4446: [lib] Create util function for parsing locally unique thread ID.
Jul 19 2022, 8:29 AM
jacek added inline comments to D4457: [web] Introduce `chat-creation` mode in `navInfo`.
Jul 19 2022, 8:22 AM
jacek added inline comments to D4463: [web] Introduce onMessageSent callbacks.
Jul 19 2022, 8:18 AM
jacek added a comment to D4455: [web] Introduce pending thread creation in `websiteResponder` if it is missing.
  1. Introduce a diff that properly constructs pendingThread in website_responders so we "start off" with correct and consistent values for activeChatThreadID and pendingThread
  2. Basically this diff, but modified such that all of the logic is "within" an action handler
Jul 19 2022, 8:16 AM
jacek added inline comments to D4461: [web] Introduce `ChatThreadComposer` component for selecting users to new thread.
Jul 19 2022, 7:59 AM
jacek attached a referenced file: F108277: Screenshot_Google Chrome_2022-07-19_163256.mp4.
Jul 19 2022, 7:36 AM
jacek added inline comments to D4461: [web] Introduce `ChatThreadComposer` component for selecting users to new thread.
Jul 19 2022, 7:36 AM
jacek requested review of D4574: [web] Hide "Users in parent channel" header for threads without parent in `AddMembersModal`.
Jul 19 2022, 4:27 AM

Jul 18 2022

jacek requested review of D4551: [web] Memoize `LeftLayoutAside` component.
Jul 18 2022, 4:45 AM

Jul 15 2022

jacek closed D4071: [server] Migrate database after permission updates.
Jul 15 2022, 3:08 AM
jacek closed D4514: [server] Use single connection with DB for migrations.
Jul 15 2022, 3:08 AM
jacek committed rCOMM762261bd4c4f: [server] Migrate database after permission updates (authored by jacek).
[server] Migrate database after permission updates
Jul 15 2022, 3:08 AM
jacek committed rCOMMdd58826093a1: [server] Use single connection with DB for migrations (authored by jacek).
[server] Use single connection with DB for migrations
Jul 15 2022, 3:08 AM
jacek closed D4069: [server] [fix] Unify permissions for `OPEN_SUBTHREAD` and `SECRET_SUBTHREAD`.
Jul 15 2022, 3:07 AM
jacek committed rCOMM58b491f3f390: [server] [fix] Unify permissions for `OPEN_SUBTHREAD` and `SECRET_SUBTHREAD` (authored by jacek).
[server] [fix] Unify permissions for `OPEN_SUBTHREAD` and `SECRET_SUBTHREAD`
Jul 15 2022, 3:07 AM
jacek updated the diff for D4514: [server] Use single connection with DB for migrations.

end migrationConnection when migrations are deactivated

Jul 15 2022, 2:51 AM

Jul 14 2022

jacek closed D4506: [server] Add delay before setuping database and running migrations.
Jul 14 2022, 4:16 AM
jacek committed rCOMM4e21e3d264df: [server] Add delay before setuping database and running migrations (authored by jacek).
[server] Add delay before setuping database and running migrations
Jul 14 2022, 4:16 AM
jacek updated the diff for D4506: [server] Add delay before setuping database and running migrations.

move dbVersion closer to where it's used

Jul 14 2022, 4:03 AM
jacek updated the diff for D4514: [server] Use single connection with DB for migrations.

Introduce ConnectionContext

Jul 14 2022, 4:01 AM
jacek added inline comments to D4514: [server] Use single connection with DB for migrations.
Jul 14 2022, 4:00 AM

Jul 13 2022

jacek added inline comments to D4506: [server] Add delay before setuping database and running migrations.
Jul 13 2022, 8:13 AM
jacek updated the diff for D4071: [server] Migrate database after permission updates.

rebase

Jul 13 2022, 8:07 AM
jacek added reviewers for D4514: [server] Use single connection with DB for migrations: abosh, ashoat.
Jul 13 2022, 8:06 AM
jacek requested review of D4514: [server] Use single connection with DB for migrations.
Jul 13 2022, 7:08 AM

Jul 12 2022

jacek requested review of D4506: [server] Add delay before setuping database and running migrations.
Jul 12 2022, 5:38 AM

Jul 11 2022

jacek abandoned D4471: [web] Fix app switcher for thread creation.

Abandoning due to changes in previous diffs that eliminated the need for the change here.

Jul 11 2022, 6:44 AM
jacek updated the summary of D4470: [web] Fix navigation after clicking on thread from thread list.
Jul 11 2022, 6:42 AM
jacek retitled D4457: [web] Introduce `chat-creation` mode in `navInfo` from [web] Introduce `chat-creation` tab in `navInfo` to [web] Introduce `chat-creation` mode in `navInfo`.
Jul 11 2022, 6:32 AM
jacek updated the diff for D4470: [web] Fix navigation after clicking on thread from thread list.

rebase

Jul 11 2022, 6:28 AM
jacek updated the diff for D4469: [web] Introduce "Create new chat" button.

rebase

Jul 11 2022, 6:27 AM
jacek updated the diff for D4466: [web] Introduce `useOnClickNewThread` hook.

rebase

Jul 11 2022, 6:27 AM
jacek updated the diff for D4465: [web] Support chat creation in `ChatMessageListContainer`.

rebase

Jul 11 2022, 6:26 AM
jacek updated the diff for D4462: [web] Implement callbacks modifying navigation from `ChatThreadComposer`.

rebase

Jul 11 2022, 6:25 AM
jacek updated the diff for D4457: [web] Introduce `chat-creation` mode in `navInfo`.

Introduce chatMode field instead of creating new tab.

Jul 11 2022, 6:19 AM
jacek planned changes to D4457: [web] Introduce `chat-creation` mode in `navInfo`.
Jul 11 2022, 4:40 AM
jacek added a comment to D4457: [web] Introduce `chat-creation` mode in `navInfo`.

Can you provide some more context for why we need a new tab type for this? It seems pretty confusing to me... in the UI, we have just three tabs. It would seem like chat creation should be part of the chat tab?

Jul 11 2022, 4:40 AM
jacek added a comment to D4443: [lib] Support pending threads in `URLInfo` calculation.

Looking at the code now, I suppose keeping using pendingThreadID instead of LocallyUniqueThreadID would have made the code more readable.

Awesome – what do you think the best way to follow up is? Maybe we should create a separate Linear task for it, since it seems like this change will touch a lot of files.

Jul 11 2022, 3:13 AM
jacek attached a referenced file: F95640: Screenshot_Code_2022-07-08_084203@2x.png.
Jul 11 2022, 3:02 AM
jacek updated the diff for D4471: [web] Fix app switcher for thread creation.

revert accidental import change

Jul 11 2022, 2:33 AM
jacek updated the diff for D4461: [web] Introduce `ChatThreadComposer` component for selecting users to new thread.

simplify CSS

Jul 11 2022, 2:33 AM
jacek added inline comments to D4461: [web] Introduce `ChatThreadComposer` component for selecting users to new thread.
Jul 11 2022, 2:32 AM
jacek planned changes to D4471: [web] Fix app switcher for thread creation.
Jul 11 2022, 1:58 AM

Jul 8 2022

jacek added inline comments to D4471: [web] Fix app switcher for thread creation.
Jul 8 2022, 4:16 AM
jacek updated the diff for D4461: [web] Introduce `ChatThreadComposer` component for selecting users to new thread.

Simplify if condition

Jul 8 2022, 4:06 AM
jacek added inline comments to D4461: [web] Introduce `ChatThreadComposer` component for selecting users to new thread.
Jul 8 2022, 4:00 AM
jacek requested review of D4455: [web] Introduce pending thread creation in `websiteResponder` if it is missing.
Jul 8 2022, 3:51 AM
jacek added a comment to D4455: [web] Introduce pending thread creation in `websiteResponder` if it is missing.

Thanks @atul, for the detailed comment!

Jul 8 2022, 3:50 AM
jacek requested review of D4443: [lib] Support pending threads in `URLInfo` calculation.
Jul 8 2022, 2:52 AM
jacek added inline comments to D4443: [lib] Support pending threads in `URLInfo` calculation.
Jul 8 2022, 2:52 AM

Jul 7 2022

jacek added inline comments to D4443: [lib] Support pending threads in `URLInfo` calculation.
Jul 7 2022, 11:46 PM
jacek added a reviewer for D4443: [lib] Support pending threads in `URLInfo` calculation: abosh.
Jul 7 2022, 7:22 AM
jacek added a reviewer for D4455: [web] Introduce pending thread creation in `websiteResponder` if it is missing: abosh.
Jul 7 2022, 7:22 AM
jacek added a reviewer for D4457: [web] Introduce `chat-creation` mode in `navInfo`: abosh.
Jul 7 2022, 7:22 AM
jacek added a reviewer for D4474: [web] Keep `activeChatThreadID` and `pendingThread` updated in `navInfo` in thread creation mode: abosh.
Jul 7 2022, 7:22 AM
jacek added a reviewer for D4470: [web] Fix navigation after clicking on thread from thread list: abosh.
Jul 7 2022, 7:22 AM
jacek added a reviewer for D4469: [web] Introduce "Create new chat" button: abosh.
Jul 7 2022, 7:22 AM
jacek added a reviewer for D4466: [web] Introduce `useOnClickNewThread` hook: abosh.
Jul 7 2022, 7:22 AM
jacek added a reviewer for D4465: [web] Support chat creation in `ChatMessageListContainer`: abosh.
Jul 7 2022, 7:21 AM
jacek added a reviewer for D4464: [web] Close thread composer after sending a message: abosh.
Jul 7 2022, 7:21 AM
jacek added a reviewer for D4463: [web] Introduce onMessageSent callbacks: abosh.
Jul 7 2022, 7:21 AM
jacek added a reviewer for D4462: [web] Implement callbacks modifying navigation from `ChatThreadComposer`: abosh.
Jul 7 2022, 7:21 AM
jacek added a reviewer for D4461: [web] Introduce `ChatThreadComposer` component for selecting users to new thread: abosh.
Jul 7 2022, 7:21 AM
jacek added a reviewer for D4456: [web] Include current pending thread in thread list: abosh.
Jul 7 2022, 7:20 AM
jacek requested review of D4474: [web] Keep `activeChatThreadID` and `pendingThread` updated in `navInfo` in thread creation mode.
Jul 7 2022, 6:57 AM
jacek added reviewers for D4466: [web] Introduce `useOnClickNewThread` hook: tomek, atul.
Jul 7 2022, 6:02 AM
jacek updated the summary of D4471: [web] Fix app switcher for thread creation.
Jul 7 2022, 6:01 AM
jacek updated the summary of D4469: [web] Introduce "Create new chat" button.
Jul 7 2022, 5:55 AM
jacek requested review of D4471: [web] Fix app switcher for thread creation.
Jul 7 2022, 5:49 AM
jacek requested review of D4470: [web] Fix navigation after clicking on thread from thread list.
Jul 7 2022, 5:40 AM
jacek requested review of D4469: [web] Introduce "Create new chat" button.
Jul 7 2022, 5:34 AM
jacek requested review of D4466: [web] Introduce `useOnClickNewThread` hook.
Jul 7 2022, 4:32 AM
jacek requested review of D4465: [web] Support chat creation in `ChatMessageListContainer`.
Jul 7 2022, 4:12 AM