Adress Tomek's and Atul's feedback
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jul 21 2022
Address Atul's suggestions
Add more tests and checking if the whole string matches ID regex
Updated the Regex to prevent empty IDs between '+' chars.
Jul 20 2022
rebase & remove redundant prop & follow Tomeks suggestion with separate memo
rebase & follow review comments
Move pending thread creation from navReducer to website Responder as Atul suggested
use pending thread ID regex in function to check if provided ID is valid.
add comment in code as Tomek suggested
rebase & update after review comments
Jul 19 2022
- Introduce a diff that properly constructs pendingThread in website_responders so we "start off" with correct and consistent values for activeChatThreadID and pendingThread
- Basically this diff, but modified such that all of the logic is "within" an action handler
Jul 18 2022
Jul 15 2022
end migrationConnection when migrations are deactivated
Jul 14 2022
move dbVersion closer to where it's used
Introduce ConnectionContext
Jul 13 2022
rebase
Jul 12 2022
Jul 11 2022
Abandoning due to changes in previous diffs that eliminated the need for the change here.
rebase
rebase
rebase
rebase
rebase
Introduce chatMode field instead of creating new tab.
In D4457#126948, @ashoat wrote:Can you provide some more context for why we need a new tab type for this? It seems pretty confusing to me... in the UI, we have just three tabs. It would seem like chat creation should be part of the chat tab?
In D4443#127905, @ashoat wrote:Looking at the code now, I suppose keeping using pendingThreadID instead of LocallyUniqueThreadID would have made the code more readable.
Awesome – what do you think the best way to follow up is? Maybe we should create a separate Linear task for it, since it seems like this change will touch a lot of files.
revert accidental import change
simplify CSS
Jul 8 2022
Simplify if condition
Thanks @atul, for the detailed comment!