rebase and land
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Jun 3 2024
Jun 3 2024
atul published D12292: [lib] Narrow types in `memberHasAdminPowers` call stack to remove `invariant` for review.
atul published D12289: [lib] Introduce `threadIsWithBlockedUserOnlyWithoutAdminRoleCheck` for review.
atul published D12288: [lib] Consume `useThreadFrozenDueToViewerBlock` in `web/ChatInputBar` for review.
atul updated the diff for D12266: [lib] Narrow `threadInfo` argument of `threadFrozenDueToViewerBlock`.
Jun 2 2024
Jun 2 2024
atul requested review of D12266: [lib] Narrow `threadInfo` argument of `threadFrozenDueToViewerBlock`.
May 31 2024
May 31 2024
atul requested review of D12259: [lib] Replace `threadMemberHasPermission` logic in `appendUserInfo`.
land
atul updated the diff for D12154: [lib] Add `skipMemberAdminRoleCheck` argument to `threadIsWithBlockedUserOnly`.
make entries of ThreadIsWithBlockedUserOnlyOptions read-only
atul updated the test plan for D12154: [lib] Add `skipMemberAdminRoleCheck` argument to `threadIsWithBlockedUserOnly`.
atul added inline comments to D12154: [lib] Add `skipMemberAdminRoleCheck` argument to `threadIsWithBlockedUserOnly`.
remove unnecessary spread
update and amend
atul updated the diff for D12154: [lib] Add `skipMemberAdminRoleCheck` argument to `threadIsWithBlockedUserOnly`.
"create some sort of options object for threadIsWithBlockedUserOnly"
May 30 2024
May 30 2024
I'd like to understand a bit more why this is safe to do at this time.
atul updated the diff for D12246: [lib] Narrow `threadHasPermission` so it only accepts `ThreadPermissionNotAffectedByBlock`.
now we should be good to land this
atul updated the diff for D11753: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings*`.
remove extraneous threadInfo from useEffect + deplist
atul added inline comments to D11753: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings*`.
atul updated the diff for D12154: [lib] Add `skipMemberAdminRoleCheck` argument to `threadIsWithBlockedUserOnly`.
partially address feedback
atul updated the diff for D11753: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings*`.
address @tomek's feedback
atul added inline comments to D11753: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings*`.
atul updated the diff for D12246: [lib] Narrow `threadHasPermission` so it only accepts `ThreadPermissionNotAffectedByBlock`.
rebase before addressing feedback
rebase before addressing feedback
atul updated the diff for D12154: [lib] Add `skipMemberAdminRoleCheck` argument to `threadIsWithBlockedUserOnly`.
rebase before addressing feedback
atul updated the diff for D11753: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings*`.
rebase before addressing feedback
atul added a comment to D12246: [lib] Narrow `threadHasPermission` so it only accepts `ThreadPermissionNotAffectedByBlock`.
Ah, got to land D11753 before I can land this one. Will update that diff to get it land-able.
atul updated the diff for D12246: [lib] Narrow `threadHasPermission` so it only accepts `ThreadPermissionNotAffectedByBlock`.
rebase and land
atul updated the diff for D12245: [lib] Pull `threadPermissionsDisabledByBlock` out from `threadPermissions`.
rebase and land
atul added inline comments to D12245: [lib] Pull `threadPermissionsDisabledByBlock` out from `threadPermissions`.
atul added a comment to D12246: [lib] Narrow `threadHasPermission` so it only accepts `ThreadPermissionNotAffectedByBlock`.
The high level goal of this work was to remove non-viewer/non-admin computed Member permissions to reduce space taken up by them on the clients.
atul requested review of D12245: [lib] Pull `threadPermissionsDisabledByBlock` out from `threadPermissions`.
atul updated the diff for D12150: [lib] Make `checkOnlyViewerBlock` argument of `threadIsWithBlockedUserOnly` required.
ready to land
atul updated the diff for D12150: [lib] Make `checkOnlyViewerBlock` argument of `threadIsWithBlockedUserOnly` required.
rebase
atul updated the diff for D12149: [lib] Add `memberHasAdminRole` check to `useThreadsWithPermission`.
ready to land
atul updated the test plan for D12149: [lib] Add `memberHasAdminRole` check to `useThreadsWithPermission`.
atul updated the diff for D12149: [lib] Add `memberHasAdminRole` check to `useThreadsWithPermission`.
fix logic to handle undefined case
atul updated the diff for D12149: [lib] Add `memberHasAdminRole` check to `useThreadsWithPermission`.
address feedback before updating test plan and before landing
atul updated the test plan for D12145: [lib] Pull `useCommunityRootMembersToRole` out of `useThreadSearchIndex`.
atul updated the diff for D12145: [lib] Pull `useCommunityRootMembersToRole` out of `useThreadSearchIndex`.
address feedback before updating test plan and before landing
May 21 2024
May 21 2024
atul published D12154: [lib] Add `skipMemberAdminRoleCheck` argument to `threadIsWithBlockedUserOnly` for review.
atul published D12149: [lib] Add `memberHasAdminRole` check to `useThreadsWithPermission` for review.
atul published D12145: [lib] Pull `useCommunityRootMembersToRole` out of `useThreadSearchIndex` for review.
May 15 2024
May 15 2024
atul updated the test plan for D11950: [lib] Introduce `useThreadsInChatList` and consume in `useFilteredChildThreads`.
atul updated the test plan for D11981: [lib] Replace `threadInChatList` with `useThreadInChatList` in `useWatchThread`.
atul updated the test plan for D11980: [web] Replace `threadInChatList` with `useThreadsInChatList` in `SidebarsModal`.
atul updated the diff for D11981: [lib] Replace `threadInChatList` with `useThreadInChatList` in `useWatchThread`.
fix
atul updated the diff for D11950: [lib] Introduce `useThreadsInChatList` and consume in `useFilteredChildThreads`.
address feedback before landing
atul updated the test plan for D11980: [web] Replace `threadInChatList` with `useThreadsInChatList` in `SidebarsModal`.
atul updated the test plan for D11950: [lib] Introduce `useThreadsInChatList` and consume in `useFilteredChildThreads`.
atul updated the diff for D11981: [lib] Replace `threadInChatList` with `useThreadInChatList` in `useWatchThread`.
resolve merge conflicts
atul updated the diff for D11980: [web] Replace `threadInChatList` with `useThreadsInChatList` in `SidebarsModal`.
resolve merge conflicts
atul updated the diff for D11950: [lib] Introduce `useThreadsInChatList` and consume in `useFilteredChildThreads`.
resolve merge conflicts
land
May 14 2024
May 14 2024
atul updated the diff for D11924: [lib] Introduce `useThreadsWithPermission` to filter `ThreadInfo`s.
address feedback and land
atul updated the test plan for D11924: [lib] Introduce `useThreadsWithPermission` to filter `ThreadInfo`s.