Page MenuHomePhabricator
Feed Advanced Search

Jun 14 2024

tomek committed rCOMM66a65374c86a: [keyserver] Modify thread join responder to handle thread invite links (authored by tomek).
[keyserver] Modify thread join responder to handle thread invite links
Jun 14 2024, 5:27 AM
tomek closed D12393: [keyserver] Don't return thread link to clients.
Jun 14 2024, 5:27 AM
tomek committed rCOMMc5af22f1add1: [keyserver] Don't return thread link to clients (authored by tomek).
[keyserver] Don't return thread link to clients
Jun 14 2024, 5:27 AM
tomek closed D12392: [keyserver] Extend link validation to support thread links.
Jun 14 2024, 5:27 AM
tomek closed D12354: [keyserver] Extend link creation logic to support invite links to threads.
Jun 14 2024, 5:27 AM
tomek committed rCOMM8341afe4c45d: [keyserver] Extend link validation to support thread links (authored by tomek).
[keyserver] Extend link validation to support thread links
Jun 14 2024, 5:27 AM
tomek committed rCOMM5b9cba27a018: [keyserver] Extend link creation logic to support invite links to threads (authored by tomek).
[keyserver] Extend link creation logic to support invite links to threads
Jun 14 2024, 5:27 AM
tomek closed D12351: [keyserver] Add a thread column to invite links.
Jun 14 2024, 5:27 AM
tomek committed rCOMM4c41696fb864: [keyserver] Add a thread column to invite links (authored by tomek).
[keyserver] Add a thread column to invite links
Jun 14 2024, 5:27 AM
tomek updated the summary of D12422: [web][native] Display both thread and community names in the modal.
Jun 14 2024, 3:29 AM
tomek updated the diff for D12422: [web][native] Display both thread and community names in the modal.

Handle long names on web. Updated the summary with some screenshots.

Jun 14 2024, 3:29 AM
tomek planned changes to D12422: [web][native] Display both thread and community names in the modal.

How does it look if the names are really long?

Jun 14 2024, 3:16 AM

Jun 13 2024

tomek accepted D12395: Enable encrypted notifications to have keyservevrID or senderDeviceID.
Jun 13 2024, 8:19 AM
tomek accepted D12394: Move all notif types to lib except for APNs notifs.
Jun 13 2024, 7:54 AM
tomek requested review of D12426: [lib] Extract a file with invite links constants.
Jun 13 2024, 7:12 AM
tomek requested review of D12425: [lib] Join a thread from an invite link.
Jun 13 2024, 6:14 AM
tomek updated the test plan for D12420: [native][web] Navigate to a thread if already joined.
Jun 13 2024, 5:55 AM
tomek updated the diff for D12420: [native][web] Navigate to a thread if already joined.

Modify the message when a link is a thread link

Jun 13 2024, 5:54 AM
tomek requested review of D12424: [lib] Define steps in link acceptance hook.
Jun 13 2024, 5:53 AM
tomek requested review of D12423: [lib] Modify the approach to handling invite link acceptance.
Jun 13 2024, 5:51 AM
tomek requested review of D12422: [web][native] Display both thread and community names in the modal.
Jun 13 2024, 5:40 AM
tomek requested review of D12421: [lib] Rename useAcceptInviteLink return values.
Jun 13 2024, 5:04 AM
tomek requested review of D12420: [native][web] Navigate to a thread if already joined.
Jun 13 2024, 5:03 AM
tomek updated the test plan for D12399: [keyserver] Modify thread join responder to handle thread invite links.
Jun 13 2024, 4:40 AM
tomek accepted D12410: [keyserver] update fetchCommunityInfos to query by community ids.
Jun 13 2024, 3:59 AM
tomek requested changes to D12409: [lib] Use sqlite for message store local instead of redux persist.

It might be a good idea to create a task tracking landing this.

Jun 13 2024, 3:56 AM
tomek accepted D12383: [lib] refresh device lists after restore.
Jun 13 2024, 3:46 AM
tomek accepted D12381: [lib] broadcast device list updates after secondary device logout.
Jun 13 2024, 3:38 AM
tomek accepted D12380: [lib] broadcast updates when becoming aware of new device existence.
Jun 13 2024, 3:38 AM
tomek accepted D12379: [lib] handle `DEVICE_LIST_UPDATED` message.
Jun 13 2024, 3:15 AM
tomek accepted D12378: [Identity] send `IdentityDeviceListUpdated` after logout.
Jun 13 2024, 3:14 AM
tomek accepted D12376: [lib] handle `IdentityDeviceListUpdated` P2P message.
Jun 13 2024, 3:04 AM
tomek accepted D12375: [lib] add `IdentityDeviceListUpdated` P2P message type.
Jun 13 2024, 2:39 AM

Jun 12 2024

tomek accepted D12374: [lib] factor out getting and updating device list to hook.
Jun 12 2024, 5:53 AM
tomek accepted D12373: [lib] factor out broadcasting device list updates to hook.
Jun 12 2024, 5:43 AM
tomek accepted D12372: [lib] convert `peerToPeerMessageHandler` to a hook.
Jun 12 2024, 4:26 AM
tomek accepted D12371: [lib] move processing `MESSAGE_TO_DEVICE` to a component.
Jun 12 2024, 4:25 AM
tomek accepted D12384: [lib] assert function and setting client db with sqlite data.
Jun 12 2024, 4:17 AM
tomek accepted D12400: [lib] introduce updateThreadStoreThreadInfos.
Jun 12 2024, 4:13 AM
tomek accepted D12370: [native/web] introduce migration to move local message info to sqlite.
Jun 12 2024, 4:11 AM
tomek accepted D12358: [lib] update message reducer to use ops approach for local field.
Jun 12 2024, 4:09 AM

Jun 11 2024

tomek requested review of D12399: [keyserver] Modify thread join responder to handle thread invite links.
Jun 11 2024, 11:29 AM
tomek requested review of D12393: [keyserver] Don't return thread link to clients.
Jun 11 2024, 10:18 AM
tomek requested review of D12392: [keyserver] Extend link validation to support thread links.
Jun 11 2024, 10:17 AM
tomek added a comment to D12391: [keyserver] Make sanitizeInput work even if validation fails.

Hmm... perhaps I'm not understanding you correctly. I added a couple test cases with nested validators, and these did reveal an issue: I wasn't propagating options during recursion. But a second traversal (as you suggested) didn't appear to be necessary.

Perhaps you are suggesting that we should redact properties based on their keys? That's probably not a bad idea, but I'd rather keep it out of the scope here for now.

Yeah, that's my suggestion. And agree, we don't have to include this in the scope right now.

Jun 11 2024, 10:10 AM
tomek accepted D12391: [keyserver] Make sanitizeInput work even if validation fails.

I think this solution has an issue: some sensitive data could be placed in a prop that fails the validation and we probably won't be able to sanitize it properly. I don't think this problem can be solved in general, but maybe we should traverse the whole tree after the conversion and redact by hand all the fields that should usually be sanitized e.g. password.

Jun 11 2024, 8:42 AM
tomek accepted D12387: [keyserver] Improve logging in checkInputValidator.
Jun 11 2024, 4:18 AM
tomek accepted D12390: [lib/native] lift legacyUpdateRolesAndPermissions into lib.
Jun 11 2024, 2:38 AM
tomek accepted D12384: [lib] assert function and setting client db with sqlite data.
Jun 11 2024, 2:36 AM

Jun 10 2024

tomek accepted D12369: [lib][native][web] Recover from socket crash loop using fetchPendingUpdates.
Jun 10 2024, 7:02 AM
tomek accepted D12368: [lib] Rename failuresAfterPolicyAcknowledgment to initFailureCountAfterPolicyAcknowledgment.
Jun 10 2024, 6:44 AM
tomek added inline comments to D12361: [keyserver][lib] Move clientResponseInputValidator to lib.
Jun 10 2024, 6:43 AM
tomek accepted D12367: [lib] Add $ReadOnly wrapper around type spreads in socket-types.js.
Jun 10 2024, 4:50 AM
tomek accepted D12366: [lib] Introduce fetchPendingUpdates action.
Jun 10 2024, 4:45 AM
tomek added a comment to D12358: [lib] update message reducer to use ops approach for local field.

We should also check for store inconsistencies in setClientDBStoreActionType - but I guess that extending this action will be done later in the stack.

Jun 10 2024, 4:06 AM
tomek accepted D12365: [lib] Simplify param to generateOpsForThreadUpdates.
Jun 10 2024, 4:04 AM
tomek accepted D12364: [keyserver][lib] Introduce fetch_pending_updates endpoint.
Jun 10 2024, 4:03 AM
tomek accepted D12363: [keyserver] Factor out fetchDataForSocketInit.
Jun 10 2024, 3:55 AM
tomek accepted D12362: [keyserver][lib] Move sessionStateValidator to lib.
Jun 10 2024, 3:48 AM
tomek accepted D12361: [keyserver][lib] Move clientResponseInputValidator to lib.
Jun 10 2024, 3:47 AM
tomek accepted D12360: [keyserver] Deduplicate validators in activity-responders.js.
Jun 10 2024, 3:43 AM
tomek accepted D12359: [keyserver][lib] Deduplicate validators in entry-responders.js.
Jun 10 2024, 3:42 AM
tomek requested changes to D12358: [lib] update message reducer to use ops approach for local field.
Jun 10 2024, 3:40 AM
tomek accepted D12357: [web] handle message store local ops types in processMessageStoreOperations.
Jun 10 2024, 3:19 AM
tomek accepted D12352: [lib] Discard keyserver usernames for joinThreadActionTypes and newThreadActionTypes.
Jun 10 2024, 3:15 AM

Jun 7 2024

tomek requested review of D12354: [keyserver] Extend link creation logic to support invite links to threads.
Jun 7 2024, 1:42 PM
tomek updated the diff for D12351: [keyserver] Add a thread column to invite links.

Default null

Jun 7 2024, 11:29 AM
tomek requested review of D12351: [keyserver] Add a thread column to invite links.
Jun 7 2024, 9:25 AM
tomek accepted D12332: [lib] Stop processing user infos from secondary keyservers on keyserverAuthActionTypes.
Jun 7 2024, 6:49 AM

Jun 6 2024

tomek accepted D12333: [lib] Stop processing user infos from secondary keyservers on updateUserAvatarActionTypes.
Jun 6 2024, 9:57 AM
tomek requested changes to D12332: [lib] Stop processing user infos from secondary keyservers on keyserverAuthActionTypes.
Jun 6 2024, 9:53 AM
tomek accepted D12331: [lib] Stop processing user infos from secondary keyservers on joinThreadActionTypes and newThreadActionTypes.
Jun 6 2024, 9:48 AM
tomek accepted D12330: [lib] update device list when updating `UserStore`.
Jun 6 2024, 9:41 AM
tomek closed D12320: [lib][web][native] Navigate to a thread after joining a community.
Jun 6 2024, 9:28 AM
tomek closed D12317: [native] Open a community when a user clicks an invite link and is already a member.
Jun 6 2024, 9:28 AM
tomek committed rCOMM95220f0be98f: [lib][web][native] Navigate to a thread after joining a community (authored by tomek).
[lib][web][native] Navigate to a thread after joining a community
Jun 6 2024, 9:28 AM
tomek committed rCOMM63a1cf0a71f8: [native] Open a community when a user clicks an invite link and is already a… (authored by tomek).
[native] Open a community when a user clicks an invite link and is already a…
Jun 6 2024, 9:28 AM
tomek closed D12316: [web] Open a community when a user clicks an invite link and is already a member.
Jun 6 2024, 9:27 AM
tomek committed rCOMMfb63d1e6ca6c: [web] Open a community when a user clicks an invite link and is already a member (authored by tomek).
[web] Open a community when a user clicks an invite link and is already a member
Jun 6 2024, 9:27 AM
tomek accepted D12329: [lib] Dispatch processNewUserIDsActionType.
Jun 6 2024, 4:18 AM
tomek accepted D12328: [lib] Avoid unnecessary state change in user reducer.
Jun 6 2024, 4:06 AM

Jun 5 2024

tomek accepted D12318: [lib] Don't remove avatar when fetching username.
Jun 5 2024, 6:59 AM
tomek accepted D12319: [lib] Fetch user avatars for new user ids.
Jun 5 2024, 6:53 AM
tomek requested review of D12320: [lib][web][native] Navigate to a thread after joining a community.
Jun 5 2024, 6:40 AM
tomek requested review of D12317: [native] Open a community when a user clicks an invite link and is already a member.
Jun 5 2024, 4:38 AM
tomek requested review of D12316: [web] Open a community when a user clicks an invite link and is already a member.
Jun 5 2024, 4:00 AM
tomek added inline comments to D12315: [lib] Introduce `MemberInfoSansPermissions`.
Jun 5 2024, 2:32 AM
tomek accepted D12315: [lib] Introduce `MemberInfoSansPermissions`.
Jun 5 2024, 2:30 AM
tomek accepted D12313: [keyserver][lib] Add ACKNOWLEDGE relationship action.
Jun 5 2024, 2:27 AM

Jun 4 2024

tomek closed D12314: [lib] Fix minification issue.
Jun 4 2024, 9:15 AM
tomek committed rCOMM6d5dc0f15fcb: [lib] Fix minification issue (authored by tomek).
[lib] Fix minification issue
Jun 4 2024, 9:15 AM
tomek added inline comments to D12062: [keyserver/lib] introduce MANAGE_FARCASTER_CHANNEL_TAGS permission.
Jun 4 2024, 5:55 AM
tomek closed D12049: [lib] Add a way of marking migrations as schema-changing.
Jun 4 2024, 5:45 AM
tomek committed rCOMMd6d8d733cb12: [lib] Add a way of marking migrations as schema-changing (authored by tomek).
[lib] Add a way of marking migrations as schema-changing
Jun 4 2024, 5:45 AM
tomek closed D12015: [lib] Extract a function that runs the migrations.
Jun 4 2024, 5:45 AM
tomek committed rCOMMd83cc6dbb473: [lib] Extract a function that runs the migrations (authored by tomek).
[lib] Extract a function that runs the migrations
Jun 4 2024, 5:45 AM
tomek closed D12014: [lib] Move createAsyncMigrate to utils.
Jun 4 2024, 5:45 AM
tomek closed D11947: [web] Check backup version when restoring.
Jun 4 2024, 5:45 AM
tomek closed D12013: [native] Verify if the backup version is correct.
Jun 4 2024, 5:45 AM
tomek committed rCOMMc75e3a4b8a2a: [lib] Move createAsyncMigrate to utils (authored by tomek).
[lib] Move createAsyncMigrate to utils
Jun 4 2024, 5:45 AM