Page MenuHomePhabricator
Feed Advanced Search

Aug 5 2024

bartek added inline comments to D12960: [terraform] configure personal ip address through script and not allowed_ips var.
Aug 5 2024, 2:46 AM
bartek accepted D12959: [terraform] Adds aws region export to aws-deploy.sh script.

Accepting because according to your test plan, it worked. It should work as long as aws-cli-v2 is used because it supports AWS_DEFAULT_REGION.

Aug 5 2024, 2:41 AM
bartek accepted D12958: [native] Implement utils to lock MMKV for entire sequence of operations and use to to sync encryption and decryption of notifs.

Nice, this logic makes sense to me. I'm wondering, why lock() and unlock() are undocumented in MMKV...

Aug 5 2024, 2:35 AM
bartek published D12962: [lib] Add action type to remove peer user for review.
Aug 5 2024, 2:27 AM
bartek published D12961: [lib] Delete auxUserStore users on authoritative keyserver request for review.
Aug 5 2024, 2:27 AM

Aug 2 2024

bartek accepted D12928: [keyserver] Run webapp through comm services cluster.
Aug 2 2024, 10:35 AM

Aug 1 2024

bartek added inline comments to D12917: [tunnelbroker] Implement messages TTL after device deletion.
Aug 1 2024, 8:02 AM
bartek updated the test plan for D12945: [lib] Re-broadcast account deletion on own devices.
Aug 1 2024, 6:50 AM
bartek updated the test plan for D12944: [lib] Broadcast account deletion message to peers.
Aug 1 2024, 6:49 AM
bartek added inline comments to D12900: Prevent desktop devices from presenting themselves as web to identity.
Aug 1 2024, 6:38 AM
bartek published D12945: [lib] Re-broadcast account deletion on own devices for review.
Aug 1 2024, 2:02 AM
bartek published D12944: [lib] Broadcast account deletion message to peers for review.
Aug 1 2024, 2:01 AM
bartek accepted D12955: [lib] start using `SetDeviceTokenWithPlatform`.
Aug 1 2024, 1:52 AM
bartek accepted D12952: [lib] Remove usernames sent by the keyserver and use reservedUserIdentifiers.

As far as I have context, this makes sense!

Aug 1 2024, 1:50 AM

Jul 31 2024

bartek added inline comments to D12914: [lib] Allow creating thick threads from existing threads.
Jul 31 2024, 9:47 AM
bartek accepted D12953: [terraform] Deploy Tunnelbroker 0.14 to staging and prod.
Jul 31 2024, 7:30 AM
bartek accepted D12951: [Tunnelbroker] invalidate bad FCM tokens.
Jul 31 2024, 5:57 AM
bartek accepted D12937: [Tunnelbroker] add message to set Device Token with Platform.
Jul 31 2024, 3:45 AM
bartek closed D12926: [lib][native][web] Extend findUserIdentities response type.
Jul 31 2024, 2:07 AM
bartek closed D12925: [native_rust_library] Extend findUserIdentities response.
Jul 31 2024, 2:07 AM
bartek committed rCOMMef5dbcde24ae: [lib][native][web] Extend findUserIdentities response type (authored by bartek).
[lib][native][web] Extend findUserIdentities response type
Jul 31 2024, 2:07 AM
bartek committed rCOMM3f658aede0a3: [native_rust_library] Extend findUserIdentities response (authored by bartek).
[native_rust_library] Extend findUserIdentities response
Jul 31 2024, 2:07 AM
bartek closed D12924: [identity] Query reserved usernames in FindUserIdentities RPC.
Jul 31 2024, 2:07 AM
bartek closed D12923: [terraform][dynamodb] Add userID index to reserved usernames table.
Jul 31 2024, 2:07 AM
bartek committed rCOMMc5bb3ade0c98: [terraform][dynamodb] Add userID index to reserved usernames table (authored by bartek).
[terraform][dynamodb] Add userID index to reserved usernames table
Jul 31 2024, 2:07 AM
bartek committed rCOMM999f07d88924: [identity] Query reserved usernames in FindUserIdentities RPC (authored by bartek).
[identity] Query reserved usernames in FindUserIdentities RPC
Jul 31 2024, 2:07 AM
bartek closed D12922: [protos][identity] Add reserved usernames to UserIdentitiesResponse.
Jul 31 2024, 2:07 AM
bartek committed rCOMMca98cfd13157: [protos][identity] Add reserved usernames to UserIdentitiesResponse (authored by bartek).
[protos][identity] Add reserved usernames to UserIdentitiesResponse
Jul 31 2024, 2:07 AM
bartek added a comment to D12926: [lib][native][web] Extend findUserIdentities response type.

I think we'll need to update the two handler components here to look at the newly-returned reservedUserIdentities property, but my impression is that this will be handled by @inka in a later diff

Jul 31 2024, 1:35 AM
bartek updated the diff for D12926: [lib][native][web] Extend findUserIdentities response type.

Rename to reservedUserIdentifiers

Jul 31 2024, 1:33 AM
bartek updated the diff for D12925: [native_rust_library] Extend findUserIdentities response.

Rename to reserved_user_identifiers

Jul 31 2024, 1:33 AM
bartek updated the diff for D12924: [identity] Query reserved usernames in FindUserIdentities RPC.

Rename to reserved_user_identifiers

Jul 31 2024, 1:33 AM
bartek updated the diff for D12922: [protos][identity] Add reserved usernames to UserIdentitiesResponse.

Rename to reserved_user_identifiers

Jul 31 2024, 1:26 AM

Jul 30 2024

bartek published D12943: [lib] Add account deletion P2P message type for review.
Jul 30 2024, 11:23 PM
bartek added inline comments to D12922: [protos][identity] Add reserved usernames to UserIdentitiesResponse.
Jul 30 2024, 11:22 PM
bartek accepted D12929: [terraform] use module approach for landing.
Jul 30 2024, 8:26 AM
bartek added a comment to D12928: [keyserver] Run webapp through comm services cluster.

General question:
What's the advantage of sops-encrypting new .env files instead of reusing our sops_file resource for secrets.json, having webapp-specific config inside it, and then doing

webapp_environment_vars = merge(local.secrets.webapp_secrets,  { ... })

?

Jul 30 2024, 8:26 AM
bartek accepted D12939: [Tunnelbroker] handle `SetDeviceTokenWithPlatform` message.

In what situations are we going to keep using the old SetDeviceTokenWithoutPlatform?

Jul 30 2024, 7:57 AM
bartek accepted D12946: [Tunnelbroker] invalidate bad Web Push tokens.
Jul 30 2024, 7:53 AM
bartek accepted D12940: [Tunnelbroker] validate device platform before sending notif.
Jul 30 2024, 7:46 AM
bartek updated subscribers of D12937: [Tunnelbroker] add message to set Device Token with Platform.
Jul 30 2024, 7:28 AM
bartek accepted D12938: [Tunnelbroker] add Platform column to `device_token` DDB table.

Generally okay, personally I'd organize it a bit differently but that doesn't matter

Jul 30 2024, 7:20 AM
bartek closed D12890: [identity] Rewrite GetDeviceLists RPC to use batch functions.
Jul 30 2024, 6:05 AM
bartek committed rCOMMc54e535c5b84: [identity] Rewrite GetDeviceLists RPC to use batch functions (authored by bartek).
[identity] Rewrite GetDeviceLists RPC to use batch functions
Jul 30 2024, 6:04 AM
bartek closed D12889: [identity] Add function to batch-get platform details.
Jul 30 2024, 6:04 AM
bartek committed rCOMMdafbe70faaf7: [identity] Add function to batch-get platform details (authored by bartek).
[identity] Add function to batch-get platform details
Jul 30 2024, 6:04 AM
bartek closed D12888: [identity] Add function to batch-get device lists.
Jul 30 2024, 6:04 AM
bartek committed rCOMM52e8224b3e28: [identity] Add function to batch-get device lists (authored by bartek).
[identity] Add function to batch-get device lists
Jul 30 2024, 6:04 AM
bartek added inline comments to D12888: [identity] Add function to batch-get device lists.
Jul 30 2024, 6:00 AM
bartek accepted D12933: [Tunnelbroker] implement WNS client.
Jul 30 2024, 3:44 AM
bartek accepted D12932: [Tunnelbroker] implement WNS config.
Jul 30 2024, 3:44 AM
bartek accepted D12931: [terraform] add WNS secrets config.
Jul 30 2024, 3:43 AM

Jul 29 2024

bartek added inline comments to D12910: [Tunnelbroker][lib] add `BadDeviceToken` message type.
Jul 29 2024, 12:11 PM
bartek published D12926: [lib][native][web] Extend findUserIdentities response type for review.
Jul 29 2024, 12:04 PM
bartek published D12925: [native_rust_library] Extend findUserIdentities response for review.
Jul 29 2024, 12:03 PM
bartek published D12924: [identity] Query reserved usernames in FindUserIdentities RPC for review.
Jul 29 2024, 12:02 PM
bartek published D12923: [terraform][dynamodb] Add userID index to reserved usernames table for review.
Jul 29 2024, 12:02 PM
bartek published D12922: [protos][identity] Add reserved usernames to UserIdentitiesResponse for review.
Jul 29 2024, 12:02 PM
bartek accepted D12911: [Tunnelbroker] invalidate bad APNs tokens.
Jul 29 2024, 8:20 AM
bartek accepted D12910: [Tunnelbroker][lib] add `BadDeviceToken` message type.
Jul 29 2024, 8:15 AM
bartek accepted D12920: [Tunnelbroker] add missing `ExpiredToken` error reason.
Jul 29 2024, 8:13 AM
bartek accepted D12908: [Tunnelbroker] add DDB column with information about invalid device token.

Thanks

Jul 29 2024, 8:07 AM
bartek accepted D12909: [Tunnelbroker] implement marking device token ad invalid.
Jul 29 2024, 7:28 AM
bartek requested changes to D12908: [Tunnelbroker] add DDB column with information about invalid device token.

This can be simplified and a bit more stable

Jul 29 2024, 7:26 AM
bartek published D12918: [identity] Ask Tunnelbroker to delete data on account deletion for review.
Jul 29 2024, 7:17 AM
bartek published D12917: [tunnelbroker] Implement messages TTL after device deletion for review.
Jul 29 2024, 7:13 AM
bartek closed D12897: [lib] Implement sending WebPush notifs using Tunnelbroker.
Jul 29 2024, 5:56 AM
bartek committed rCOMM9d2b6b4ad0aa: [lib] Implement sending WebPush notifs using Tunnelbroker (authored by bartek).
[lib] Implement sending WebPush notifs using Tunnelbroker
Jul 29 2024, 5:56 AM
bartek closed D12896: [tunnelbroker] Implement sending WebPush notifs by clients.
Jul 29 2024, 5:56 AM
bartek closed D12895: [tunnelbroker][lib] Add WebPush notif message type.
Jul 29 2024, 5:56 AM
bartek committed rCOMM7bb781975a47: [tunnelbroker] Implement sending WebPush notifs by clients (authored by bartek).
[tunnelbroker] Implement sending WebPush notifs by clients
Jul 29 2024, 5:56 AM
bartek committed rCOMM61bfe5dd37da: [tunnelbroker][lib] Add WebPush notif message type (authored by bartek).
[tunnelbroker][lib] Add WebPush notif message type
Jul 29 2024, 5:56 AM
bartek closed D12893: [tunnelbroker] Implement WebPush client adapter.
Jul 29 2024, 5:56 AM
bartek closed D12894: [tunnelbroker] Implement sending WebPush notifs.
Jul 29 2024, 5:56 AM
bartek committed rCOMM60a01205a529: [tunnelbroker] Implement sending WebPush notifs (authored by bartek).
[tunnelbroker] Implement sending WebPush notifs
Jul 29 2024, 5:56 AM
bartek committed rCOMMdfc5114afe7f: [tunnelbroker] Implement WebPush client adapter (authored by bartek).
[tunnelbroker] Implement WebPush client adapter
Jul 29 2024, 5:56 AM
bartek closed D12903: [util-macros] Improve TagAwareDeserialize to read serde attributes.
Jul 29 2024, 5:56 AM
bartek closed D12902: [util-macros] Add tests for serde and TagAwareDeserialize behavior.
Jul 29 2024, 5:56 AM
bartek committed rCOMMe33868cba63d: [util-macros] Improve TagAwareDeserialize to read serde attributes (authored by bartek).
[util-macros] Improve TagAwareDeserialize to read serde attributes
Jul 29 2024, 5:56 AM
bartek committed rCOMMa1ec2400de91: [util-macros] Add tests for serde and TagAwareDeserialize behavior (authored by bartek).
[util-macros] Add tests for serde and TagAwareDeserialize behavior
Jul 29 2024, 5:56 AM
bartek closed D12901: [shared][rust] Add proc-macro to deserialize tagged enum variants.
Jul 29 2024, 5:56 AM
bartek committed rCOMM9463274996c6: [shared][rust] Add proc-macro to deserialize tagged enum variants (authored by bartek).
[shared][rust] Add proc-macro to deserialize tagged enum variants
Jul 29 2024, 5:56 AM
bartek added inline comments to D12895: [tunnelbroker][lib] Add WebPush notif message type.
Jul 29 2024, 5:52 AM
bartek resigned from D12676: Migrate notifications crypto account to MMKV on native.

I'm lacking too much context here

Jul 29 2024, 1:29 AM
bartek accepted D12900: Prevent desktop devices from presenting themselves as web to identity.

now that we supply platform details as metadata, should we be sending the device type in the key upload at all? seems like we should just remove it? cc @bartek

Jul 29 2024, 1:27 AM
bartek closed D12886: [identity] Forbid duplicated devices in device lists.
Jul 29 2024, 12:16 AM
bartek committed rCOMM4c54b9c24d52: [identity] Forbid duplicated devices in device lists (authored by bartek).
[identity] Forbid duplicated devices in device lists
Jul 29 2024, 12:16 AM
bartek resigned from D12907: [native] linked devices component.

Neat! 😄 I'm not a React/UI expert so resigning, but I'm glad my gist helped.

Jul 29 2024, 12:12 AM

Jul 28 2024

bartek accepted D12906: [terraform] Create module for webapp/landing and convert webapp to module.

Nice! The code structure looks neat!
In the future we can do a similar thing to our ECS services - modules can help avoid lots of duplication.

Jul 28 2024, 11:55 PM
bartek accepted D12905: [terraform] move dns_name output to outputs.tf.
Jul 28 2024, 11:40 PM
bartek accepted D12904: [terraform] Remove unnecessary mariadb address output.
Jul 28 2024, 11:40 PM
bartek published D12903: [util-macros] Improve TagAwareDeserialize to read serde attributes for review.
Jul 28 2024, 8:11 AM
bartek published D12902: [util-macros] Add tests for serde and TagAwareDeserialize behavior for review.
Jul 28 2024, 8:10 AM
bartek published D12901: [shared][rust] Add proc-macro to deserialize tagged enum variants for review.
Jul 28 2024, 8:09 AM
bartek updated the diff for D12897: [lib] Implement sending WebPush notifs using Tunnelbroker.

Rebase

Jul 28 2024, 7:50 AM
bartek updated the diff for D12896: [tunnelbroker] Implement sending WebPush notifs by clients.

Rebase

Jul 28 2024, 7:50 AM
bartek updated the diff for D12895: [tunnelbroker][lib] Add WebPush notif message type.

Add TagAwareDeserialize to the struct. This should fix CI

Jul 28 2024, 7:18 AM

Jul 26 2024

bartek closed D12898: [identity] Fix saving majorDesktopVersion metadata.
Jul 26 2024, 7:19 AM
bartek committed rCOMMdbd6643c2d91: [identity] Fix saving majorDesktopVersion metadata (authored by bartek).
[identity] Fix saving majorDesktopVersion metadata
Jul 26 2024, 7:19 AM
bartek published D12898: [identity] Fix saving majorDesktopVersion metadata for review.
Jul 26 2024, 7:16 AM