Page MenuHomePhabricator
Feed Advanced Search

Aug 20 2024

tomek closed D13058: [lib] Delete old replies count logic.
Aug 20 2024, 9:34 AM
tomek committed rCOMM26695fb50339: [lib] Delete old replies count logic (authored by tomek).
[lib] Delete old replies count logic
Aug 20 2024, 9:34 AM
tomek committed rCOMM79baf254c49b: [lib] Add function allowing extracting ThreadInfo from updates (authored by tomek).
[lib] Add function allowing extracting ThreadInfo from updates
Aug 20 2024, 9:34 AM
tomek closed D13053: [lib] Split change thread settings spec.
Aug 20 2024, 9:33 AM
tomek closed D13055: [lib] Allow sending messages to some users.
Aug 20 2024, 9:33 AM
tomek committed rCOMM18ddf9534ce1: [lib] Allow sending messages to some users (authored by tomek).
[lib] Allow sending messages to some users
Aug 20 2024, 9:33 AM
tomek committed rCOMMf8120854b4f3: [lib] Split change thread settings spec (authored by tomek).
[lib] Split change thread settings spec
Aug 20 2024, 9:33 AM
tomek closed D13052: [lib] Split add members spec.
Aug 20 2024, 9:33 AM
tomek committed rCOMMd2fee63e6327: [lib] Split add members spec (authored by tomek).
[lib] Split add members spec
Aug 20 2024, 9:33 AM
tomek requested review of D13122: [lib] Check the store when searching for message edits.
Aug 20 2024, 8:51 AM
tomek updated the diff for D13059: [lib] Update the replies count.

Rebase

Aug 20 2024, 8:33 AM
tomek updated the diff for D13058: [lib] Delete old replies count logic.

Rebase

Aug 20 2024, 8:15 AM
tomek updated the diff for D13059: [lib] Update the replies count.

Call the new function

Aug 20 2024, 7:46 AM
tomek updated the diff for D13057: [lib] Add function allowing extracting ThreadInfo from updates.

Make the type wider

Aug 20 2024, 7:34 AM
tomek accepted D13079: [native] Fetch coordinates from context in nux tips overlay.
Aug 20 2024, 7:31 AM
tomek accepted D13085: [native] Add nux handler.
Aug 20 2024, 7:30 AM
tomek updated the diff for D13057: [lib] Add function allowing extracting ThreadInfo from updates.

Having threadInfo as a parameter doesn't make sense because in order to call this function we would need to know which part of the update represents the thread ID, which defeats the purpose of encapsulating this logic inside the spec.

Aug 20 2024, 7:02 AM
tomek added inline comments to D13081: [native] Extract community drawer button for nux tips, create community drawer tip.
Aug 20 2024, 4:43 AM
tomek requested review of D13059: [lib] Update the replies count.
In D13059#369998, @inka wrote:

We tested sidebar creation and replies count is incorrect - after creating a sidebar and adding one message to it, the count was 2 instead of 1

Aug 20 2024, 4:40 AM
tomek accepted D13080: [native] Add <next> button to nux tips.
Aug 20 2024, 4:32 AM
tomek accepted D13049: [lib] process Inbound P2P messages on app start.
Aug 20 2024, 4:30 AM
tomek added inline comments to D13057: [lib] Add function allowing extracting ThreadInfo from updates.
Aug 20 2024, 4:11 AM
tomek updated the diff for D13057: [lib] Add function allowing extracting ThreadInfo from updates.

Add a function to the read status spec

Aug 20 2024, 3:21 AM
tomek added a comment to D13057: [lib] Add function allowing extracting ThreadInfo from updates.
In D13057#370009, @inka wrote:

One thing we could do here is add a separate update type for unread status. This way the logic from D13059 that needs getUpdatedThreadInfo would not be needed, and so getUpdatedThreadInfo would not be needed. But this might be too much work.

Aug 20 2024, 2:53 AM
tomek accepted D13110: [lib][native] use `processDBStoreOperations` only from `SQLiteAPI`.
Aug 20 2024, 1:44 AM
tomek accepted D13109: [lib][native] unify `DBOpsHandler` usage.
Aug 20 2024, 1:43 AM
tomek accepted D13108: [SQLite] enable DB on web for all users.
Aug 20 2024, 1:42 AM
tomek accepted D13107: [lib][native] remove code duplication from `processDBStoreOperations`.
Aug 20 2024, 1:39 AM
tomek accepted D13114: [keyserver] Recalculate permissions and reintroduce ADD_MEMBERS permission.
Aug 20 2024, 1:37 AM
tomek accepted D13112: [lib] Allow admins to react and edit messages in sidebars.
Aug 20 2024, 1:31 AM
tomek accepted D13113: [lib] Propagate MEMBER permissions to all chats in a community.
Aug 20 2024, 1:29 AM
tomek accepted D13118: [native] Rename RegistrationButton.
Aug 20 2024, 1:24 AM
tomek accepted D13077: [native] Add mappaing from nux tips to button onPress params.
Aug 20 2024, 1:21 AM
tomek added inline comments to D13081: [native] Extract community drawer button for nux tips, create community drawer tip.
Aug 20 2024, 1:15 AM
tomek added inline comments to D13084: [native] Create muted tab tip.
Aug 20 2024, 1:13 AM

Aug 19 2024

tomek added inline comments to D13053: [lib] Split change thread settings spec.
Aug 19 2024, 7:29 AM
tomek updated the diff for D13053: [lib] Split change thread settings spec.

Rename, fix the types

Aug 19 2024, 7:28 AM
tomek added inline comments to D13052: [lib] Split add members spec.
Aug 19 2024, 7:09 AM
tomek updated the diff for D13052: [lib] Split add members spec.

Fix returned validation result

Aug 19 2024, 7:09 AM
tomek accepted D13083: [SQLite] deprecate `removeOutboundP2PMessagesOlderThan` and update to remove only one specific message.
Aug 19 2024, 6:20 AM
tomek accepted D13078: [lib] refactor sequential handling of Tunnelbroker messages.
Aug 19 2024, 6:18 AM
tomek accepted D13056: [lib] resend messages after session creation request.
Aug 19 2024, 5:55 AM
tomek accepted D13047: [SQLite] recreate table for Inbound P2P messages.
Aug 19 2024, 5:51 AM
tomek accepted D13046: [lib] reset session and resend message when device is unable to decrypt messages.
Aug 19 2024, 5:46 AM
tomek accepted D13033: [lib] add session version to EncryptedData.
Aug 19 2024, 5:34 AM
tomek requested review of D13106: [lib] Don't prune messages from thick threads.
Aug 19 2024, 5:27 AM

Aug 14 2024

tomek requested changes to D13085: [native] Add nux handler.
Aug 14 2024, 10:13 AM
tomek accepted D13084: [native] Create muted tab tip.
Aug 14 2024, 10:05 AM
tomek added inline comments to D13080: [native] Add <next> button to nux tips.
Aug 14 2024, 10:03 AM
tomek requested changes to D13082: [native] Create custom top tabs component.

Looks ok, but based on this comment https://linear.app/comm/issue/ENG-9041/update-tabs-style#comment-ce51487d I'm wondering if we can use TabBarItem from react-native-tab-view.

Aug 14 2024, 9:55 AM
tomek added a reviewer for D13081: [native] Extract community drawer button for nux tips, create community drawer tip: ashoat.

Adding @ashoat as blocking because of the copy.

Aug 14 2024, 9:37 AM
tomek accepted D13081: [native] Extract community drawer button for nux tips, create community drawer tip.
Aug 14 2024, 9:34 AM
tomek requested changes to D13080: [native] Add <next> button to nux tips.
Aug 14 2024, 9:30 AM
tomek requested changes to D13079: [native] Fetch coordinates from context in nux tips overlay.
Aug 14 2024, 9:22 AM
tomek accepted D12409: [lib] Use sqlite for message store local instead of redux persist.
Aug 14 2024, 9:11 AM
tomek accepted D13076: [keyserver] Regenerate permissions for all threads.
Aug 14 2024, 9:08 AM
tomek accepted D13075: [keyserver] Prevent updateRoles from resetting user-surfaced permissions.
Aug 14 2024, 9:08 AM
tomek accepted D13074: [keyserver][lib] Restrict updateRoles endpoint to ThinThreadType.

I don't think we're using ThreadChanges for thick threads currently.

Aug 14 2024, 8:40 AM
tomek accepted D13073: [lib] Extract userSurfacedPermissionsFromRolePermissions.
Aug 14 2024, 8:37 AM
tomek added inline comments to D13067: [lib] Add several permissions to threadPermissionsDisabledByBlock.
Aug 14 2024, 8:17 AM
tomek accepted D13068: [lib] Don't restrict permissions in descendant chats for announcement roots.
Aug 14 2024, 7:03 AM
tomek accepted D13067: [lib] Add several permissions to threadPermissionsDisabledByBlock.
Aug 14 2024, 6:55 AM
tomek accepted D13061: [lib] Make sure community admins can always react and edit messages.
Aug 14 2024, 6:51 AM
tomek accepted D13072: [native] Add possibility to display nux tip above an item.
Aug 14 2024, 6:46 AM
tomek accepted D13071: [native] Refactor nux tips overlay to reanimated 2.
Aug 14 2024, 6:08 AM
tomek accepted D13070: [native] Update reaniamted flow types.
Aug 14 2024, 5:54 AM
tomek accepted D13069: [native] Extract normal style from animated style.
Aug 14 2024, 5:53 AM
tomek accepted D13066: [native] Refactor background opacity to reanimated 2.
Aug 14 2024, 5:50 AM
tomek accepted D13065: [native] Simplify types.
Aug 14 2024, 5:36 AM
tomek accepted D13064: [native] Modify overlay context to handle reanimated 2 components.
Aug 14 2024, 5:33 AM
tomek accepted D13063: [native] Simplify name.
Aug 14 2024, 2:45 AM
tomek accepted D13062: [native] Turn MenuComponent into text.
Aug 14 2024, 2:44 AM

Aug 13 2024

tomek accepted D13060: [lib] implement function that processes and sends DM operations.
Aug 13 2024, 7:06 AM
tomek requested review of D13059: [lib] Update the replies count.
Aug 13 2024, 6:05 AM
tomek requested review of D13058: [lib] Delete old replies count logic.
Aug 13 2024, 6:00 AM
tomek requested review of D13057: [lib] Add function allowing extracting ThreadInfo from updates.
Aug 13 2024, 5:58 AM

Aug 12 2024

tomek requested review of D13055: [lib] Allow sending messages to some users.
Aug 12 2024, 10:08 AM
tomek requested review of D13053: [lib] Split change thread settings spec.
Aug 12 2024, 8:55 AM
tomek requested review of D13052: [lib] Split add members spec.
Aug 12 2024, 8:41 AM
tomek accepted D13032: [lib] resend messages after race condition.
Aug 12 2024, 1:21 AM
tomek accepted D13031: [lib] introduce resetting Outbound P2P Messages to `SQLiteAPI`.
Aug 12 2024, 1:18 AM
tomek accepted D13030: [native] introduce resetting Outbound P2P Messages to `CommCoreModule`.
Aug 12 2024, 1:17 AM
tomek accepted D13029: [web] introduce resetting Outbound P2P Messages to shared worker.
Aug 12 2024, 1:13 AM
tomek accepted D13028: [SQLite] implement resetting Outbound P2P messages.
Aug 12 2024, 1:11 AM

Aug 9 2024

tomek closed D12987: [lib] Extract read status operations logic.
Aug 9 2024, 5:24 AM
tomek committed rCOMMf9c63706bbd2: [lib] Extract read status operations logic (authored by tomek).
[lib] Extract read status operations logic
Aug 9 2024, 5:24 AM
tomek updated the diff for D12987: [lib] Extract read status operations logic.

Fix eslint

Aug 9 2024, 4:52 AM
tomek updated the diff for D12987: [lib] Extract read status operations logic.

Rebase

Aug 9 2024, 2:53 AM
tomek added inline comments to D12987: [lib] Extract read status operations logic.
Aug 9 2024, 2:46 AM
tomek accepted D13027: [lib] create session with peer only when it is missing.
Aug 9 2024, 2:39 AM
tomek accepted D13025: [web][native] unify errors from `CryptoModule` on web and native.
Aug 9 2024, 2:37 AM
tomek accepted D13024: [lib] allow to overwrite content session.
Aug 9 2024, 2:25 AM
tomek accepted D13034: [lib] Refactor decodeRolePermissionBitmask to use constructThreadPermissionString.
Aug 9 2024, 2:22 AM
tomek accepted D13019: [keyserver] Migration to recalculate all permissions.
Aug 9 2024, 2:18 AM
tomek accepted D13018: [lib] Remove descendantJoinThread from knowOfSecretChannelsPermissions.
Aug 9 2024, 2:18 AM
tomek accepted D13017: [lib] Fix role permissions for channels.
Aug 9 2024, 2:17 AM

Aug 8 2024

tomek accepted D12963: [native] Add nux context.
Aug 8 2024, 7:54 AM
tomek accepted D13016: [lib] Don't clear member_ prefix when propagating permissions to children.
Aug 8 2024, 3:19 AM
tomek added inline comments to D13015: [lib] Add support for new member_ prefix to RawThreadInfo encoders.
Aug 8 2024, 3:19 AM
tomek accepted D13015: [lib] Add support for new member_ prefix to RawThreadInfo encoders.
Aug 8 2024, 3:14 AM