- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Aug 25 2022
Aug 24 2022
Address Tomek's comments
Aug 23 2022
Aug 17 2022
Address Atul's and Ashoat's comments
Address Atul's suggestions
optimize dependency array
Aug 16 2022
address Tomek's comment
In D4824#139635, @atul wrote:Are values like inlineSidebarLeftTopOffset also expected to be used outside of the ComposedMessage component? If not, can we just set the values in the ComposedMessage styles object to avoid indirection?
Yes, these values will be used in TooltipInlineSidebar in next diff to correctly set its position.
Aug 12 2022
I confirm it works!
Aug 11 2022
In D4806#138759, @ashoat wrote:Does this have any visual effect (outside of fixing ENG-1591)?
Aug 8 2022
remove double negation
Aug 4 2022
use getContainingThreadID
Aug 3 2022
Aug 2 2022
In D4679#134595, @ashoat wrote:In D4679#134458, @jacek wrote:In D4679#134441, @tomek wrote:I think we should consider having consistent relationship action colors through the app. So green when we send / accept and red when we decline / block. @ashoat what do you think?
In native, we use the same color for every action. Probably such change will require adding some "green" variant of button because we don't have such one on web.
Maybe we can create a backlog task? I agree it would be nice to be more consistent with the colors, but don't want to slow down our progress on feature work. Ultimately we'll probably end up needing to redesign most of this after a designer takes a look.
Moved loading status selector, change updateRelationshipsAction callback name
Move createLoadingStatusSelector into Button component & simplify sintax
Fix imports
Aug 1 2022
Jul 29 2022
rebase & remove unnecessary props
Disable buttons basing on loading status
improvements after Tomek's review
In D4679#134441, @tomek wrote:I think we should consider having consistent relationship action colors through the app. So green when we send / accept and red when we decline / block. @ashoat what do you think?
Jul 28 2022
Updated Tabs component after discussion with Tomek
Seems to work correctly now!