address feedback
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Mar 26 2023
Mar 26 2023
ginsu updated the diff for D7137: [native] render thread avatars for parent/child threads in thread settings.
address feedback
ginsu updated the diff for D7135: [native] render thread avatar in CHANNEL AVATAR thread settings section.
address feedback
ginsu retitled D7134: [native] update message list header to new design from [native] render thread avatar in message list header title to [native] update message list header to new design.
Mar 25 2023
Mar 25 2023
update message list header to new desgin
No longer necessary with D7178
In D7132#212051, @ashoat wrote:Mostly questions
remove stray ?
change order
new version of useGetAvatarForThread
Mar 23 2023
Mar 23 2023
[native] render user avatars in chat screen
In D7067#212617, @ashoat wrote:One last thing that would be great if you could test: what happens if you upload a single very "thin" photo? I want to make sure it doesn't expand to take the whole width and then becomes super tall. (Or at least, that there's no regression in this.)
Sorry for all the specific test plan requests, I just remember there being a lot of edge cases with this code from back when I was working on it.
ginsu added a reverting change for rCOMM8588624614a4: [web] render avatar in account screen: rCOMM3a1e14753e51: Revert "[web] render avatar in account screen".
ginsu committed rCOMM3a1e14753e51: Revert "[web] render avatar in account screen" (authored by ginsu).
Revert "[web] render avatar in account screen"
ginsu added a reverting change for rCOMM5db4c70262ee: [web] render user avatars in chat screen: rCOMM7a811e67f0ee: Revert "[web] render user avatars in chat screen".
ginsu committed rCOMM7a811e67f0ee: Revert "[web] render user avatars in chat screen" (authored by ginsu).
Revert "[web] render user avatars in chat screen"
ginsu committed rCOMMc3011806b124: Revert "[keyserver/lib/web/native] fetch user avatar column from users table… (authored by ginsu).
Revert "[keyserver/lib/web/native] fetch user avatar column from users table…
ginsu added a reverting change for rCOMM8588624614a4: [web] render avatar in account screen: D7160: Revert "[web] render avatar in account screen".
ginsu added a reverting change for rCOMM5db4c70262ee: [web] render user avatars in chat screen: D7159: Revert "[web] render user avatars in chat screen".
ginsu committed rCOMM126db3bda66c: [keyserver/lib/web/native] fetch user avatar column from users table for… (authored by ginsu).
[keyserver/lib/web/native] fetch user avatar column from users table for…
[web] render user avatars in chat screen
[web] render avatar in account screen
memoize MessageTooltipButtonAvatar
address comments
you almost certainly need to be looking at threadInfoFromRawThreadInfo.
Mar 22 2023
Mar 22 2023
My last proposed solution to fix the chat bubble poking out of the message box is to make the message box a flex container and align the inner text messages (either flex-end or flex-start) depending on if the message came from the viewer or not. This solution is very similar to how we position the InlineEngagement component, which inspired me to implement the solution this way.
add feature flags and fix poking chat bubble
ginsu committed rCOMM9ea6a06baee7: [lib] introduce getDefaultAvatar helper function (authored by ginsu).
[lib] introduce getDefaultAvatar helper function
ginsu updated the summary of D7137: [native] render thread avatars for parent/child threads in thread settings.
ginsu updated the diff for D7135: [native] render thread avatar in CHANNEL AVATAR thread settings section.
update prop types for thread settings avatar
ginsu updated the summary of D7135: [native] render thread avatar in CHANNEL AVATAR thread settings section.