Works on dev. On prod I get invalid_parameters on the keyserver but I think that's because it's expecting web.comm.app

Will wait on docker keyserver build CI before landing

Eh, I don't love it but I won't veto. @atul what do you think?

Awesome, let's land this thing!!

Still need to delete all instances of deviceEd25519PublicKey

I'm not sure if it is the case. For now, displaying both 'delivery failed' and the label ('Edited') at the same time is impossible.

That looks correct!

Got no response to this one, requesting changes again

Cool! My feedback now is that deviceEd25519PublicKey should be removed to dedup, but I think @jon is waiting on @varun to confirm before making that change

I think it would be easier to make the requested change RE keyserverID and follow up with questions you might have for me separately.

Please remove the conditional before landing (it doesn't do anything)

@kuba can you reach out to Ted on the design team regarding this? Design above looks weird, I would at the least swap the order of the two

Got it, I think it's okay to have both. Up to you

I'm also asking for consistent naming of the ed25519 primary device public key

My personal inclination is to remove the duplication, and just parse of the keys, as we should be validating the IdentityKey payload anyway.

I think this diff would be easier to review if you included this new function's usage in the same diff

I think this diff would be easier to review if you included this new function's usage in the same diff

Cool, glad it never reached prod. Don't care about Redux vs. MySQL consistency (personally)

Mostly requesting changes to get rid of the keyserverID concept

Mostly requesting changes to revise this API to get rid of all streams for gRPC-web compatibility, but see inline comments

Is it possible we'll want to add some metadata to the content field later? I think it would be safer to use JSON

This is fine, but in order to unblock ENS-3302 we need to get to the point where we're actually rendering images here I think

Update to 3.2.14; respond to review

I agree with @varun