- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Thu, Mar 16
only reduce the width of non viewer-composed messages as well as all multimedia messages
Specifically adding @tomek as reviewer since he seemed to have some thoughts during the Encryption Sync (that might've been discussed offline?)
Specifically adding @tomek as reviewer since he seemed to have some thoughts during the Encryption Sync (that might've been discussed offline?)
Specifically adding @tomek as reviewer since he seemed to have some thoughts during the Encryption Sync (that might've been discussed offline?)
@anunay also talked about adding some JS tests, but we can sequence that later
We'll also need to update:
Prune stale dependencies
Also assert that session_key was set in test
Remove sever_setup from constructors
Use opaque 2.0, remove server setup
Open to decreasing media width
Looks good to me
Wed, Mar 15
i'm a little confused why we're moving config.rs and constants.rs into this cargo project. they seem pretty specific to the identity service.
Open to decreasing media width
I feel like we should still reduce the width for viewer-composed multimedia messages so all the multimedia messages have a consistently smaller size,
rebase before landing
rebase and land
extract useSignedIdentityKeysBlob hook to cut repetition
fix maxWidth for chat bubble so it's not poking out anymore (see test plan for visulization)
Seems uncontroversial
This is the last diff in the stack that I planned on putting up Monday/Tuesday, but ran into issues with D7081. Going to do some additional testing before landing to be extra careful.
rebase
i'm a little confused why we're moving config.rs and constants.rs into this cargo project. they seem pretty specific to the identity service. if we decide we want to store the secret key in a different location, it feels awkward that we'd have to modify a library that the identity service consumes rather than the service's own config
Thanks!! Can you send that over to Ted on the design team to make sure he approves of the changes to FailedSend? (It's worth mentioning to Ted that it's not possible for both FailedSend and the edited label to appear at the same time.)
In D7017#209805, @ashoat wrote:Can you share an updated screenshot?
Hmm, not sure if that's an issue or not. I think it might be best to try using things like paddingLeft / marginLeft instead of left and position: 'absolute'... worried that border miscalculations can lead to issues, but not immediately sure what sort of concrete issues