Page MenuHomePhabricator
Feed All Stories

Mar 17 2023

jon closed D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 17 2023, 3:41 PM
jon committed rCOMM8751e77ed757: [comm-opaque] Create opaque 2.0 facade for usage in Comm (authored by jon).
[comm-opaque] Create opaque 2.0 facade for usage in Comm
Mar 17 2023, 3:41 PM
jon added inline comments to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 17 2023, 3:38 PM
ginsu added inline comments to D7097: [lib] Introduce `*AvatarDBContent` types.
Mar 17 2023, 3:21 PM
jon updated the diff for D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

rlib -> lib

Mar 17 2023, 2:38 PM
ginsu accepted D7098: [keyserver] Add `avatar` column to `threads` table of serverDB.
Mar 17 2023, 2:18 PM
ginsu accepted D7097: [lib] Introduce `*AvatarDBContent` types.
Mar 17 2023, 2:16 PM
atul accepted D7060: [lib] Introduce superblock padding.

The Notion doc was super helpful for understanding what's going on. Thanks for taking the time to write that all out.

Mar 17 2023, 2:11 PM
ashoat added inline comments to D7059: [lib] Introduce PKCS#7 padding.
Mar 17 2023, 2:01 PM
atul added inline comments to D7059: [lib] Introduce PKCS#7 padding.
Mar 17 2023, 1:08 PM
atul accepted D7059: [lib] Introduce PKCS#7 padding.

Thanks for including unit tests!

Mar 17 2023, 1:01 PM
atul published D7098: [keyserver] Add `avatar` column to `threads` table of serverDB for review.
Mar 17 2023, 12:51 PM
atul accepted D7091: [native] Fork Olm.
Mar 17 2023, 12:49 PM
atul accepted D7089: [web][keyserver] Fork Olm.
Mar 17 2023, 12:48 PM
atul added inline comments to D7097: [lib] Introduce `*AvatarDBContent` types.
Mar 17 2023, 12:20 PM
atul published D7097: [lib] Introduce `*AvatarDBContent` types for review.
Mar 17 2023, 12:19 PM
ashoat accepted D7096: [web/desktop] Update immediately on versions v1 and v2.
Mar 17 2023, 11:30 AM
michal requested review of D7096: [web/desktop] Update immediately on versions v1 and v2.
Mar 17 2023, 11:29 AM
ashoat added a comment to D7095: [desktop] Stop checking for a new version after download.

I'm confused – we're just deleting this? Can you provide more details on what it was supposed to do, and how that intent is handled now?

Mar 17 2023, 11:28 AM
michal requested review of D7095: [desktop] Stop checking for a new version after download.
Mar 17 2023, 11:24 AM
ashoat accepted D7094: [keyserver] Send updateBadgeCount notifs to macOS.
Mar 17 2023, 11:24 AM
ginsu accepted D7093: [native] Use a JSON blob for heightMeasurerKey.
Mar 17 2023, 11:12 AM
michal requested review of D7094: [keyserver] Send updateBadgeCount notifs to macOS.
Mar 17 2023, 11:11 AM
ashoat requested review of D7093: [native] Use a JSON blob for heightMeasurerKey.
Mar 17 2023, 9:44 AM
ashoat accepted D7087: [Comm-opaque2] Add wasm build to client.

Dependencies look good! No context on Rust unfortunately

Mar 17 2023, 8:29 AM
ginsu added a comment to D7067: [native] render user avatars in chat screen.

I'm thinking basically:

  1. In current master, figure out what % of total screen width a chat bubble can take
  2. Subtract the space necessary for the avatar from the total screen width
  3. Keep the % from 1 the same after adjusting for 2

Does that make sense?

Mar 17 2023, 8:21 AM
ashoat added inline comments to D7092: [web-db] Use unique filename for each prod `sql-wasm.wasm` asset.
Mar 17 2023, 8:20 AM
kamil added inline comments to D7092: [web-db] Use unique filename for each prod `sql-wasm.wasm` asset.
Mar 17 2023, 6:46 AM
ashoat added inline comments to D7092: [web-db] Use unique filename for each prod `sql-wasm.wasm` asset.
Mar 17 2023, 6:24 AM
ashoat added inline comments to D7092: [web-db] Use unique filename for each prod `sql-wasm.wasm` asset.
Mar 17 2023, 6:23 AM
InkaSokolowska closed D6999: [web] Fix compose subchannels modal for long names.
Mar 17 2023, 5:57 AM
InkaSokolowska committed rCOMM45da19523557: [web] Fix compose subchannels modal for long names (authored by InkaSokolowska).
[web] Fix compose subchannels modal for long names
Mar 17 2023, 5:57 AM
michal accepted D7092: [web-db] Use unique filename for each prod `sql-wasm.wasm` asset.
Mar 17 2023, 5:52 AM
tomek added a comment to D7059: [lib] Introduce PKCS#7 padding.
In D7059#210217, @atul wrote:

Specifically adding @tomek as reviewer since he seemed to have some thoughts during the Encryption Sync (that might've been discussed offline?)

Mar 17 2023, 4:53 AM
kamil published D7092: [web-db] Use unique filename for each prod `sql-wasm.wasm` asset for review.
Mar 17 2023, 4:29 AM
kamil added a comment to D6993: [web-db] initialize SQLite database.

Example usage is in the test plan, unfortunately, it can not be done as elegantly as in olm case - where both web and .wasm file is hosted from the same place.

Mar 17 2023, 4:23 AM
kamil updated the test plan for D6993: [web-db] initialize SQLite database.
Mar 17 2023, 4:19 AM
kamil updated the diff for D6993: [web-db] initialize SQLite database.

Reflect changes caused by D7092

Mar 17 2023, 4:18 AM
kamil closed D6988: [web-db] not include `crypto`, `fs`, and `path` polyfills for workers.
Mar 17 2023, 3:47 AM
kamil committed rCOMMc768b34b0417: [web-db] not include `crypto`, `fs`, and `path` polyfills for workers (authored by kamil).
[web-db] not include `crypto`, `fs`, and `path` polyfills for workers
Mar 17 2023, 3:47 AM
kamil closed D6987: [web-db] add Shared Worker config.
Mar 17 2023, 3:47 AM
kamil committed rCOMM5e8770bd0377: [web-db] add Shared Worker config (authored by kamil).
[web-db] add Shared Worker config
Mar 17 2023, 3:47 AM

Mar 16 2023

ashoat updated the summary of D7089: [web][keyserver] Fork Olm.
Mar 16 2023, 8:41 PM
ashoat added a comment to D7067: [native] render user avatars in chat screen.

I'm thinking basically:

Mar 16 2023, 8:28 PM
ashoat accepted D7088: [landing] remove abosh from the team page.
Mar 16 2023, 8:25 PM
ashoat added inline comments to D7091: [native] Fork Olm.
Mar 16 2023, 8:04 PM
ashoat updated the summary of D7090: Unit tests for Olm's new X3DH methods.
Mar 16 2023, 8:03 PM
ashoat updated the summary of D7090: Unit tests for Olm's new X3DH methods.
Mar 16 2023, 8:03 PM
ashoat updated the diff for D7090: Unit tests for Olm's new X3DH methods.

Rebase

Mar 16 2023, 8:03 PM
ashoat updated the diff for D7091: [native] Fork Olm.

Rebase

Mar 16 2023, 8:02 PM
ashoat updated the diff for D7089: [web][keyserver] Fork Olm.

Update to 0.0.2... it doesn't actually affect web or keyserver, but I figure it's better to do it

Mar 16 2023, 8:02 PM
ashoat requested review of D7090: Unit tests for Olm's new X3DH methods.
Mar 16 2023, 7:50 PM
ashoat requested review of D7091: [native] Fork Olm.
Mar 16 2023, 7:49 PM
ashoat added a comment to D7089: [web][keyserver] Fork Olm.

Pulled out native side to D7091 since it turned out to be more work than expected

Mar 16 2023, 7:35 PM
ashoat updated the diff for D7089: [web][keyserver] Fork Olm.

Pull out the native work

Mar 16 2023, 7:33 PM
ashoat retitled D7089: [web][keyserver] Fork Olm from Fork Olm to [web][keyserver] Fork Olm.
Mar 16 2023, 7:33 PM
ashoat accepted D7083: Amended Account & Session types..

I handled my first comment in D7089, and added tests in D7090. I also updated this diff to include the libdef in keyserver

Mar 16 2023, 6:59 PM
ashoat updated the test plan for D7089: [web][keyserver] Fork Olm.
Mar 16 2023, 6:56 PM
ashoat requested review of D7089: [web][keyserver] Fork Olm.

RE CI failure, looks like we need to update the xcode folder in the fork as well. Will publish this for review for now, but will definitely make sure to fix the xcode folder before landing

Mar 16 2023, 6:56 PM
ashoat updated the diff for D7083: Amended Account & Session types..

Add keyserver types as well

Mar 16 2023, 6:51 PM
ginsu accepted D7018: [web] Displaying 'Edit' label next to edited messages.

Ah nice, disregard my comment about the if condition in the previous diff.

Mar 16 2023, 6:50 PM
ginsu added a comment to D7017: [web] Added displaying 'Labels' to InlineEngagment.

Also after reading D7018 disregard my comment above about the if statement

Mar 16 2023, 6:49 PM
ginsu requested changes to D7017: [web] Added displaying 'Labels' to InlineEngagment.

Left a few comments inline. Should we also add a condition to the if condition in composed-message to render the inline engagement?

Mar 16 2023, 6:40 PM
ginsu accepted D6966: [lib] Add 'hasBeenEdited' status to messages.
Mar 16 2023, 6:25 PM
ginsu accepted D6965: [lib][native] Displaying edited messages from database.

accepting with one question inline

Mar 16 2023, 5:33 PM
varun accepted D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

just one nit inline

Mar 16 2023, 5:23 PM
ginsu requested review of D7088: [landing] remove abosh from the team page.
Mar 16 2023, 5:15 PM
ginsu accepted D6963: [lib] Added new MessageSpec for editing messages.

Nice thanks for addressing my comments and adding shimUnsupportedMessageInfo and unshimMessageInfo . Just make sure before you land that you address @ashoat's comment above and please make note somewhere or create a linear task to set the correct code version when we launch this feature

Mar 16 2023, 5:14 PM
jon added a comment to D7087: [Comm-opaque2] Add wasm build to client.

This currently produces the outpus:

$ du -hd0 --apparent-size pkg/*
715	pkg/comm_opaque.d.ts
160	pkg/comm_opaque.js
14K	pkg/comm_opaque_bg.js
142K	pkg/comm_opaque_bg.wasm
1005	pkg/comm_opaque_bg.wasm.d.ts
249	pkg/package.json
Mar 16 2023, 5:04 PM
jon added a comment to D7087: [Comm-opaque2] Add wasm build to client.

Add @ashoat because addtion of wasm-pack utility, and new usage of wasm_bindgen crate

Mar 16 2023, 5:02 PM
jon updated the diff for D7087: [Comm-opaque2] Add wasm build to client.

Add back rlib for in-repo usage

Mar 16 2023, 5:01 PM
jon updated the diff for D7087: [Comm-opaque2] Add wasm build to client.

Add wasm-pack to this diff

Mar 16 2023, 5:00 PM
jon updated the diff for D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

Move wasm-pack to wasm diff

Mar 16 2023, 4:59 PM
jon added inline comments to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Mar 16 2023, 4:56 PM
jon updated the diff for D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

Address feedback

Mar 16 2023, 4:56 PM
jon requested review of D7087: [Comm-opaque2] Add wasm build to client.
Mar 16 2023, 4:45 PM
ginsu added a comment to D7067: [native] render user avatars in chat screen.

Did you decrease both chat bubbles' sizes by avatarOffset? That means we're subtracting 2 * avatarOffset when we only need space for avatarOffset, right? Can you please adjust it appropriately to maintain previous proportions?

Mar 16 2023, 4:17 PM
ashoat requested changes to D7067: [native] render user avatars in chat screen.

Did you decrease both chat bubbles' sizes by avatarOffset? That means we're subtracting 2 * avatarOffset when we only need space for avatarOffset, right? Can you please adjust it appropriately to maintain previous proportions?

Mar 16 2023, 3:38 PM
ginsu added inline comments to D7067: [native] render user avatars in chat screen.
Mar 16 2023, 3:22 PM
ginsu updated the summary of D7067: [native] render user avatars in chat screen.
Mar 16 2023, 3:21 PM
ginsu updated the diff for D7067: [native] render user avatars in chat screen.

make width consistent for all composed messages

Mar 16 2023, 3:19 PM
ginsu planned changes to D7067: [native] render user avatars in chat screen.

Reduce the width for ALL composed messages bubbles to maintain consistency on the width

Mar 16 2023, 3:12 PM
ginsu added a comment to D7067: [native] render user avatars in chat screen.

Offline asked @ginsu if we should maintain consistency on the width of chat message bubbles for viewer vs. non-viewer, he's going to check with Ted

Mar 16 2023, 3:09 PM
ashoat added a comment to D7067: [native] render user avatars in chat screen.

Offline asked @ginsu if we should maintain consistency on the width of chat message bubbles for viewer vs. non-viewer, he's going to check with Ted

Mar 16 2023, 3:05 PM
ashoat closed D7080: [lib] Don't mention GENESIS in chat creation notifs.
Mar 16 2023, 2:32 PM
ashoat closed D7079: [lib] Don't refer to children of GENESIS as channels.
Mar 16 2023, 2:32 PM
ashoat committed rCOMMe6395952c5fc: [lib] Don't mention GENESIS in chat creation notifs (authored by ashoat).
[lib] Don't mention GENESIS in chat creation notifs
Mar 16 2023, 2:32 PM
ashoat committed rCOMM8a45f64f5cf9: [lib] Don't refer to children of GENESIS as channels (authored by ashoat).
[lib] Don't refer to children of GENESIS as channels
Mar 16 2023, 2:32 PM
ashoat closed D7078: [lib] Pass threadType and parentThreadID to alwaysDisplayShortName ThreadEntity.
Mar 16 2023, 2:32 PM
ashoat committed rCOMMa8e48f162d74: [lib] Pass threadType and parentThreadID to alwaysDisplayShortName ThreadEntity (authored by ashoat).
[lib] Pass threadType and parentThreadID to alwaysDisplayShortName ThreadEntity
Mar 16 2023, 2:32 PM
ashoat closed D7071: [keyserver] Fix update-geoip call in Docker environment.
Mar 16 2023, 2:29 PM
ashoat committed rCOMMdf25e4a43a8d: [keyserver] Fix update-geoip call in Docker environment (authored by ashoat).
[keyserver] Fix update-geoip call in Docker environment
Mar 16 2023, 2:29 PM
atul committed rCOMMa642904cfbf4: Revert "[native] Temporary changes for staff release" (authored by atul).
Revert "[native] Temporary changes for staff release"
Mar 16 2023, 2:17 PM
atul committed rCOMM231f12c54514: [native] `codeVersion` -> 202 (authored by atul).
[native] `codeVersion` -> 202
Mar 16 2023, 2:17 PM
atul committed rCOMMcd03dee294ec: [native] Temporary changes for staff release (authored by atul).
[native] Temporary changes for staff release
Mar 16 2023, 2:17 PM
atul committed rCOMMdd2f634cda2d: [native] `codeVersion` -> 201 (authored by atul).
[native] `codeVersion` -> 201
Mar 16 2023, 2:17 PM
ashoat closed D7086: [lib] Add message type to "content must be defined" errors.
Mar 16 2023, 2:01 PM
ashoat closed D7085: [native] Add a C++ MessageSpec for SidebarSource.
Mar 16 2023, 2:01 PM
ashoat committed rCOMM85ee79ab18d1: [lib] Add message type to "content must be defined" errors (authored by ashoat).
[lib] Add message type to "content must be defined" errors
Mar 16 2023, 2:01 PM
ashoat committed rCOMM7faf93694def: [native] Add a C++ MessageSpec for SidebarSource (authored by ashoat).
[native] Add a C++ MessageSpec for SidebarSource
Mar 16 2023, 2:01 PM