- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Mar 17 2023
rlib -> lib
The Notion doc was super helpful for understanding what's going on. Thanks for taking the time to write that all out.
Thanks for including unit tests!
I'm confused – we're just deleting this? Can you provide more details on what it was supposed to do, and how that intent is handled now?
Dependencies look good! No context on Rust unfortunately
In D7067#210469, @ashoat wrote:I'm thinking basically:
- In current master, figure out what % of total screen width a chat bubble can take
- Subtract the space necessary for the avatar from the total screen width
- Keep the % from 1 the same after adjusting for 2
Does that make sense?
In D7059#210217, @atul wrote:Specifically adding @tomek as reviewer since he seemed to have some thoughts during the Encryption Sync (that might've been discussed offline?)
Example usage is in the test plan, unfortunately, it can not be done as elegantly as in olm case - where both web and .wasm file is hosted from the same place.
Reflect changes caused by D7092
Mar 16 2023
I'm thinking basically:
Update to 0.0.2... it doesn't actually affect web or keyserver, but I figure it's better to do it
Pulled out native side to D7091 since it turned out to be more work than expected
Pull out the native work
RE CI failure, looks like we need to update the xcode folder in the fork as well. Will publish this for review for now, but will definitely make sure to fix the xcode folder before landing
Add keyserver types as well
Ah nice, disregard my comment about the if condition in the previous diff.
Also after reading D7018 disregard my comment above about the if statement
Left a few comments inline. Should we also add a condition to the if condition in composed-message to render the inline engagement?
accepting with one question inline
just one nit inline
Nice thanks for addressing my comments and adding shimUnsupportedMessageInfo and unshimMessageInfo . Just make sure before you land that you address @ashoat's comment above and please make note somewhere or create a linear task to set the correct code version when we launch this feature
This currently produces the outpus:
$ du -hd0 --apparent-size pkg/* 715 pkg/comm_opaque.d.ts 160 pkg/comm_opaque.js 14K pkg/comm_opaque_bg.js 142K pkg/comm_opaque_bg.wasm 1005 pkg/comm_opaque_bg.wasm.d.ts 249 pkg/package.json
Add @ashoat because addtion of wasm-pack utility, and new usage of wasm_bindgen crate
Add back rlib for in-repo usage
Add wasm-pack to this diff
Move wasm-pack to wasm diff
Address feedback
In D7067#210294, @ashoat wrote:Did you decrease both chat bubbles' sizes by avatarOffset? That means we're subtracting 2 * avatarOffset when we only need space for avatarOffset, right? Can you please adjust it appropriately to maintain previous proportions?
Did you decrease both chat bubbles' sizes by avatarOffset? That means we're subtracting 2 * avatarOffset when we only need space for avatarOffset, right? Can you please adjust it appropriately to maintain previous proportions?
make width consistent for all composed messages
Reduce the width for ALL composed messages bubbles to maintain consistency on the width
Offline asked @ginsu if we should maintain consistency on the width of chat message bubbles for viewer vs. non-viewer, he's going to check with Ted
Offline asked @ginsu if we should maintain consistency on the width of chat message bubbles for viewer vs. non-viewer, he's going to check with Ted