Page MenuHomePhabricator
People angelika

angelika (Angelika Serwa)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 14 2024, 4:25 AM (23 w, 18 h)

Recent Activity
View All

Fri, Mar 21

angelika requested review of D14487: [ci] Update mac runner image in github workflows.
Fri, Mar 21, 5:28 AM
angelika accepted D14486: [native] Script to bump native version.

LGTM, but:

  • don't we need to document it somewhere in some README?
  • as far as I understand to update the version you bump the version in version.mjs first, then run the script, can't we automate the first step too?
  • you can also automate making commits too later?
Fri, Mar 21, 12:32 AM

Thu, Mar 20

angelika published D14481: [native] Remove ffmpeg dependency for review.
Thu, Mar 20, 5:57 AM
angelika published D14480: [native] Use transcodeVideo() from MediaModule instead of ffmpeg for review.
Thu, Mar 20, 5:57 AM
angelika published D14479: [ios] Implement transcodeVideo() function on iOS for review.
Thu, Mar 20, 5:57 AM
angelika published D14478: [android] Implement transcodeVideo() function on Android for review.
Thu, Mar 20, 5:57 AM
angelika published D14477: [native] Use generateThumbnail() from MediaModule instead of ffmpeg for review.
Thu, Mar 20, 5:57 AM
angelika published D14476: [ios] Implement generateThumbnail() function on iOS for review.
Thu, Mar 20, 5:56 AM
angelika published D14475: [android] Implement generateThumbnail() function on Android for review.
Thu, Mar 20, 5:56 AM
angelika published D14474: [native] Use hasMultipleFrames() from MediaModule instead of ffmpeg for review.
Thu, Mar 20, 5:56 AM
angelika published D14473: [ios] Implement hasMultipleFrames() function on iOS for review.
Thu, Mar 20, 5:56 AM
angelika published D14472: [android] Implement hasMultipleFrames() function on Android for review.
Thu, Mar 20, 5:56 AM
angelika published D14471: [native] Use getVideoInfo from MediaModule instead of ffmpeg for review.
Thu, Mar 20, 5:55 AM
angelika published D14470: [ios] Implement getVideoInfo() function on iOS for review.
Thu, Mar 20, 5:55 AM
angelika published D14469: [android] Implement getVideoInfo() function on Android for review.
Thu, Mar 20, 5:55 AM
angelika published D14468: [native] Add MediaModule expo module for review.
Thu, Mar 20, 5:55 AM

Mon, Mar 17

angelika closed D14430: [native] Temporary fix for not opening FullScreenViewModal on Android.
Mon, Mar 17, 7:11 AM
angelika committed rCOMM14f44e8ce8a8: [native] Temporary fix for not opening FullScreenViewModal on Android (authored by angelika).
[native] Temporary fix for not opening FullScreenViewModal on Android
Mon, Mar 17, 7:11 AM

Thu, Mar 13

angelika accepted D14442: [native] update Podfile.lock.
Thu, Mar 13, 8:52 AM

Wed, Mar 12

angelika updated the diff for D14430: [native] Temporary fix for not opening FullScreenViewModal on Android.

Rebase & fix outsideButtons on Android

Wed, Mar 12, 4:23 AM

Tue, Mar 11

angelika accepted D14434: [CI] update NDK to 23 and bump Corrosion.
Tue, Mar 11, 6:44 AM

Mon, Mar 10

angelika added inline comments to D14434: [CI] update NDK to 23 and bump Corrosion.
Mon, Mar 10, 8:27 AM
angelika added a comment to D14430: [native] Temporary fix for not opening FullScreenViewModal on Android.
In D14430#401022, @tomek wrote:

How does the app look like with a modal and the status bar visible?

Mon, Mar 10, 7:07 AM

Wed, Mar 5

angelika updated the summary of D14430: [native] Temporary fix for not opening FullScreenViewModal on Android.
Wed, Mar 5, 2:36 AM
angelika published D14430: [native] Temporary fix for not opening FullScreenViewModal on Android for review.
Wed, Mar 5, 2:33 AM

Mon, Mar 3

angelika closed D14409: [native] Remove reanimated v1 code from animation-utils.js.
Mon, Mar 3, 5:58 AM
angelika closed D14411: [native] Remove tipHorizontalOffset from NUXTipsOverlay.
Mon, Mar 3, 5:58 AM
angelika closed D14410: [native] Rename clampV2 to clamp.
Mon, Mar 3, 5:58 AM
angelika committed rCOMMe2e38d447227: [native] Remove tipHorizontalOffset from NUXTipsOverlay (authored by angelika).
[native] Remove tipHorizontalOffset from NUXTipsOverlay
Mon, Mar 3, 5:58 AM
angelika committed rCOMM510a19d15c0a: [native] Remove reanimated v1 code from animation-utils.js (authored by angelika).
[native] Remove reanimated v1 code from animation-utils.js
Mon, Mar 3, 5:58 AM
angelika committed rCOMM4e296f4ab640: [native] Rename clampV2 to clamp (authored by angelika).
[native] Rename clampV2 to clamp
Mon, Mar 3, 5:58 AM
angelika closed D14407: [native] Rename positionV2 to position in overlay navigator.
Mon, Mar 3, 5:58 AM
angelika closed D14408: [native] Rename progressV2 variables to progress.
Mon, Mar 3, 5:58 AM
angelika committed rCOMM0c8cb92c0d46: [native] Rename positionV2 to position in overlay navigator (authored by angelika).
[native] Rename positionV2 to position in overlay navigator
Mon, Mar 3, 5:58 AM
angelika committed rCOMMfcfc812c065a: [native] Rename progressV2 variables to progress (authored by angelika).
[native] Rename progressV2 variables to progress
Mon, Mar 3, 5:58 AM
angelika closed D14406: [native] Remove position from overlay navigator.
Mon, Mar 3, 5:57 AM
angelika committed rCOMMe99d6d2a3732: [native] Remove position from overlay navigator (authored by angelika).
[native] Remove position from overlay navigator
Mon, Mar 3, 5:57 AM

Wed, Feb 26

angelika added a comment to D14411: [native] Remove tipHorizontalOffset from NUXTipsOverlay.
In D14411#400429, @ashoat wrote:

Was the NUX tooltips ever implemented in Reanimated v1? It's relatively new in our codebase

Wed, Feb 26, 3:09 AM

Tue, Feb 25

angelika added a comment to D14411: [native] Remove tipHorizontalOffset from NUXTipsOverlay.
In D14411#400375, @tomek wrote:

Do we know what was the intention of this code and whether we have a corresponding logic in the Reanimated 2 code?

Tue, Feb 25, 5:17 AM
angelika published D14411: [native] Remove tipHorizontalOffset from NUXTipsOverlay for review.
Tue, Feb 25, 3:36 AM
angelika published D14410: [native] Rename clampV2 to clamp for review.
Tue, Feb 25, 3:35 AM
angelika published D14409: [native] Remove reanimated v1 code from animation-utils.js for review.
Tue, Feb 25, 3:35 AM
angelika published D14408: [native] Rename progressV2 variables to progress for review.
Tue, Feb 25, 3:35 AM
angelika published D14407: [native] Rename positionV2 to position in overlay navigator for review.
Tue, Feb 25, 3:35 AM
angelika published D14406: [native] Remove position from overlay navigator for review.
Tue, Feb 25, 3:34 AM
angelika closed D14381: [web] Add colon in qr code login copy.
Tue, Feb 25, 2:52 AM
angelika committed rCOMMb952e5ec7881: [web] Add colon in qr code login copy (authored by angelika).
[web] Add colon in qr code login copy
Tue, Feb 25, 2:52 AM
angelika closed D14313: [native] Migrate render function and finish FullScreenViewModal migration to functional component.
Tue, Feb 25, 2:48 AM
angelika committed rCOMM5a00b30209f9: [native] Migrate render function and finish FullScreenViewModal migration to… (authored by angelika).
[native] Migrate render function and finish FullScreenViewModal migration to…
Tue, Feb 25, 2:48 AM
angelika closed D14312: [native] Migrate animated styles to Reanimated v2 API in FullScreenViewModal.
Tue, Feb 25, 2:48 AM
angelika closed D14311: [native] Migrate updateDimensions method in FullScreenViewModal to functional component.
Tue, Feb 25, 2:48 AM
angelika committed rCOMM0452eeb23353: [native] Migrate animated styles to Reanimated v2 API in FullScreenViewModal (authored by angelika).
[native] Migrate animated styles to Reanimated v2 API in FullScreenViewModal
Tue, Feb 25, 2:48 AM
angelika closed D14310: [native] Remove leftover Reanimated v1 code in FullScreenViewModal.
Tue, Feb 25, 2:48 AM
angelika committed rCOMMf6871b1a3ad0: [native] Migrate updateDimensions method in FullScreenViewModal to functional… (authored by angelika).
[native] Migrate updateDimensions method in FullScreenViewModal to functional…
Tue, Feb 25, 2:48 AM
angelika closed D14309: [native] Cancel animations when gesture is started in FullScreenViewModal.
Tue, Feb 25, 2:48 AM
angelika committed rCOMM43c03694bf15: [native] Remove leftover Reanimated v1 code in FullScreenViewModal (authored by angelika).
[native] Remove leftover Reanimated v1 code in FullScreenViewModal
Tue, Feb 25, 2:48 AM
angelika closed D14308: [native] Migrate fling functionality in FullScreenViewModal.
Tue, Feb 25, 2:48 AM
angelika committed rCOMM3e75cc6b16f4: [native] Cancel animations when gesture is started in FullScreenViewModal (authored by angelika).
[native] Cancel animations when gesture is started in FullScreenViewModal
Tue, Feb 25, 2:48 AM
angelika closed D14307: [native] Migrate recenter functionality in FullScreenViewModal.
Tue, Feb 25, 2:48 AM
angelika committed rCOMMf4bc51387b80: [native] Migrate fling functionality in FullScreenViewModal (authored by angelika).
[native] Migrate fling functionality in FullScreenViewModal
Tue, Feb 25, 2:48 AM
angelika committed rCOMM87db6a222d12: [native] Migrate recenter functionality in FullScreenViewModal (authored by angelika).
[native] Migrate recenter functionality in FullScreenViewModal
Tue, Feb 25, 2:48 AM
angelika closed D14306: [native] Migrate backdropOpacityUpdate in FullScreenViewModal.
Tue, Feb 25, 2:48 AM
angelika closed D14305: [native] Migrate double tap gesture handling in FullScreenViewModal.
Tue, Feb 25, 2:48 AM
angelika committed rCOMM89acbf761f52: [native] Migrate backdropOpacityUpdate in FullScreenViewModal (authored by angelika).
[native] Migrate backdropOpacityUpdate in FullScreenViewModal
Tue, Feb 25, 2:48 AM
angelika closed D14304: [native] Migrate single tap gesture handling in FullScreenViewModal.
Tue, Feb 25, 2:48 AM
angelika committed rCOMMe0028f81cbb3: [native] Migrate double tap gesture handling in FullScreenViewModal (authored by angelika).
[native] Migrate double tap gesture handling in FullScreenViewModal
Tue, Feb 25, 2:48 AM
angelika committed rCOMM624f6e3eacf9: [native] Migrate single tap gesture handling in FullScreenViewModal (authored by angelika).
[native] Migrate single tap gesture handling in FullScreenViewModal
Tue, Feb 25, 2:48 AM
angelika closed D14303: [native] Migrate pinch gesture handling in FullScreenViewModal.
Tue, Feb 25, 2:48 AM
angelika closed D14302: [native] Migrate pan gesture handling in FullScreenViewModal.
Tue, Feb 25, 2:48 AM
angelika closed D14301: [native] Migrate buttons refs and measuring in FullScreenViewModal.
Tue, Feb 25, 2:48 AM
angelika committed rCOMMc2e2ab2d01b8: [native] Migrate pan gesture handling in FullScreenViewModal (authored by angelika).
[native] Migrate pan gesture handling in FullScreenViewModal
Tue, Feb 25, 2:48 AM
angelika committed rCOMMc84b9db1aeb4: [native] Migrate pinch gesture handling in FullScreenViewModal (authored by angelika).
[native] Migrate pinch gesture handling in FullScreenViewModal
Tue, Feb 25, 2:48 AM
angelika committed rCOMM86f44da46631: [native] Migrate buttons refs and measuring in FullScreenViewModal (authored by angelika).
[native] Migrate buttons refs and measuring in FullScreenViewModal
Tue, Feb 25, 2:48 AM
angelika closed D14299: [native] Migrate state in FullScreenViewModal to functional component.
Tue, Feb 25, 2:48 AM
angelika closed D14300: [native] Migrate gestures to react-native-gesture-handler v2 API in FullScreenViewModal.
Tue, Feb 25, 2:48 AM
angelika committed rCOMM5205769762e3: [native] Migrate state in FullScreenViewModal to functional component (authored by angelika).
[native] Migrate state in FullScreenViewModal to functional component
Tue, Feb 25, 2:48 AM
angelika committed rCOMM35649a6fa388: [native] Migrate gestures to react-native-gesture-handler v2 API in… (authored by angelika).
[native] Migrate gestures to react-native-gesture-handler v2 API in…
Tue, Feb 25, 2:48 AM
angelika closed D14298: [native] Migrate orientation logic in FullScreenViewModal to functional component.
Tue, Feb 25, 2:48 AM
angelika committed rCOMMa2da5af2a7d5: [native] Migrate orientation logic in FullScreenViewModal to functional… (authored by angelika).
[native] Migrate orientation logic in FullScreenViewModal to functional…
Tue, Feb 25, 2:48 AM

Mon, Feb 24

angelika updated the diff for D14313: [native] Migrate render function and finish FullScreenViewModal migration to functional component.

Rebase

Mon, Feb 24, 3:54 AM
angelika updated the diff for D14312: [native] Migrate animated styles to Reanimated v2 API in FullScreenViewModal.

Rebase

Mon, Feb 24, 3:54 AM
angelika updated the diff for D14311: [native] Migrate updateDimensions method in FullScreenViewModal to functional component.

Rebase

Mon, Feb 24, 3:53 AM
angelika updated the diff for D14310: [native] Remove leftover Reanimated v1 code in FullScreenViewModal.

Rebase

Mon, Feb 24, 3:53 AM
angelika updated the diff for D14309: [native] Cancel animations when gesture is started in FullScreenViewModal.

Rebase

Mon, Feb 24, 3:53 AM
angelika updated the diff for D14308: [native] Migrate fling functionality in FullScreenViewModal.

Rebase

Mon, Feb 24, 3:53 AM
angelika updated the diff for D14307: [native] Migrate recenter functionality in FullScreenViewModal.

Rebase

Mon, Feb 24, 3:52 AM
angelika updated the diff for D14306: [native] Migrate backdropOpacityUpdate in FullScreenViewModal.

Rebase

Mon, Feb 24, 3:52 AM
angelika updated the diff for D14305: [native] Migrate double tap gesture handling in FullScreenViewModal.

Rebase

Mon, Feb 24, 3:52 AM
angelika updated the diff for D14304: [native] Migrate single tap gesture handling in FullScreenViewModal.

Rebase

Mon, Feb 24, 3:51 AM
angelika updated the diff for D14303: [native] Migrate pinch gesture handling in FullScreenViewModal.

Rebase

Mon, Feb 24, 3:51 AM
angelika updated the diff for D14302: [native] Migrate pan gesture handling in FullScreenViewModal.

Rebase

Mon, Feb 24, 3:51 AM
angelika updated the diff for D14301: [native] Migrate buttons refs and measuring in FullScreenViewModal.

Rebase

Mon, Feb 24, 3:50 AM
angelika updated the diff for D14300: [native] Migrate gestures to react-native-gesture-handler v2 API in FullScreenViewModal.

Rebase

Mon, Feb 24, 3:50 AM
angelika updated the diff for D14299: [native] Migrate state in FullScreenViewModal to functional component.

Rebase

Mon, Feb 24, 3:50 AM
angelika updated the diff for D14298: [native] Migrate orientation logic in FullScreenViewModal to functional component.

Rebase

Mon, Feb 24, 3:49 AM

Feb 21 2025

angelika updated the diff for D14313: [native] Migrate render function and finish FullScreenViewModal migration to functional component.

Fix rebase

Feb 21 2025, 10:15 PM
angelika updated the diff for D14312: [native] Migrate animated styles to Reanimated v2 API in FullScreenViewModal.

Fix rebase

Feb 21 2025, 10:15 PM
angelika updated the diff for D14311: [native] Migrate updateDimensions method in FullScreenViewModal to functional component.

Fix rebase

Feb 21 2025, 10:14 PM
angelika updated the diff for D14310: [native] Remove leftover Reanimated v1 code in FullScreenViewModal.

Fix rebase

Feb 21 2025, 10:14 PM
angelika updated the diff for D14309: [native] Cancel animations when gesture is started in FullScreenViewModal.

Fix rebase

Feb 21 2025, 10:14 PM