HomePhabricator
Diffusion Comm 7bb11205a532

[CI] update NDK to 23 and bump Corrosion

Description

[CI] update NDK to 23 and bump Corrosion

Summary:
ENG-10302


Android

The issue
There was a new, major version of rustup (1.28.0) with two breaking changes:

  1. rustup will no longer automatically install the active toolchain if it is not installed - this makes our CI to fail on most of our pipelines
  2. rustup show's output format has been cleaned up, making it easier to find out about your toolchains' status - this command is used by Corrosion, which we use to integrate Rust on Android

Fix for 1
In D14429, there is an example of how to do it explicitly, and it works, but because this major update caused many CI's to fail, there is a hotfix for this in 1.28.1

Fix for 2
To achieve that, we need to update Corrosion version to 0.5.1 which is prepared for new output format, v0.5.1.

Why NDK update?
We need to bump Corrosion from 0.2.1 to 0.5.1, which is a lot, and the minimal Rust version has been changed. According to this blog post, the minimum supported NDK version is 23. I took it from 0.71-stable. It should be fine as we're probably going to have 27 soon after the react-native upgrade (cc. @angelika). There is some context on this in D5900 (cc. @ashoat).


Commtest

It is going to be fixed, but in a not-yet published version 1.28.2, we can patch it by explicitly adding a target in the Dockerfile.

Test Plan: CI - not sure if I need to test something else; not familiar with Android configuration

Reviewers: ashoat, angelika, bartek, tomek

Reviewed By: ashoat, angelika

Differential Revision: https://phab.comm.dev/D14434

Details

Provenance
kamilAuthored on Mon, Mar 10, 6:27 AM
Reviewer
ashoat
Differential Revision
D14434: [CI] update NDK to 23 and bump Corrosion
Parents
rCOMMd2b3b9c85abc: [terraform] Bump RabbitMQ engine_version to 3.13.7
Branches
Unknown
Tags
Unknown