HomePhabricator
Diffusion Comm 8d9e6fd35d0c

[lib] Stop setting dataLoaded from register / siweAuth actions

Description

[lib] Stop setting dataLoaded from register / siweAuth actions

Summary:
This is the final diff in the stack that solves ENG-4048.

From the first diff in the stack:

Context: dataLoaded is used in isLoggedIn here, which is in turn used in LogInHandler here to decide when to dismiss LoggedOutModal and the other accountModals (such as RegistrationNavigator).

We want to defer dismissal until the avatar setting keyserver endpoint returns. The easiest way to do that is make sure dataLoaded doesn't get set at the end of register. To achieve that, I'm going to use a separate Redux action to set dataLoaded, and in a later diff will stop registration from setting dataLoaded.

This is that "later diff" where we stop registration from setting dataLoaded.

Depends on D8110

Test Plan: Tested registration (SIWE and otherwise) flows on native and web

Reviewers: atul, ginsu

Reviewed By: atul

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D8111

Details

Provenance
ashoatAuthored on Jun 5 2023, 8:57 AM
Reviewer
atul
Differential Revision
D8111: [lib] Stop setting dataLoaded from register / siweAuth actions
Parents
rCOMM1cc8fe1aedbf: [native] Dispatch SET_DATA_LOADED action after registration completes
Branches
Unknown
Tags
Unknown