diff --git a/web/roles/create-roles-modal.react.js b/web/roles/create-roles-modal.react.js index a114b4534..0b322c707 100644 --- a/web/roles/create-roles-modal.react.js +++ b/web/roles/create-roles-modal.react.js @@ -1,293 +1,295 @@ // @flow import classNames from 'classnames'; import invariant from 'invariant'; import * as React from 'react'; import { modifyCommunityRole, modifyCommunityRoleActionTypes, } from 'lib/actions/thread-actions.js'; import { useModalContext } from 'lib/components/modal-provider.react.js'; import { createLoadingStatusSelector } from 'lib/selectors/loading-selectors.js'; import type { LoadingStatus } from 'lib/types/loading-types.js'; import type { UserSurfacedPermission, UserSurfacedPermissionOption, } from 'lib/types/thread-permission-types.js'; import type { ThreadInfo, RoleModificationRequest, } from 'lib/types/thread-types.js'; import { useServerCall, useDispatchActionPromise, } from 'lib/utils/action-utils.js'; import { values } from 'lib/utils/objects.js'; import { useFilterPermissionOptionsByThreadType } from 'lib/utils/role-utils.js'; import css from './create-roles-modal.css'; import Button, { buttonThemes } from '../components/button.react.js'; import EnumSettingsOption from '../components/enum-settings-option.react.js'; import LoadingIndicator from '../loading-indicator.react.js'; import Input from '../modals/input.react.js'; import Modal from '../modals/modal.react.js'; import UnsavedChangesModal from '../modals/unsaved-changes-modal.react.js'; import { useSelector } from '../redux/redux-utils.js'; const createRolesLoadingStatusSelector = createLoadingStatusSelector( modifyCommunityRoleActionTypes, ); type CreateRolesModalProps = { +threadInfo: ThreadInfo, +action: 'create_role' | 'edit_role', +existingRoleID?: string, +roleName: string, +rolePermissions: $ReadOnlySet, }; type RoleCreationErrorVariant = 'already_exists' | 'unknown_error'; function CreateRolesModal(props: CreateRolesModalProps): React.Node { const { pushModal, popModal } = useModalContext(); const { threadInfo, action, existingRoleID, roleName, rolePermissions } = props; const callModifyCommunityRole = useServerCall(modifyCommunityRole); const dispatchActionPromise = useDispatchActionPromise(); const createRolesLoadingStatus: LoadingStatus = useSelector( createRolesLoadingStatusSelector, ); const [pendingRoleName, setPendingRoleName] = React.useState(roleName); const [pendingRolePermissions, setPendingRolePermissions] = React.useState<$ReadOnlySet>(rolePermissions); const [roleCreationFailed, setRoleCreationFailed] = React.useState(); + const createButtonText = action === 'create_role' ? 'Create' : 'Save'; + const onChangeRoleName = React.useCallback( (event: SyntheticEvent) => { setRoleCreationFailed(null); setPendingRoleName(event.currentTarget.value); }, [], ); const onCloseModal = React.useCallback(() => { const pendingSet = new Set(pendingRolePermissions); const roleSet = new Set(rolePermissions); let arePermissionsEqual = true; if (pendingSet.size !== roleSet.size) { arePermissionsEqual = false; } for (const permission of pendingSet) { if (!roleSet.has(permission)) { arePermissionsEqual = false; break; } } if (pendingRoleName === roleName && arePermissionsEqual) { popModal(); return; } pushModal(); }, [ pendingRoleName, roleName, pendingRolePermissions, rolePermissions, pushModal, popModal, ]); const clearPermissionsClassNames = classNames({ [css.clearPermissions]: true, [css.clearPermissionsDisabled]: pendingRolePermissions.size === 0, [css.clearPermissionsEnabled]: pendingRolePermissions.size > 0, }); const onClearPermissions = React.useCallback( () => setPendingRolePermissions(new Set()), [], ); const isUserSurfacedPermissionSelected = React.useCallback( (option: UserSurfacedPermissionOption) => pendingRolePermissions.has(option.userSurfacedPermission), [pendingRolePermissions], ); const onEnumValuePress = React.useCallback( (option: UserSurfacedPermissionOption) => setPendingRolePermissions(currentPermissions => { if (currentPermissions.has(option.userSurfacedPermission)) { const newPermissions = new Set(currentPermissions); newPermissions.delete(option.userSurfacedPermission); return newPermissions; } else { return new Set([ ...currentPermissions, option.userSurfacedPermission, ]); } }), [], ); const filteredUserSurfacedPermissionOptions = useFilterPermissionOptionsByThreadType(threadInfo.type); const permissionsList = React.useMemo( () => [...filteredUserSurfacedPermissionOptions].map(permission => ( onEnumValuePress(permission)} icon={null} title={permission.title} type="checkbox" statements={[{ statement: permission.description }]} /> )), [ filteredUserSurfacedPermissionOptions, isUserSurfacedPermissionSelected, onEnumValuePress, ], ); const errorMessageClassNames = classNames({ [css.errorMessage]: true, [css.errorMessageVisible]: !!roleCreationFailed, }); const threadRoleNames = React.useMemo( () => values(threadInfo.roles).map(role => role.name), [threadInfo], ); const onClickCreateRole = React.useCallback(() => { if (threadRoleNames.includes(pendingRoleName) && action === 'create_role') { setRoleCreationFailed('already_exists'); return; } let callModifyCommunityRoleParams: RoleModificationRequest; if (action === 'create_role') { callModifyCommunityRoleParams = { community: threadInfo.id, action, name: pendingRoleName, permissions: [...pendingRolePermissions], }; } else { invariant(existingRoleID, 'existingRoleID should be defined'); callModifyCommunityRoleParams = { community: threadInfo.id, existingRoleID, action, name: pendingRoleName, permissions: [...pendingRolePermissions], }; } dispatchActionPromise( modifyCommunityRoleActionTypes, (async () => { try { const response = await callModifyCommunityRole( callModifyCommunityRoleParams, ); popModal(); return response; } catch (e) { setRoleCreationFailed('unknown_error'); throw e; } })(), ); }, [ callModifyCommunityRole, dispatchActionPromise, threadInfo, action, existingRoleID, pendingRoleName, pendingRolePermissions, popModal, threadRoleNames, ]); const errorMessage = React.useMemo(() => { if (roleCreationFailed === 'already_exists') { return 'There is already a role with this name in the community'; } else { return 'An unknown error occurred. Please try again'; } }, [roleCreationFailed]); const saveButtonContent = React.useMemo(() => { if (createRolesLoadingStatus === 'loading') { return ( ); } - return 'Save'; - }, [createRolesLoadingStatus]); + return createButtonText; + }, [createRolesLoadingStatus, createButtonText]); return (
Role Name
{errorMessage}

Permissions
Clear Permissions
{permissionsList}
); } export default CreateRolesModal; diff --git a/web/roles/role-actions-menu.react.js b/web/roles/role-actions-menu.react.js index 8a3cdd313..67c1da5f5 100644 --- a/web/roles/role-actions-menu.react.js +++ b/web/roles/role-actions-menu.react.js @@ -1,84 +1,108 @@ // @flow import invariant from 'invariant'; import * as React from 'react'; +import { useModalContext } from 'lib/components/modal-provider.react.js'; import SWMansionIcon from 'lib/components/SWMansionIcon.react.js'; +import { useRoleUserSurfacedPermissions } from 'lib/shared/thread-utils.js'; import type { ThreadInfo } from 'lib/types/thread-types.js'; import { useRoleDeletableAndEditableStatus } from 'lib/utils/role-utils.js'; +import CreateRolesModal from './create-roles-modal.react.js'; import css from './role-actions-menu.css'; import MenuItem from '../components/menu-item.react.js'; import Menu from '../components/menu.react.js'; const menuIcon = ; type RoleActionsMenuProps = { +threadInfo: ThreadInfo, +roleName: string, }; function RoleActionsMenu(props: RoleActionsMenuProps): React.Node { const { threadInfo, roleName } = props; + const { pushModal } = useModalContext(); const defaultRoleID = Object.keys(threadInfo.roles).find( roleID => threadInfo.roles[roleID].isDefault, ); invariant(defaultRoleID, 'default role should exist'); const existingRoleID = Object.keys(threadInfo.roles).find( roleID => threadInfo.roles[roleID].name === roleName, ); invariant(existingRoleID, 'existing role should exist'); const roleOptions = useRoleDeletableAndEditableStatus( roleName, defaultRoleID, existingRoleID, ); - // TODO: Implement in following diffs - const openEditRoleModal = React.useCallback(() => {}, []); + const roleNamesToUserSurfacedPermissions = + useRoleUserSurfacedPermissions(threadInfo); + + const openEditRoleModal = React.useCallback( + () => + pushModal( + , + ), + [ + existingRoleID, + pushModal, + roleName, + roleNamesToUserSurfacedPermissions, + threadInfo, + ], + ); const openDeleteRoleModal = React.useCallback(() => {}, []); const menuItems = React.useMemo(() => { const availableOptions = []; const { isDeletable, isEditable } = roleOptions; if (isEditable) { availableOptions.push( , ); } if (isDeletable) { availableOptions.push( , ); } return availableOptions; }, [roleOptions, openDeleteRoleModal, openEditRoleModal]); return (
{menuItems}
); } export default RoleActionsMenu;