diff --git a/native/avatars/avatar-hooks.js b/native/avatars/avatar-hooks.js index c93040b88..cf294f99e 100644 --- a/native/avatars/avatar-hooks.js +++ b/native/avatars/avatar-hooks.js @@ -1,313 +1,312 @@ // @flow import { useActionSheet } from '@expo/react-native-action-sheet'; import * as ImagePicker from 'expo-image-picker'; import * as React from 'react'; import { Platform } from 'react-native'; import Alert from 'react-native/Libraries/Alert/Alert.js'; import { useSafeAreaInsets } from 'react-native-safe-area-context'; import { uploadMultimedia } from 'lib/actions/upload-actions.js'; import { extensionFromFilename, filenameFromPathOrURI, } from 'lib/media/file-utils.js'; import type { ImageAvatarDBContent } from 'lib/types/avatar-types.js'; -import type { SetState } from 'lib/types/hook-types.js'; import type { NativeMediaSelection, MediaLibrarySelection, MediaMissionFailure, UploadMultimediaResult, } from 'lib/types/media-types.js'; import { useServerCall } from 'lib/utils/action-utils.js'; import CommIcon from '../components/comm-icon.react.js'; import SWMansionIcon from '../components/swmansion-icon.react.js'; import { getCompatibleMediaURI } from '../media/identifier-utils.js'; import type { MediaResult } from '../media/media-utils.js'; import { processMedia } from '../media/media-utils.js'; import { useSelector } from '../redux/redux-utils.js'; import { useStyles } from '../themes/colors.js'; import { useStaffCanSee } from '../utils/staff-utils.js'; function useUploadProcessedMedia(): MediaResult => Promise { const callUploadMultimedia = useServerCall(uploadMultimedia); const uploadProcessedMultimedia: MediaResult => Promise = React.useCallback( processedMedia => { const { uploadURI, filename, mime, dimensions } = processedMedia; return callUploadMultimedia( { uri: uploadURI, name: filename, type: mime, }, dimensions, ); }, [callUploadMultimedia], ); return uploadProcessedMultimedia; } function useProcessSelectedMedia(): NativeMediaSelection => Promise< MediaMissionFailure | MediaResult, > { const hasWiFi = useSelector(state => state.connectivity.hasWiFi); const staffCanSee = useStaffCanSee(); const processSelectedMedia = React.useCallback( async (selection: NativeMediaSelection) => { const { resultPromise } = processMedia(selection, { hasWiFi, finalFileHeaderCheck: staffCanSee, }); return await resultPromise; }, [hasWiFi, staffCanSee], ); return processSelectedMedia; } async function selectFromGallery(): Promise { try { const { assets, canceled } = await ImagePicker.launchImageLibraryAsync({ mediaTypes: ImagePicker.MediaTypeOptions.Images, allowsEditing: true, allowsMultipleSelection: false, quality: 1, }); if (canceled || assets.length === 0) { return undefined; } const asset = assets.pop(); const { width, height, assetId: mediaNativeID } = asset; const assetFilename = asset.fileName || filenameFromPathOrURI(asset.uri) || ''; const uri = getCompatibleMediaURI( asset.uri, extensionFromFilename(assetFilename), ); const currentTime = Date.now(); const selection: MediaLibrarySelection = { step: 'photo_library', dimensions: { height, width }, uri, filename: assetFilename, mediaNativeID, selectTime: currentTime, sendTime: currentTime, retries: 0, }; return selection; } catch (e) { console.log(e); return undefined; } } function useUploadSelectedMedia( - setProcessingOrUploadInProgress: SetState, + setProcessingOrUploadInProgress: (inProgress: boolean) => void, ): (selection: NativeMediaSelection) => Promise { const processSelectedMedia = useProcessSelectedMedia(); const uploadProcessedMedia = useUploadProcessedMedia(); return React.useCallback( async (selection: NativeMediaSelection) => { if (!selection) { Alert.alert( 'Media selection failed', 'Unable to select media from Media Library.', ); return undefined; } setProcessingOrUploadInProgress(true); let processedMedia; try { processedMedia = await processSelectedMedia(selection); } catch (e) { Alert.alert( 'Media processing failed', 'Unable to process selected media.', ); setProcessingOrUploadInProgress(false); return undefined; } if (!processedMedia.success) { Alert.alert( 'Media processing failed', 'Unable to process selected media.', ); setProcessingOrUploadInProgress(false); return undefined; } let uploadedMedia: UploadMultimediaResult; try { uploadedMedia = await uploadProcessedMedia(processedMedia); } catch { Alert.alert( 'Media upload failed', 'Unable to upload selected media. Please try again.', ); setProcessingOrUploadInProgress(false); return undefined; } if (!uploadedMedia.id) { return undefined; } return { type: 'image', uploadID: uploadedMedia.id, }; }, [ processSelectedMedia, setProcessingOrUploadInProgress, uploadProcessedMedia, ], ); } type ShowAvatarActionSheetOptions = { +id: 'emoji' | 'image' | 'camera' | 'ens' | 'cancel' | 'remove', +onPress?: () => mixed, }; function useShowAvatarActionSheet( options: $ReadOnlyArray, ): () => void { options = Platform.OS === 'ios' ? [...options, { id: 'cancel' }] : options; const insets = useSafeAreaInsets(); const { showActionSheetWithOptions } = useActionSheet(); const styles = useStyles(unboundStyles); const showAvatarActionSheet = React.useCallback(() => { const texts = options.map((option: ShowAvatarActionSheetOptions) => { if (option.id === 'emoji') { return 'Use Emoji'; } else if (option.id === 'image') { return 'Select image'; } else if (option.id === 'camera') { return 'Camera'; } else if (option.id === 'ens') { return 'Use ENS Avatar'; } else if (option.id === 'remove') { return 'Remove avatar'; } else { return 'Cancel'; } }); const cancelButtonIndex = options.findIndex( option => option.id === 'cancel', ); const containerStyle = { paddingBotton: insets.bottom, }; const icons = options.map(option => { if (option.id === 'emoji') { return ( ); } else if (option.id === 'image') { return ( ); } else if (option.id === 'camera') { return ( ); } else if (option.id === 'ens') { return ( ); } else if (option.id === 'remove') { return ( ); } else { return undefined; } }); const onPressAction = (selectedIndex: ?number) => { if ( selectedIndex === null || selectedIndex === undefined || selectedIndex < 0 ) { return; } const option = options[selectedIndex]; if (option.onPress) { option.onPress(); } }; showActionSheetWithOptions( { options: texts, cancelButtonIndex, containerStyle, icons, }, onPressAction, ); }, [ insets.bottom, options, showActionSheetWithOptions, styles.bottomSheetIcon, ]); return showAvatarActionSheet; } const unboundStyles = { bottomSheetIcon: { color: '#000000', }, }; export { selectFromGallery, useUploadSelectedMedia, useUploadProcessedMedia, useProcessSelectedMedia, useShowAvatarActionSheet, }; diff --git a/native/avatars/edit-thread-avatar-provider.react.js b/native/avatars/edit-thread-avatar-provider.react.js index 1dc11d6f0..ba3db43c2 100644 --- a/native/avatars/edit-thread-avatar-provider.react.js +++ b/native/avatars/edit-thread-avatar-provider.react.js @@ -1,157 +1,178 @@ // @flow import * as React from 'react'; import { Alert } from 'react-native'; import { changeThreadSettings, changeThreadSettingsActionTypes, } from 'lib/actions/thread-actions.js'; import { createLoadingStatusSelector } from 'lib/selectors/loading-selectors.js'; import type { UpdateUserAvatarRemoveRequest } from 'lib/types/avatar-types.js'; import type { LoadingStatus } from 'lib/types/loading-types.js'; import type { MediaLibrarySelection } from 'lib/types/media-types.js'; import type { UpdateThreadRequest } from 'lib/types/thread-types.js'; import { useDispatchActionPromise, useServerCall, } from 'lib/utils/action-utils.js'; import { selectFromGallery, useUploadSelectedMedia } from './avatar-hooks.js'; import { activeThreadSelector } from '../navigation/nav-selectors.js'; import { NavContext } from '../navigation/navigation-context.js'; import { useSelector } from '../redux/redux-utils.js'; export type EditThreadAvatarContextType = { +threadAvatarSaveInProgress: boolean, +selectFromGalleryAndUpdateThreadAvatar: (threadID: string) => Promise, +removeThreadAvatar: (threadID: string) => void, }; const EditThreadAvatarContext: React.Context = React.createContext(); type Props = { +children: React.Node, }; function EditThreadAvatarProvider(props: Props): React.Node { const { children } = props; const navContext = React.useContext(NavContext); const activeThreadID = React.useMemo( () => activeThreadSelector(navContext) ?? '', [navContext], ); const updateThreadAvatarLoadingStatus: LoadingStatus = useSelector( createLoadingStatusSelector( changeThreadSettingsActionTypes, `${changeThreadSettingsActionTypes.started}:${activeThreadID}:avatar`, ), ); const dispatchActionPromise = useDispatchActionPromise(); const changeThreadSettingsCall = useServerCall(changeThreadSettings); - const [processingOrUploadInProgress, setProcessingOrUploadInProgress] = - React.useState(false); + const [ + threadAvatarMediaUploadInProgress, + setThreadAvatarMediaUploadInProgress, + ] = React.useState<$ReadOnlySet>(new Set()); + + const updateThreadAvatarMediaUploadInProgress = React.useCallback( + (inProgress: boolean) => + setThreadAvatarMediaUploadInProgress(prevState => { + const updatedSet = new Set(prevState); + if (inProgress) { + updatedSet.add(activeThreadID); + } else { + updatedSet.delete(activeThreadID); + } + return updatedSet; + }), + [activeThreadID], + ); const threadAvatarSaveInProgress = - processingOrUploadInProgress || + threadAvatarMediaUploadInProgress.has(activeThreadID) || updateThreadAvatarLoadingStatus === 'loading'; const uploadSelectedMedia = useUploadSelectedMedia( - setProcessingOrUploadInProgress, + updateThreadAvatarMediaUploadInProgress, ); const selectFromGalleryAndUpdateThreadAvatar = React.useCallback( async (threadID: string) => { const selection: ?MediaLibrarySelection = await selectFromGallery(); if (!selection) { return; } const imageAvatarUpdateRequest = await uploadSelectedMedia(selection); if (!imageAvatarUpdateRequest) { return; } const updateThreadRequest: UpdateThreadRequest = { threadID, changes: { avatar: imageAvatarUpdateRequest, }, }; const action = changeThreadSettingsActionTypes.started; dispatchActionPromise( changeThreadSettingsActionTypes, (async () => { - setProcessingOrUploadInProgress(false); + updateThreadAvatarMediaUploadInProgress(false); try { return await changeThreadSettingsCall(updateThreadRequest); } catch (e) { Alert.alert('Avatar update failed', 'Unable to update avatar.'); throw e; } })(), { customKeyName: `${action}:${threadID}:avatar`, }, ); }, - [changeThreadSettingsCall, dispatchActionPromise, uploadSelectedMedia], + [ + changeThreadSettingsCall, + dispatchActionPromise, + updateThreadAvatarMediaUploadInProgress, + uploadSelectedMedia, + ], ); const removeThreadAvatar = React.useCallback( (threadID: string) => { const removeAvatarRequest: UpdateUserAvatarRemoveRequest = { type: 'remove', }; const updateThreadRequest: UpdateThreadRequest = { threadID, changes: { avatar: removeAvatarRequest, }, }; const action = changeThreadSettingsActionTypes.started; dispatchActionPromise( changeThreadSettingsActionTypes, (async () => { try { return await changeThreadSettingsCall(updateThreadRequest); } catch (e) { Alert.alert('Avatar update failed', 'Unable to update avatar.'); throw e; } })(), { customKeyName: `${action}:${threadID}:avatar` }, ); }, [changeThreadSettingsCall, dispatchActionPromise], ); const context = React.useMemo( () => ({ threadAvatarSaveInProgress, selectFromGalleryAndUpdateThreadAvatar, removeThreadAvatar, }), [ removeThreadAvatar, selectFromGalleryAndUpdateThreadAvatar, threadAvatarSaveInProgress, ], ); return ( {children} ); } export { EditThreadAvatarContext, EditThreadAvatarProvider };