diff --git a/web/modals/threads/thread-settings-modal.react.js b/web/modals/threads/thread-settings-modal.react.js index 81c3f9723..6a64450f4 100644 --- a/web/modals/threads/thread-settings-modal.react.js +++ b/web/modals/threads/thread-settings-modal.react.js @@ -1,515 +1,536 @@ // @flow import classNames from 'classnames'; import invariant from 'invariant'; import _pickBy from 'lodash/fp/pickBy'; import PropTypes from 'prop-types'; import * as React from 'react'; import { deleteThreadActionTypes, deleteThread, changeThreadSettingsActionTypes, changeThreadSettings, } from 'lib/actions/thread-actions'; import { createLoadingStatusSelector } from 'lib/selectors/loading-selectors'; import { threadHasPermission, threadTypeDescriptions, robotextName, } from 'lib/shared/thread-utils'; import { type ThreadInfo, threadInfoPropType, threadTypes, assertThreadType, type ChangeThreadSettingsPayload, type UpdateThreadRequest, type LeaveThreadPayload, threadPermissions, type ThreadChanges, } from 'lib/types/thread-types'; import { type UserInfos, userInfoPropType } from 'lib/types/user-types'; -import type { DispatchActionPromise } from 'lib/utils/action-utils'; -import { connect } from 'lib/utils/redux-utils'; +import { + useDispatchActionPromise, + useServerCall, + type DispatchActionPromise, +} from 'lib/utils/action-utils'; -import type { AppState } from '../../redux/redux-setup'; +import { useSelector } from '../../redux/redux-utils'; import css from '../../style.css'; import Modal from '../modal.react'; import ColorPicker from './color-picker.react'; type TabType = 'general' | 'privacy' | 'delete'; type TabProps = { name: string, tabType: TabType, selected: boolean, onClick: (tabType: TabType) => void, }; class Tab extends React.PureComponent { render() { const classNamesForTab = classNames({ [css['current-tab']]: this.props.selected, [css['delete-tab']]: this.props.selected && this.props.tabType === 'delete', }); return (
  • {this.props.name}
  • ); } onClick = () => { return this.props.onClick(this.props.tabType); }; } -type Props = { - threadInfo: ThreadInfo, - onClose: () => void, - // Redux state - inputDisabled: boolean, - viewerID: ?string, - userInfos: UserInfos, - // Redux dispatch functions - dispatchActionPromise: DispatchActionPromise, - // async functions that hit server APIs - deleteThread: ( +type BaseProps = {| + +threadInfo: ThreadInfo, + +onClose: () => void, +|}; +type Props = {| + ...BaseProps, + +inputDisabled: boolean, + +viewerID: ?string, + +userInfos: UserInfos, + +dispatchActionPromise: DispatchActionPromise, + +deleteThread: ( threadID: string, currentAccountPassword: string, ) => Promise, - changeThreadSettings: ( + +changeThreadSettings: ( update: UpdateThreadRequest, ) => Promise, -}; +|}; type State = {| queuedChanges: ThreadChanges, errorMessage: string, accountPassword: string, currentTabType: TabType, |}; class ThreadSettingsModal extends React.PureComponent { nameInput: ?HTMLInputElement; newThreadPasswordInput: ?HTMLInputElement; accountPasswordInput: ?HTMLInputElement; constructor(props: Props) { super(props); this.state = { queuedChanges: Object.freeze({}), errorMessage: '', accountPassword: '', currentTabType: 'general', }; } componentDidMount() { invariant(this.nameInput, 'nameInput ref unset'); this.nameInput.focus(); } possiblyChangedValue(key: string) { const valueChanged = this.state.queuedChanges[key] !== null && this.state.queuedChanges[key] !== undefined; return valueChanged ? this.state.queuedChanges[key] : this.props.threadInfo[key]; } namePlaceholder() { return robotextName( this.props.threadInfo, this.props.viewerID, this.props.userInfos, ); } changeQueued() { return ( Object.keys( _pickBy( (value) => value !== null && value !== undefined, // the lodash/fp libdef coerces the returned object's properties to the // same type, which means it only works for object-as-maps $FlowFixMe )(this.state.queuedChanges), ).length > 0 ); } render() { let mainContent = null; if (this.state.currentTabType === 'general') { mainContent = (
    Thread name
    Description
    Color
    ); } else if (this.state.currentTabType === 'privacy') { mainContent = (
    Thread type
    ); } else if (this.state.currentTabType === 'delete') { mainContent = ( <>

    Your thread will be permanently deleted. There is no way to reverse this.

    Please enter your account password to confirm your identity

    Account password
    ); } let buttons = null; if (this.state.currentTabType === 'delete') { buttons = ( ); } else { buttons = ( ); } const tabs = [ , ]; if (this.possiblyChangedValue('parentThreadID')) { tabs.push( , ); } const canDeleteThread = threadHasPermission( this.props.threadInfo, threadPermissions.DELETE_THREAD, ); if (canDeleteThread) { tabs.push( , ); } return (
      {tabs}
    {mainContent}
    {buttons}
    {this.state.errorMessage}
    ); } setTab = (tabType: TabType) => { this.setState({ currentTabType: tabType }); }; nameInputRef = (nameInput: ?HTMLInputElement) => { this.nameInput = nameInput; }; newThreadPasswordInputRef = (newThreadPasswordInput: ?HTMLInputElement) => { this.newThreadPasswordInput = newThreadPasswordInput; }; accountPasswordInputRef = (accountPasswordInput: ?HTMLInputElement) => { this.accountPasswordInput = accountPasswordInput; }; onChangeName = (event: SyntheticEvent) => { const target = event.currentTarget; const newValue = target.value !== this.props.threadInfo.name ? target.value : undefined; this.setState((prevState: State) => ({ ...prevState, queuedChanges: { ...prevState.queuedChanges, name: newValue, }, })); }; onChangeDescription = (event: SyntheticEvent) => { const target = event.currentTarget; const newValue = target.value !== this.props.threadInfo.description ? target.value : undefined; this.setState((prevState: State) => ({ ...prevState, queuedChanges: { ...prevState.queuedChanges, description: newValue, }, })); }; onChangeColor = (color: string) => { const newValue = color !== this.props.threadInfo.color ? color : undefined; this.setState((prevState: State) => ({ ...prevState, queuedChanges: { ...prevState.queuedChanges, color: newValue, }, })); }; onChangeThreadType = (event: SyntheticEvent) => { const uiValue = assertThreadType(parseInt(event.currentTarget.value, 10)); const newValue = uiValue !== this.props.threadInfo.type ? uiValue : undefined; this.setState((prevState: State) => ({ ...prevState, queuedChanges: { ...prevState.queuedChanges, type: newValue, }, })); }; onChangeAccountPassword = (event: SyntheticEvent) => { const target = event.currentTarget; this.setState({ accountPassword: target.value }); }; onSubmit = (event: SyntheticEvent) => { event.preventDefault(); this.props.dispatchActionPromise( changeThreadSettingsActionTypes, this.changeThreadSettingsAction(), ); }; async changeThreadSettingsAction() { try { const response = await this.props.changeThreadSettings({ threadID: this.props.threadInfo.id, changes: this.state.queuedChanges, }); this.props.onClose(); return response; } catch (e) { this.setState( (prevState) => ({ ...prevState, queuedChanges: Object.freeze({}), accountPassword: '', errorMessage: 'unknown error', currentTabType: 'general', }), () => { invariant(this.nameInput, 'nameInput ref unset'); this.nameInput.focus(); }, ); throw e; } } onDelete = (event: SyntheticEvent) => { event.preventDefault(); this.props.dispatchActionPromise( deleteThreadActionTypes, this.deleteThreadAction(), ); }; async deleteThreadAction() { try { const response = await this.props.deleteThread( this.props.threadInfo.id, this.state.accountPassword, ); this.props.onClose(); return response; } catch (e) { const errorMessage = e.message === 'invalid_credentials' ? 'wrong password' : 'unknown error'; this.setState( { accountPassword: '', errorMessage: errorMessage, }, () => { invariant( this.accountPasswordInput, 'accountPasswordInput ref unset', ); this.accountPasswordInput.focus(); }, ); throw e; } } } ThreadSettingsModal.propTypes = { threadInfo: threadInfoPropType.isRequired, onClose: PropTypes.func.isRequired, inputDisabled: PropTypes.bool.isRequired, viewerID: PropTypes.string, userInfos: PropTypes.objectOf(userInfoPropType).isRequired, dispatchActionPromise: PropTypes.func.isRequired, deleteThread: PropTypes.func.isRequired, changeThreadSettings: PropTypes.func.isRequired, }; const deleteThreadLoadingStatusSelector = createLoadingStatusSelector( deleteThreadActionTypes, ); const changeThreadSettingsLoadingStatusSelector = createLoadingStatusSelector( changeThreadSettingsActionTypes, ); -export default connect( - (state: AppState) => ({ - inputDisabled: +export default React.memo(function ConnectedThreadSettingsModal( + props: BaseProps, +) { + const inputDisabled = useSelector( + (state) => deleteThreadLoadingStatusSelector(state) === 'loading' || changeThreadSettingsLoadingStatusSelector(state) === 'loading', - viewerID: state.currentUserInfo && state.currentUserInfo.id, - userInfos: state.userStore.userInfos, - }), - { deleteThread, changeThreadSettings }, -)(ThreadSettingsModal); + ); + const viewerID = useSelector( + (state) => state.currentUserInfo && state.currentUserInfo.id, + ); + const userInfos = useSelector((state) => state.userStore.userInfos); + const callDeleteThread = useServerCall(deleteThread); + const callChangeThreadSettings = useServerCall(changeThreadSettings); + const dispatchActionPromise = useDispatchActionPromise(); + + return ( + + ); +});