diff --git a/native/avatars/edit-thread-avatar-provider.react.js b/native/avatars/edit-thread-avatar-provider.react.js index f009c8074..5c933d619 100644 --- a/native/avatars/edit-thread-avatar-provider.react.js +++ b/native/avatars/edit-thread-avatar-provider.react.js @@ -1,193 +1,191 @@ // @flow import * as React from 'react'; import { Alert } from 'react-native'; import { changeThreadSettings, changeThreadSettingsActionTypes, } from 'lib/actions/thread-actions.js'; import { createLoadingStatusSelector } from 'lib/selectors/loading-selectors.js'; -import type { UpdateUserAvatarRemoveRequest } from 'lib/types/avatar-types.js'; +import type { UpdateUserAvatarRequest } from 'lib/types/avatar-types.js'; import type { LoadingStatus } from 'lib/types/loading-types.js'; import type { MediaLibrarySelection, NativeMediaSelection, } from 'lib/types/media-types.js'; import type { UpdateThreadRequest } from 'lib/types/thread-types.js'; import { useDispatchActionPromise, useServerCall, } from 'lib/utils/action-utils.js'; import { selectFromGallery, useUploadSelectedMedia } from './avatar-hooks.js'; import { activeThreadSelector } from '../navigation/nav-selectors.js'; import { NavContext } from '../navigation/navigation-context.js'; import { useSelector } from '../redux/redux-utils.js'; export type EditThreadAvatarContextType = { +threadAvatarSaveInProgress: boolean, +selectFromGalleryAndUpdateThreadAvatar: (threadID: string) => Promise, +updateImageThreadAvatar: ( selection: NativeMediaSelection, threadID: string, ) => Promise, - +removeThreadAvatar: (threadID: string) => void, + +setThreadAvatar: ( + threadID: string, + avatarRequest: UpdateUserAvatarRequest, + ) => Promise, }; const EditThreadAvatarContext: React.Context = React.createContext(); type Props = { +children: React.Node, }; function EditThreadAvatarProvider(props: Props): React.Node { const { children } = props; const navContext = React.useContext(NavContext); const activeThreadID = React.useMemo( () => activeThreadSelector(navContext) ?? '', [navContext], ); const updateThreadAvatarLoadingStatus: LoadingStatus = useSelector( createLoadingStatusSelector( changeThreadSettingsActionTypes, `${changeThreadSettingsActionTypes.started}:${activeThreadID}:avatar`, ), ); const dispatchActionPromise = useDispatchActionPromise(); const changeThreadSettingsCall = useServerCall(changeThreadSettings); const [ threadAvatarMediaUploadInProgress, setThreadAvatarMediaUploadInProgress, ] = React.useState<$ReadOnlySet>(new Set()); const updateThreadAvatarMediaUploadInProgress = React.useCallback( (inProgress: boolean) => setThreadAvatarMediaUploadInProgress(prevState => { const updatedSet = new Set(prevState); if (inProgress) { updatedSet.add(activeThreadID); } else { updatedSet.delete(activeThreadID); } return updatedSet; }), [activeThreadID], ); const threadAvatarSaveInProgress = threadAvatarMediaUploadInProgress.has(activeThreadID) || updateThreadAvatarLoadingStatus === 'loading'; const uploadSelectedMedia = useUploadSelectedMedia( updateThreadAvatarMediaUploadInProgress, ); const updateImageThreadAvatar = React.useCallback( async (selection: NativeMediaSelection, threadID: string) => { const imageAvatarUpdateRequest = await uploadSelectedMedia(selection); if (!imageAvatarUpdateRequest) { return; } const updateThreadRequest: UpdateThreadRequest = { threadID, changes: { avatar: imageAvatarUpdateRequest, }, }; const action = changeThreadSettingsActionTypes.started; dispatchActionPromise( changeThreadSettingsActionTypes, (async () => { updateThreadAvatarMediaUploadInProgress(false); try { return await changeThreadSettingsCall(updateThreadRequest); } catch (e) { Alert.alert('Avatar update failed', 'Unable to update avatar.'); throw e; } })(), { customKeyName: `${action}:${threadID}:avatar`, }, ); }, [ changeThreadSettingsCall, dispatchActionPromise, updateThreadAvatarMediaUploadInProgress, uploadSelectedMedia, ], ); const selectFromGalleryAndUpdateThreadAvatar = React.useCallback( async (threadID: string) => { const selection: ?MediaLibrarySelection = await selectFromGallery(); if (!selection) { return; } await updateImageThreadAvatar(selection, threadID); }, [updateImageThreadAvatar], ); - const removeThreadAvatar = React.useCallback( - (threadID: string) => { - const removeAvatarRequest: UpdateUserAvatarRemoveRequest = { - type: 'remove', - }; - + const setThreadAvatar = React.useCallback( + async (threadID: string, avatarRequest: UpdateUserAvatarRequest) => { const updateThreadRequest: UpdateThreadRequest = { threadID, changes: { - avatar: removeAvatarRequest, + avatar: avatarRequest, }, }; - const action = changeThreadSettingsActionTypes.started; - dispatchActionPromise( - changeThreadSettingsActionTypes, - (async () => { - try { - return await changeThreadSettingsCall(updateThreadRequest); - } catch (e) { - Alert.alert('Avatar update failed', 'Unable to update avatar.'); - throw e; - } - })(), - { customKeyName: `${action}:${threadID}:avatar` }, - ); + const promise = (async () => { + try { + return await changeThreadSettingsCall(updateThreadRequest); + } catch (e) { + Alert.alert('Avatar update failed', 'Unable to update avatar.'); + throw e; + } + })(); + dispatchActionPromise(changeThreadSettingsActionTypes, promise, { + customKeyName: `${action}:${threadID}:avatar`, + }); + await promise; }, [changeThreadSettingsCall, dispatchActionPromise], ); const context = React.useMemo( () => ({ threadAvatarSaveInProgress, selectFromGalleryAndUpdateThreadAvatar, updateImageThreadAvatar, - removeThreadAvatar, + setThreadAvatar, }), [ - removeThreadAvatar, + threadAvatarSaveInProgress, selectFromGalleryAndUpdateThreadAvatar, updateImageThreadAvatar, - threadAvatarSaveInProgress, + setThreadAvatar, ], ); return ( {children} ); } export { EditThreadAvatarContext, EditThreadAvatarProvider }; diff --git a/native/avatars/edit-thread-avatar.react.js b/native/avatars/edit-thread-avatar.react.js index 47de602c6..ccb9260c4 100644 --- a/native/avatars/edit-thread-avatar.react.js +++ b/native/avatars/edit-thread-avatar.react.js @@ -1,117 +1,117 @@ // @flow import { useNavigation } from '@react-navigation/native'; import invariant from 'invariant'; import * as React from 'react'; import { ActivityIndicator, TouchableOpacity, View } from 'react-native'; import type { RawThreadInfo, ThreadInfo } from 'lib/types/thread-types.js'; import { useShowAvatarActionSheet } from './avatar-hooks.js'; import EditAvatarBadge from './edit-avatar-badge.react.js'; import { EditThreadAvatarContext } from './edit-thread-avatar-provider.react.js'; import ThreadAvatar from './thread-avatar.react.js'; import { EmojiThreadAvatarCreationRouteName, ThreadAvatarCameraModalRouteName, } from '../navigation/route-names.js'; import { useStyles } from '../themes/colors.js'; type Props = { +threadInfo: RawThreadInfo | ThreadInfo, +disabled?: boolean, }; function EditThreadAvatar(props: Props): React.Node { const styles = useStyles(unboundStyles); const { threadInfo, disabled } = props; const editThreadAvatarContext = React.useContext(EditThreadAvatarContext); invariant(editThreadAvatarContext, 'editThreadAvatarContext should be set'); const { threadAvatarSaveInProgress, selectFromGalleryAndUpdateThreadAvatar, - removeThreadAvatar, + setThreadAvatar, } = editThreadAvatarContext; const { navigate } = useNavigation(); const navigateToThreadEmojiAvatarCreation = React.useCallback(() => { navigate<'EmojiThreadAvatarCreation'>({ name: EmojiThreadAvatarCreationRouteName, params: { threadID: threadInfo.id, containingThreadID: threadInfo.containingThreadID, }, }); }, [navigate, threadInfo.containingThreadID, threadInfo.id]); const selectFromGallery = React.useCallback( () => selectFromGalleryAndUpdateThreadAvatar(threadInfo.id), [selectFromGalleryAndUpdateThreadAvatar, threadInfo.id], ); const navigateToCamera = React.useCallback(() => { navigate<'ThreadAvatarCameraModal'>({ name: ThreadAvatarCameraModalRouteName, params: { threadID: threadInfo.id }, }); }, [navigate, threadInfo.id]); const removeAvatar = React.useCallback( - () => removeThreadAvatar(threadInfo.id), - [removeThreadAvatar, threadInfo.id], + () => setThreadAvatar(threadInfo.id, { type: 'remove' }), + [setThreadAvatar, threadInfo.id], ); const actionSheetConfig = React.useMemo(() => { const configOptions = [ { id: 'emoji', onPress: navigateToThreadEmojiAvatarCreation }, { id: 'image', onPress: selectFromGallery }, { id: 'camera', onPress: navigateToCamera }, ]; if (threadInfo.avatar) { configOptions.push({ id: 'remove', onPress: removeAvatar }); } return configOptions; }, [ navigateToCamera, navigateToThreadEmojiAvatarCreation, removeAvatar, selectFromGallery, threadInfo.avatar, ]); const showAvatarActionSheet = useShowAvatarActionSheet(actionSheetConfig); let spinner; if (threadAvatarSaveInProgress) { spinner = ( ); } return ( {spinner} {!disabled ? : null} ); } const unboundStyles = { spinnerContainer: { position: 'absolute', alignItems: 'center', justifyContent: 'center', top: 0, bottom: 0, left: 0, right: 0, }, }; export default EditThreadAvatar;