Changeset View
Changeset View
Standalone View
Standalone View
lib/types/avatar-types.js
- This file was added.
// @flow | |||||
export type EmojiAvatar = { | |||||
ashoat: We should add a `type` here immediately. Otherwise we'll have to deal with clients that have an… | |||||
ginsuAuthorUnsubmitted Done Inline ActionsJust to clarify this comment you are referring to a field called type, or are you are referring to creating more types for example an ImageAvatar, and an AvatarInfo type which could be EmojiAvatar | ImageAvatar ginsu: Just to clarify this comment you are referring to a field called `type`, or are you are… | |||||
ashoatUnsubmitted Not Done Inline ActionsThe latter, add +type: 'emoji' here ashoat: The latter, add `+type: 'emoji'` here | |||||
+emoji: string, | |||||
+color: string, | |||||
}; |
We should add a type here immediately. Otherwise we'll have to deal with clients that have an avatar without a type, and default those to the "emoji" type