Page MenuHomePhabricator

Active Repositories

Recent Activity

Today

rohan updated the diff for D5539: [native] Maintain the revealed state of spoilers.

Revert back to using Text instead of GestureTouchableOpacity

Sat, Nov 26, 8:29 AM
rohan retitled D5539: [native] Maintain the revealed state of spoilers from [native] Maintain the spoiler reveal state on tap to [native] Maintain the revealed state of spoilers.
Sat, Nov 26, 8:28 AM
rohan retitled D5539: [native] Maintain the revealed state of spoilers from [native] Prevent tooltip from appearing on spoiler tap if spoiler is not yet revealed to [native] Maintain the spoiler reveal state on tap.
Sat, Nov 26, 8:27 AM
rohan added a comment to D5515: [native] Update the existing Context API for Markdown to encompass AppNavigator.

I ended up needing something like MessageContext in a stack I am working on to address the gestures/press experience issues, but I called it TextMessageMarkdownContext. Don't worry about addressing the comments below... I suspect you'll end up needing to rebase on top of my stack anyways, so you can just get rid of MessageContext when that happens

Sat, Nov 26, 8:23 AM
rohan updated the diff for D5515: [native] Update the existing Context API for Markdown to encompass AppNavigator.

Rebase and resolve conflicts in root.react.js

Sat, Nov 26, 8:22 AM
rohan updated the summary of D5715: [lib] Prevent spoiler text from appearing in MessagePreview.
Sat, Nov 26, 8:03 AM
rohan updated the diff for D5715: [lib] Prevent spoiler text from appearing in MessagePreview.

Recurse down the AST instead (tested web and native)

Sat, Nov 26, 8:00 AM
rohan added inline comments to D5715: [lib] Prevent spoiler text from appearing in MessagePreview.
Sat, Nov 26, 7:54 AM

Yesterday

tomek requested changes to D5718: [native] Add expand button for drawer elemennts.
Fri, Nov 25, 9:48 AM
bartek added a comment to D5703: [services][blob] Handle uploading new blobs.

Thanks for the suggestion regarding splitting the diff - sounds reasonable to me.

Fri, Nov 25, 9:41 AM
tomek added inline comments to D5724: [web] Fixed visual bug with disappearing buttons.
Fri, Nov 25, 9:35 AM
tomek requested changes to D5724: [web] Fixed visual bug with disappearing buttons.
Fri, Nov 25, 9:29 AM
przemek added inline comments to D5724: [web] Fixed visual bug with disappearing buttons.
Fri, Nov 25, 9:27 AM
tomek accepted D5724: [web] Fixed visual bug with disappearing buttons.
Fri, Nov 25, 9:26 AM
tomek requested changes to D5722: [web] Creating typeahead overlay in ChatInputbar.
Fri, Nov 25, 9:17 AM
tomek accepted D5720: [web] Calling utility functions in Overlay component..
Fri, Nov 25, 9:05 AM
tomek accepted D5719: [web] Added more utility functions for typeahead..
Fri, Nov 25, 9:00 AM
przemek added 1 blocking reviewer(s) for D5724: [web] Fixed visual bug with disappearing buttons: tomek.
Fri, Nov 25, 8:39 AM
przemek updated the summary of D5724: [web] Fixed visual bug with disappearing buttons.
Fri, Nov 25, 8:39 AM
przemek updated the diff for D5724: [web] Fixed visual bug with disappearing buttons.

Fixed. Changes I've made in previous diff were.. far fetched to say the least. Minor css fix did the job!

Fri, Nov 25, 8:35 AM
przemek updated the diff for D5722: [web] Creating typeahead overlay in ChatInputbar.

Realized too late that it also should be put inside useMemo.

Fri, Nov 25, 8:17 AM
przemek added inline comments to D5722: [web] Creating typeahead overlay in ChatInputbar.
Fri, Nov 25, 8:13 AM
przemek updated the diff for D5722: [web] Creating typeahead overlay in ChatInputbar.

Responded to inlines and fixed code.

Fri, Nov 25, 8:12 AM
przemek updated the diff for D5720: [web] Calling utility functions in Overlay component..

Fixed props.

Fri, Nov 25, 8:10 AM
przemek added inline comments to D5720: [web] Calling utility functions in Overlay component..
Fri, Nov 25, 8:10 AM
przemek updated the diff for D5719: [web] Added more utility functions for typeahead..

Had some problems with our git workflow and left that as an artifact. Sorry for that, fixed now.

Fri, Nov 25, 8:09 AM
przemek added inline comments to D5719: [web] Added more utility functions for typeahead..
Fri, Nov 25, 8:04 AM
przemek updated the diff for D5719: [web] Added more utility functions for typeahead..

Responded to inlines and fixed code.

Fri, Nov 25, 8:04 AM
przemek updated the diff for D5717: [web] Moved typeahead utils to `web/chat`.

Rebase

Fri, Nov 25, 7:57 AM
przemek updated the diff for D5674: [lib] Added getTextsOffsets function. Refactored mention-utils.js..

Renaming function

Fri, Nov 25, 7:54 AM
tomek requested changes to D5703: [services][blob] Handle uploading new blobs.

This looks great and is a lot more readable than the original solution! Regarding splitting the diff, one option might be to handle chunks upload as a separate one - this makes sense as the first diff would be about setting up and determining the action, and the second one about executing it.

Fri, Nov 25, 6:48 AM
tomek accepted D5702: [services][blob] Handle removing blobs.
Fri, Nov 25, 5:11 AM
tomek accepted D5701: [services][blob] Handle getting blob data.
Fri, Nov 25, 5:01 AM
marcin updated the diff for D5710: Adjust reducers to new redux action.

Remove unnecessary [] change

Fri, Nov 25, 4:51 AM
marcin updated the diff for D5711: Use new redux action and storeLoaded field.

Use set store loaded action type in sqlite context provider

Fri, Nov 25, 4:48 AM
marcin updated the diff for D5709: Move Store Loaded to redux.

Introduce action to set exclusively storeLoaded field in redux and implement its reduction in native reducer

Fri, Nov 25, 4:46 AM
tomek accepted D5726: [web] Added on enter animation for typeahead overlay..
Fri, Nov 25, 4:43 AM
tomek requested changes to D5724: [web] Fixed visual bug with disappearing buttons.

Do we have a task for this?

Fri, Nov 25, 4:37 AM
tomek accepted D5709: Move Store Loaded to redux.
Fri, Nov 25, 4:28 AM
przemek added inline comments to D5674: [lib] Added getTextsOffsets function. Refactored mention-utils.js..
Fri, Nov 25, 3:54 AM