Page MenuHomePhabricator

Active Repositories
View All

Recent Activity
View All

Today

ashoat accepted D13334: Call textMessageCreationSideEffectsFunc after sending DM text message.
Wed, Sep 18, 4:11 AM
marcin added a comment to D13334: Call textMessageCreationSideEffectsFunc after sending DM text message.
In D13334#376477, @ashoat wrote:

It appears that the only thing this diff is doing is having textMessageCreationSideEffectsFunc called after the text message is created for thick threads, but before the text message is created for thin threads.

Two questions:

  1. Why do the side effects need to happen after the text message is created for thick threads?
Wed, Sep 18, 3:50 AM
tomek updated the diff for D13362: [lib] Allow reacting and creating sidebars from failed messages in thick threads.

Delete logs

Wed, Sep 18, 3:23 AM
bartek closed D13360: [terraform] Make Tunnelbroker deployments more future-proof.
Wed, Sep 18, 3:03 AM
bartek committed rCOMMde4a5b45fcfb: [terraform] Make Tunnelbroker deployments more future-proof (authored by bartek).
[terraform] Make Tunnelbroker deployments more future-proof
Wed, Sep 18, 3:03 AM
ashoat closed D13369: Add keyserver/certs to .dockerignore.
Wed, Sep 18, 2:59 AM
ashoat committed rCOMMca3fb9b70ad5: Add keyserver/certs to .dockerignore (authored by ashoat).
Add keyserver/certs to .dockerignore
Wed, Sep 18, 2:59 AM
ashoat accepted D13370: [terraform] bump staging identity to 0.38.
Wed, Sep 18, 2:58 AM
varun requested review of D13370: [terraform] bump staging identity to 0.38.
Wed, Sep 18, 2:52 AM
kamil accepted D13353: Fix BAD_MESSAGE_FORMAT issue with e2ee web notifs.
Wed, Sep 18, 12:52 AM
kamil accepted D13360: [terraform] Make Tunnelbroker deployments more future-proof.
Wed, Sep 18, 12:51 AM

Yesterday

bartek added inline comments to D13360: [terraform] Make Tunnelbroker deployments more future-proof.
Tue, Sep 17, 11:57 PM
will accepted D13369: Add keyserver/certs to .dockerignore.
Tue, Sep 17, 3:57 PM
ashoat requested review of D13369: Add keyserver/certs to .dockerignore.
Tue, Sep 17, 3:54 PM
varun closed D13367: [terraform] bump prod identity to 0.37.
Tue, Sep 17, 3:34 PM
varun committed rCOMM1414c736a283: [terraform] bump prod identity to 0.37 (authored by varun).
[terraform] bump prod identity to 0.37
Tue, Sep 17, 3:34 PM
ashoat accepted D13367: [terraform] bump prod identity to 0.37.
Tue, Sep 17, 2:09 PM
ashoat added a comment to D13334: Call textMessageCreationSideEffectsFunc after sending DM text message.

It appears that the only thing this diff is doing is having textMessageCreationSideEffectsFunc called after the text message is created for thick threads, but before the text message is created for thin threads.

Tue, Sep 17, 2:04 PM
ashoat committed rCOMMf519789d0465: [web][keyserver] codeVersion -> 116 (authored by ashoat).
[web][keyserver] codeVersion -> 116
Tue, Sep 17, 1:12 PM
ashoat closed D13368: [keyserver] Replace deprecated sendToDevice firebase-admin method.
Tue, Sep 17, 1:11 PM
ashoat committed rCOMM3733bf3e39eb: [keyserver] Replace deprecated sendToDevice firebase-admin method (authored by ashoat).
[keyserver] Replace deprecated sendToDevice firebase-admin method
Tue, Sep 17, 1:11 PM
ashoat updated subscribers of D13368: [keyserver] Replace deprecated sendToDevice firebase-admin method.
Tue, Sep 17, 1:10 PM
ashoat added a comment to D13368: [keyserver] Replace deprecated sendToDevice firebase-admin method.

Guessing there’s some tunnelbroker follow up work too?

Tue, Sep 17, 1:10 PM
will accepted D13368: [keyserver] Replace deprecated sendToDevice firebase-admin method.
Tue, Sep 17, 1:06 PM
varun accepted D13368: [keyserver] Replace deprecated sendToDevice firebase-admin method.

Guessing there’s some tunnelbroker follow up work too?

Tue, Sep 17, 1:06 PM
ashoat published D13368: [keyserver] Replace deprecated sendToDevice firebase-admin method for review.

Will wait on CI before landing

Tue, Sep 17, 1:02 PM
will accepted D13367: [terraform] bump prod identity to 0.37.
Tue, Sep 17, 10:14 AM
varun requested review of D13367: [terraform] bump prod identity to 0.37.
Tue, Sep 17, 10:06 AM
will accepted D13359: [web] Remove admins tab when there are no admins.
Tue, Sep 17, 9:53 AM
tomek requested review of D13366: [lib] Update the conditions we check before processing the operations.
Tue, Sep 17, 9:10 AM
tomek requested review of D13365: [lib] Queue operations.
Tue, Sep 17, 9:06 AM
tomek requested review of D13364: [lib] Allow queueing based on new conditions.
Tue, Sep 17, 9:03 AM
tomek requested review of D13363: [lib] Introduce new operation queues.
Tue, Sep 17, 9:02 AM
varun closed D13355: [grpc_clients] bump gRPC connection timeout to 30 seconds.
Tue, Sep 17, 8:59 AM
varun committed rCOMM849adf8a969d: [grpc_clients] bump gRPC connection timeout to 30 seconds (authored by varun).
[grpc_clients] bump gRPC connection timeout to 30 seconds
Tue, Sep 17, 8:59 AM
varun updated the diff for D13355: [grpc_clients] bump gRPC connection timeout to 30 seconds.

fix title and description

Tue, Sep 17, 8:58 AM
varun updated the diff for D13355: [grpc_clients] bump gRPC connection timeout to 30 seconds.

undo request timeout addition

Tue, Sep 17, 8:56 AM
varun removed 1 blocking reviewer(s) for D13355: [grpc_clients] bump gRPC connection timeout to 30 seconds: ashoat.

nvm. applying @ashoat 's feedback as intended and deferring the request timeout work

Tue, Sep 17, 8:56 AM
varun requested review of D13355: [grpc_clients] bump gRPC connection timeout to 30 seconds.

30 seconds feels excessive for establishing the tcp connection, but i think it makes sense for completing the actual request

Tue, Sep 17, 8:51 AM
varun updated the diff for D13355: [grpc_clients] bump gRPC connection timeout to 30 seconds.

add a request timeout of 30 seconds

Tue, Sep 17, 8:46 AM