Page MenuHomePhabricator

Active Repositories

Recent Activity

Today

ashoat accepted D11661: Handle key permanently invalidated error to fix Android app crash.
Sun, Apr 14, 10:54 AM
marcin requested review of D11661: Handle key permanently invalidated error to fix Android app crash.
Sun, Apr 14, 4:21 AM

Yesterday

ashoat requested review of D11660: [native] Recreate CommMMKV keys if they can't be loaded.
Sat, Apr 13, 5:14 PM
ashoat requested review of D11659: [native][android] Move database and MMKV initialization to CommHybrid.
Sat, Apr 13, 5:13 PM
varun requested review of D11658: [identity] check that prekeys are formatted correctly.
Sat, Apr 13, 11:57 AM
varun published D11608: [identity] otk db changes for review.
Sat, Apr 13, 11:40 AM
varun requested review of D11657: check one-time key format.
Sat, Apr 13, 8:58 AM

Fri, Apr 12

ashoat requested review of D11656: [lib] Use useDerivedObject to reduce renders due to preRequestUserState.
Fri, Apr 12, 2:33 PM
ashoat requested review of D11654: [lib] Don't clear authoritative keyserver cookie during identity auth.
Fri, Apr 12, 2:30 PM
ashoat requested review of D11655: [lib] Introduce usePreRequestUserState.
Fri, Apr 12, 2:30 PM
atul published D11653: [lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromClientDB` to handle `farcaster_mutual` for review.
Fri, Apr 12, 1:12 PM
atul published D11652: [lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromServerDB` to handle `farcaster_mutual` for review.
Fri, Apr 12, 12:59 PM
ginsu accepted D11636: Implement screen to create backup mesage and its signature.

would be good to get a screenshot to see the colors visually as a sanity check for the colors but the color variables follow our conventions

Fri, Apr 12, 12:32 PM
ginsu retitled D11613: [lib/native] introduce connect farcaster alert handler from [lib/native] introduce farcaster handler to [lib/native] introduce connect farcaster alert handler.
Fri, Apr 12, 12:28 PM
ginsu added inline comments to D11613: [lib/native] introduce connect farcaster alert handler.
Fri, Apr 12, 12:27 PM
ginsu updated the diff for D11613: [lib/native] introduce connect farcaster alert handler.

address comments

Fri, Apr 12, 12:27 PM
atul updated the test plan for D11651: [lib] Include `[creator/target]FID` in `messageContentForServerDB` when update relationship op is `farcaster_mutual`.
Fri, Apr 12, 12:27 PM
atul published D11651: [lib] Include `[creator/target]FID` in `messageContentForServerDB` when update relationship op is `farcaster_mutual` for review.
Fri, Apr 12, 12:26 PM
ginsu added inline comments to D11613: [lib/native] introduce connect farcaster alert handler.
Fri, Apr 12, 12:16 PM
atul requested review of D11650: [lib] Split `UpdateRelationshipMessageInfo` into `Update[Traditional/Farcaster]RelationshipMessageInfo`.
Fri, Apr 12, 12:03 PM
tomek requested review of D11649: [web] Reassign the notifs session.
Fri, Apr 12, 11:51 AM
tomek requested review of D11648: [web] Create a function that reassigns notifs session.
Fri, Apr 12, 11:36 AM
tomek requested review of D11647: [web] Extract a function that determines where to store notifs session.
Fri, Apr 12, 11:26 AM
will updated the summary of D11629: [native][lib] Replace usages of FIDProvider with Synced Metadata Store.
Fri, Apr 12, 9:02 AM
will closed D11640: [lib] rewrite integrityInfos ThreadHashes.
Fri, Apr 12, 9:01 AM
will committed rCOMMa00666640f0d: [lib] rewrite integrityInfos ThreadHashes (authored by will).
[lib] rewrite integrityInfos ThreadHashes
Fri, Apr 12, 9:01 AM
ashoat added inline comments to D11644: Extract shareable logic from CreateSIWEBackupMessage component.
Fri, Apr 12, 8:53 AM
ashoat added a comment to D11645: Force already logged in ETH users to create and sign backup message.

Can you share a screenshot of what this looks like?

Fri, Apr 12, 8:52 AM
ashoat requested changes to D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.

Just a question

Fri, Apr 12, 8:50 AM
ashoat added inline comments to D11551: [protos] Replace challengeResponse with nonce and signature pair.
Fri, Apr 12, 8:42 AM
ashoat requested changes to D11643: [web] Show a popup when client_version_unsupported.
Fri, Apr 12, 8:21 AM
ashoat added inline comments to D11636: Implement screen to create backup mesage and its signature.
Fri, Apr 12, 8:14 AM
ashoat added a comment to D11635: Handle backup message type with different user texts in siwe.reac.js.

Would be good to include screenshots of what the various screens look like from mobile. (You can omit the original screen if it's unchanged.)

Fri, Apr 12, 8:13 AM
ashoat added a comment to D11634: Introduce user texts for siwe backup message creation.

Seeing now that @marcin added me for approval:

Fri, Apr 12, 8:05 AM
ashoat added inline comments to D11634: Introduce user texts for siwe backup message creation.
Fri, Apr 12, 8:02 AM
ashoat accepted D11631: [lib] Stop attempting recovery when client version unsupported.

I can review this one, since I wrote the original code that dispatches setActiveSessionRecoveryActionType

Fri, Apr 12, 7:56 AM
inka accepted D11644: Extract shareable logic from CreateSIWEBackupMessage component.
Fri, Apr 12, 6:54 AM
ashoat added inline comments to D11583: [web] update `WorkerCryptoStore` to handle session version.
Fri, Apr 12, 6:36 AM
marcin requested review of D11645: Force already logged in ETH users to create and sign backup message.
Fri, Apr 12, 5:57 AM
marcin updated the diff for D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.

Simplify hook

Fri, Apr 12, 5:44 AM