Page MenuHomePhabricator

Active Repositories

Recent Activity

Today

michal accepted D11127: Enable SQLite database to hold two olm accounts: content and notifs.
Mon, Mar 4, 3:32 AM
michal added a comment to D11230: [lib][native] Introduce supportingMultipleKeyservers constant.

is there an existing task tracking implementing backup restore for corrupt database recovery, for both native and web? I want to add a comment referencing this code in SQLiteDataHandler, to make sure it's updated as part of that task.

Mon, Mar 4, 3:17 AM
tomek accepted D11217: [lib][native] Try session recovery on web too for policy acknowledgment crash loop.
Mon, Mar 4, 2:51 AM
tomek accepted D11216: [lib][native] Use unified keyserver session recovery in native/socket.react.js.
Mon, Mar 4, 2:49 AM
tomek accepted D11215: [lib][native][web] Use unified keyserver session recovery in lib/socket/socket.react.js.
Mon, Mar 4, 2:43 AM
tomek accepted D11214: [lib] Deprecate resetUserStateActionType.
Mon, Mar 4, 2:38 AM
marcin accepted D11219: [lib][native][web] Refactor useInitialNotificationsEncryptedMessage to get Olm session creator from context.
Mon, Mar 4, 2:10 AM
marcin added a comment to D11168: [SQLite] add table for messages to device.

Are we going to backup this table? If so then we should add it to NativeSQLiteConnectionManager so that logs are capture for this table. If not then we should update createMainCompaction method so that removeDeviceSpecificDataSQL script removes data from this table after backup is created.

Mon, Mar 4, 2:04 AM
tomek accepted D11213: [native] Use unified keyserver session recovery in LoggedOutModal.
Mon, Mar 4, 1:58 AM
tomek accepted D11212: [lib] Replace sessionRecoveryInProgress with actionSessionRecovery.

Just to make sure: sessionRecoveryInProgress isn't persisted, right?

Mon, Mar 4, 1:47 AM
tomek accepted D11211: [lib] Deprecate recoveryActionSources.sqliteOpFailure.

I think that the practice of keeping commented-out types has a big advantage of reducing confusion when searching older revisions while it doesn't have any significant disadvantages.

Mon, Mar 4, 1:29 AM
tomek accepted D11210: [lib][native] Separate out recoveryActionSources.
Mon, Mar 4, 1:25 AM
tomek requested changes to D11209: [lib] Update `threadHasAdminRole` to consider `specialField`.

However, if there is no specialRole field encountered, we will assume we're dealing with a Server/"legacy" type and fallback to sketchy string search.

What is the scenario when this can happen?

Mon, Mar 4, 1:07 AM
tomek accepted D11208: [lib] Deprecate `useRoleDeletableAndEditableStatus` and determine `is[Editable/Deletable]` directly in `RoleActionsMenu`.

We should reintroduce the util (probably as a simple function) if we would need to decide if we can edit / delete a role in some other places.

Mon, Mar 4, 1:05 AM
tomek accepted D11206: [web] Compute `existingRole` instead of `existingRoleID` in `RoleActionsMenu`.
Mon, Mar 4, 12:59 AM
tomek requested changes to D11205: [lib][native] Introduce `useRoleNamesToSpecialRole` to remove `"Admins"` string check in `RolePanelEntry`.

I don't understand the reason behind this diff and the task from the summary doesn't have any description. Why can't we simply check RoleInfo and its specialRole field?

Mon, Mar 4, 12:57 AM
tomek accepted D11194: [identity] separate allow origin lists for staging and prod.
Mon, Mar 4, 12:48 AM

Yesterday

ashoat requested review of D11224: [lib][native] Deprecate DispatchRecoveryAttempt in favor of DispatchActionPromise.
Sun, Mar 3, 11:30 PM
will requested review of D11231: [identity] Replace elastic crate in identity.
Sun, Mar 3, 10:59 PM
ashoat requested review of D11230: [lib][native] Introduce supportingMultipleKeyservers constant.
Sun, Mar 3, 10:18 PM
ashoat requested review of D11229: [lib][web] Update condition for Redux state reset in SET_NEW_SESSION reducers.
Sun, Mar 3, 10:14 PM
ashoat requested review of D11228: [lib] Introduce relyingOnAuthoritativeKeyserver constant.
Sun, Mar 3, 10:10 PM
ashoat requested review of D11227: [native] Use useKeyserverRecoveryLogIn from SQLiteDataHandler.
Sun, Mar 3, 10:06 PM
ashoat requested review of D11226: [lib] Extract useKeyserverRecoveryLogIn.
Sun, Mar 3, 10:02 PM
ashoat requested review of D11225: [lib] Make resolveKeyserverSessionInvalidation generic.
Sun, Mar 3, 9:58 PM
ashoat requested review of D11223: [lib][native] Make cancellation work for keyserver session recovery.
Sun, Mar 3, 9:49 PM
ashoat requested review of D11222: [lib] Don't cancel an auth that the keyserver completes.
Sun, Mar 3, 9:45 PM
ashoat requested review of D11221: [lib] Factor out CANCELLED_ERROR into keyserver-conn-types.js.
Sun, Mar 3, 9:42 PM
ashoat requested review of D11220: [lib][native] Initialize notif Olm channel during keyserver session recovery.
Sun, Mar 3, 9:37 PM
ashoat requested review of D11219: [lib][native][web] Refactor useInitialNotificationsEncryptedMessage to get Olm session creator from context.
Sun, Mar 3, 9:33 PM
ashoat requested review of D11218: [lib] Initiate a keyserver session recovery when keyserver socket sends not_logged_in.
Sun, Mar 3, 9:29 PM
ashoat requested review of D11217: [lib][native] Try session recovery on web too for policy acknowledgment crash loop.
Sun, Mar 3, 9:25 PM
ashoat requested review of D11216: [lib][native] Use unified keyserver session recovery in native/socket.react.js.
Sun, Mar 3, 9:21 PM
ashoat requested review of D11215: [lib][native][web] Use unified keyserver session recovery in lib/socket/socket.react.js.
Sun, Mar 3, 9:17 PM
ashoat requested review of D11214: [lib] Deprecate resetUserStateActionType.
Sun, Mar 3, 9:13 PM
ashoat requested review of D11213: [native] Use unified keyserver session recovery in LoggedOutModal.
Sun, Mar 3, 9:08 PM
ashoat requested review of D11212: [lib] Replace sessionRecoveryInProgress with actionSessionRecovery.
Sun, Mar 3, 9:04 PM
ashoat requested review of D11211: [lib] Deprecate recoveryActionSources.sqliteOpFailure.
Sun, Mar 3, 9:00 PM
ashoat requested review of D11210: [lib][native] Separate out recoveryActionSources.
Sun, Mar 3, 8:56 PM
ashoat updated the diff for D10972: [lib] Clear sessionRecoveryInProgress during auth / deauth.

Rebase

Sun, Mar 3, 8:37 PM