Page MenuHomePhabricator

Active Repositories
View All

Recent Activity
View All

Today

ashoat accepted D7137: [native] render thread avatars for parent/child threads in thread settings.

Accepting to unblock but the pattern of copy-paste is concerning

Sun, Mar 26, 6:03 AM
ashoat accepted D7136: [native] render thread avatars in community drawer.

Please make sure @inka creates the task I requested before you land this

Sun, Mar 26, 6:00 AM
ashoat accepted D7134: [native] update message list header to new design.
Sun, Mar 26, 5:57 AM
ashoat accepted D7132: [lib] introduce useGetAvatarForThread hook.
Sun, Mar 26, 5:53 AM
ashoat accepted D7178: [lib] introduce getUserAvatarForThread function.
Sun, Mar 26, 5:53 AM
ashoat accepted D7177: [keyserver/lib/native/web] introduce color-utils and move color functions from thread-utils to color-utils.

Looks like this is just a move diff so blindly accepting. Not familiar with that error myself, wondering what "initialization" means in this context (is it a circular dependency issue?)

Sun, Mar 26, 5:43 AM
ginsu added inline comments to D7137: [native] render thread avatars for parent/child threads in thread settings.
Sun, Mar 26, 12:18 AM
ginsu updated the diff for D7137: [native] render thread avatars for parent/child threads in thread settings.

address feedback

Sun, Mar 26, 12:13 AM
ginsu attached a referenced file: F445626: Screenshot 2023-03-24 at 3.04.22 PM.png.
Sun, Mar 26, 12:12 AM
ginsu attached a referenced file: F445627: Screenshot 2023-03-26 at 3.11.51 AM.png.
Sun, Mar 26, 12:12 AM
ginsu updated the test plan for D7136: [native] render thread avatars in community drawer.
Sun, Mar 26, 12:12 AM
ginsu added a reviewer for D7136: [native] render thread avatars in community drawer: inka.
Sun, Mar 26, 12:09 AM
ginsu updated the diff for D7136: [native] render thread avatars in community drawer.

address feedback

Sun, Mar 26, 12:09 AM
ginsu updated the diff for D7135: [native] render thread avatar in CHANNEL AVATAR thread settings section.

rebase

Sun, Mar 26, 12:05 AM
ginsu attached a referenced file: F445550: Screenshot 2023-03-25 at 11.08.46 PM.png.
Sun, Mar 26, 12:02 AM
ginsu attached a referenced file: F445551: Screenshot 2023-03-25 at 10.39.40 PM.png.
Sun, Mar 26, 12:02 AM
ginsu attached a referenced file: F445552: Screenshot 2023-03-25 at 11.09.09 PM.png.
Sun, Mar 26, 12:02 AM
ginsu attached a referenced file: F445554: Screenshot 2023-03-25 at 10.55.13 PM.png.
Sun, Mar 26, 12:02 AM
ginsu attached a referenced file: F445555: Screenshot 2023-03-25 at 11.10.05 PM.png.
Sun, Mar 26, 12:02 AM
ginsu attached a referenced file: F445556: Screenshot 2023-03-25 at 10.53.19 PM.png.
Sun, Mar 26, 12:02 AM
ginsu attached a referenced file: F445558: Screenshot 2023-03-26 at 2.56.38 AM.png.
Sun, Mar 26, 12:02 AM
ginsu attached a referenced file: F445562: Screenshot 2023-03-26 at 3.01.08 AM.png.
Sun, Mar 26, 12:02 AM
ginsu retitled D7134: [native] update message list header to new design from [native] render thread avatar in message list header title to [native] update message list header to new design.
Sun, Mar 26, 12:02 AM

Yesterday

ginsu updated the diff for D7134: [native] update message list header to new design.

update message list header to new desgin

Sat, Mar 25, 11:44 PM
ginsu abandoned D7133: [lib] introduce getAvatarForThreadEntity function.

No longer necessary with D7178

Sat, Mar 25, 11:41 PM
ginsu added a comment to D7132: [lib] introduce useGetAvatarForThread hook.
In D7132#212051, @ashoat wrote:

Mostly questions

Sat, Mar 25, 11:41 PM
ginsu updated the diff for D7132: [lib] introduce useGetAvatarForThread hook.

remove stray ?

Sat, Mar 25, 11:37 PM
ginsu updated the summary of D7178: [lib] introduce getUserAvatarForThread function.
Sat, Mar 25, 11:35 PM
ginsu attached a referenced file: F445490: Screenshot 2023-03-24 at 3.04.22 PM.png.
Sat, Mar 25, 11:34 PM
ginsu attached a referenced file: F445489: Screenshot 2023-03-24 at 3.04.13 PM.png.
Sat, Mar 25, 11:34 PM
ginsu updated the summary of D7132: [lib] introduce useGetAvatarForThread hook.
Sat, Mar 25, 11:34 PM
ginsu updated the diff for D7132: [lib] introduce useGetAvatarForThread hook.

change order

Sat, Mar 25, 11:24 PM
ginsu updated the diff for D7132: [lib] introduce useGetAvatarForThread hook.

new version of useGetAvatarForThread

Sat, Mar 25, 11:20 PM
ginsu added inline comments to D7178: [lib] introduce getUserAvatarForThread function.
Sat, Mar 25, 11:17 PM
ginsu attached a referenced file: F445426: Screenshot 2023-03-26 at 2.03.53 AM.png.
Sat, Mar 25, 11:16 PM
ginsu attached a referenced file: F445425: Screenshot 2023-03-26 at 2.03.55 AM.png.
Sat, Mar 25, 11:16 PM
ginsu attached a referenced file: F445424: Screenshot 2023-03-26 at 2.05.59 AM.png.
Sat, Mar 25, 11:16 PM
ginsu attached a referenced file: F445423: Screenshot 2023-03-26 at 2.05.44 AM.png.
Sat, Mar 25, 11:16 PM
ginsu updated the summary of D7178: [lib] introduce getUserAvatarForThread function.
Sat, Mar 25, 11:16 PM
ginsu requested review of D7178: [lib] introduce getUserAvatarForThread function.
Sat, Mar 25, 11:04 PM