Page MenuHomePhabricator

Active Repositories
View All

Recent Activity
View All

Today

ginsu updated the diff for D9258: [native] introduce UserProfileRelationshipButton.

fix icon

Thu, Sep 21, 8:43 PM
ashoat accepted D9262: [lib] Add `ThreadActivityStore` to Redux.
In D9262#272510, @atul wrote:
In D9262#272502, @ashoat wrote:

In the past, we would need to update websites-responders.js when adding a new field to Redux state. Now that Redux state for the web is fetched via an API call, is there a different place we should be updating?

Based on my reading of https://phab.comm.dev/D9145, the "new place" is web/redux/default-state.js which I did update in this diff.

Thu, Sep 21, 7:01 PM
atul added inline comments to D9262: [lib] Add `ThreadActivityStore` to Redux.
Thu, Sep 21, 2:37 PM
atul updated the diff for D9262: [lib] Add `ThreadActivityStore` to Redux.

fix

Thu, Sep 21, 2:33 PM
atul updated the diff for D9262: [lib] Add `ThreadActivityStore` to Redux.

address feedback

Thu, Sep 21, 2:30 PM
atul added a comment to D9262: [lib] Add `ThreadActivityStore` to Redux.
In D9262#272502, @ashoat wrote:

In the past, we would need to update websites-responders.js when adding a new field to Redux state. Now that Redux state for the web is fetched via an API call, is there a different place we should be updating?

Thu, Sep 21, 2:22 PM
ashoat requested changes to D9262: [lib] Add `ThreadActivityStore` to Redux.

In the past, we would need to update websites-responders.js when adding a new field to Redux state. Now that Redux state for the web is fetched via an API call, is there a different place we should be updating?

Thu, Sep 21, 2:14 PM
atul published D9262: [lib] Add `ThreadActivityStore` to Redux for review.
Thu, Sep 21, 1:58 PM
ginsu closed D9204: [lib] introduce threadInfosSelectorForThreadType selector.
Thu, Sep 21, 1:45 PM
ginsu committed rCOMM9e4fe445626b: [lib] introduce threadInfosSelectorForThreadType selector (authored by ginsu).
[lib] introduce threadInfosSelectorForThreadType selector
Thu, Sep 21, 1:45 PM
ginsu closed D9235: [lib] introduce createPendingPersonalThread function.
Thu, Sep 21, 1:45 PM
ginsu committed rCOMM37a9f269f73e: [lib] introduce createPendingPersonalThread function (authored by ginsu).
[lib] introduce createPendingPersonalThread function
Thu, Sep 21, 1:45 PM
ginsu updated the diff for D9204: [lib] introduce threadInfosSelectorForThreadType selector.

rebase before landing

Thu, Sep 21, 1:42 PM
ginsu updated the diff for D9235: [lib] introduce createPendingPersonalThread function.

rebase before landing

Thu, Sep 21, 1:41 PM
ginsu closed D9223: [nix] add logs to console while waiting for MariaDB to come up.
Thu, Sep 21, 1:37 PM
ginsu committed rCOMM0bdf8c8da1a4: [nix] add logs to console while waiting for MariaDB to come up (authored by ginsu).
[nix] add logs to console while waiting for MariaDB to come up
Thu, Sep 21, 1:37 PM
ashoat accepted D9223: [nix] add logs to console while waiting for MariaDB to come up.
Thu, Sep 21, 1:01 PM
ashoat accepted D9235: [lib] introduce createPendingPersonalThread function.
Thu, Sep 21, 1:00 PM
ginsu requested review of D9261: [native] introduce useNavigateToUserProfileBottomSheet hook.
Thu, Sep 21, 12:18 PM
varun accepted D9223: [nix] add logs to console while waiting for MariaDB to come up.
Thu, Sep 21, 12:01 PM
ginsu updated the summary of D9260: [native] improve BottomSheet component close function.
Thu, Sep 21, 12:00 PM
varun accepted D9220: [keyserver] Encode the device id into the QR code.

thank you! one comment inline

Thu, Sep 21, 11:57 AM
ginsu requested review of D9260: [native] improve BottomSheet component close function.
Thu, Sep 21, 11:45 AM
ginsu attached a referenced file: F769080: Screenshot 2023-09-21 at 2.03.59 PM.png.
Thu, Sep 21, 11:15 AM
ginsu attached a referenced file: F769081: Screenshot 2023-09-21 at 2.02.28 PM.png.
Thu, Sep 21, 11:15 AM
ginsu attached a referenced file: F769082: Screenshot 2023-09-21 at 2.04.07 PM.png.
Thu, Sep 21, 11:15 AM
ginsu attached a referenced file: F769112: Screen Recording 2023-09-21 at 2.10.10 PM.mov.
Thu, Sep 21, 11:15 AM
ginsu attached a referenced file: F769113: Screen Recording 2023-09-21 at 2.11.46 PM.mov.
Thu, Sep 21, 11:15 AM
ginsu attached a referenced file: F769117: Screenshot 2023-09-20 at 4.49.07 PM.png.
Thu, Sep 21, 11:15 AM
ginsu updated the test plan for D9258: [native] introduce UserProfileRelationshipButton.
Thu, Sep 21, 11:15 AM
ginsu updated subscribers of D9258: [native] introduce UserProfileRelationshipButton.
Thu, Sep 21, 11:14 AM
ginsu requested review of D9258: [native] introduce UserProfileRelationshipButton.
Thu, Sep 21, 11:14 AM
atul updated the diff for D9227: [patch] Patch `expo-modules-core` to unblock iOS build on macOS Sonoma.

rebase

Thu, Sep 21, 10:55 AM
ginsu requested review of D9235: [lib] introduce createPendingPersonalThread function.
Thu, Sep 21, 10:41 AM
rohan closed D9180: [keyserver] Print out a QR code to the terminal.
Thu, Sep 21, 10:21 AM
rohan committed rCOMM5842359feb58: [keyserver] Print out a QR code to the terminal (authored by rohan).
[keyserver] Print out a QR code to the terminal
Thu, Sep 21, 10:21 AM
ginsu updated the diff for D9223: [nix] add logs to console while waiting for MariaDB to come up.

simplify/address comments

Thu, Sep 21, 10:07 AM
ginsu closed D9203: [web] introduce AppearanceChangeModal.
Thu, Sep 21, 9:52 AM
ginsu committed rCOMM57caceed7b27: [web] introduce AppearanceChangeModal (authored by ginsu).
[web] introduce AppearanceChangeModal
Thu, Sep 21, 9:52 AM
ginsu closed D9120: [native] update UserProfileBottomSheet to get a userInfo from a userID.
Thu, Sep 21, 9:51 AM