Page MenuHomePhabricator

Active Repositories

Recent Activity

Today

bartek updated the summary of D14916: [lib] Add hook to check if restoration finished.
Mon, Jul 14, 7:34 AM
bartek published D14916: [lib] Add hook to check if restoration finished for review.
Mon, Jul 14, 7:33 AM
bartek accepted D14923: [native] Correctly handle Farcaster disconnection during the registration flow.
Mon, Jul 14, 7:25 AM
bartek published D14925: [native] Navigate to error screen after restoration failure for review.
Mon, Jul 14, 7:18 AM
bartek published D14924: [native] Add screen for restoration error for review.
Mon, Jul 14, 7:17 AM
bartek added a comment to D14920: [web] Add UI for tracking restoration progress.

Separately, question: does the test_error line wrap?

Mon, Jul 14, 7:02 AM
bartek attached a referenced file: F10946946: Screenshot 2025-07-14 at 15.54.15.png.
Mon, Jul 14, 6:55 AM
bartek added a comment to D14920: [web] Add UI for tracking restoration progress.

I wonder if we can reduce the amount of text. Where is it sourced from? I'd like to provide suggestions, but I can't see the source here.

Mon, Jul 14, 6:54 AM
ashoat added a comment to D14920: [web] Add UI for tracking restoration progress.

Thanks, this looks better!

Mon, Jul 14, 6:39 AM
bartek attached a referenced file: F10946184: v3.mp4.
Mon, Jul 14, 6:35 AM
bartek added a comment to D14920: [web] Add UI for tracking restoration progress.

Aligning to the largerst screen (error) looks like this:

Mon, Jul 14, 6:35 AM
ashoat added a comment to D14920: [web] Add UI for tracking restoration progress.

Thanks, this looks way better! We're almost there... only thing left is to align the dimensions. I feel strongly that dimensions of a modal should not randomly change in size. It's okay that it looks kind of empty, we can eg. vertical-align the progress step indicator to make it look better. Additionally, realizing that the process of the subtitle in the header in only some cases (not on the starting screen) will be weird, so probably best to move the subtitle below the "underline" that appears under the header, so that the underline looks look like it jumps around.

Mon, Jul 14, 5:53 AM
kamil updated the diff for D14910: [lib] remove threadActivityStore asserting.

add threadActivityStore to persistBlacklist

Mon, Jul 14, 4:57 AM
kamil accepted D14913: [lib] Let useInvalidCSATLogOut run once.
Mon, Jul 14, 4:52 AM
kamil accepted D14912: [backup] Fix version info for RPC-uploaded UserKeys.
Mon, Jul 14, 4:49 AM
kamil closed D14908: [lib] create holders after restoring.
Mon, Jul 14, 4:49 AM
kamil closed D14907: [lib][web][native] implement SQLiteAPI method to get holders.
Mon, Jul 14, 4:49 AM
kamil committed rCOMM10a36b9985c9: [lib] create holders after restoring (authored by kamil).
[lib] create holders after restoring
Mon, Jul 14, 4:49 AM
kamil committed rCOMM2fab07c7c5cf: [lib][web][native] implement SQLiteAPI method to get holders (authored by kamil).
[lib][web][native] implement SQLiteAPI method to get holders
Mon, Jul 14, 4:49 AM
kamil closed D14906: [native] get attachments during compaction and log upload based on holders table.
Mon, Jul 14, 4:49 AM
kamil committed rCOMM49b3e1216c16: [native] get attachments during compaction and log upload based on holders table (authored by kamil).
[native] get attachments during compaction and log upload based on holders table
Mon, Jul 14, 4:49 AM
kamil updated the diff for D14908: [lib] create holders after restoring.

rebase before landing

Mon, Jul 14, 4:08 AM
kamil closed D14905: [lib][web][native] remove holders asserting and blacklist holder store.
Mon, Jul 14, 4:01 AM
kamil committed rCOMM44f410123877: [lib][web][native] remove holders asserting and blacklist holder store (authored by kamil).
[lib][web][native] remove holders asserting and blacklist holder store
Mon, Jul 14, 4:01 AM
kamil added inline comments to D14906: [native] get attachments during compaction and log upload based on holders table.
Mon, Jul 14, 3:44 AM
bartek attached a referenced file: F10939777: v2.mp4.
Mon, Jul 14, 3:20 AM
bartek added a comment to D14920: [web] Add UI for tracking restoration progress.

Posting an updated video. My impressions:

  1. The progress screen is now empty, but this might be okay.
  2. All three screens (QR, progress, error) now have different modal dimensions. Aligning them would make the progress screen feel emptier.
Mon, Jul 14, 3:20 AM
tomek requested review of D14923: [native] Correctly handle Farcaster disconnection during the registration flow.
Mon, Jul 14, 2:11 AM

Fri, Jul 11

ashoat added a comment to D14920: [web] Add UI for tracking restoration progress.

UI feedback

Fri, Jul 11, 8:01 AM
ashoat resigned from D14915: [native] Show alert when DB is corrupt on app startup.

Copy looks good!

Fri, Jul 11, 7:55 AM
bartek published D14920: [web] Add UI for tracking restoration progress for review.
Fri, Jul 11, 4:05 AM
bartek published D14921: [lib] Add actions to force set restoration state for review.
Fri, Jul 11, 4:05 AM
bartek published D14919: [web] Display PushNotif modal after restoration has finished for review.
Fri, Jul 11, 3:39 AM
bartek published D14917: [native] Keep LoggedOutModal until restoration finishes for review.
Fri, Jul 11, 3:39 AM
bartek published D14918: [web] Gate logged out screen on restoration finish for review.
Fri, Jul 11, 3:38 AM
bartek published D14915: [native] Show alert when DB is corrupt on app startup for review.
Fri, Jul 11, 2:26 AM
bartek published D14913: [lib] Let useInvalidCSATLogOut run once for review.
Fri, Jul 11, 1:45 AM
bartek published D14914: [lib] Add qrAuthInProgress prop to secondary auth context for review.
Fri, Jul 11, 1:44 AM
bartek added inline comments to D14911: [native] Connect Farcaster DCs during registration.
Fri, Jul 11, 12:35 AM
bartek accepted D14908: [lib] create holders after restoring.

D14885 and D14909 are now landed

Fri, Jul 11, 12:01 AM