Page MenuHomePhabricator

varun (Varun Dhananjaya)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 30 2021, 11:14 AM (123 w, 5 d)

Recent Activity

Yesterday

varun requested review of D11658: [identity] check that prekeys are formatted correctly.
Sat, Apr 13, 11:57 AM
varun published D11608: [identity] otk db changes for review.
Sat, Apr 13, 11:40 AM
varun requested review of D11657: check one-time key format.
Sat, Apr 13, 8:58 AM

Thu, Apr 11

varun closed D11625: [native] call setCommServicesAuthMetadata on wallet registration.
Thu, Apr 11, 11:11 AM
varun committed rCOMM2778952217d6: [native] call setCommServicesAuthMetadata on wallet registration (authored by varun).
[native] call setCommServicesAuthMetadata on wallet registration
Thu, Apr 11, 11:11 AM

Wed, Apr 10

varun requested review of D11625: [native] call setCommServicesAuthMetadata on wallet registration.
Wed, Apr 10, 1:30 PM
varun closed D11585: [lib] remove reference to nonexistent keyserver endpoint.
Wed, Apr 10, 12:08 PM
varun committed rCOMM1d328ce5d786: [lib] remove reference to nonexistent keyserver endpoint (authored by varun).
[lib] remove reference to nonexistent keyserver endpoint
Wed, Apr 10, 12:08 PM
varun closed D11623: [native] remove unnecessary include.
Wed, Apr 10, 12:07 PM
varun committed rCOMMcf5e7c2e5d1e: [native] remove unnecessary include (authored by varun).
[native] remove unnecessary include
Wed, Apr 10, 12:07 PM
varun requested review of D11623: [native] remove unnecessary include.
Wed, Apr 10, 11:04 AM
varun accepted D11570: [protos][identity] Add RPC for fetching multiple device lists.
Wed, Apr 10, 10:59 AM
varun accepted D11547: [protos] Refactor user Identity message type.
Wed, Apr 10, 10:17 AM
varun accepted D11573: [native] Clear auth metadata on logout.

For some reason setCommServicesAuthMetadata creates a job that is run on GlobalDBSingleton::instance

Looks like this code was introduced by @varun in D9224. @varun, can you clarify why you're running this on the DB thread given it doesn't perform any SQLite queries? I'm wondering if it's done that way on purpose to protect against some race condition or something. @tomek changes that logic here, so we should make sure we're not accidentally reverting something that was decided intentionally.

Wed, Apr 10, 10:15 AM

Mon, Apr 8

varun requested review of D11585: [lib] remove reference to nonexistent keyserver endpoint.
Mon, Apr 8, 8:25 AM
varun requested review of D11590: add deletePasswordUser to IdentityServiceClient.
Mon, Apr 8, 8:19 AM
varun requested review of D11589: [commRustModule] expose deletePasswordUser to JS.
Mon, Apr 8, 8:14 AM
varun requested review of D11588: [native_rust_library] implement delete_password_user method and move delete methods to a separate file.
Mon, Apr 8, 8:08 AM
varun requested review of D11587: replace single deleteUser RPC with deleteWalletUser, deletePasswordUserStart, and deletePasswordUserFinish.
Mon, Apr 8, 8:04 AM
varun abandoned D10657: [shared][protos] update UpdateUserPassword and DeleteUser workflows to match whitepaper.
Mon, Apr 8, 7:42 AM
varun abandoned D10738: [identity] identity service changes corresponding to proto updates.
Mon, Apr 8, 7:42 AM

Fri, Apr 5

varun requested changes to D11547: [protos] Refactor user Identity message type.
Fri, Apr 5, 7:21 AM

Thu, Apr 4

varun accepted D11548: [identity] Store social proof as a Map in DDB.
Thu, Apr 4, 8:22 PM
varun closed D11515: [keyserver] expose getFarcasterUsers client method to JS on keyserver.
Thu, Apr 4, 6:42 PM
varun committed rCOMMd36ab4dcb7f8: [keyserver] expose getFarcasterUsers client method to JS on keyserver (authored by varun).
[keyserver] expose getFarcasterUsers client method to JS on keyserver
Thu, Apr 4, 6:42 PM
varun closed D11514: [native] fix regression in error handling.
Thu, Apr 4, 6:42 PM
varun committed rCOMMb7b0e9b81b8a: [native] fix regression in error handling (authored by varun).
[native] fix regression in error handling
Thu, Apr 4, 6:42 PM
varun accepted D11549: [protos] Remove social_proof from IdentityKeyInfo.

amazing, thank you!

Thu, Apr 4, 12:22 PM
varun accepted D11556: Update comm_query_executor.wasm.
Thu, Apr 4, 12:10 PM
varun added inline comments to D11549: [protos] Remove social_proof from IdentityKeyInfo.
Thu, Apr 4, 11:40 AM
varun accepted D11551: [protos] Replace challengeResponse with nonce and signature pair.
Thu, Apr 4, 11:38 AM

Wed, Apr 3

varun added a comment to D11524: [native_rust_library] Cleanup remaining APIs.

in your testing were you able to see Rust logs in Xcode or your terminal? noticed we have #[instrument] for some functions in this library but i don't think we configure tracing anywhere...

Wed, Apr 3, 10:34 AM
varun accepted D11524: [native_rust_library] Cleanup remaining APIs.
Wed, Apr 3, 10:31 AM
varun accepted D11523: [native_rust_library] Move device list APIs to submodule.
Wed, Apr 3, 10:30 AM
varun accepted D11522: [native_rust_library] Move account actions to submodule.
Wed, Apr 3, 10:30 AM
varun accepted D11521: [native_rust_library] Move X3DH APIs to submodule.
Wed, Apr 3, 10:28 AM
varun accepted D11520: [native_rust_library] Move login APIs to submodule.
Wed, Apr 3, 10:27 AM
varun accepted D11519: [native_rust_library] Move password registration to submodule.
Wed, Apr 3, 10:26 AM
varun accepted D11518: [native_rust_library] Create ffi submodules for identity API.
Wed, Apr 3, 10:25 AM
varun accepted D11517: [native_rust_library] Create identity submodule.
Wed, Apr 3, 10:22 AM
varun accepted D11516: [native_rust_library] Extract utils module.
Wed, Apr 3, 10:21 AM
varun accepted D11546: [protos][identity] Make keyserver_info response non-optional.
Wed, Apr 3, 9:21 AM

Tue, Apr 2

varun added inline comments to D11514: [native] fix regression in error handling.
Tue, Apr 2, 12:29 PM
varun added inline comments to D11515: [keyserver] expose getFarcasterUsers client method to JS on keyserver.
Tue, Apr 2, 12:06 PM

Mon, Apr 1

varun accepted D11469: [native] Add LogInExistingDevice to native_rust_library.
Mon, Apr 1, 9:42 PM
varun accepted D11470: [native] Add JSI bindings for LogInExistingDevice RPC.
Mon, Apr 1, 9:35 PM
varun accepted D11466: [identity] Implement LogInExistingDevice RPC.
Mon, Apr 1, 9:28 PM
varun accepted D11471: [protos][identity] Add primary device keys to GetKeyserverKeys response.
Mon, Apr 1, 8:42 PM
varun accepted D11495: [lib][native] Pass FID from useRegistrationServerCall to identity service during registration.
Mon, Apr 1, 8:32 PM
varun requested review of D11515: [keyserver] expose getFarcasterUsers client method to JS on keyserver.
Mon, Apr 1, 3:15 PM
varun requested review of D11514: [native] fix regression in error handling.
Mon, Apr 1, 12:56 PM

Fri, Mar 29

varun accepted D11465: [protos] Add RPC to log in existing device.
Fri, Mar 29, 12:21 PM
varun accepted D11464: [commtest] Add test for FindUserIdentity RPC.
Fri, Mar 29, 12:20 PM

Thu, Mar 28

varun closed D11433: [lib][web][native] add unlinkFarcasterAccount to IdentityServiceClient interface and implementations.
Thu, Mar 28, 3:17 PM
varun committed rCOMM3806a88cd6aa: [lib][web][native] add unlinkFarcasterAccount to IdentityServiceClient… (authored by varun).
[lib][web][native] add unlinkFarcasterAccount to IdentityServiceClient…
Thu, Mar 28, 3:17 PM
varun closed D11431: [native] add unlinkFarcasterAccount to CommRustModule.
Thu, Mar 28, 3:17 PM
varun closed D11430: [native_rust_library] unlink_farcaster_account method.
Thu, Mar 28, 3:17 PM
varun committed rCOMM8cda325dd924: [native] add unlinkFarcasterAccount to CommRustModule (authored by varun).
[native] add unlinkFarcasterAccount to CommRustModule
Thu, Mar 28, 3:17 PM
varun committed rCOMMcfc0654d4c18: [native_rust_library] unlink_farcaster_account method (authored by varun).
[native_rust_library] unlink_farcaster_account method
Thu, Mar 28, 3:17 PM
varun closed D11423: [identity] unlink farcaster account RPC.
Thu, Mar 28, 3:17 PM
varun committed rCOMM361377ad6c39: [identity] unlink farcaster account RPC (authored by varun).
[identity] unlink farcaster account RPC
Thu, Mar 28, 3:17 PM
varun closed D11413: [identity] on linkFarcasterUser we should return an error if the FID already exists for a different user in the users table.
Thu, Mar 28, 3:17 PM
varun closed D11412: [identity] check if fid is already taken when registering new user.
Thu, Mar 28, 3:17 PM
varun committed rCOMM7e269eae587e: [identity] on linkFarcasterUser we should return an error if the FID already… (authored by varun).
[identity] on linkFarcasterUser we should return an error if the FID already…
Thu, Mar 28, 3:17 PM
varun committed rCOMMc648927875bc: [identity] check if fid is already taken when registering new user (authored by varun).
[identity] check if fid is already taken when registering new user
Thu, Mar 28, 3:17 PM
varun closed D11411: [identity] don't let linkFarcasterAccount overwrite existing fid for user.
Thu, Mar 28, 3:17 PM
varun closed D11410: [web] add client methods to web.
Thu, Mar 28, 3:17 PM
varun committed rCOMM8ec3ffdc4d77: [identity] don't let linkFarcasterAccount overwrite existing fid for user (authored by varun).
[identity] don't let linkFarcasterAccount overwrite existing fid for user
Thu, Mar 28, 3:17 PM
varun committed rCOMM563337b5ede7: [web] add client methods to web (authored by varun).
[web] add client methods to web
Thu, Mar 28, 3:17 PM
varun closed D11409: [native] add linkFarcasterAccount to native IdentityServiceContextProvider.
Thu, Mar 28, 3:17 PM
varun closed D11408: [native] add linkFarcasterAccount to commRustModule.
Thu, Mar 28, 3:17 PM
varun committed rCOMM046f7eed864b: [native] add linkFarcasterAccount to native IdentityServiceContextProvider (authored by varun).
[native] add linkFarcasterAccount to native IdentityServiceContextProvider
Thu, Mar 28, 3:17 PM
varun committed rCOMM80b046bb17c9: [native] add linkFarcasterAccount to commRustModule (authored by varun).
[native] add linkFarcasterAccount to commRustModule
Thu, Mar 28, 3:17 PM
varun closed D11407: [native_rust_library] implement link_farcaster_account client method.
Thu, Mar 28, 3:17 PM
varun committed rCOMM607b65279825: [native_rust_library] implement link_farcaster_account client method (authored by varun).
[native_rust_library] implement link_farcaster_account client method
Thu, Mar 28, 3:17 PM
varun closed D11406: [identity] link farcaster account implementation.
Thu, Mar 28, 3:13 PM
varun closed D11405: [lib][native] Add getFarcasterUsers to IdentityServiceContextProvider.
Thu, Mar 28, 3:13 PM
varun committed rCOMMf1d96072c6f2: [identity] link farcaster account implementation (authored by varun).
[identity] link farcaster account implementation
Thu, Mar 28, 3:13 PM
varun committed rCOMM17638e45a66f: [lib][native] Add getFarcasterUsers to IdentityServiceContextProvider (authored by ashoat).
[lib][native] Add getFarcasterUsers to IdentityServiceContextProvider
Thu, Mar 28, 3:13 PM
varun closed D11403: [native_rust_library] get_farcaster_users client method.
Thu, Mar 28, 3:13 PM
varun closed D11404: [native] add getFarcasterUsers to commRustModule.
Thu, Mar 28, 3:13 PM
varun committed rCOMMa9273fca68b7: [native_rust_library] get_farcaster_users client method (authored by varun).
[native_rust_library] get_farcaster_users client method
Thu, Mar 28, 3:13 PM
varun committed rCOMM1c4801b3aae5: [native] add getFarcasterUsers to commRustModule (authored by varun).
[native] add getFarcasterUsers to commRustModule
Thu, Mar 28, 3:13 PM
varun closed D11402: [identity] get farcaster users rpc implementation.
Thu, Mar 28, 3:13 PM
varun committed rCOMM88d9a0987b2b: [identity] get farcaster users rpc implementation (authored by varun).
[identity] get farcaster users rpc implementation
Thu, Mar 28, 3:13 PM
varun closed D11401: [identity] db method to get users for a set of farcaster ids.
Thu, Mar 28, 2:55 PM
varun closed D11400: [terraform] add GSI for farcasterID.
Thu, Mar 28, 2:55 PM
varun committed rCOMMaa1feb75a585: [identity] db method to get users for a set of farcaster ids (authored by varun).
[identity] db method to get users for a set of farcaster ids
Thu, Mar 28, 2:55 PM
varun committed rCOMM6a0e5b571f8b: [terraform] add GSI for farcasterID (authored by varun).
[terraform] add GSI for farcasterID
Thu, Mar 28, 2:55 PM
varun closed D11399: [identity][proto] add GetFarcasterUsers and LinkFarcasterAccount rpcs.
Thu, Mar 28, 2:55 PM
varun closed D11398: [native] expose farcaster id param to native identity service context provider.
Thu, Mar 28, 2:55 PM
varun committed rCOMMcbc627ce542e: [native] expose farcaster id param to native identity service context provider (authored by varun).
[native] expose farcaster id param to native identity service context provider
Thu, Mar 28, 2:55 PM
varun committed rCOMMcbdd966e6c5f: [identity][proto] add GetFarcasterUsers and LinkFarcasterAccount rpcs (authored by varun).
[identity][proto] add GetFarcasterUsers and LinkFarcasterAccount rpcs
Thu, Mar 28, 2:55 PM
varun closed D11396: [proto][identity] add optional fid to registration request messages.
Thu, Mar 28, 2:55 PM
varun committed rCOMM75706c132d20: [proto][identity] add optional fid to registration request messages (authored by varun).
[proto][identity] add optional fid to registration request messages
Thu, Mar 28, 2:55 PM
varun added inline comments to D11406: [identity] link farcaster account implementation.
Thu, Mar 28, 2:45 PM
varun added inline comments to D11411: [identity] don't let linkFarcasterAccount overwrite existing fid for user.
Thu, Mar 28, 2:33 PM
varun added inline comments to D11403: [native_rust_library] get_farcaster_users client method.
Thu, Mar 28, 2:17 PM
varun added inline comments to D11401: [identity] db method to get users for a set of farcaster ids.
Thu, Mar 28, 2:06 PM
varun added inline comments to D11401: [identity] db method to get users for a set of farcaster ids.
Thu, Mar 28, 1:38 PM