Page MenuHomePhabricator
People varun

varun (Varun Dhananjaya)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 30 2021, 11:14 AM (138 w, 3 d)

Recent Activity
View All

Yesterday

varun added inline comments to D12888: [identity] Add function to batch-get device lists.
Fri, Jul 26, 12:30 PM
varun accepted D12888: [identity] Add function to batch-get device lists.
Fri, Jul 26, 12:29 PM
varun added inline comments to D12884: [native] replace keyserver using qr code auth.
Fri, Jul 26, 12:14 PM
varun abandoned D12885: [keyserver] script to output new db version.
Fri, Jul 26, 12:12 PM
varun accepted D12886: [identity] Forbid duplicated devices in device lists.
Fri, Jul 26, 8:14 AM

Thu, Jul 25

varun requested review of D12885: [keyserver] script to output new db version.
Thu, Jul 25, 9:09 PM
varun requested review of D12884: [native] replace keyserver using qr code auth.
Thu, Jul 25, 8:53 PM
varun closed D12873: [terraform] bump prod identity to 0.33.
Thu, Jul 25, 8:47 PM
varun committed rCOMMc82f82a0a1db: [terraform] bump prod identity to 0.33 (authored by varun).
[terraform] bump prod identity to 0.33
Thu, Jul 25, 8:47 PM
varun updated the diff for D12805: [lib] introduce new device list function to replace keyserver device.

address feedback

Thu, Jul 25, 8:37 PM
varun accepted D12880: [services] Replace deprecated aws_config::from_env().
Thu, Jul 25, 1:03 PM
varun accepted D12879: [services] Update AWS Rust SDK.
Thu, Jul 25, 12:55 PM
varun accepted D12883: [web] Fixes the emscripten CI build by allowing curl redirects.
Thu, Jul 25, 10:55 AM
varun accepted D12878: Update Rust to 1.76.
Thu, Jul 25, 8:30 AM

Wed, Jul 24

varun requested review of D12873: [terraform] bump prod identity to 0.33.
Wed, Jul 24, 12:06 PM
varun accepted D12868: [terraform] Rename `aws_ecs` to `keyserver_cluster` and move shared security group.
Wed, Jul 24, 11:34 AM
varun accepted D12863: [terraform] move image config to aws_ecs and add custom image variable.
Wed, Jul 24, 11:15 AM
varun accepted D12862: [terraform] update variables.tf self-host descriptions.
Wed, Jul 24, 10:47 AM
varun accepted D12861: [terraform] Actually use db_instance_class for mariadb.
Wed, Jul 24, 10:45 AM

Tue, Jul 23

varun accepted D12864: [terraform] upgrade the disk image to 1.0.102.
Tue, Jul 23, 6:20 PM

Mon, Jul 22

varun closed D12845: [terraform] bump staging identity to 0.33-staging.
Mon, Jul 22, 12:21 PM
varun committed rCOMM46def1591f85: [terraform] bump staging identity to 0.33-staging (authored by varun).
[terraform] bump staging identity to 0.33-staging
Mon, Jul 22, 12:21 PM
varun requested review of D12845: [terraform] bump staging identity to 0.33-staging.
Mon, Jul 22, 11:30 AM
varun abandoned D11810: [keyserver] mark prekeys and OTKs as published right before calling identity service.
Mon, Jul 22, 11:05 AM
varun abandoned D11811: [web][native] mark keys as published before uploading to identity service.
Mon, Jul 22, 11:04 AM
varun accepted D12823: [terraform] Avoid including Terraform state and secrets in keyserver Docker images.
Mon, Jul 22, 10:57 AM
varun closed D12832: [identity] modify get_all_user_details to return wallet addresses too.
Mon, Jul 22, 10:03 AM
varun closed D12830: [identity] check users table before reserved usernames table for user ID during wallet login.
Mon, Jul 22, 10:03 AM
varun closed D12831: [identity] get all usernames and wallet addresses in get_all_usernames.
Mon, Jul 22, 10:03 AM
varun committed rCOMM63e8e9dea808: [identity] check users table before reserved usernames table for user ID during… (authored by varun).
[identity] check users table before reserved usernames table for user ID during…
Mon, Jul 22, 10:03 AM
varun committed rCOMM2f4606fcdba3: [identity] modify get_all_user_details to return wallet addresses too (authored by varun).
[identity] modify get_all_user_details to return wallet addresses too
Mon, Jul 22, 10:03 AM
varun committed rCOMMa1e09026a6c1: [identity] get all usernames and wallet addresses in get_all_usernames (authored by varun).
[identity] get all usernames and wallet addresses in get_all_usernames
Mon, Jul 22, 10:03 AM
varun added a comment to D12831: [identity] get all usernames and wallet addresses in get_all_usernames.
In D12831#363248, @bartek wrote:

Accepting, but I noticed one more thing that needs to be considered.
Scan operation doesn't always return all items. It has response limit of 1MB. If it's exceeded, the response contains LastEvaluatedKey property, from which we should start a subsequent scan.

On the other hand, this table is relatively small (1k items, ~60kB) so it's far from the limit. And it's not expected to grow, so we could ignore the issue as well

AWS Docs: https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_Scan.html

Mon, Jul 22, 9:56 AM
varun closed D12822: [terraform] bump staging identity to 0.32-staging.
Mon, Jul 22, 7:40 AM
varun closed D12820: [identity] use redact_sensitive_data config to redact sensitive data in logs.
Mon, Jul 22, 7:40 AM
varun committed rCOMM7c295141bbfc: [terraform] bump staging identity to 0.32-staging (authored by varun).
[terraform] bump staging identity to 0.32-staging
Mon, Jul 22, 7:40 AM
varun committed rCOMMc5c4435b7b75: [identity] use redact_sensitive_data config to redact sensitive data in logs (authored by varun).
[identity] use redact_sensitive_data config to redact sensitive data in logs
Mon, Jul 22, 7:40 AM
varun closed D12819: [identity] redact_sensitive_data config.
Mon, Jul 22, 7:40 AM
varun committed rCOMMa7cfa610e0f3: [identity] redact_sensitive_data config (authored by varun).
[identity] redact_sensitive_data config
Mon, Jul 22, 7:40 AM

Sun, Jul 21

varun published D12832: [identity] modify get_all_user_details to return wallet addresses too for review.
Sun, Jul 21, 8:54 PM
varun requested review of D12831: [identity] get all usernames and wallet addresses in get_all_usernames.
Sun, Jul 21, 3:23 PM
varun requested review of D12830: [identity] check users table before reserved usernames table for user ID during wallet login.
Sun, Jul 21, 1:38 PM

Sat, Jul 20

varun published D12822: [terraform] bump staging identity to 0.32-staging for review.
Sat, Jul 20, 12:03 AM
varun requested review of D12820: [identity] use redact_sensitive_data config to redact sensitive data in logs.
Sat, Jul 20, 12:03 AM
varun updated the diff for D12819: [identity] redact_sensitive_data config.

env var should be string

Sat, Jul 20, 12:01 AM

Fri, Jul 19

varun requested review of D12819: [identity] redact_sensitive_data config.
Fri, Jul 19, 11:55 PM
varun abandoned D12818: [identity] remove user ID from "no device list" log.

abandoning in favor of D12819 and D12820

Fri, Jul 19, 11:41 PM
varun requested review of D12818: [identity] remove user ID from "no device list" log.
Fri, Jul 19, 10:55 PM
varun requested review of D12809: [lib] add new selector and function to get own user's keyserver device ID.
Fri, Jul 19, 2:34 PM
varun requested review of D12805: [lib] introduce new device list function to replace keyserver device.
Fri, Jul 19, 1:09 PM

Thu, Jul 18

varun added inline comments to D12734: [lib] add device type to qr code URL.
Thu, Jul 18, 9:39 PM
varun accepted D12800: [terraform] use `.env` in self-host folder for keyserver config variables instead of specifying values in terraform.tfvars or terraform.tfvars.json.
Thu, Jul 18, 4:06 PM
varun closed D12798: [terraform] bump staging identity to 0.31-staging.
Thu, Jul 18, 3:49 PM
varun committed rCOMM2bfca588eb95: [terraform] bump staging identity to 0.31-staging (authored by varun).
[terraform] bump staging identity to 0.31-staging
Thu, Jul 18, 3:49 PM
varun requested review of D12798: [terraform] bump staging identity to 0.31-staging.
Thu, Jul 18, 2:21 PM
varun closed D12797: [identity] increase connect timeout to 60 seconds.
Thu, Jul 18, 2:03 PM
varun committed rCOMMee487b75b248: [identity] increase connect timeout to 60 seconds (authored by varun).
[identity] increase connect timeout to 60 seconds
Thu, Jul 18, 2:03 PM
varun requested review of D12797: [identity] increase connect timeout to 60 seconds.
Thu, Jul 18, 1:49 PM
varun closed D12792: [terraform] Increase Identity memory to 2048.
Thu, Jul 18, 12:04 PM
varun committed rCOMM2f2e98ec0869: [terraform] Increase Identity memory to 2048 (authored by bartek).
[terraform] Increase Identity memory to 2048
Thu, Jul 18, 12:04 PM
varun updated the diff for D12792: [terraform] Increase Identity memory to 2048.

commandeer

Thu, Jul 18, 11:15 AM
varun commandeered D12792: [terraform] Increase Identity memory to 2048.

bartek is afk so i'm going to commandeer and land

Thu, Jul 18, 10:59 AM
varun accepted D12792: [terraform] Increase Identity memory to 2048.
Thu, Jul 18, 7:41 AM

Wed, Jul 17

varun accepted D12725: [terraform] add Tunnelbroker configuration variable to self-host.
Wed, Jul 17, 2:17 PM
varun added inline comments to D12734: [lib] add device type to qr code URL.
Wed, Jul 17, 11:09 AM

Fri, Jul 12

varun closed D12732: [terraform] bump prod identity to 0.29.
Fri, Jul 12, 2:08 PM
varun committed rCOMM05fa3c592f34: [terraform] bump prod identity to 0.29 (authored by varun).
[terraform] bump prod identity to 0.29
Fri, Jul 12, 2:08 PM
varun requested review of D12734: [lib] add device type to qr code URL.
Fri, Jul 12, 12:34 PM
varun closed D12620: [native] modify SecondaryDeviceQRCodeScanner to support emulator.
Fri, Jul 12, 12:19 PM
varun committed rCOMM63899045a319: [native] modify SecondaryDeviceQRCodeScanner to support emulator (authored by varun).
[native] modify SecondaryDeviceQRCodeScanner to support emulator
Fri, Jul 12, 12:19 PM
varun added inline comments to D12620: [native] modify SecondaryDeviceQRCodeScanner to support emulator.
Fri, Jul 12, 10:37 AM
varun closed D12619: [keyserver] display copyable url for qr code auth.
Fri, Jul 12, 12:18 AM
varun closed D12618: [keyserver] don't display the QR code if keyserver is already logged in.
Fri, Jul 12, 12:18 AM
varun committed rCOMM816b07e456a8: [keyserver] display copyable url for qr code auth (authored by varun).
[keyserver] display copyable url for qr code auth
Fri, Jul 12, 12:18 AM
varun committed rCOMM314adf5b2f47: [keyserver] don't display the QR code if keyserver is already logged in (authored by varun).
[keyserver] don't display the QR code if keyserver is already logged in
Fri, Jul 12, 12:18 AM
varun closed D12213: [keyserver] finish secondary login via qr code.
Fri, Jul 12, 12:18 AM
varun committed rCOMMc7755c1d0935: [keyserver] finish secondary login via qr code (authored by varun).
[keyserver] finish secondary login via qr code
Fri, Jul 12, 12:18 AM
varun added inline comments to D12620: [native] modify SecondaryDeviceQRCodeScanner to support emulator.
Fri, Jul 12, 12:15 AM

Thu, Jul 11

varun added inline comments to D12620: [native] modify SecondaryDeviceQRCodeScanner to support emulator.
Thu, Jul 11, 3:19 PM
varun updated the diff for D12620: [native] modify SecondaryDeviceQRCodeScanner to support emulator.

address feedback

Thu, Jul 11, 3:18 PM
varun removed a reviewer for D12732: [terraform] bump prod identity to 0.29: will. varun added 1 blocking reviewer(s) for D12732: [terraform] bump prod identity to 0.29: ashoat.

making ashoat blocking since we're discussing when to do this deployment on Comm

Thu, Jul 11, 1:02 PM
varun published D12732: [terraform] bump prod identity to 0.29 for review.
Thu, Jul 11, 12:47 PM
varun closed D12723: [terraform] bump staging identity to 0.29-staging.
Thu, Jul 11, 12:37 PM
varun committed rCOMM9110bf477939: [terraform] bump staging identity to 0.29-staging (authored by varun).
[terraform] bump staging identity to 0.29-staging
Thu, Jul 11, 12:37 PM
varun added a comment to D12619: [keyserver] display copyable url for qr code auth.
In D12619#357437, @ashoat wrote:

What is the URL that is printed? Wondering if it's https or some sort of deep link

Thu, Jul 11, 12:02 PM
varun added a comment to D12213: [keyserver] finish secondary login via qr code.

https://linear.app/comm/issue/ENG-8813/remove-recursive-logic-from-tunnelbroker-websocket-code-in-keyserver

Thu, Jul 11, 11:57 AM
varun requested review of D12723: [terraform] bump staging identity to 0.29-staging.

staging is fixed now -- all items in the identity-users table with a username attribute now also have a usernameLower attribute

Thu, Jul 11, 11:02 AM
varun requested review of D12723: [terraform] bump staging identity to 0.29-staging.
Thu, Jul 11, 12:38 AM
varun accepted D12709: [terraform] Ensure only one running ecs task for primary service.
Thu, Jul 11, 12:20 AM
varun accepted D12691: [terraform] include REDIS_URL as part of keyserver terraform config.
Thu, Jul 11, 12:18 AM
varun accepted D12690: [terraform] restrict redis access to ecs keyserver service only.
Thu, Jul 11, 12:17 AM

Wed, Jul 10

varun added a comment to D12689: [terraform] create comm database on aws rds startup.

this solution is pretty neat

Wed, Jul 10, 11:58 PM
varun accepted D12689: [terraform] create comm database on aws rds startup.
Wed, Jul 10, 11:58 PM
varun accepted D12688: [terraform] make aws rds instance class configurable for self-hosting.
Wed, Jul 10, 11:56 PM
varun accepted D12719: Fix CORS issues with identity HTTP.
Wed, Jul 10, 11:55 PM
varun added a comment to D12704: [identity] fix issues with capitalized usernames in users and reserved usernames tables.
In D12704#360102, @will wrote:

Directly synced with Varun. Looks good. Before landing make sure to remove need for unnecessary partition key check and add a comment for changes starting from line 340 in services/identity/src/database.rs

Wed, Jul 10, 11:49 PM
varun closed D12704: [identity] fix issues with capitalized usernames in users and reserved usernames tables.
Wed, Jul 10, 11:48 PM
varun committed rCOMM8383596b0c9c: [identity] fix issues with capitalized usernames in users and reserved… (authored by varun).
[identity] fix issues with capitalized usernames in users and reserved…
Wed, Jul 10, 11:48 PM
varun updated the diff for D12704: [identity] fix issues with capitalized usernames in users and reserved usernames tables.

some small fixes

Wed, Jul 10, 11:39 PM
varun closed D12705: [terraform] bump production identity service to 0.28.
Wed, Jul 10, 1:17 AM