User Details
User Details
- User Since
- Nov 30 2021, 11:14 AM (157 w, 6 d)
Mon, Dec 2
Mon, Dec 2
varun committed rCOMM8a57c1cde452: [terraform] identity 0.46 staging deployment (authored by varun).
[terraform] identity 0.46 staging deployment
varun requested review of D14070: [terraform] identity 0.46 staging deployment.
Wed, Nov 27
Wed, Nov 27
varun added inline comments to D14054: [native] navigate to community directory nux tip if user declines prompt or closes bottom sheet.
Tue, Nov 26
Tue, Nov 26
varun added inline comments to D13986: [native] bottom sheet for exploring communities.
Mon, Nov 25
Mon, Nov 25
varun added inline comments to D13994: [native] community list item component.
varun added inline comments to D13986: [native] bottom sheet for exploring communities.
varun added inline comments to D14040: [keyserver] Add param to getRetention to customize activity period being checked.
Thu, Nov 21
Thu, Nov 21
varun added a comment to D13996: [native] community joiner modal.
btw, this diff replaces D13493, which I plan on abandoning. i think i've applied all the feedback from there, but referencing here just in case
varun requested review of D13996: [native] community joiner modal.
varun requested review of D13995: [native] introduce community list component.
varun added a comment to D13994: [native] community list item component.
the search bar placeholder text is in the following diff, where it is actually "Search communities" (see D13995)
varun updated the test plan for D13994: [native] community list item component.
varun attached a referenced file: F3335850: RPReplay_Final1732217286.MP4.
varun added a comment to D13994: [native] community list item component.
varun requested review of D13994: [native] community list item component.
varun added inline comments to D13986: [native] bottom sheet for exploring communities.
varun requested review of D13987: [native] button in community drawer for exploring communities.
varun requested review of D13986: [native] bottom sheet for exploring communities.
Wed, Nov 20
Wed, Nov 20
varun committed rCOMM183ac09a25b3: [keyserver] return threadInfo in fetchAllCommunityInfosWithNames (authored by varun).
[keyserver] return threadInfo in fetchAllCommunityInfosWithNames
varun committed rCOMM1490b842faf6: [keyserver] new fetchPrivilegedThreadInfos function (authored by varun).
[keyserver] new fetchPrivilegedThreadInfos function
Tue, Nov 19
Tue, Nov 19
varun added inline comments to D13854: [keyserver] return threadInfo in fetchAllCommunityInfosWithNames.
varun added inline comments to D13852: [keyserver] new fetchPrivilegedThreadInfos function.
varun updated the diff for D13854: [keyserver] return threadInfo in fetchAllCommunityInfosWithNames.
address feedback
varun updated the diff for D13852: [keyserver] new fetchPrivilegedThreadInfos function.
address feedback
Fri, Nov 15
Fri, Nov 15
varun committed rCOMM5e90e9617847: [keyserver][lib] change thread info validators -> thin raw thread info… (authored by varun).
[keyserver][lib] change thread info validators -> thin raw thread info…
varun updated the diff for D13852: [keyserver] new fetchPrivilegedThreadInfos function.
make param read only
varun updated the diff for D13852: [keyserver] new fetchPrivilegedThreadInfos function.
new approach without using script viewer
changing approach
varun added a comment to D13851: [keyserver] fetchThreadInfos -> fetchAccessibleThreadInfos.
decided not to rename. will instead call my new function fetchPrivilegedThreadInfos
can you please make sure that Linear creates issues when these alarms fire?
Wed, Nov 13
Wed, Nov 13
[native] remove exitingCallback
varun committed rCOMMe8675e276b22: [native] make the list of NUX tips to be displayed configurable (authored by varun).
[native] make the list of NUX tips to be displayed configurable
Tue, Nov 12
Tue, Nov 12
varun requested review of D13920: [native] remove exitingCallback.
varun requested review of D13917: [native] make the list of NUX tips to be displayed configurable.
[shared] bump opaque-ke to 2.1.0-pre.1
Upgrade to Rust 1.81
varun added inline comments to D13895: [shared] bump opaque-ke to 2.1.0-pre.1.
Nov 8 2024
Nov 8 2024
varun added inline comments to D13895: [shared] bump opaque-ke to 2.1.0-pre.1.
Nov 7 2024
Nov 7 2024
varun updated the diff for D13896: Upgrade to Rust 1.81.
minimal Cargo.lock update
varun requested review of D13896: Upgrade to Rust 1.81.
varun updated the diff for D13895: [shared] bump opaque-ke to 2.1.0-pre.1.
get argon2 0.5 from root Cargo.toml
varun updated the summary of D13895: [shared] bump opaque-ke to 2.1.0-pre.1.
varun updated the summary of D13895: [shared] bump opaque-ke to 2.1.0-pre.1.
realize there's Rust code so @ashoat isn't a good reviewer
varun updated the test plan for D13895: [shared] bump opaque-ke to 2.1.0-pre.1.
varun requested review of D13895: [shared] bump opaque-ke to 2.1.0-pre.1.
Nov 5 2024
Nov 5 2024
We normally wait a day before promoting a version from staging to prod
varun added a comment to D13883: [services] Remove requirement to specify port for identity service config.
Removed my suggestion, your solution is good
do you need the www origin?
varun requested changes to D13847: [native] update Secondary Device Auth flow to support SIWE users.
left a question inline
Nov 4 2024
Nov 4 2024
Nov 1 2024
Nov 1 2024
varun requested changes to D13808: [backup-service][backup-client] rename `username` -> `user_identifier`.
varun added inline comments to D13805: [commtest] use registered `UserIdentity` in backup tests.
varun attached a referenced file: F3122660: Simulator Screen Recording - iPhone 16 Pro Max - 2024-11-01 at 13.49.33.mp4.
varun updated the test plan for D13493: [native] scaffolding for CommunityJoinerModal.
Oct 31 2024
Oct 31 2024
varun updated the diff for D13493: [native] scaffolding for CommunityJoinerModal.
small fixes
varun added inline comments to D13493: [native] scaffolding for CommunityJoinerModal.
varun added a comment to D13493: [native] scaffolding for CommunityJoinerModal.
fixing the avatars here is tracked in https://linear.app/comm/issue/ENG-9834/get-farcaster-thread-avatars-to-render-correctly-in-new-modals
varun attached a referenced file: F3117719: Simulator Screenshot - iPhone 16 Pro Max - 2024-11-01 at 02.15.52.png.
varun added a comment to D13493: [native] scaffolding for CommunityJoinerModal.
varun added a reviewer for D13853: [keyserver] add know_of permission if viewer.isScriptViewer: ashoat.
varun planned changes to D13854: [keyserver] return threadInfo in fetchAllCommunityInfosWithNames.