Page MenuHomePhabricator

varun (Varun Dhananjaya)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 30 2021, 11:14 AM (68 w, 4 d)

Recent Activity

Fri, Mar 24

varun added 1 blocking reviewer(s) for D7113: [native] RustPromiseManager: ashoat.
Fri, Mar 24, 3:29 PM
varun requested review of D7113: [native] RustPromiseManager.

sorry, requesting review again because i decided to just add the thread safety changes to this diff....

Fri, Mar 24, 3:29 PM
varun updated the diff for D7113: [native] RustPromiseManager.

return early when we can

Fri, Mar 24, 3:29 PM
varun planned changes to D7113: [native] RustPromiseManager.

sorry addressing feedback now

Fri, Mar 24, 3:22 PM
varun updated the diff for D7113: [native] RustPromiseManager.

make promises map thread-safe

Fri, Mar 24, 3:19 PM
varun added a comment to D7114: [native][draft] Calling Rust get_42() function from JS async.

i also missed jon's feedback from earlier so i'll address those comments now

Fri, Mar 24, 2:04 PM
varun planned changes to D7114: [native][draft] Calling Rust get_42() function from JS async.

yeah fair i should just split this out into two diffs

Fri, Mar 24, 2:02 PM
varun updated the diff for D7113: [native] RustPromiseManager.

address last piece of feedback

Fri, Mar 24, 2:00 PM
varun planned changes to D7113: [native] RustPromiseManager.
Fri, Mar 24, 1:45 PM
varun updated the diff for D7113: [native] RustPromiseManager.

remove unnecessary include

Fri, Mar 24, 1:44 PM
varun updated the diff for D7113: [native] RustPromiseManager.

address feedback

Fri, Mar 24, 1:43 PM
varun requested review of D7114: [native][draft] Calling Rust get_42() function from JS async.
Fri, Mar 24, 1:37 PM
varun accepted D7172: [cargo] Add `--release` flag to native library/tunnelbroker builds.
Fri, Mar 24, 12:15 PM

Wed, Mar 22

varun added inline comments to D7115: [Identity] Update X3DH protobuf to differiente key requests.
Wed, Mar 22, 7:15 PM
varun accepted D7116: [Comm-opaque2] Change project name to avoid name clash.
Wed, Mar 22, 7:13 PM
varun accepted D7149: [web] Add grpc-web@1.4.2.
Wed, Mar 22, 6:26 PM
varun accepted D7130: [Identity] Add client device service to identity service.

nice! just one nit

Wed, Mar 22, 1:58 PM
varun accepted D7115: [Identity] Update X3DH protobuf to differiente key requests.

just a couple nits

Wed, Mar 22, 1:54 PM

Mon, Mar 20

varun added inline comments to D7113: [native] RustPromiseManager.
Mon, Mar 20, 9:58 PM
varun requested review of D7113: [native] RustPromiseManager.
Mon, Mar 20, 9:20 PM
varun accepted D7087: [Comm-opaque2] Add wasm build to client.
Mon, Mar 20, 1:15 PM
varun requested changes to D7087: [Comm-opaque2] Add wasm build to client.
Mon, Mar 20, 7:33 AM

Thu, Mar 16

varun accepted D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

just one nit inline

Thu, Mar 16, 5:23 PM
varun added inline comments to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Thu, Mar 16, 1:42 PM
varun requested changes to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Thu, Mar 16, 12:41 PM

Wed, Mar 15

varun requested changes to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Wed, Mar 15, 12:29 PM
varun added a comment to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.

i'm a little confused why we're moving config.rs and constants.rs into this cargo project. they seem pretty specific to the identity service. if we decide we want to store the secret key in a different location, it feels awkward that we'd have to modify a library that the identity service consumes rather than the service's own config

Wed, Mar 15, 12:29 PM

Tue, Mar 14

varun accepted D7052: [direnv] Redirect `use flake` to `/dev/null` if `COMM_NIX_LOGGING_LEVEL` is "none".

jon’s suggestion makes sense to me

Tue, Mar 14, 10:07 AM

Mon, Mar 13

varun added inline comments to D7053: [lib] introduce getAvatarForUser in avatar-utils.
Mon, Mar 13, 3:26 PM
varun accepted D7003: [Identity] Add client <-> identity protobuf defintions.

yeah let's de-dupe and remove deviceEd25519PublicKey. one other nit inline

Mon, Mar 13, 3:13 PM

Fri, Mar 10

varun added inline comments to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Fri, Mar 10, 12:21 PM
varun added a comment to D7020: [comm-opaque] Add dependencies for client and server logic.

i frankly don't think this adds much clutter at all... also it's more tedious for me to switch between diffs to see how these dependencies are being used. just looking at this diff, i have no idea what any of these dependencies are for besides the one that @jon annotated, and even then i still have to look at another diff to see what handle_pake_to_grpc_err looks like. the lack of context in this diff makes it difficult to determine if a given dependency is appropriate or propose an alternative.

Fri, Mar 10, 11:35 AM
varun requested changes to D7022: [comm-opaque] Create opaque 2.0 facade for usage in Comm.
Fri, Mar 10, 12:04 AM

Thu, Mar 9

varun accepted D7020: [comm-opaque] Add dependencies for client and server logic.

i don't love adding the dependencies in a separate diff, would like to see them added when they're actually being used

Thu, Mar 9, 11:38 PM
varun requested changes to D7003: [Identity] Add client <-> identity protobuf defintions.
Thu, Mar 9, 11:35 PM
varun accepted D7028: [Identity] Change default port to 50054 to avoid port collision.
Thu, Mar 9, 10:59 PM
varun added inline comments to D7021: [keyserver] Use `build:debug` instead of `build` in `postinstall`.
Thu, Mar 9, 10:30 AM
varun accepted D7021: [keyserver] Use `build:debug` instead of `build` in `postinstall`.
Thu, Mar 9, 10:18 AM

Wed, Mar 8

varun added a comment to D7001: [Identity] Rename IdentityService service to IdentityKeyserverService.

the set of RPCs that devices will call is different than the set that ashoat's keyserver can call today. also, the actual messages are slightly different, as the linear issue i linked explains. we think it makes more sense to just have a separate service for devices, rather than introduce a bunch of conditional logic in the current service

Wed, Mar 8, 3:40 PM
varun added a comment to D7001: [Identity] Rename IdentityService service to IdentityKeyserverService.

I'm more confused as to why are we're separating the protos / services out at all

Wed, Mar 8, 3:32 PM
varun added a comment to D7003: [Identity] Add client <-> identity protobuf defintions.

how about identity.general? identity.client feels weird

Wed, Mar 8, 2:00 PM
varun accepted D7001: [Identity] Rename IdentityService service to IdentityKeyserverService.
Wed, Mar 8, 12:30 PM

Tue, Mar 7

varun accepted D7000: [keyserver] Don't invalidate cookies for identity DDB population if codeVersion doesn't provide necessary info.
Tue, Mar 7, 3:14 PM
varun closed D6998: [keyserver] update compare-user.js to get missing users by querying identity service.
Tue, Mar 7, 2:34 PM
varun committed rCOMM6ef0f2342a85: [keyserver] update compare-user.js to get missing users by querying identity… (authored by varun).
[keyserver] update compare-user.js to get missing users by querying identity…
Tue, Mar 7, 2:34 PM
varun closed D6997: [keyserver] add new compareUsers function to rust-node-addon.
Tue, Mar 7, 2:32 PM
varun committed rCOMMfc69c7467481: [keyserver] add new compareUsers function to rust-node-addon (authored by varun).
[keyserver] add new compareUsers function to rust-node-addon
Tue, Mar 7, 2:32 PM
varun added a comment to D6982: [lib] Add deviceTypes constant for enumerating all valid mobile device types.

oh nvm, i’ll delete my comment

Tue, Mar 7, 10:58 AM
varun accepted D6984: [keyserver] Non-identity parts for comparing users.
Tue, Mar 7, 10:30 AM
varun updated the diff for D6998: [keyserver] update compare-user.js to get missing users by querying identity service.

remove "// eslint-disable-next-line no-unused-vars"

Tue, Mar 7, 10:29 AM
varun accepted D6983: [keyserver] Introduce fetchNativeCookieIDsForUserIDs.
Tue, Mar 7, 10:27 AM
varun added a comment to D6982: [lib] Add deviceTypes constant for enumerating all valid mobile device types.
Tue, Mar 7, 10:25 AM
varun accepted D6982: [lib] Add deviceTypes constant for enumerating all valid mobile device types.
Tue, Mar 7, 10:22 AM
varun published D6997: [keyserver] add new compareUsers function to rust-node-addon for review.
Tue, Mar 7, 10:19 AM
varun published D6998: [keyserver] update compare-user.js to get missing users by querying identity service for review.
Tue, Mar 7, 10:18 AM
varun closed D6960: [keyserver] try registerUser if loginUser fails in keyserver logInResponder.
Tue, Mar 7, 8:10 AM
varun committed rCOMM030104821306: [keyserver] try registerUser if loginUser fails in keyserver logInResponder (authored by varun).
[keyserver] try registerUser if loginUser fails in keyserver logInResponder
Tue, Mar 7, 8:10 AM
varun added a comment to D6960: [keyserver] try registerUser if loginUser fails in keyserver logInResponder.

https://linear.app/comm/issue/ENG-3253/improve-handling-of-rust-node-addon-errors

Tue, Mar 7, 8:10 AM

Mon, Mar 6

varun requested review of D6960: [keyserver] try registerUser if loginUser fails in keyserver logInResponder.
Mon, Mar 6, 10:54 PM

Sat, Mar 4

varun closed D6955: [keyserver] change how we load config for the identity service client.
Sat, Mar 4, 7:04 PM
varun committed rCOMM562ef92502c2: [keyserver] change how we load config for the identity service client (authored by varun).
[keyserver] change how we load config for the identity service client
Sat, Mar 4, 7:04 PM

Fri, Mar 3

varun updated the diff for D6955: [keyserver] change how we load config for the identity service client.

map camelCase JSON to snake_case struct

Fri, Mar 3, 10:28 PM
varun requested review of D6955: [keyserver] change how we load config for the identity service client.
Fri, Mar 3, 9:51 PM
varun accepted D6954: [nit] Fix comment in `siweAuthResponder`.

stat-padding smh

Fri, Mar 3, 4:13 PM
varun added a comment to D6944: [Keyserver/identity] Call identity service update_user.

Please wait for CI before landing

Fri, Mar 3, 3:53 PM
varun accepted D6944: [Keyserver/identity] Call identity service update_user.
Fri, Mar 3, 3:53 PM
varun requested changes to D6944: [Keyserver/identity] Call identity service update_user.
Fri, Mar 3, 3:13 PM
varun abandoned D6254: [keyserver] call identity service register RPC on account creation.
Fri, Mar 3, 3:05 PM
varun accepted D6939: [Identity] Implment update_user endpoint on server.

please address the typos and import consolidation before landing, i'm fine with deferring the error logging/Status stuff and creating a linear task for it

Fri, Mar 3, 3:05 PM
varun requested changes to D6944: [Keyserver/identity] Call identity service update_user.

back to your queue to address feedback on previous revision

Fri, Mar 3, 2:49 PM
varun accepted D6953: [keyserver] Fetch getRustAPI inline with where it's used.

LGTM

Fri, Mar 3, 2:39 PM
varun requested changes to D6944: [Keyserver/identity] Call identity service update_user.
Fri, Mar 3, 2:32 PM
varun accepted D6925: [Identity] Refactor opaque_ke usage to dedicated file.

I'm good with backlogging my suggestions, just want to make sure we call them all out specifically in the linear task so we don't lose track of small things

Fri, Mar 3, 2:13 PM
varun accepted D6912: [Protos] Add UpdateUser definitions.

Let's capitalize Identity Service everywhere in the .proto file for consistency. otherwise looks good

Fri, Mar 3, 1:46 PM
varun closed D6946: [keyserver] double-write to identity service from siweAuthResponder callpoint.
Fri, Mar 3, 1:29 PM
varun closed D6945: [identity] db and siwe verification changes to handle login requests from keyserver.
Fri, Mar 3, 1:29 PM
varun committed rCOMM930a4c1916ae: [keyserver] double-write to identity service from siweAuthResponder callpoint (authored by varun).
[keyserver] double-write to identity service from siweAuthResponder callpoint
Fri, Mar 3, 1:29 PM
varun closed D6943: [keyserver] add loginUserWallet function.
Fri, Mar 3, 1:29 PM
varun committed rCOMMac51dc28a7fd: [identity] db and siwe verification changes to handle login requests from… (authored by varun).
[identity] db and siwe verification changes to handle login requests from…
Fri, Mar 3, 1:29 PM
varun committed rCOMM9df888d813d3: [keyserver] add loginUserWallet function (authored by varun).
[keyserver] add loginUserWallet function
Fri, Mar 3, 1:29 PM
varun updated the diff for D6946: [keyserver] double-write to identity service from siweAuthResponder callpoint.

address feedback

Fri, Mar 3, 1:28 PM
varun added inline comments to D6945: [identity] db and siwe verification changes to handle login requests from keyserver.
Fri, Mar 3, 12:53 PM
varun added a comment to D6943: [keyserver] add loginUserWallet function.

Why is socialProof separate from siweMessage + siweSignature? Is it for the same reason that we pull signingPublicKey from sessionInitializationInfo (convenience)?

Fri, Mar 3, 12:49 PM
varun closed D6941: [keyserver] call Identity service RegisterUser RPC from createAccount.
Fri, Mar 3, 12:29 PM
varun closed D6942: [identity] change siwe signature type.
Fri, Mar 3, 12:29 PM
varun committed rCOMM6b9f77e57a98: [identity] change siwe signature type (authored by varun).
[identity] change siwe signature type
Fri, Mar 3, 12:29 PM
varun committed rCOMM51cb23048180: [keyserver] call Identity service RegisterUser RPC from createAccount (authored by varun).
[keyserver] call Identity service RegisterUser RPC from createAccount
Fri, Mar 3, 12:29 PM
varun closed D6914: [keyserver] add loginUserPake function to rust-node-addon, call it from loginResponder in js.
Fri, Mar 3, 12:28 PM
varun committed rCOMMdd246f514a3d: [keyserver] add loginUserPake function to rust-node-addon, call it from… (authored by varun).
[keyserver] add loginUserPake function to rust-node-addon, call it from…
Fri, Mar 3, 12:28 PM
varun added inline comments to D6941: [keyserver] call Identity service RegisterUser RPC from createAccount.
Fri, Mar 3, 12:25 PM
varun updated the diff for D6943: [keyserver] add loginUserWallet function.

address feedback

Fri, Mar 3, 12:24 PM
varun updated the diff for D6941: [keyserver] call Identity service RegisterUser RPC from createAccount.

address feedback

Fri, Mar 3, 11:58 AM
varun added a comment to D6914: [keyserver] add loginUserPake function to rust-node-addon, call it from loginResponder in js.

Realizing my comment from last time probably doesn't make sense to Flow

Fri, Mar 3, 11:34 AM
varun updated the diff for D6914: [keyserver] add loginUserPake function to rust-node-addon, call it from loginResponder in js.

address feedback

Fri, Mar 3, 11:34 AM
varun requested review of D6946: [keyserver] double-write to identity service from siweAuthResponder callpoint.
Fri, Mar 3, 1:05 AM
varun requested review of D6945: [identity] db and siwe verification changes to handle login requests from keyserver.
Fri, Mar 3, 1:03 AM
varun closed D6940: [identity] some small fixes.
Fri, Mar 3, 12:53 AM
varun committed rCOMMc3174b1ed019: [identity] some small fixes (authored by varun).
[identity] some small fixes
Fri, Mar 3, 12:53 AM

Thu, Mar 2

varun requested review of D6943: [keyserver] add loginUserWallet function.
Thu, Mar 2, 9:12 PM
varun requested review of D6942: [identity] change siwe signature type.
Thu, Mar 2, 8:19 PM