User Details
- User Since
- Nov 30 2021, 11:14 AM (94 w, 4 d)
Yesterday
Thu, Sep 21
thank you! one comment inline
Wed, Sep 20
after they find a match
accepting with nit inline
Can we use any random string as an AES-256 key? Or are there some additional requirements?
Tue, Sep 19
I ended up adding a new setCommServicesAuthMetadata method because we will set user id, device id, and access token all at once initially, but subsequently may need to update just the access token.
also changed getCommServicesAccessToken to getCommServicesAuthMetadata since we will need to retrieve all three at once
address feedback
Mon, Sep 18
Thu, Sep 14
remove oneTimeKey and correct create_inbound_from args
address feedback
Wed, Sep 13
resolve ESLint/Flow/Jest issues
I found it confusing that we were using oneTimeKey instead of oneTimeKeys for arrays of keys so I changed that as well here
address feedback
rebase
Tue, Sep 12
address feedback (CommSecureStore changes will come later, but wanted to acknowledge the comment)
Mon, Sep 11
Fri, Sep 8
looks pretty good, but have some q's/suggestions
introduce new CryptoModule function to get signed prekey the correct way
Wed, Sep 6
should be using olm_account_prekey_signature()
Tue, Sep 5
Mon, Sep 4
Thu, Aug 31
actual code looks fine to me but i don't really understand the motivation for this work. i've left a question on ENG-4812; we can discuss there
i'll commandeer and fix up grammar later today
Wed, Aug 30
Tue, Aug 29
LGTM. I wonder if it's possible to simplify the type conversion logic with folly/dynamic
Mon, Aug 28
i left a suggestion and nit inline
LGTM. we should consider adding jitter, though
Aug 23 2023
mistakenly put this up without deduping.. fixing rn