Page MenuHomePhabricator

varun (Varun Dhananjaya)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 30 2021, 11:14 AM (94 w, 4 d)

Recent Activity

Yesterday

varun requested review of D9270: [native] update password client method and CommRustModule implementation.
Fri, Sep 22, 1:24 PM
varun requested review of D9269: [native] helper functions for resolving JS promises with void.
Fri, Sep 22, 1:23 PM
varun closed D9264: [keyserver] use correct key for device ID.
Fri, Sep 22, 8:21 AM
varun committed rCOMM2b0757b8e34b: [keyserver] use correct key for device ID (authored by varun).
[keyserver] use correct key for device ID
Fri, Sep 22, 8:21 AM
varun requested review of D9264: [keyserver] use correct key for device ID.
Fri, Sep 22, 12:18 AM

Thu, Sep 21

varun accepted D9223: [nix] add logs to console while waiting for MariaDB to come up.
Thu, Sep 21, 12:01 PM
varun accepted D9220: [keyserver] Encode the device id into the QR code.

thank you! one comment inline

Thu, Sep 21, 11:57 AM

Wed, Sep 20

varun accepted D9242: [services-lib] Use constant-time-eq for token verification.
Wed, Sep 20, 11:22 PM
varun added a comment to D9242: [services-lib] Use constant-time-eq for token verification.

after they find a match

Wed, Sep 20, 11:22 PM
varun requested changes to D9220: [keyserver] Encode the device id into the QR code.
Wed, Sep 20, 10:56 PM
varun accepted D9202: [keyserver/web/native] Covert AES-256 key from Uint8Array representation to hex string representation.

accepting with nit inline

Wed, Sep 20, 10:01 PM
varun accepted D9181: [keyserver] Generate an AES256 key (ephemeral) to encode.

Can we use any random string as an AES-256 key? Or are there some additional requirements?

Wed, Sep 20, 9:48 PM

Tue, Sep 19

varun requested review of D9236: [keyserver] Update keyserver delete account endpoint to not require password.
Tue, Sep 19, 9:23 PM
varun updated the test plan for D9224: [native] commCoreModule methods for getting, setting, and clearing the commServicesAccessToken.
Tue, Sep 19, 8:03 PM
varun added a comment to D9224: [native] commCoreModule methods for getting, setting, and clearing the commServicesAccessToken.

I ended up adding a new setCommServicesAuthMetadata method because we will set user id, device id, and access token all at once initially, but subsequently may need to update just the access token.
also changed getCommServicesAccessToken to getCommServicesAuthMetadata since we will need to retrieve all three at once

Tue, Sep 19, 7:59 PM
varun updated the diff for D9224: [native] commCoreModule methods for getting, setting, and clearing the commServicesAccessToken.

address feedback

Tue, Sep 19, 7:56 PM

Mon, Sep 18

varun requested review of D9224: [native] commCoreModule methods for getting, setting, and clearing the commServicesAccessToken.
Mon, Sep 18, 2:56 PM

Thu, Sep 14

varun closed D8407: [keyserver] accountOwnershipResponder.
Thu, Sep 14, 11:43 AM
varun committed rCOMM573418ac654a: [keyserver] accountOwnershipResponder (authored by varun).
[keyserver] accountOwnershipResponder
Thu, Sep 14, 11:43 AM
varun added a comment to D8929: [keyserver] modify createPickledOlmSession.

https://linear.app/comm/issue/ENG-4944/remove-create-inbound-call-from-createpickledolmsession

Thu, Sep 14, 11:33 AM
varun updated the diff for D8929: [keyserver] modify createPickledOlmSession.

remove oneTimeKey and correct create_inbound_from args

Thu, Sep 14, 11:32 AM
varun updated the diff for D8407: [keyserver] accountOwnershipResponder.

address feedback

Thu, Sep 14, 9:56 AM
varun closed D9129: [lib] utility function to get array of OneTimeKeys from an OLMOneTimeKeys object.
Thu, Sep 14, 9:26 AM
varun committed rCOMM5e71db19bf33: [lib] utility function to get array of OneTimeKeys from an OLMOneTimeKeys object (authored by varun).
[lib] utility function to get array of OneTimeKeys from an OLMOneTimeKeys object
Thu, Sep 14, 9:26 AM

Wed, Sep 13

varun updated the diff for D9129: [lib] utility function to get array of OneTimeKeys from an OLMOneTimeKeys object.

resolve ESLint/Flow/Jest issues

Wed, Sep 13, 12:00 PM
varun added a comment to D9129: [lib] utility function to get array of OneTimeKeys from an OLMOneTimeKeys object.

I found it confusing that we were using oneTimeKey instead of oneTimeKeys for arrays of keys so I changed that as well here

Wed, Sep 13, 11:42 AM
varun updated the diff for D9129: [lib] utility function to get array of OneTimeKeys from an OLMOneTimeKeys object.

address feedback

Wed, Sep 13, 11:41 AM
varun closed D9127: [native] rename fields in JSON serialized string to camelCase from snake_case.
Wed, Sep 13, 11:18 AM
varun committed rCOMMace6020e7439: [native] rename fields in JSON serialized string to camelCase from snake_case (authored by varun).
[native] rename fields in JSON serialized string to camelCase from snake_case
Wed, Sep 13, 11:18 AM
varun closed D9115: [lib] move a shared type to lib.
Wed, Sep 13, 11:18 AM
varun committed rCOMMc774123d9980: [lib] move a shared type to lib (authored by varun).
[lib] move a shared type to lib
Wed, Sep 13, 11:18 AM
varun added inline comments to D9115: [lib] move a shared type to lib.
Wed, Sep 13, 10:59 AM
varun closed D9114: [native] update action types and reducer for setting comm access token.
Wed, Sep 13, 10:09 AM
varun committed rCOMM00dd73623778: [native] update action types and reducer for setting comm access token (authored by varun).
[native] update action types and reducer for setting comm access token
Wed, Sep 13, 10:09 AM
varun updated the diff for D9114: [native] update action types and reducer for setting comm access token.

rebase

Wed, Sep 13, 10:06 AM

Tue, Sep 12

varun updated the test plan for D9114: [native] update action types and reducer for setting comm access token.
Tue, Sep 12, 9:04 PM
varun updated the diff for D9114: [native] update action types and reducer for setting comm access token.

address feedback (CommSecureStore changes will come later, but wanted to acknowledge the comment)

Tue, Sep 12, 8:59 PM
varun closed D9085: [native] getNotificationsOneTimeKeys.
Tue, Sep 12, 12:54 PM
varun closed D9113: [native] get notifications one time keys.
Tue, Sep 12, 12:54 PM
varun committed rCOMMf13fe4b8c615: [native] get notifications one time keys (authored by varun).
[native] get notifications one time keys
Tue, Sep 12, 12:54 PM
varun committed rCOMM0fbe980d5a9e: [native] getNotificationsOneTimeKeys (authored by varun).
[native] getNotificationsOneTimeKeys
Tue, Sep 12, 12:54 PM
varun closed D9083: [native] generateAndGetNotificationsPrekey.
Tue, Sep 12, 12:54 PM
varun closed D9084: [native] get signed prekeys.
Tue, Sep 12, 12:54 PM
varun committed rCOMM58a033c26d1b: [native] get signed prekeys (authored by varun).
[native] get signed prekeys
Tue, Sep 12, 12:54 PM
varun committed rCOMMf1cc65ed1a2e: [native] generateAndGetNotificationsPrekey (authored by varun).
[native] generateAndGetNotificationsPrekey
Tue, Sep 12, 12:54 PM
varun closed D9076: [native] expose prekey generation to js.
Tue, Sep 12, 12:54 PM
varun committed rCOMM6b237d1978ae: [native] expose prekey generation to js (authored by varun).
[native] expose prekey generation to js
Tue, Sep 12, 12:54 PM
varun closed D8820: [Keyserver/rust] Used shared identity client.
Tue, Sep 12, 12:45 PM
varun committed rCOMM269eddc91b6b: [Keyserver/rust] Used shared identity client (authored by jon).
[Keyserver/rust] Used shared identity client
Tue, Sep 12, 12:45 PM
varun accepted D9093: [lib/web/native] Generate and encode an ephemeral AES-256 key in the QR code.
Tue, Sep 12, 9:21 AM
varun updated the test plan for D8407: [keyserver] accountOwnershipResponder.
Tue, Sep 12, 9:09 AM
varun added a reviewer for D8407: [keyserver] accountOwnershipResponder: ashoat.
Tue, Sep 12, 9:08 AM
varun published D8407: [keyserver] accountOwnershipResponder for review.
Tue, Sep 12, 9:08 AM

Mon, Sep 11

varun requested review of D9129: [lib] utility function to get array of OneTimeKeys from an OLMOneTimeKeys object.
Mon, Sep 11, 10:56 AM
varun added inline comments to D9127: [native] rename fields in JSON serialized string to camelCase from snake_case.
Mon, Sep 11, 10:33 AM
varun commandeered D8820: [Keyserver/rust] Used shared identity client.
Mon, Sep 11, 8:33 AM
varun requested review of D9127: [native] rename fields in JSON serialized string to camelCase from snake_case.
Mon, Sep 11, 8:00 AM
varun accepted D9125: [keyserver] fix fetching identity info.
Mon, Sep 11, 7:15 AM

Fri, Sep 8

varun published D9115: [lib] move a shared type to lib for review.
Fri, Sep 8, 12:59 PM
varun published D9114: [native] update action types and reducer for setting comm access token for review.
Fri, Sep 8, 12:58 PM
varun requested changes to D9093: [lib/web/native] Generate and encode an ephemeral AES-256 key in the QR code.

looks pretty good, but have some q's/suggestions

Fri, Sep 8, 10:19 AM
varun requested review of D9113: [native] get notifications one time keys.
Fri, Sep 8, 9:51 AM
varun added inline comments to D9076: [native] expose prekey generation to js.
Fri, Sep 8, 8:52 AM
varun updated the diff for D9084: [native] get signed prekeys.

introduce new CryptoModule function to get signed prekey the correct way

Fri, Sep 8, 8:50 AM
varun accepted D9106: [keyserver] add missing `napi` annotation.
Fri, Sep 8, 5:06 AM

Wed, Sep 6

varun planned changes to D9084: [native] get signed prekeys.

should be using olm_account_prekey_signature()

Wed, Sep 6, 9:57 PM

Tue, Sep 5

varun accepted D9038: [terraform] Set up ECS Service Connect.

LGTM

Tue, Sep 5, 11:07 AM
varun requested review of D9085: [native] getNotificationsOneTimeKeys.
Tue, Sep 5, 7:50 AM
varun requested review of D9084: [native] get signed prekeys.
Tue, Sep 5, 7:21 AM
varun requested review of D9083: [native] generateAndGetNotificationsPrekey.
Tue, Sep 5, 6:24 AM

Mon, Sep 4

varun requested review of D9076: [native] expose prekey generation to js.
Mon, Sep 4, 10:36 PM

Thu, Aug 31

varun accepted D9034: [services-lib] Introduce crypto module.

actual code looks fine to me but i don't really understand the motivation for this work. i've left a question on ENG-4812; we can discuss there

Thu, Aug 31, 5:49 PM
varun closed D9032: [identity] some clean up.
Thu, Aug 31, 10:03 AM
varun committed rCOMMffbaa6982715: [identity] some clean up (authored by varun).
[identity] some clean up
Thu, Aug 31, 10:03 AM
varun added a comment to D9033: [Tunnelbroker] Add readme.

i'll commandeer and fix up grammar later today

Thu, Aug 31, 10:02 AM

Wed, Aug 30

varun requested review of D9032: [identity] some clean up.
Wed, Aug 30, 12:11 PM
varun closed D8930: [rust-node-addon] add client method to call getInboundKeysForUser.
Wed, Aug 30, 12:04 PM
varun committed rCOMMb82d22a09a85: [rust-node-addon] add client method to call getInboundKeysForUser (authored by varun).
[rust-node-addon] add client method to call getInboundKeysForUser
Wed, Aug 30, 12:04 PM
varun added inline comments to D8930: [rust-node-addon] add client method to call getInboundKeysForUser.
Wed, Aug 30, 12:04 PM
varun closed D8863: [identity] getInboundKeysForUser RPC implementation.
Wed, Aug 30, 11:38 AM
varun closed D8765: [identity] more helpers for identity service.
Wed, Aug 30, 11:38 AM
varun committed rCOMMa4954c15ddff: [identity] getInboundKeysForUser RPC implementation (authored by varun).
[identity] getInboundKeysForUser RPC implementation
Wed, Aug 30, 11:38 AM
varun committed rCOMMe1591be9eb39: [identity] more helpers for identity service (authored by varun).
[identity] more helpers for identity service
Wed, Aug 30, 11:38 AM
varun closed D8761: [identity] db method to get inbound keys for user.
Wed, Aug 30, 11:38 AM
varun committed rCOMMa91792c497ce: [identity] db method to get inbound keys for user (authored by varun).
[identity] db method to get inbound keys for user
Wed, Aug 30, 11:38 AM
varun added inline comments to D8863: [identity] getInboundKeysForUser RPC implementation.
Wed, Aug 30, 11:38 AM
varun added inline comments to D8765: [identity] more helpers for identity service.
Wed, Aug 30, 11:15 AM
varun added inline comments to D8761: [identity] db method to get inbound keys for user.
Wed, Aug 30, 11:05 AM

Tue, Aug 29

varun added a comment to D8975: [reports-service] Implement Blob storage.

Adding @tomek because of new dependency while @ashoat is unavailable

But also sha2, seems much more popular than sha256. We use in commtest already

Tue, Aug 29, 11:53 AM
varun accepted D8960: [terraform][blob] Remove gRPC service.
Tue, Aug 29, 9:54 AM
varun accepted D8886: [client-backup] implement C++ function for computing `BackupKey`.

LGTM. I wonder if it's possible to simplify the type conversion logic with folly/dynamic

Tue, Aug 29, 9:54 AM

Mon, Aug 28

varun accepted D8895: [services-lib] Add BatchWriteItem utility function.

i left a suggestion and nit inline

Mon, Aug 28, 10:48 AM
varun accepted D8894: [services-lib] Add DDB batch operation helpers.

LGTM. we should consider adding jitter, though

Mon, Aug 28, 10:09 AM

Aug 23 2023

varun planned changes to D8933: [keyserver] new account creator for users already registered with identity service.

mistakenly put this up without deduping.. fixing rn

Aug 23 2023, 2:31 PM
varun requested review of D8933: [keyserver] new account creator for users already registered with identity service.
Aug 23 2023, 10:19 AM
varun requested review of D8930: [rust-node-addon] add client method to call getInboundKeysForUser.
Aug 23 2023, 8:57 AM
varun closed D8735: [keyserver] dedup username db queries.
Aug 23 2023, 8:41 AM
varun committed rCOMM4d3425cfeeaf: [keyserver] dedup username db queries (authored by varun).
[keyserver] dedup username db queries
Aug 23 2023, 8:41 AM
varun requested review of D8929: [keyserver] modify createPickledOlmSession.
Aug 23 2023, 8:36 AM

Aug 22 2023

varun requested review of D8735: [keyserver] dedup username db queries.
Aug 22 2023, 12:46 PM