User Details
User Details
- User Since
- Nov 30 2021, 11:14 AM (121 w, 1 d)
Yesterday
Yesterday
varun requested review of D11431: [native] add unlinkFarcasterAccount to CommRustModule.
varun requested review of D11430: [native_rust_library] unlink_farcaster_account method.
varun added a comment to D11412: [identity] check if fid is already taken when registering new user.
varun requested review of D11423: [identity] unlink farcaster account RPC.
varun added inline comments to D11398: [native] expose farcaster id param to native identity service context provider.
varun updated the test plan for D11401: [identity] db method to get users for a set of farcaster ids.
varun updated the diff for D11402: [identity] get farcaster users rpc implementation.
rebase, but nothing changed
varun updated the diff for D11398: [native] expose farcaster id param to native identity service context provider.
remove TODOs. Here's the linear task, instead: https://linear.app/comm/issue/ENG-7588/replace-params-in-native-rust-library-methods-with-serialized-structs
varun added inline comments to D11401: [identity] db method to get users for a set of farcaster ids.
varun requested review of D11412: [identity] check if fid is already taken when registering new user.
varun updated the diff for D11398: [native] expose farcaster id param to native identity service context provider.
squash with D11397
varun requested review of D11411: [identity] don't let linkFarcasterAccount overwrite existing fid for user.
varun requested review of D11410: [web] add client methods to web.
varun requested review of D11409: [native] add linkFarcasterAccount to native IdentityServiceContextProvider.
varun requested review of D11408: [native] add linkFarcasterAccount to commRustModule.
varun requested review of D11407: [native_rust_library] implement link_farcaster_account client method.
varun requested review of D11406: [identity] link farcaster account implementation.
varun requested review of D11405: [lib][native] Add getFarcasterUsers to IdentityServiceContextProvider.
varun requested review of D11404: [native] add getFarcasterUsers to commRustModule.
varun requested review of D11403: [native_rust_library] get_farcaster_users client method.
varun requested review of D11402: [identity] get farcaster users rpc implementation.
varun requested review of D11401: [identity] db method to get users for a set of farcaster ids.
varun requested review of D11400: [terraform] add GSI for farcasterID.
varun requested review of D11399: [identity][proto] add GetFarcasterUsers and LinkFarcasterAccount rpcs.
varun requested review of D11396: [proto][identity] add optional fid to registration request messages.
varun added inline comments to D11393: [lib] Add preRequestUserState to identity login.
varun requested changes to D11393: [lib] Add preRequestUserState to identity login.
varun requested changes to D11379: [protos][identity] Add RPC to find username by user ID.
what happens if the user doesn't exist? it seems like we'd want to return a "not found" tonic status in this case, but i'm not sure that's what we're doing here
Mon, Mar 25
Mon, Mar 25
varun committed rCOMMdfeeffe61ae5: [native] don't generate or send one time keys on login (authored by varun).
[native] don't generate or send one time keys on login
varun committed rCOMMb95b1f3a65f5: [web] don't generate or send one time keys on login (authored by varun).
[web] don't generate or send one time keys on login
varun committed rCOMM40d04cc63042: [web] factor out common code in authNewDeviceKeyUpload (authored by varun).
[web] factor out common code in authNewDeviceKeyUpload
varun committed rCOMM6121c2e62621: [lib][web] deviceKeyUpload -> newDeviceKeyUpload (authored by varun).
[lib][web] deviceKeyUpload -> newDeviceKeyUpload
varun committed rCOMMd2f01b572f83: [keyserver][lib] don't generate one time keys on identity login (authored by varun).
[keyserver][lib] don't generate one time keys on identity login
varun added inline comments to D11360: [keyserver][lib] don't generate one time keys on identity login.
varun added inline comments to D11360: [keyserver][lib] don't generate one time keys on identity login.
varun added inline comments to D11363: [web] don't generate or send one time keys on login.
Fri, Mar 22
Fri, Mar 22
[terraform] use farcaster image on staging
Thu, Mar 21
Thu, Mar 21
varun requested review of D11371: [terraform] use farcaster image on staging.
varun updated the diff for D11363: [web] don't generate or send one time keys on login.
dedup
Wed, Mar 20
Wed, Mar 20
varun committed rCOMM528670e7c977: [native] improve error handling in parseOLMPrekeys (authored by varun).
[native] improve error handling in parseOLMPrekeys
varun committed rCOMM05d0a3892342: [native][lib][web] update IdentityServiceClient implementations and useLogOut… (authored by varun).
[native][lib][web] update IdentityServiceClient implementations and useLogOut…
varun added a comment to D11335: [native][lib][web] update IdentityServiceClient implementations and useLogOut in user-actions.js.
Tue, Mar 19
Tue, Mar 19
varun requested review of D11364: [native] don't generate or send one time keys on login.
varun planned changes to D11363: [web] don't generate or send one time keys on login.
need to dedup a little
varun published D11363: [web] don't generate or send one time keys on login for review.
varun requested review of D11362: [web] factor out common code in authNewDeviceKeyUpload.
varun requested review of D11361: [lib][web] deviceKeyUpload -> newDeviceKeyUpload.
varun requested review of D11360: [keyserver][lib] don't generate one time keys on identity login.
varun requested review of D11356: [native] improve error handling in parseOLMPrekeys.
Mon, Mar 18
Mon, Mar 18
[native] add logOut to CommRustModule
varun committed rCOMM8251ee8e892a: [native] update userAlreadyExists in ConnectEthereum component (authored by varun).
[native] update userAlreadyExists in ConnectEthereum component
varun committed rCOMMe76b8a89a463: [native] use findUserID RPC in UsernameSelection component (authored by varun).
[native] use findUserID RPC in UsernameSelection component
varun committed rCOMM0390a90e6730: [crypto] make sure short format of prekey is expected when creating an outbound… (authored by varun).
[crypto] make sure short format of prekey is expected when creating an outbound…
[native] use short form for prekeys
varun added inline comments to D11312: [native] use short form for prekeys.
varun updated the diff for D11335: [native][lib][web] update IdentityServiceClient implementations and useLogOut in user-actions.js.
address feedback on previous revision
varun updated the diff for D11335: [native][lib][web] update IdentityServiceClient implementations and useLogOut in user-actions.js.
after rebasing i started getting a flow error. updated web/grpc/identity-service-client-proxy.js to resolve it, but not really sure what this code does... going to add @michal as a reviewer
[terraform] use identity 0.12 on prod
Sat, Mar 16
Sat, Mar 16
varun added inline comments to D11320: [native] use findUserID RPC in UsernameSelection component.
Fri, Mar 15
Fri, Mar 15
setting @ashoat as blocking
varun updated the diff for D11334: [native] add logOut to CommRustModule.
rebase
varun updated the diff for D11334: [native] add logOut to CommRustModule.
rebase on top of prekey format diffs
Thu, Mar 14
Thu, Mar 14
varun requested review of D11334: [native] add logOut to CommRustModule.
varun committed rCOMMf3c665ffa54b: [identity] Update invalid username check on Identity service (authored by varun).
[identity] Update invalid username check on Identity service
varun requested review of D11329: [identity] Update invalid username check on Identity service.
Wed, Mar 13
Wed, Mar 13
varun requested review of D11321: [native] update userAlreadyExists in ConnectEthereum component.
varun requested review of D11320: [native] use findUserID RPC in UsernameSelection component.
varun requested review of D11305: [terraform] use identity 0.12 on prod.
varun added a comment to D11305: [terraform] use identity 0.12 on prod.
- What's "retagging" mean and why was it necessary here?
Tue, Mar 12
Tue, Mar 12
[keyserver] make force login configurable