Page MenuHomePhabricator

varun (Varun Dhananjaya)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 30 2021, 11:14 AM (121 w, 1 d)

Recent Activity

Yesterday

varun requested review of D11433: [lib][web][native] add unlinkFarcasterAccount to IdentityServiceClient interface and implementations.
Wed, Mar 27, 9:51 PM
varun requested review of D11431: [native] add unlinkFarcasterAccount to CommRustModule.
Wed, Mar 27, 9:38 PM
varun requested review of D11430: [native_rust_library] unlink_farcaster_account method.
Wed, Mar 27, 9:36 PM
varun added a comment to D11412: [identity] check if fid is already taken when registering new user.

@varun looking at the test plan here, is it fair to say you weren't able to reproduce ENG-7390? Is it worth trying to test via the UI to see if that reproduces it?

Wed, Mar 27, 8:12 PM
varun added a comment to D11410: [web] add client methods to web.

Do we need to update anything for registerPasswordUser or registerWalletUser on web?

Wed, Mar 27, 7:15 PM
varun requested review of D11423: [identity] unlink farcaster account RPC.
Wed, Mar 27, 5:06 PM
varun added inline comments to D11398: [native] expose farcaster id param to native identity service context provider.
Wed, Mar 27, 3:22 PM
varun updated the test plan for D11401: [identity] db method to get users for a set of farcaster ids.
Wed, Mar 27, 1:59 PM
varun updated the diff for D11402: [identity] get farcaster users rpc implementation.

rebase, but nothing changed

Wed, Mar 27, 1:58 PM
varun updated the diff for D11398: [native] expose farcaster id param to native identity service context provider.

remove TODOs. Here's the linear task, instead: https://linear.app/comm/issue/ENG-7588/replace-params-in-native-rust-library-methods-with-serialized-structs

Wed, Mar 27, 1:56 PM
varun requested review of D11413: [identity] on linkFarcasterUser we should return an error if the FID already exists for a different user in the users table.
Wed, Mar 27, 1:52 PM
varun added inline comments to D11401: [identity] db method to get users for a set of farcaster ids.
Wed, Mar 27, 1:50 PM
varun requested review of D11412: [identity] check if fid is already taken when registering new user.
Wed, Mar 27, 1:49 PM
varun updated the diff for D11398: [native] expose farcaster id param to native identity service context provider.

squash with D11397

Wed, Mar 27, 1:44 PM
varun requested review of D11411: [identity] don't let linkFarcasterAccount overwrite existing fid for user.
Wed, Mar 27, 1:40 PM
varun requested review of D11410: [web] add client methods to web.
Wed, Mar 27, 1:36 PM
varun requested review of D11409: [native] add linkFarcasterAccount to native IdentityServiceContextProvider.
Wed, Mar 27, 1:32 PM
varun requested review of D11408: [native] add linkFarcasterAccount to commRustModule.
Wed, Mar 27, 1:27 PM
varun requested review of D11407: [native_rust_library] implement link_farcaster_account client method.
Wed, Mar 27, 1:25 PM
varun requested review of D11406: [identity] link farcaster account implementation.
Wed, Mar 27, 1:23 PM
varun requested review of D11405: [lib][native] Add getFarcasterUsers to IdentityServiceContextProvider.
Wed, Mar 27, 1:21 PM
varun requested review of D11404: [native] add getFarcasterUsers to commRustModule.
Wed, Mar 27, 1:10 PM
varun requested review of D11403: [native_rust_library] get_farcaster_users client method.
Wed, Mar 27, 1:05 PM
varun requested review of D11402: [identity] get farcaster users rpc implementation.
Wed, Mar 27, 1:01 PM
varun requested review of D11401: [identity] db method to get users for a set of farcaster ids.
Wed, Mar 27, 12:57 PM
varun requested review of D11400: [terraform] add GSI for farcasterID.
Wed, Mar 27, 12:54 PM
varun requested review of D11399: [identity][proto] add GetFarcasterUsers and LinkFarcasterAccount rpcs.
Wed, Mar 27, 12:51 PM
varun requested review of D11398: [native] expose farcaster id param to native identity service context provider.
Wed, Mar 27, 12:46 PM
varun requested review of D11396: [proto][identity] add optional fid to registration request messages.
Wed, Mar 27, 12:42 PM
varun added inline comments to D11393: [lib] Add preRequestUserState to identity login.
Wed, Mar 27, 9:05 AM
varun requested changes to D11393: [lib] Add preRequestUserState to identity login.
Wed, Mar 27, 9:00 AM
varun requested changes to D11379: [protos][identity] Add RPC to find username by user ID.
Wed, Mar 27, 8:28 AM
varun accepted D11379: [protos][identity] Add RPC to find username by user ID.

what happens if the user doesn't exist? it seems like we'd want to return a "not found" tonic status in this case, but i'm not sure that's what we're doing here

Wed, Mar 27, 8:28 AM

Mon, Mar 25

varun closed D11364: [native] don't generate or send one time keys on login.
Mon, Mar 25, 12:52 PM
varun committed rCOMMdfeeffe61ae5: [native] don't generate or send one time keys on login (authored by varun).
[native] don't generate or send one time keys on login
Mon, Mar 25, 12:52 PM
varun closed D11363: [web] don't generate or send one time keys on login.
Mon, Mar 25, 12:52 PM
varun committed rCOMMb95b1f3a65f5: [web] don't generate or send one time keys on login (authored by varun).
[web] don't generate or send one time keys on login
Mon, Mar 25, 12:52 PM
varun closed D11362: [web] factor out common code in authNewDeviceKeyUpload.
Mon, Mar 25, 12:52 PM
varun closed D11361: [lib][web] deviceKeyUpload -> newDeviceKeyUpload.
Mon, Mar 25, 12:52 PM
varun committed rCOMM40d04cc63042: [web] factor out common code in authNewDeviceKeyUpload (authored by varun).
[web] factor out common code in authNewDeviceKeyUpload
Mon, Mar 25, 12:52 PM
varun committed rCOMM6121c2e62621: [lib][web] deviceKeyUpload -> newDeviceKeyUpload (authored by varun).
[lib][web] deviceKeyUpload -> newDeviceKeyUpload
Mon, Mar 25, 12:52 PM
varun closed D11360: [keyserver][lib] don't generate one time keys on identity login.
Mon, Mar 25, 12:52 PM
varun committed rCOMMd2f01b572f83: [keyserver][lib] don't generate one time keys on identity login (authored by varun).
[keyserver][lib] don't generate one time keys on identity login
Mon, Mar 25, 12:52 PM
varun added inline comments to D11360: [keyserver][lib] don't generate one time keys on identity login.
Mon, Mar 25, 12:29 PM
varun added inline comments to D11360: [keyserver][lib] don't generate one time keys on identity login.
Mon, Mar 25, 12:25 PM
varun added inline comments to D11363: [web] don't generate or send one time keys on login.
Mon, Mar 25, 12:22 PM

Fri, Mar 22

varun closed D11371: [terraform] use farcaster image on staging.
Fri, Mar 22, 12:02 PM
varun committed rCOMM2f2c103a8228: [terraform] use farcaster image on staging (authored by varun).
[terraform] use farcaster image on staging
Fri, Mar 22, 12:02 PM

Thu, Mar 21

varun requested review of D11371: [terraform] use farcaster image on staging.
Thu, Mar 21, 6:47 PM
varun added a reviewer for D11363: [web] don't generate or send one time keys on login: michal.
Thu, Mar 21, 9:06 AM
varun updated the diff for D11363: [web] don't generate or send one time keys on login.

dedup

Thu, Mar 21, 9:06 AM

Wed, Mar 20

varun closed D11356: [native] improve error handling in parseOLMPrekeys.
Wed, Mar 20, 2:33 PM
varun committed rCOMM528670e7c977: [native] improve error handling in parseOLMPrekeys (authored by varun).
[native] improve error handling in parseOLMPrekeys
Wed, Mar 20, 2:33 PM
varun closed D11335: [native][lib][web] update IdentityServiceClient implementations and useLogOut in user-actions.js.
Wed, Mar 20, 2:33 PM
varun committed rCOMM05d0a3892342: [native][lib][web] update IdentityServiceClient implementations and useLogOut… (authored by varun).
[native][lib][web] update IdentityServiceClient implementations and useLogOut…
Wed, Mar 20, 2:33 PM
varun added a comment to D11335: [native][lib][web] update IdentityServiceClient implementations and useLogOut in user-actions.js.

Looks good on the identity-service-client-proxy part.

Short explanation is -> we are moving the identity client to worker so that multiple tabs can synchronize the identity calls between them and not conflict. identity-service-client-wrapper.js will run on web worker and identity-service-client-proxy.js will run in the tab JS context and pass the method calls to the worker (we didn't "flip the switch" yet so for now the identity-service-client-wrapper.js is still running in the tab JS context though).

Wed, Mar 20, 2:31 PM
varun added inline comments to D11335: [native][lib][web] update IdentityServiceClient implementations and useLogOut in user-actions.js.
Wed, Mar 20, 2:30 PM

Tue, Mar 19

varun requested review of D11364: [native] don't generate or send one time keys on login.
Tue, Mar 19, 6:44 PM
varun planned changes to D11363: [web] don't generate or send one time keys on login.

need to dedup a little

Tue, Mar 19, 6:40 PM
varun published D11363: [web] don't generate or send one time keys on login for review.
Tue, Mar 19, 6:39 PM
varun requested review of D11362: [web] factor out common code in authNewDeviceKeyUpload.
Tue, Mar 19, 6:38 PM
varun requested review of D11361: [lib][web] deviceKeyUpload -> newDeviceKeyUpload.
Tue, Mar 19, 6:37 PM
varun requested review of D11360: [keyserver][lib] don't generate one time keys on identity login.
Tue, Mar 19, 6:36 PM
varun added inline comments to D11335: [native][lib][web] update IdentityServiceClient implementations and useLogOut in user-actions.js.
Tue, Mar 19, 5:57 PM
varun requested review of D11356: [native] improve error handling in parseOLMPrekeys.
Tue, Mar 19, 12:08 PM
varun added inline comments to D11335: [native][lib][web] update IdentityServiceClient implementations and useLogOut in user-actions.js.
Tue, Mar 19, 8:26 AM

Mon, Mar 18

varun closed D11321: [native] update userAlreadyExists in ConnectEthereum component.
Mon, Mar 18, 10:32 PM
varun closed D11334: [native] add logOut to CommRustModule.
Mon, Mar 18, 10:32 PM
varun committed rCOMM428986bd7ab1: [native] add logOut to CommRustModule (authored by varun).
[native] add logOut to CommRustModule
Mon, Mar 18, 10:32 PM
varun committed rCOMM8251ee8e892a: [native] update userAlreadyExists in ConnectEthereum component (authored by varun).
[native] update userAlreadyExists in ConnectEthereum component
Mon, Mar 18, 10:32 PM
varun closed D11319: [crypto] make sure short format of prekey is expected when creating an outbound session.
Mon, Mar 18, 10:32 PM
varun closed D11320: [native] use findUserID RPC in UsernameSelection component.
Mon, Mar 18, 10:32 PM
varun committed rCOMMe76b8a89a463: [native] use findUserID RPC in UsernameSelection component (authored by varun).
[native] use findUserID RPC in UsernameSelection component
Mon, Mar 18, 10:32 PM
varun committed rCOMM0390a90e6730: [crypto] make sure short format of prekey is expected when creating an outbound… (authored by varun).
[crypto] make sure short format of prekey is expected when creating an outbound…
Mon, Mar 18, 10:32 PM
varun closed D11312: [native] use short form for prekeys.
Mon, Mar 18, 10:32 PM
varun committed rCOMM3d1844eb73a8: [native] use short form for prekeys (authored by varun).
[native] use short form for prekeys
Mon, Mar 18, 10:32 PM
varun added inline comments to D11312: [native] use short form for prekeys.
Mon, Mar 18, 10:28 PM
varun added a reviewer for D11335: [native][lib][web] update IdentityServiceClient implementations and useLogOut in user-actions.js: michal.
Mon, Mar 18, 10:13 PM
varun updated the diff for D11335: [native][lib][web] update IdentityServiceClient implementations and useLogOut in user-actions.js.

address feedback on previous revision

Mon, Mar 18, 7:40 PM
varun updated the diff for D11335: [native][lib][web] update IdentityServiceClient implementations and useLogOut in user-actions.js.

after rebasing i started getting a flow error. updated web/grpc/identity-service-client-proxy.js to resolve it, but not really sure what this code does... going to add @michal as a reviewer

Mon, Mar 18, 7:36 PM
varun closed D11305: [terraform] use identity 0.12 on prod.
Mon, Mar 18, 7:44 AM
varun committed rCOMM503fd514a397: [terraform] use identity 0.12 on prod (authored by varun).
[terraform] use identity 0.12 on prod
Mon, Mar 18, 7:44 AM

Sat, Mar 16

varun added inline comments to D11320: [native] use findUserID RPC in UsernameSelection component.
Sat, Mar 16, 4:37 PM

Fri, Mar 15

varun added 1 blocking reviewer(s) for D11305: [terraform] use identity 0.12 on prod: ashoat.

setting @ashoat as blocking

Fri, Mar 15, 12:47 PM
varun updated the diff for D11334: [native] add logOut to CommRustModule.

rebase

Fri, Mar 15, 12:46 PM
varun updated the diff for D11334: [native] add logOut to CommRustModule.

rebase on top of prekey format diffs

Fri, Mar 15, 12:44 PM
varun published D11335: [native][lib][web] update IdentityServiceClient implementations and useLogOut in user-actions.js for review.
Fri, Mar 15, 12:43 PM

Thu, Mar 14

varun requested review of D11334: [native] add logOut to CommRustModule.
Thu, Mar 14, 9:34 PM
varun requested review of D11319: [crypto] make sure short format of prekey is expected when creating an outbound session.
Thu, Mar 14, 9:30 PM
varun closed D11329: [identity] Update invalid username check on Identity service.
Thu, Mar 14, 3:02 PM
varun committed rCOMMf3c665ffa54b: [identity] Update invalid username check on Identity service (authored by varun).
[identity] Update invalid username check on Identity service
Thu, Mar 14, 3:02 PM
varun requested review of D11329: [identity] Update invalid username check on Identity service.
Thu, Mar 14, 9:03 AM

Wed, Mar 13

varun requested review of D11321: [native] update userAlreadyExists in ConnectEthereum component.
Wed, Mar 13, 7:15 PM
varun requested review of D11320: [native] use findUserID RPC in UsernameSelection component.
Wed, Mar 13, 7:11 PM
varun requested review of D11319: [crypto] make sure short format of prekey is expected when creating an outbound session.
Wed, Mar 13, 5:38 PM
varun requested review of D11305: [terraform] use identity 0.12 on prod.
Wed, Mar 13, 12:51 PM
varun added a comment to D11305: [terraform] use identity 0.12 on prod.
  1. What's "retagging" mean and why was it necessary here?
Wed, Mar 13, 12:51 PM

Tue, Mar 12

varun closed D11285: [keyserver] make force login configurable.
Tue, Mar 12, 11:26 PM
varun committed rCOMMe7c687014447: [keyserver] make force login configurable (authored by varun).
[keyserver] make force login configurable
Tue, Mar 12, 11:26 PM
varun closed D11278: [identity] add optional force param to password login RPC.
Tue, Mar 12, 11:26 PM