[identity] Forbid duplicated devices in device lists
ClosedPublic
Actions

Authored by bartek on Jul 25 2024, 10:19 PM.

Details

Reviewers

varun

Commits

rCOMM4c54b9c24d52: [identity] Forbid duplicated devices in device lists

Summary

Addresses ENG-8898.
Added a condition to check if the device list udpate contains duplicates.

Test Plan

Added unit test

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jul 25 2024, 10:19 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 25 2024, 10:19 PM

Harbormaster failed remote builds in B30683: Diff 42795!Jul 25 2024, 10:21 PM

bartek published this revision for review.Jul 25 2024, 10:27 PM

bartek added inline comments.

services/identity/src/device_list.rs
331–332 ↗	(On Diff #42795)	`copied()` is only needed to convert `&&str` into `&str`. It's cheap

varun accepted this revision.Jul 26 2024, 8:14 AM

This revision is now accepted and ready to land.Jul 26 2024, 8:14 AM

This revision was landed with ongoing or failed builds.Jul 29 2024, 12:16 AM

Closed by commit rCOMM4c54b9c24d52: [identity] Forbid duplicated devices in device lists (authored by bartek). · Explain Why

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM4c54b9c24d52: [identity] Forbid duplicated devices in device lists.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

device_list.rs

21 lines

Diff 42858

View Options

services/identity/src/device_list.rs

[identity] Forbid duplicated devices in device listsClosedPublicActions