Page MenuHomePhabricator

ashoat (Ashoat)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jul 20 2020, 9:28 AM (139 w, 6 d)
Roles
Administrator

Recent Activity

Today

ashoat accepted D7137: [native] render thread avatars for parent/child threads in thread settings.

Accepting to unblock but the pattern of copy-paste is concerning

Sun, Mar 26, 6:03 AM
ashoat accepted D7136: [native] render thread avatars in community drawer.

Please make sure @inka creates the task I requested before you land this

Sun, Mar 26, 6:00 AM
ashoat accepted D7134: [native] update message list header to new design.
Sun, Mar 26, 5:57 AM
ashoat accepted D7132: [lib] introduce useGetAvatarForThread hook.
Sun, Mar 26, 5:53 AM
ashoat accepted D7178: [lib] introduce getUserAvatarForThread function.
Sun, Mar 26, 5:53 AM
ashoat accepted D7177: [keyserver/lib/native/web] introduce color-utils and move color functions from thread-utils to color-utils.

Looks like this is just a move diff so blindly accepting. Not familiar with that error myself, wondering what "initialization" means in this context (is it a circular dependency issue?)

Sun, Mar 26, 5:43 AM

Yesterday

ashoat accepted D7176: [keyserver] Don't gate `avatar` inclusion in `*LoggedInUserInfo` based on `codeVersion`.
Sat, Mar 25, 4:13 PM
ashoat added a reviewer for D7175: [lib] Include an isPinned flag in ChatMessageInfoItem: kuba.

Also throwing in @kuba, since he has been looking at chat-selectors.js recently too

Sat, Mar 25, 10:42 AM
ashoat added inline comments to D7123: [web-db] implement function get all drafts from SQLite.
Sat, Mar 25, 10:40 AM
ashoat accepted D7148: [keyserver/lib] Introduce a new message type and spec for toggling pins.

Please apply the requested change before landing!

Sat, Mar 25, 3:00 AM
ashoat added inline comments to D7168: [lib] Introduce encrypted media types.
Sat, Mar 25, 2:56 AM
ashoat accepted D7167: [keyserver] Process and store encrypted media.
Sat, Mar 25, 2:54 AM
ashoat accepted D7166: [lib][keyserver] Attach MIME and encryption key to uploads.
Sat, Mar 25, 2:51 AM
ashoat accepted D7113: [native] RustPromiseManager.

Looks great, just minor nits! Great work on the synchronization, really for the distraction looking at threadsafe collections

Sat, Mar 25, 2:40 AM
ashoat added inline comments to D7120: Use notifications permission request API on Android 13 while keeping old behavior on older Androids..
Sat, Mar 25, 2:33 AM
ashoat added a comment to D7106: Native Java code to request notifications permissions from JS on Android 13.

Thanks @bartek, your explanation makes sense... I agree now that doing something on the Java side doesn't make any sense. I think we can move the discussion to D7120 for the JS side and safely land this diff as-is

Sat, Mar 25, 2:29 AM
ashoat requested changes to D7120: Use notifications permission request API on Android 13 while keeping old behavior on older Androids..
Sat, Mar 25, 2:26 AM

Fri, Mar 24

ashoat accepted D7106: Native Java code to request notifications permissions from JS on Android 13.

After gathering the discussion above my statement on this is that:

  1. I would follow @bartek approach since as he stated it is a common practice he encountered in open source projects.
  2. If there is no acceptance to this approach I will make this method resolve not to two but to three values: false, true, null. The promise resolved to null will be interpreted in JS code that the request is already in progress and another promise will shortly resolve to some meaningful value we can react to (by querying for device token or setting it to null). It will probably be an early return in JS. Alternatively to resolving to ?boolean we can resolve to string constants such as GRANTED, DENIED and REQUEST_ALREADY_IN_PROGRESS.
Fri, Mar 24, 6:48 PM
ashoat requested review of D7174: [keyserver] Fix account deletion performance.
Fri, Mar 24, 5:31 PM
ashoat added inline comments to D7148: [keyserver/lib] Introduce a new message type and spec for toggling pins.
Fri, Mar 24, 2:56 PM
ashoat accepted D7113: [native] RustPromiseManager.

Talked to @varun offline, plan is to handle thread safety in a later diff

Fri, Mar 24, 2:50 PM
ashoat requested changes to D7113: [native] RustPromiseManager.

Collection should be threadsafe

Fri, Mar 24, 2:04 PM
ashoat requested changes to D7114: [native][draft] Calling Rust get_42() function from JS async.

Is this still meant to be a dummy / example diff that doesn't get landed?

Fri, Mar 24, 2:00 PM
ashoat closed D7164: [keyserver] Launch NSE for build 199 and above.
Fri, Mar 24, 1:58 PM
ashoat committed rCOMM8e3ede03a4e4: [keyserver] Launch NSE for build 199 and above (authored by ashoat).
[keyserver] Launch NSE for build 199 and above
Fri, Mar 24, 1:58 PM
ashoat closed D7173: Allow while(true) in the JS codebase.
Fri, Mar 24, 1:58 PM
ashoat committed rCOMMe7b714f20e83: Allow while(true) in the JS codebase (authored by ashoat).
Allow while(true) in the JS codebase
Fri, Mar 24, 1:58 PM
ashoat accepted D7120: Use notifications permission request API on Android 13 while keeping old behavior on older Androids..

Please make the requested changes before landing

Fri, Mar 24, 1:57 PM
ashoat accepted D7162: [keyserver] Update `fetchUserInfos` to include `avatar`s in `GlobalUserInfo`s.
Fri, Mar 24, 1:55 PM
ashoat added inline comments to D7162: [keyserver] Update `fetchUserInfos` to include `avatar`s in `GlobalUserInfo`s.
Fri, Mar 24, 1:55 PM
ashoat added a comment to D7164: [keyserver] Launch NSE for build 199 and above.

No, I don't think so

Fri, Mar 24, 1:52 PM
ashoat added inline comments to D6929: [keyserver] Add a function to toggle the pin status of a message.
Fri, Mar 24, 1:52 PM
ashoat added inline comments to D6973: [web] Extract from drawer item code that can be reused in community items.
Fri, Mar 24, 1:49 PM
ashoat accepted D7125: Use new notifications permission API to modify push notifs settings alerts on Android 13.
Fri, Mar 24, 1:47 PM
ashoat requested changes to D7106: Native Java code to request notifications permissions from JS on Android 13.

I'm starting to wonder if it'd be better to revert my suggestion just to avoid all that fuss.

Fri, Mar 24, 1:34 PM
ashoat accepted D7105: Build files set-up for Android 13.

Awesome!! Thanks for taking the time to revise this a bunch, I know it was more complicated than initially expected

Fri, Mar 24, 12:28 PM
ashoat requested review of D7173: Allow while(true) in the JS codebase.
Fri, Mar 24, 12:26 PM
ashoat added a comment to D7101: [web-db] add `sql.js` types.

Thanks for explaining!

Fri, Mar 24, 12:25 PM
ashoat requested changes to D7148: [keyserver/lib] Introduce a new message type and spec for toggling pins.

Really close!

Fri, Mar 24, 12:21 PM
ashoat requested changes to D7117: [keyserver] Add migration - process messages in our db for search.

Back to you

Fri, Mar 24, 12:14 PM
ashoat added inline comments to D7117: [keyserver] Add migration - process messages in our db for search.
Fri, Mar 24, 12:13 PM
ashoat requested changes to D7077: [keyserver] Process new messages for search.
Fri, Mar 24, 12:03 PM
ashoat requested changes to D7076: [keyserver] Add search table to the db.

Ah but actually some of my other feedback hasn't been addressed yet

Fri, Mar 24, 12:03 PM
ashoat accepted D7076: [keyserver] Add search table to the db.

In retrospect, D7077 is the right place for this discussion – @inka, would you mind responding to my questions in this diff there?

Fri, Mar 24, 12:02 PM
ashoat added inline comments to D7076: [keyserver] Add search table to the db.
Fri, Mar 24, 12:01 PM
ashoat requested changes to D7065: [native] Added displaying labels to InlineEngagement.

Will this affect the height of the item? Have you made the necessary changes to the height determination code (textMessageItemHeight)?

Fri, Mar 24, 11:56 AM
ashoat accepted D7168: [lib] Introduce encrypted media types.

I think we should include localMediaSelection, but not sure if a future diff adds that

Fri, Mar 24, 11:54 AM
ashoat accepted D7169: [lib] Shim encrypted multimedia.
Fri, Mar 24, 11:53 AM
ashoat requested changes to D7167: [keyserver] Process and store encrypted media.
Fri, Mar 24, 11:47 AM
ashoat requested changes to D7166: [lib][keyserver] Attach MIME and encryption key to uploads.

Passing back to you with question about multiple files being uploaded to the same endpoint at once. I don't think we actually ever do this, so I'm wondering if we can simply throw an exception if we get multiple files in the same upload

Fri, Mar 24, 11:41 AM
ashoat added inline comments to D7166: [lib][keyserver] Attach MIME and encryption key to uploads.
Fri, Mar 24, 11:00 AM
ashoat requested changes to D7129: [lib] Added new 'sendEditMessage' action.
Fri, Mar 24, 10:57 AM
ashoat requested changes to D7143: [lib] Function to dispatch edit message action.
Fri, Mar 24, 10:54 AM
ashoat added inline comments to D7143: [lib] Function to dispatch edit message action.
Fri, Mar 24, 10:54 AM
ashoat added inline comments to D7140: [lib] Displaying edited content in a pending thread.
Fri, Mar 24, 10:52 AM
ashoat attached a referenced file: F443322: Screenshot 2023-03-24 at 10.28.41 AM.png.
Fri, Mar 24, 9:22 AM
ashoat attached a referenced file: F443323: Screenshot 2023-03-24 at 12.18.25 PM.png.
Fri, Mar 24, 9:22 AM
ashoat added inline comments to D7076: [keyserver] Add search table to the db.
Fri, Mar 24, 9:22 AM

Thu, Mar 23

ashoat requested review of D7165: [lib] Introduce useENSAvatar hook.
Thu, Mar 23, 9:19 PM
ashoat requested review of D7164: [keyserver] Launch NSE for build 199 and above.
Thu, Mar 23, 8:47 PM
ashoat requested review of D7163: [native] Introduce useNativeMessageListData and NativeChatMessageItem.
Thu, Mar 23, 8:36 PM
ashoat closed D7093: [native] Use a JSON blob for heightMeasurerKey.
Thu, Mar 23, 8:17 PM
ashoat committed rCOMM4765c224e781: [native] Use a JSON blob for heightMeasurerKey (authored by ashoat).
[native] Use a JSON blob for heightMeasurerKey
Thu, Mar 23, 8:17 PM
ashoat requested changes to D7162: [keyserver] Update `fetchUserInfos` to include `avatar`s in `GlobalUserInfo`s.

That makes sense RE older clients. Thinking about it more, I'm not actually sure why we ever thought it made sense to "hide" the avatar field from older clients... they're going to eventually need the field, and if we hide it from them initially then they will need to rely on the state check mechanism to fix things after they upgrade codeVersions.

Thu, Mar 23, 8:06 PM
ashoat added a comment to D6924: [keyserver] Introduce columns in messages table to support pinned messages.

The current fetchPinnedMessageInfos query doesn't have the ability to paginate, but it can always be added in later. We could initially fetch all of the pinned messages at once from the server, but have a task to paginate the fetching

Thu, Mar 23, 7:46 PM
ashoat accepted D7110: [keyserver/lib] Add a fetchPinnedMessages method to retrieve all pinned messages for a thread.
Thu, Mar 23, 7:44 PM
ashoat added a comment to D5995: [native] clear database when malformation is detected.

Yeah we can probably get rid of them, feel free to put up a diff

Thu, Mar 23, 7:37 PM
ashoat accepted D7156: [lib] Update `CurrentUserInfo` on `updateUserAvatarActionTypes.success`.
Thu, Mar 23, 7:37 PM
ashoat accepted D7157: [keyserver] `JSON.parse()` stringified `avatar` in `fetchLoggedInUserInfo`.
Thu, Mar 23, 7:35 PM
ashoat added a comment to D7067: [native] render user avatars in chat screen.

One last thing that would be great if you could test: what happens if you upload a single very "thin" photo? I want to make sure it doesn't expand to take the whole width and then becomes super tall. (Or at least, that there's no regression in this.)

Thu, Mar 23, 7:34 PM
ashoat accepted D7067: [native] render user avatars in chat screen.
Thu, Mar 23, 7:32 PM
ashoat requested changes to D7141: [keyserver] Add the latest edit message to the new sidebar if the source message is edited.

Back to your queue for nits and fetchDerivedMessages

Thu, Mar 23, 7:26 PM
ashoat added inline comments to D7148: [keyserver/lib] Introduce a new message type and spec for toggling pins.
Thu, Mar 23, 7:26 PM
ashoat added inline comments to D7148: [keyserver/lib] Introduce a new message type and spec for toggling pins.
Thu, Mar 23, 7:25 PM
ashoat added a reviewer for D7148: [keyserver/lib] Introduce a new message type and spec for toggling pins: kuba.

Adding @kuba here – he is looking at fetchDerivedMessages right now in D7141

Thu, Mar 23, 7:25 PM
ashoat added a reviewer for D7141: [keyserver] Add the latest edit message to the new sidebar if the source message is edited: rohan.
Thu, Mar 23, 7:24 PM
ashoat added inline comments to D7120: Use notifications permission request API on Android 13 while keeping old behavior on older Androids..
Thu, Mar 23, 7:17 PM
ashoat added inline comments to D7106: Native Java code to request notifications permissions from JS on Android 13.
Thu, Mar 23, 7:13 PM
ashoat attached a referenced file: F442421: Screenshot 2023-03-23 at 9.53.39 PM.png.
Thu, Mar 23, 6:59 PM
ashoat requested changes to D7105: Build files set-up for Android 13.

Can you please amend the Test Plan to include:

Thu, Mar 23, 6:59 PM
ashoat accepted D7161: [ios] Add `--repo-update` to `pod install` command.
Thu, Mar 23, 2:05 PM
ashoat accepted D7154: [web-db] get client database store from SQLite.
Thu, Mar 23, 12:55 PM
ashoat added inline comments to D7101: [web-db] add `sql.js` types.
Thu, Mar 23, 12:54 PM
ashoat accepted D7153: [web-db] process Draft Store Operations on worker.
Thu, Mar 23, 12:52 PM
ashoat accepted D7124: [web-db] add unit tests for draft store queries.

Did not review this closely

Thu, Mar 23, 12:50 PM
ashoat accepted D7123: [web-db] implement function get all drafts from SQLite.
Thu, Mar 23, 12:48 PM
ashoat added inline comments to D7118: [web-db] add function for parsing SQLite query.
Thu, Mar 23, 12:46 PM
ashoat added inline comments to D7118: [web-db] add function for parsing SQLite query.
Thu, Mar 23, 12:45 PM
ashoat accepted D7121: [web-db] create drafts table in SQLite database.

I'm sorry, I completely missed that it was an old migration. My apologies for making assumptions and leaving an unnecessarily aggressive comment

Thu, Mar 23, 12:39 PM
ashoat accepted D7118: [web-db] add function for parsing SQLite query.
Thu, Mar 23, 12:38 PM
ashoat accepted D7101: [web-db] add `sql.js` types.
Thu, Mar 23, 12:37 PM
ashoat added a comment to D6978: [web] Add a badge on the Inbox button.

On context on why this diff has been up for 2 weeks and hasn't been reviewed?

Thu, Mar 23, 12:30 PM
ashoat closed D7150: [web] Scaffolding for opaque-ke-wasm project.
Thu, Mar 23, 12:20 PM
ashoat committed rCOMMede918e1a6f5: [web] Scaffolding for opaque-ke-wasm project (authored by ashoat).
[web] Scaffolding for opaque-ke-wasm project
Thu, Mar 23, 12:20 PM
ashoat closed D7149: [web] Add grpc-web@1.4.2.
Thu, Mar 23, 12:20 PM
ashoat committed rCOMM4559bf844167: [web] Add grpc-web@1.4.2 (authored by ashoat).
[web] Add grpc-web@1.4.2
Thu, Mar 23, 12:20 PM
ashoat added a comment to D7150: [web] Scaffolding for opaque-ke-wasm project.

Note that I didn't bother adding a line here because @commapp/opaque-ke-wasm isn't actually consumed directly via Yarn workspaces, so we don't need its package.json in order to run yarn cleaninstall (apparently anyways, given that CI passes). Instead, we'll consume published versions of @commapp/opaque-ke-wasm as an NPM package.

Thu, Mar 23, 12:12 PM
ashoat added inline comments to D7083: Amended Account & Session types..
Thu, Mar 23, 8:02 AM
ashoat closed D7151: [native] Migrate from react-native-fast-image to expo-image.
Thu, Mar 23, 5:27 AM
ashoat committed rCOMM115e490e58c1: [native] Migrate from react-native-fast-image to expo-image (authored by ashoat).
[native] Migrate from react-native-fast-image to expo-image
Thu, Mar 23, 5:27 AM