User Details
- User Since
- Jul 20 2020, 9:28 AM (209 w, 4 d)
- Roles
- Administrator
Tue, Jul 23
Mon, Jul 22
Before we land this, let's see if we can solve it for @marcin some other way
Even if we don't use localforage in our code outside of web, this patch probably affects some transitive dependencies for other projects. It looks like it's backwards-compatible, so it should be safe. But we face some trouble at a later point if a transitive dependency upgrades it version, depending on which package Yarn hoists to the workspace root, and how patch-package handles it when multiple versions of a package are present (does it patch all of them, or only the one at the workspace root?)
I wonder if we should have a separate task for updating the replies count. I don't think I contemplated it in sendTextMessageSpec
Looks like CommTest passes – would love to get another accept from either reviewer before landing, to confirm that this new strategy seems safe
Try ignoring all *.tfstate and *.tfvars files
It makes sense for the sidebar creation use case that I designed for, which is where this hook will be used. I don't think you'll want to use this particular hook, but I can see how for the search use case, it might make sense to replace getRelatedMessages with an API that can query a batch of message IDs at once. I haven't considered the performance implications here – would be good for you and @kamil to consider this, and make a decision on whether the API needs to be replaced
Sun, Jul 21
Looks good but would prefer somebody with Terraform / Rust experience reviewed
Generally makes sense to me, but would be good for one of the Rust people to review
Sat, Jul 20
Fri, Jul 19
Same feedback as D12814
Don't love all the copy-paste here. Let's create a follow-up task to ask @bartek if there's a way to reduce it
Looks like some context in D8255... web doesn't really need this route, landing definitely does, and it's not clear if it's needed at the root either. I think it's fine to remove given we'll be running landing on the apex domain
Don't forget to add to CMake!
Could you update the spacing to match the rest of the file?
Thu, Jul 18
Lovely! Forgot that we don't use COMM_JSONCONFIG for the MariaDB config in the Docker configuration. I think we initially made this decision because it made it easier to access them from our Docker Compose config. Seems like there's a similar benefit for making it easy to access from the Terraform config.