User Details
- User Since
- Jul 20 2020, 9:28 AM (192 w, 3 d)
- Roles
- Administrator
Yesterday
I previously reviewed this code in person
We have ENG-7514 to track improving the robotext here, so that it mentions the user's Farcaster username
We should include the new package in keyserver/package.json since it's used in keyserver/.babelrc.cjs. It doesn't cause any issues right now because the package isn't getting hoisted, but subtle changes to dependencies could change that.
Thanks for cleaning this up!
Right, my bad!
Wed, Mar 27
Guessing the plumbing for native (and the rest of the plumbing for web) will come in a later diff
Do we need to update anything for registerPasswordUser or registerWalletUser on web?
Add a constant for reconnect delay. Also add a similar constant for the similar logic in lib/socket/socket.react.js
Tue, Mar 26
Would be good for @varun to review the Rust.
Yes, but only for uploadNewOneTimeKeys. I left a comment on ENG-6691 mentioning this
Mon, Mar 25
Given that both scenario and scenario 1 have to do with fetchUpdateOlmAccount, I wonder if we should consider what I suggested in my comment about scenario 1:
This is going to be the case for login as well once ENG-6598 is implemented. This makes me wonder if AccessTokenHandler is needed at all. If we will be setting CSAT on login and register actions, is there a need for it? I guess the CSAT can change while being logged in, but then how do we handle that on web, and why is native different?
Yes, we could consider skipping Tunnelbroker and having clients connect directly to identity (eg. via WebSocket)
Sun, Mar 24
Thu, Mar 21
Would be great if @michal takes a look
After today's meeting, I wonder if we still need to add this ID to all actions
Wed, Mar 20
Tue, Mar 19
Some nits below, but I didn't review closely.
New dependency seems fine
That was fast!!
Mon, Mar 18
Thanks for explaining!
I would be good to land this soon, as it's blocking some folks