Page MenuHomePhabricator

ashoat (Ashoat)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jul 20 2020, 9:28 AM (192 w, 3 d)
Roles
Administrator

Recent Activity

Yesterday

ashoat requested review of D11460: [lib] Hook everything together in FarcasterDataHandler.
Thu, Mar 28, 7:46 PM
ashoat closed D11444: [native] Fix up project.pbxproj after yarn cleaninstall.
Thu, Mar 28, 7:13 PM
ashoat committed rCOMMa0cab739d3ff: [native] Fix up project.pbxproj after yarn cleaninstall (authored by ashoat).
[native] Fix up project.pbxproj after yarn cleaninstall
Thu, Mar 28, 7:13 PM
ashoat accepted D11459: [lib] Implement `UpdateRelationshipSpec.shimUnsupportedMessageInfo`.

I previously reviewed this code in person

Thu, Mar 28, 7:09 PM
ashoat accepted D11458: [lib] Handle `farcaster_mutual` case in `robotext/notificationTexts`.

We have ENG-7514 to track improving the robotext here, so that it mentions the user's Farcaster username

Thu, Mar 28, 4:30 PM
ashoat accepted D11454: [sqlite] downgrade migration version on native from '65' to '64'.
Thu, Mar 28, 11:46 AM
ashoat accepted D11456: Revert "[lib] integrity reducer tests".
Thu, Mar 28, 11:46 AM
ashoat accepted D11453: Revert "[native][web] Read integrity thread hashes from SQLite on app start".
Thu, Mar 28, 11:46 AM
ashoat requested review of D11444: [native] Fix up project.pbxproj after yarn cleaninstall.
Thu, Mar 28, 10:17 AM
ashoat accepted D11427: [keyserver/landing] add @babel/plugin-transform-private-methods to list of plugins.
Thu, Mar 28, 9:48 AM
ashoat added inline comments to D11432: [landing/lib/native] introduce FarcasterWebView.
Thu, Mar 28, 6:45 AM
ashoat added inline comments to D11428: [landing] introduce ConnectFarcaster.
Thu, Mar 28, 6:41 AM
ashoat requested changes to D11427: [keyserver/landing] add @babel/plugin-transform-private-methods to list of plugins.

We should include the new package in keyserver/package.json since it's used in keyserver/.babelrc.cjs. It doesn't cause any issues right now because the package isn't getting hoisted, but subtle changes to dependencies could change that.

Thu, Mar 28, 6:41 AM
ashoat accepted D11426: [landing] add @farcaster/auth-kit dep.
Thu, Mar 28, 6:39 AM
ashoat added a comment to D11347: [web/native] Use olmAPI instead of `OlmSessionCreatorContext`.

Thanks for cleaning this up!

Thu, Mar 28, 6:34 AM
ashoat added a comment to D11410: [web] add client methods to web.

Right, my bad!

Thu, Mar 28, 6:29 AM
ashoat closed D11425: [lib][native] FIDProvider.
Thu, Mar 28, 5:07 AM
ashoat committed rCOMM652a137d6429: [lib][native] FIDProvider (authored by ashoat).
[lib][native] FIDProvider
Thu, Mar 28, 5:07 AM

Wed, Mar 27

ashoat requested review of D11425: [lib][native] FIDProvider.
Wed, Mar 27, 6:03 PM
ashoat added inline comments to D11418: [sqlite] implement C++ synced metadata store ops.
Wed, Mar 27, 5:41 PM
ashoat accepted D11423: [identity] unlink farcaster account RPC.

Guessing the plumbing for native (and the rest of the plumbing for web) will come in a later diff

Wed, Mar 27, 5:34 PM
ashoat added a comment to D11410: [web] add client methods to web.

Do we need to update anything for registerPasswordUser or registerWalletUser on web?

Wed, Mar 27, 5:33 PM
ashoat accepted D11398: [native] expose farcaster id param to native identity service context provider.
Wed, Mar 27, 5:32 PM
ashoat added a comment to D11412: [identity] check if fid is already taken when registering new user.

@varun looking at the test plan here, is it fair to say you weren't able to reproduce ENG-7390? Is it worth trying to test via the UI to see if that reproduces it?

Wed, Mar 27, 5:29 PM
ashoat added a comment to D11411: [identity] don't let linkFarcasterAccount overwrite existing fid for user.
Wed, Mar 27, 5:28 PM
ashoat accepted D11410: [web] add client methods to web.
Wed, Mar 27, 5:25 PM
ashoat accepted D11409: [native] add linkFarcasterAccount to native IdentityServiceContextProvider.
Wed, Mar 27, 5:23 PM
ashoat accepted D11405: [lib][native] Add getFarcasterUsers to IdentityServiceContextProvider.
Wed, Mar 27, 5:22 PM
ashoat accepted D11399: [identity][proto] add GetFarcasterUsers and LinkFarcasterAccount rpcs.
Wed, Mar 27, 5:21 PM
ashoat accepted D11396: [proto][identity] add optional fid to registration request messages.
Wed, Mar 27, 5:19 PM
ashoat added inline comments to D11368: [native][web] Remove processing the ops from reducers.
Wed, Mar 27, 5:15 PM
ashoat added inline comments to D11393: [lib] Add preRequestUserState to identity login.
Wed, Mar 27, 5:12 PM
ashoat added inline comments to D11394: [lib][web][native] Handle idnentity login in reducers.
Wed, Mar 27, 5:11 PM
ashoat added inline comments to D11394: [lib][web][native] Handle idnentity login in reducers.
Wed, Mar 27, 5:25 AM
ashoat closed D11392: [keyserver] Construct a new TunnelbrokerSocket when one closes.
Wed, Mar 27, 5:25 AM
ashoat committed rCOMM2a37b6defc5b: [keyserver] Construct a new TunnelbrokerSocket when one closes (authored by ashoat).
[keyserver] Construct a new TunnelbrokerSocket when one closes
Wed, Mar 27, 5:25 AM
ashoat requested changes to D11395: [lib][native] Stop deleting CSAT on login actions.
Wed, Mar 27, 5:25 AM
ashoat closed D11391: [keyserver] Track closed state in TunnelbrokerSocket.
Wed, Mar 27, 5:25 AM
ashoat committed rCOMM7b5b4e870f12: [keyserver] Track closed state in TunnelbrokerSocket (authored by ashoat).
[keyserver] Track closed state in TunnelbrokerSocket
Wed, Mar 27, 5:25 AM
ashoat updated the diff for D11392: [keyserver] Construct a new TunnelbrokerSocket when one closes.

Add a constant for reconnect delay. Also add a similar constant for the similar logic in lib/socket/socket.react.js

Wed, Mar 27, 5:19 AM
ashoat closed D11390: [keyserver][lib] Introduce relationshipActions.FARCASTER_MUTUAL.
Wed, Mar 27, 5:09 AM
ashoat committed rCOMM28575a979991: [keyserver][lib] Introduce relationshipActions.FARCASTER_MUTUAL (authored by ashoat).
[keyserver][lib] Introduce relationshipActions.FARCASTER_MUTUAL
Wed, Mar 27, 5:09 AM
ashoat closed D11389: [lib][native] Introduce NeynarClientProvider.
Wed, Mar 27, 5:04 AM
ashoat closed D11388: [lib] Initial NeynarClient with fetchFriendFIDs method.
Wed, Mar 27, 5:04 AM
ashoat committed rCOMM367d98f58f01: [lib][native] Introduce NeynarClientProvider (authored by ashoat).
[lib][native] Introduce NeynarClientProvider
Wed, Mar 27, 5:04 AM
ashoat committed rCOMM67a098b70fb2: [lib] Initial NeynarClient with fetchFriendFIDs method (authored by ashoat).
[lib] Initial NeynarClient with fetchFriendFIDs method
Wed, Mar 27, 5:04 AM
ashoat closed D11387: [lib][native] Introduce FarcasterDataHandler.
Wed, Mar 27, 5:04 AM
ashoat committed rCOMM52940b1e1659: [lib][native] Introduce FarcasterDataHandler (authored by ashoat).
[lib][native] Introduce FarcasterDataHandler
Wed, Mar 27, 5:04 AM

Tue, Mar 26

ashoat requested review of D11392: [keyserver] Construct a new TunnelbrokerSocket when one closes.
Tue, Mar 26, 8:40 PM
ashoat requested review of D11391: [keyserver] Track closed state in TunnelbrokerSocket.
Tue, Mar 26, 8:39 PM
ashoat requested review of D11390: [keyserver][lib] Introduce relationshipActions.FARCASTER_MUTUAL.
Tue, Mar 26, 7:47 PM
ashoat requested review of D11389: [lib][native] Introduce NeynarClientProvider.
Tue, Mar 26, 7:40 PM
ashoat requested review of D11388: [lib] Initial NeynarClient with fetchFriendFIDs method.
Tue, Mar 26, 7:35 PM
ashoat requested review of D11387: [lib][native] Introduce FarcasterDataHandler.
Tue, Mar 26, 7:34 PM
ashoat added a comment to D11349: [native] migrate integrityStore to SQLite.

Spoke to @will about this in person and he clarified that we're purposing double-storing this data right for validation. @will will post a Linear issue in a sec that will track:

Tue, Mar 26, 1:48 PM
ashoat accepted D11383: [CommCoreModule] MessageSpec changes for updated `UPDATE_RELATIONSHIP`.
Tue, Mar 26, 1:09 PM
ashoat added inline comments to D11358: [native][web] Read integrity thread hashes from SQLite on app start.
Tue, Mar 26, 1:08 PM
ashoat added a comment to D11349: [native] migrate integrityStore to SQLite.

At some point we should also blacklist integrityStore on native so that it isn't persisted using redux-persist

Tue, Mar 26, 12:59 PM
ashoat accepted D11379: [protos][identity] Add RPC to find username by user ID.

Would be good for @varun to review the Rust.

Tue, Mar 26, 12:55 PM
ashoat accepted D11378: [protos] Rename UpdateDeviceListForUser RPC to UpdateDeviceList.
Tue, Mar 26, 12:47 PM
ashoat added inline comments to D11373: [web] Use shared worker crypto store in identity client provider.
Tue, Mar 26, 12:45 PM
ashoat closed D11384: [keyserver] Fix olm_session_creation_failure bug due to fetchOlmUpdateAccount retry.
Tue, Mar 26, 6:34 AM
ashoat committed rCOMM5ab5ebdad4f1: [keyserver] Fix olm_session_creation_failure bug due to fetchOlmUpdateAccount… (authored by ashoat).
[keyserver] Fix olm_session_creation_failure bug due to fetchOlmUpdateAccount…
Tue, Mar 26, 6:34 AM
ashoat added a comment to D11384: [keyserver] Fix olm_session_creation_failure bug due to fetchOlmUpdateAccount retry.

Yes, but only for uploadNewOneTimeKeys. I left a comment on ENG-6691 mentioning this

Tue, Mar 26, 6:33 AM

Mon, Mar 25

ashoat added a comment to D11384: [keyserver] Fix olm_session_creation_failure bug due to fetchOlmUpdateAccount retry.

Given that both scenario and scenario 1 have to do with fetchUpdateOlmAccount, I wonder if we should consider what I suggested in my comment about scenario 1:

Mon, Mar 25, 8:59 PM
ashoat updated the summary of D11384: [keyserver] Fix olm_session_creation_failure bug due to fetchOlmUpdateAccount retry.
Mon, Mar 25, 8:58 PM
ashoat requested review of D11384: [keyserver] Fix olm_session_creation_failure bug due to fetchOlmUpdateAccount retry.
Mon, Mar 25, 8:52 PM
ashoat closed D11377: [keyserver] Fix memberOfContainingThreadPromise behavior for users missing in DB.
Mon, Mar 25, 9:37 AM
ashoat committed rCOMM5fbb261555f3: [keyserver] Fix memberOfContainingThreadPromise behavior for users missing in DB (authored by ashoat).
[keyserver] Fix memberOfContainingThreadPromise behavior for users missing in DB
Mon, Mar 25, 9:37 AM
ashoat closed D11376: [keyserver] Debounce one-time key refresh request.
Mon, Mar 25, 9:37 AM
ashoat closed D11375: [keyserver] Make keyserver handle one-time key refresh requests sequentially.
Mon, Mar 25, 9:37 AM
ashoat committed rCOMMe443dca044c6: [keyserver] Make keyserver handle one-time key refresh requests sequentially (authored by ashoat).
[keyserver] Make keyserver handle one-time key refresh requests sequentially
Mon, Mar 25, 9:36 AM
ashoat committed rCOMM9413ba103cad: [keyserver] Debounce one-time key refresh request (authored by ashoat).
[keyserver] Debounce one-time key refresh request
Mon, Mar 25, 9:36 AM
ashoat closed D11374: [lib] Avoid clearing CSAT on identityRegisterActionTypes.success.
Mon, Mar 25, 9:36 AM
ashoat committed rCOMMa8cd439d267a: [lib] Avoid clearing CSAT on identityRegisterActionTypes.success (authored by ashoat).
[lib] Avoid clearing CSAT on identityRegisterActionTypes.success
Mon, Mar 25, 9:36 AM
ashoat updated subscribers of D11374: [lib] Avoid clearing CSAT on identityRegisterActionTypes.success.

This is going to be the case for login as well once ENG-6598 is implemented. This makes me wonder if AccessTokenHandler is needed at all. If we will be setting CSAT on login and register actions, is there a need for it? I guess the CSAT can change while being logged in, but then how do we handle that on web, and why is native different?

Mon, Mar 25, 8:28 AM
ashoat added inline comments to D11375: [keyserver] Make keyserver handle one-time key refresh requests sequentially.
Mon, Mar 25, 8:23 AM
ashoat added a comment to D11376: [keyserver] Debounce one-time key refresh request.

Yes, we could consider skipping Tunnelbroker and having clients connect directly to identity (eg. via WebSocket)

Mon, Mar 25, 8:21 AM

Sun, Mar 24

ashoat requested review of D11377: [keyserver] Fix memberOfContainingThreadPromise behavior for users missing in DB.
Sun, Mar 24, 8:06 PM
ashoat requested review of D11376: [keyserver] Debounce one-time key refresh request.
Sun, Mar 24, 8:04 PM
ashoat requested review of D11375: [keyserver] Make keyserver handle one-time key refresh requests sequentially.
Sun, Mar 24, 8:03 PM
ashoat requested review of D11374: [lib] Avoid clearing CSAT on identityRegisterActionTypes.success.
Sun, Mar 24, 8:03 PM

Thu, Mar 21

ashoat accepted D11363: [web] don't generate or send one time keys on login.

Would be great if @michal takes a look

Thu, Mar 21, 6:15 PM
ashoat added a comment to D11281: [lib] Add an optional ID field to all the actions.

After today's meeting, I wonder if we still need to add this ID to all actions

Thu, Mar 21, 5:58 PM

Wed, Mar 20

ashoat added inline comments to D11352: [web] Deprecate non-worker opaque wasm.
Wed, Mar 20, 11:23 AM
ashoat accepted D11360: [keyserver][lib] don't generate one time keys on identity login.
Wed, Mar 20, 11:19 AM
ashoat accepted D11364: [native] don't generate or send one time keys on login.
Wed, Mar 20, 11:08 AM
ashoat accepted D11362: [web] factor out common code in authNewDeviceKeyUpload.
Wed, Mar 20, 11:06 AM

Tue, Mar 19

ashoat added a comment to D8665: Implement native iOS code to fetch data from blob service and keyserver code to upload notification payload if it exceeds APNs limits.

Some nits below, but I didn't review closely.

Tue, Mar 19, 6:14 PM
ashoat resigned from D9069: Schedule blob deletion on Android when large notifications arrives.

New dependency seems fine

Tue, Mar 19, 6:13 PM
ashoat accepted D11353: [web] Replace $FlowFixMe with any.
Tue, Mar 19, 6:00 PM
ashoat added inline comments to D11352: [web] Deprecate non-worker opaque wasm.
Tue, Mar 19, 5:59 PM
ashoat added inline comments to D11348: [web] Use crypto store and olm from shared worker.
Tue, Mar 19, 5:57 PM
ashoat added a comment to D11141: [IGNORE] Client hacks for testing multiple keyservers.

That was fast!!

Tue, Mar 19, 5:53 PM
ashoat added inline comments to D11341: [web] Olm session creation between own devices.
Tue, Mar 19, 5:50 PM
ashoat added inline comments to D11335: [native][lib][web] update IdentityServiceClient implementations and useLogOut in user-actions.js.
Tue, Mar 19, 5:46 PM
ashoat added inline comments to D11141: [IGNORE] Client hacks for testing multiple keyservers.
Tue, Mar 19, 9:08 AM

Mon, Mar 18

ashoat added a comment to D11281: [lib] Add an optional ID field to all the actions.

Thanks for explaining!

Mon, Mar 18, 6:47 PM
ashoat added a comment to D11319: [crypto] make sure short format of prekey is expected when creating an outbound session.

I would be good to land this soon, as it's blocking some folks

Mon, Mar 18, 6:46 PM
ashoat added inline comments to D11275: [web] Add identity client shared worker proxy.
Mon, Mar 18, 6:37 PM