One more comment update

Update comment

• don't we need to document it somewhere in some README?

I don't remember all the places where we need to add a new permission. Wondering if you modelled this on another diff that introduced a different permission – if so, would be helpful to share a link to that diff.

In D14444#401325, @varun wrote:

Feels like there are probably ways to dismiss the modal without setting the fid to null here. Ideally we can catch all methods of closing the modal, but if that's really hard, one alternative would just be to set the fid to null as soon as we show the modal.

the onClosed callback gets called by BottomSheet's onChange callback:

const onChange = React.useCallback(
  (index: number) => {
    if (index === -1) {
      onClosed();
    }
  },
  [onClosed],
);

i think this should handle all methods of closing the modal

Does it not occur on every single login because the NUX doesn't display on subsequent logins?

Feels like there are probably ways to dismiss the modal without setting the fid to null here. Ideally we can catch all methods of closing the modal, but if that's really hard, one alternative would just be to set the fid to null as soon as we show the modal.

Emscripten failure is weird, not sure why that's happening, but definitely unrelated to this diff (perhaps the issue is live on master). Created ENG-10380 to investigate

CI - not sure if I need to test something else; not familiar with Android configuration

One thing that might be worth checking is whether the outsideButtons logic is still correct

Preemptively publishing in case CI has issues, as it recently has been timing out

Preemptively publishing in case CI has issues, as it recently has been timing out

Passing back to you with a question about why we avoid goBack when showing the NUX tip

Shouldn't D14391 be added to the stack here? You seem to be depending on it

In D14414#400524, @bartek wrote:

An alternative approach, that doesn't require using temporary file:

• Extract some logic from saveRemoteMediaToDisk() in`save-file.js`, with the following changes:
  • For encrypted media, call fetchAndDecryptMedia({ destination: 'data_uri' }) instead of destination: file
  • For non-encrypted, fetch base64 but don't save to file (skip last step)
• call Clipboard.setImageFromBase64 - iOS implementation is in the patch, line 116