Page MenuHomePhabricator

ashoat (Ashoat)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jul 20 2020, 9:28 AM (188 w, 6 d)
Roles
Administrator

Recent Activity

Yesterday

ashoat requested review of D11224: [lib][native] Deprecate DispatchRecoveryAttempt in favor of DispatchActionPromise.
Sun, Mar 3, 11:30 PM
ashoat requested review of D11230: [lib][native] Introduce supportingMultipleKeyservers constant.
Sun, Mar 3, 10:18 PM
ashoat requested review of D11229: [lib][web] Update condition for Redux state reset in SET_NEW_SESSION reducers.
Sun, Mar 3, 10:14 PM
ashoat requested review of D11228: [lib] Introduce relyingOnAuthoritativeKeyserver constant.
Sun, Mar 3, 10:10 PM
ashoat requested review of D11227: [native] Use useKeyserverRecoveryLogIn from SQLiteDataHandler.
Sun, Mar 3, 10:06 PM
ashoat requested review of D11226: [lib] Extract useKeyserverRecoveryLogIn.
Sun, Mar 3, 10:02 PM
ashoat requested review of D11225: [lib] Make resolveKeyserverSessionInvalidation generic.
Sun, Mar 3, 9:58 PM
ashoat requested review of D11223: [lib][native] Make cancellation work for keyserver session recovery.
Sun, Mar 3, 9:49 PM
ashoat requested review of D11222: [lib] Don't cancel an auth that the keyserver completes.
Sun, Mar 3, 9:45 PM
ashoat requested review of D11221: [lib] Factor out CANCELLED_ERROR into keyserver-conn-types.js.
Sun, Mar 3, 9:42 PM
ashoat requested review of D11220: [lib][native] Initialize notif Olm channel during keyserver session recovery.
Sun, Mar 3, 9:37 PM
ashoat requested review of D11219: [lib][native][web] Refactor useInitialNotificationsEncryptedMessage to get Olm session creator from context.
Sun, Mar 3, 9:33 PM
ashoat requested review of D11218: [lib] Initiate a keyserver session recovery when keyserver socket sends not_logged_in.
Sun, Mar 3, 9:29 PM
ashoat requested review of D11217: [lib][native] Try session recovery on web too for policy acknowledgment crash loop.
Sun, Mar 3, 9:25 PM
ashoat requested review of D11216: [lib][native] Use unified keyserver session recovery in native/socket.react.js.
Sun, Mar 3, 9:21 PM
ashoat requested review of D11215: [lib][native][web] Use unified keyserver session recovery in lib/socket/socket.react.js.
Sun, Mar 3, 9:17 PM
ashoat requested review of D11214: [lib] Deprecate resetUserStateActionType.
Sun, Mar 3, 9:13 PM
ashoat requested review of D11213: [native] Use unified keyserver session recovery in LoggedOutModal.
Sun, Mar 3, 9:08 PM
ashoat requested review of D11212: [lib] Replace sessionRecoveryInProgress with actionSessionRecovery.
Sun, Mar 3, 9:04 PM
ashoat requested review of D11211: [lib] Deprecate recoveryActionSources.sqliteOpFailure.
Sun, Mar 3, 9:00 PM
ashoat requested review of D11210: [lib][native] Separate out recoveryActionSources.
Sun, Mar 3, 8:56 PM
ashoat updated the diff for D10972: [lib] Clear sessionRecoveryInProgress during auth / deauth.

Rebase

Sun, Mar 3, 8:37 PM
ashoat updated the diff for D10970: [lib] Dispatch SET_NEW_SESSION when session recovery fails.

Rebase

Sun, Mar 3, 8:36 PM
ashoat updated the diff for D10954: [lib] Move CallKeyserverEndpoint session recovery to KeyserverConnectionHandler.

Rebase

Sun, Mar 3, 8:34 PM
ashoat updated the diff for D10952: [lib] Let keyserver session recovery code handle calling setNewSession.

Add detail to code comment about removing boundSetNewSession call once usingCommServicesAccessToken is true

Sun, Mar 3, 8:34 PM
ashoat updated the diff for D10972: [lib] Clear sessionRecoveryInProgress during auth / deauth.

Rebase

Sun, Mar 3, 5:48 PM
ashoat updated the diff for D10970: [lib] Dispatch SET_NEW_SESSION when session recovery fails.

Rebase

Sun, Mar 3, 5:48 PM
ashoat updated the diff for D10954: [lib] Move CallKeyserverEndpoint session recovery to KeyserverConnectionHandler.

Use urlPrefixSelector

Sun, Mar 3, 5:45 PM
ashoat added inline comments to D10954: [lib] Move CallKeyserverEndpoint session recovery to KeyserverConnectionHandler.
Sun, Mar 3, 5:42 PM

Sat, Mar 2

ashoat added a reverting change for rCOMM12a56bc91fcf: [native] Temporary changes for staff release: rCOMM025145fc8b16: Revert "[native] Temporary changes for staff release".
Sat, Mar 2, 8:54 AM
ashoat committed rCOMM025145fc8b16: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
Sat, Mar 2, 8:54 AM
ashoat committed rCOMM931f4db6dcd0: [native] codeVersion -> 328 (authored by ashoat).
[native] codeVersion -> 328
Sat, Mar 2, 8:54 AM
ashoat committed rCOMM12a56bc91fcf: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
Sat, Mar 2, 8:54 AM
ashoat committed rCOMM6543d8e4a340: [native] codeVersion -> 327 (authored by ashoat).
[native] codeVersion -> 327
Sat, Mar 2, 8:54 AM
ashoat added a reverting change for rCOMMfaf2ec8553c9: [native] Test changesNotSentForReview: true AGAIN: rCOMM3a5a2fd4f65c: Revert "[native] Test changesNotSentForReview: true AGAIN".
Sat, Mar 2, 8:51 AM
ashoat committed rCOMM3a5a2fd4f65c: Revert "[native] Test changesNotSentForReview: true AGAIN" (authored by ashoat).
Revert "[native] Test changesNotSentForReview: true AGAIN"
Sat, Mar 2, 8:51 AM

Fri, Mar 1

ashoat added a reverting change for rCOMMde0269169bf1: [native] Temporary changes for staff release: rCOMMa4757d294275: Revert "[native] Temporary changes for staff release".
Fri, Mar 1, 4:49 PM
ashoat committed rCOMMa4757d294275: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
Fri, Mar 1, 4:49 PM
ashoat committed rCOMMfdc793a55aac: [native] codeVersion -> 326 (authored by ashoat).
[native] codeVersion -> 326
Fri, Mar 1, 4:49 PM
ashoat committed rCOMMde0269169bf1: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
Fri, Mar 1, 4:49 PM
ashoat committed rCOMM744eacc14c73: [native] codeVersion -> 325 (authored by ashoat).
[native] codeVersion -> 325
Fri, Mar 1, 4:49 PM
ashoat committed rCOMM4aa27479c942: [web][keyserver] codeVersion -> 73 (authored by ashoat).
[web][keyserver] codeVersion -> 73
Fri, Mar 1, 4:45 PM
ashoat accepted D11204: [web][native][keyserver] Flip the switch to enable `specialRole` field.

Just going to accept this to move it off my queue, but in our 1:1 @atul mentioned he still wanted to do some additional testing before landing

Fri, Mar 1, 3:14 PM
ashoat accepted D11207: [web] fix regression in error handling.
Fri, Mar 1, 3:08 PM
ashoat added inline comments to D11204: [web][native][keyserver] Flip the switch to enable `specialRole` field.
Fri, Mar 1, 1:32 PM

Thu, Feb 29

ashoat accepted D11202: [GH Actions] Move Android CI workflows to `macOS`.

Thanks for explaining changes inline

Thu, Feb 29, 3:01 PM
ashoat accepted D11201: [keyserver][native] treat valid eth address as invalid username in non-siwe registration.
Thu, Feb 29, 2:52 PM
ashoat added a comment to D10967: [CI] Use M1 runners for macOS-based GH Actions workflows.

Nice!!

Thu, Feb 29, 2:03 PM
ashoat added a comment to D11198: [web/native] Return null instead of throw new error when incomplete auth metadata.

Thanks!

Thu, Feb 29, 6:48 AM
ashoat accepted D11198: [web/native] Return null instead of throw new error when incomplete auth metadata.

Can you clarify what effects this will have downstream before landing?

Thu, Feb 29, 6:27 AM
ashoat published D11198: [web/native] Return null instead of throw new error when incomplete auth metadata for review.
Thu, Feb 29, 6:26 AM

Tue, Feb 27

ashoat added a comment to D11115: [web] Check backup client wasm integrity buildkite.

It's good practice to "Plan Changes" to take diffs off of your reviewers' queues if they're not ready for review

Tue, Feb 27, 8:53 PM

Mon, Feb 26

ashoat committed rCOMMaea21027b4a8: [web][keyserver] codeVersion -> 72 (authored by ashoat).
[web][keyserver] codeVersion -> 72
Mon, Feb 26, 6:20 PM
ashoat updated the diff for D10972: [lib] Clear sessionRecoveryInProgress during auth / deauth.

Rebase

Mon, Feb 26, 6:15 PM
ashoat updated the diff for D10970: [lib] Dispatch SET_NEW_SESSION when session recovery fails.

Rebase

Mon, Feb 26, 6:15 PM
ashoat updated the diff for D10954: [lib] Move CallKeyserverEndpoint session recovery to KeyserverConnectionHandler.

Rebase

Mon, Feb 26, 6:15 PM
ashoat updated the diff for D10952: [lib] Let keyserver session recovery code handle calling setNewSession.

Rebase

Mon, Feb 26, 6:14 PM
ashoat requested changes to D11159: [DO NOT LAND][web] add @neynar/nodejs-sdk dep.

Is there anything actionable here? Passing back to you to address "DO NOT LAND" status

Mon, Feb 26, 6:12 PM
ashoat added inline comments to D11115: [web] Check backup client wasm integrity buildkite.
Mon, Feb 26, 6:10 PM
ashoat added a comment to D11110: [web] implementing publishing prekeys to Identity.

This part was skipped:

Mon, Feb 26, 6:00 PM

Fri, Feb 23

ashoat updated the diff for D10972: [lib] Clear sessionRecoveryInProgress during auth / deauth.

Rebase

Fri, Feb 23, 2:06 PM
ashoat updated the diff for D10970: [lib] Dispatch SET_NEW_SESSION when session recovery fails.

Rebase

Fri, Feb 23, 2:06 PM
ashoat updated the diff for D10954: [lib] Move CallKeyserverEndpoint session recovery to KeyserverConnectionHandler.

Rebase

Fri, Feb 23, 2:05 PM
ashoat updated the diff for D10952: [lib] Let keyserver session recovery code handle calling setNewSession.

Rebase

Fri, Feb 23, 2:05 PM
ashoat added inline comments to D10858: [native] Notify backup uploader after compaction creation.
Fri, Feb 23, 10:44 AM
ashoat added inline comments to D11154: [crypto] implement prekey rotation in `OlmAPI`.
Fri, Feb 23, 7:46 AM
ashoat added inline comments to D11110: [web] implementing publishing prekeys to Identity.
Fri, Feb 23, 7:45 AM
ashoat added a comment to D11139: [terraform] Add cloudwatch alert for search index lambda failures.

i think we should just use the existing mailing list to avoid having to look through multiple lists to triage errors

Fri, Feb 23, 7:32 AM

Thu, Feb 22

ashoat accepted D11020: [web] use identity wallet login in siwe-login-form.
Thu, Feb 22, 7:44 PM
ashoat accepted D11016: [native] logic for navigating to ExistingEthereumAccount if usingCommServicesAccessToken.
Thu, Feb 22, 7:43 PM
ashoat accepted D11005: [native] use identity wallet login in fullscreen-siwe-panel.
Thu, Feb 22, 7:43 PM
ashoat added a comment to D11109: [native][web] implementing uploading one-time keys in `IdentityServiceClient`.

I think you linked the wrong diff (you linked this one)

Thu, Feb 22, 10:37 AM
ashoat added a comment to D11139: [terraform] Add cloudwatch alert for search index lambda failures.

Sounds good. Please make sure that mailing list is created before landing (I can help with that), and please rename the mailing list to avoid confusion with the existing one

Thu, Feb 22, 7:53 AM
ashoat added inline comments to D11140: [lib] reduce currentUserInfo on identity login/register.
Thu, Feb 22, 7:40 AM
ashoat added a comment to D11139: [terraform] Add cloudwatch alert for search index lambda failures.

We don't have a error-report@comm.app mailing list. Did you mean error-reports@comm.app? Or do you want us to create a new one? If so, please pick a different name... this one is too close

Thu, Feb 22, 7:38 AM
ashoat accepted D11138: [terraform] temporarily reduce identity service desired count.
Thu, Feb 22, 7:37 AM
ashoat committed rCOMMa98e068f44ac: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
Thu, Feb 22, 6:55 AM
ashoat added a reverting change for rCOMMa78619985034: [native] Temporary changes for staff release: rCOMMa98e068f44ac: Revert "[native] Temporary changes for staff release".
Thu, Feb 22, 6:55 AM
ashoat committed rCOMM9d8b8a53c845: [native] codeVersion -> 324 (authored by ashoat).
[native] codeVersion -> 324
Thu, Feb 22, 6:55 AM
ashoat committed rCOMMa78619985034: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
Thu, Feb 22, 6:55 AM
ashoat committed rCOMM98534a7426aa: [native] codeVersion -> 323 (authored by ashoat).
[native] codeVersion -> 323
Thu, Feb 22, 6:55 AM
ashoat committed rCOMMfaf2ec8553c9: [native] Test changesNotSentForReview: true AGAIN (authored by ashoat).
[native] Test changesNotSentForReview: true AGAIN
Thu, Feb 22, 6:55 AM
ashoat added a reverting change for rCOMMd59e0d26e385: [native] Temporary changes for staff release: rCOMMa49992aba081: Revert "[native] Temporary changes for staff release".
Thu, Feb 22, 6:16 AM
ashoat committed rCOMMa49992aba081: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
Thu, Feb 22, 6:16 AM
ashoat committed rCOMMd59e0d26e385: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
Thu, Feb 22, 6:16 AM
ashoat committed rCOMMbcbaa6434735: [native] codeVersion -> 322 (authored by ashoat).
[native] codeVersion -> 322
Thu, Feb 22, 6:16 AM
ashoat committed rCOMMf6b0af1e3405: [native] codeVersion -> 321 (authored by ashoat).
[native] codeVersion -> 321
Thu, Feb 22, 6:16 AM
ashoat committed rCOMM63ab0f761382: [web][keyserver] codeVersion -> 71 (authored by ashoat).
[web][keyserver] codeVersion -> 71
Thu, Feb 22, 6:11 AM
ashoat committed rCOMM035b2cd0ea52: Revert "[native] Test changesNotSentForReview: true" (authored by ashoat).
Revert "[native] Test changesNotSentForReview: true"
Thu, Feb 22, 6:11 AM
ashoat added a reverting change for rCOMMefa2b10aad66: [native] Test changesNotSentForReview: true: rCOMM035b2cd0ea52: Revert "[native] Test changesNotSentForReview: true".
Thu, Feb 22, 6:11 AM

Wed, Feb 21

ashoat committed rCOMM7afbc477c75f: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
Wed, Feb 21, 7:11 PM
ashoat added a reverting change for rCOMMd869777b6bdf: [native] Temporary changes for staff release: rCOMM7afbc477c75f: Revert "[native] Temporary changes for staff release".
Wed, Feb 21, 7:11 PM
ashoat committed rCOMMb5dd3c51e87b: [native] codeVersion -> 320 (authored by ashoat).
[native] codeVersion -> 320
Wed, Feb 21, 7:11 PM
ashoat committed rCOMMd869777b6bdf: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
Wed, Feb 21, 7:11 PM
ashoat committed rCOMM1c4e7340be74: [native] codeVersion -> 319 (authored by ashoat).
[native] codeVersion -> 319
Wed, Feb 21, 5:26 PM
ashoat committed rCOMMefa2b10aad66: [native] Test changesNotSentForReview: true (authored by ashoat).
[native] Test changesNotSentForReview: true
Wed, Feb 21, 5:26 PM
ashoat accepted D11058: [web] [lib] Modify useSearchUsers to include identity search and utilize identity search on web and native.
Wed, Feb 21, 4:35 PM
ashoat resigned from D10938: [lib] Basic implementation of identity search context provider without message sending.

Already reviewed this one – looks like @will wants a review from @atul based on history

Wed, Feb 21, 4:32 PM
ashoat committed rCOMM80354404c30a: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
Wed, Feb 21, 4:28 PM
ashoat added a reverting change for rCOMM937c2649ad2f: [native] Temporary changes for staff release: rCOMM80354404c30a: Revert "[native] Temporary changes for staff release".
Wed, Feb 21, 4:28 PM