ashoat (Ashoat)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since: Jul 20 2020, 9:28 AM (277 w, 4 d)
Roles: Administrator

Recent Activity
View All

Thu, Nov 13

ashoat committed rCOMMe3c418883e1d: [terraform] Bump keyserver image to 1.0.207 (authored by ashoat).

[terraform] Bump keyserver image to 1.0.207

Thu, Nov 13, 11:27 AM

ashoat added a reverting change for rCOMMb376fef9a52e: [native] Temporary changes for staff release: rCOMMcfbe7a93eaf3: Revert "[native] Temporary changes for staff release".

Thu, Nov 13, 10:28 AM

ashoat committed rCOMMcfbe7a93eaf3: Revert "[native] Temporary changes for staff release" (authored by ashoat).

Revert "[native] Temporary changes for staff release"

Thu, Nov 13, 10:28 AM

ashoat committed rCOMMf75fea88b299: [native] codeVersion -> 558 (authored by ashoat).

[native] codeVersion -> 558

Thu, Nov 13, 10:28 AM

ashoat committed rCOMMb376fef9a52e: [native] Temporary changes for staff release (authored by ashoat).

[native] Temporary changes for staff release

Thu, Nov 13, 10:28 AM

ashoat committed rCOMM0af296883ccc: [web][keyserver] codeVersion -> 207 (authored by ashoat).

[web][keyserver] codeVersion -> 207

Thu, Nov 13, 10:28 AM

ashoat committed rCOMM3da74aba262d: [native] codeVersion -> 557 (authored by ashoat).

[native] codeVersion -> 557

Thu, Nov 13, 10:28 AM

Wed, Nov 12

ashoat accepted D15542: [native] add vodozemac to native build on iOS and Android.

Discussed in 1:1; @kamil will follow-up with responses to my comments later

Wed, Nov 12, 7:42 AM

ashoat added inline comments to D15542: [native] add vodozemac to native build on iOS and Android.

Wed, Nov 12, 7:28 AM

Tue, Nov 4

ashoat accepted D15541: [terraform] optimize Fargate resource usage.

Tue, Nov 4, 7:57 AM

Mon, Nov 3

ashoat accepted D15540: [terraform] lower Fargate resource usage on prod.

Mon, Nov 3, 5:56 AM

Fri, Oct 31

ashoat added inline comments to D15539: [terraform] remove EC2 capacity provider from the cluster.

Fri, Oct 31, 10:51 AM

ashoat accepted D15536: [terraform] remove EC2-based infrastructure.

Fri, Oct 31, 10:50 AM

ashoat accepted D15539: [terraform] remove EC2 capacity provider from the cluster.

Fri, Oct 31, 10:50 AM

ashoat accepted D15538: [terraform] remove EC2-based resources.

Fri, Oct 31, 10:50 AM

ashoat accepted D15537: [terraform] remove EC2 targets from load balancers.

Fri, Oct 31, 10:50 AM

ashoat accepted D15535: [lib] Remove a leftover feature flag.

Fri, Oct 31, 5:23 AM

Thu, Oct 30

ashoat accepted D15534: [lib] Upload the Farcaster thread avatars.

Thu, Oct 30, 4:21 PM

ashoat accepted D15533: [lib] Call the Farcaster API to update the avatar.

Thu, Oct 30, 4:21 PM

ashoat accepted D15532: [lib] Add an option to remove avatar to the API.

Thu, Oct 30, 4:21 PM

ashoat accepted D15531: [lib] Introduce the API that allows setting the avatar.

Thu, Oct 30, 4:21 PM

ashoat accepted D15530: [lib] Enable setting all thread avatar types except emoji for Farcaster.

Thu, Oct 30, 4:21 PM

ashoat accepted D15529: [native] Add native_rust_library to NotificationService target.

This one is hard to review... I'm not really familiar with the .pbxproj format. Regarding the notification service limits, I'm not familiar with those either...

Thu, Oct 30, 10:49 AM

ashoat accepted D15528: [native][web][lib] make it possible to manually reset ratchet.

Thu, Oct 30, 8:39 AM

Wed, Oct 29

ashoat committed rCOMMc0c81e9d3cb5: [terraform] Bump keyserver image to 1.0.206 (authored by ashoat).

[terraform] Bump keyserver image to 1.0.206

Wed, Oct 29, 7:57 AM

ashoat added a reverting change for rCOMM604cb430fc52: [native] Temporary changes for staff release: rCOMM8af19b1e4eab: Revert "[native] Temporary changes for staff release".

Wed, Oct 29, 6:50 AM

ashoat committed rCOMM8af19b1e4eab: Revert "[native] Temporary changes for staff release" (authored by ashoat).

Revert "[native] Temporary changes for staff release"

Wed, Oct 29, 6:50 AM

ashoat committed rCOMMbb18b86772da: [native] codeVersion -> 556 (authored by ashoat).

[native] codeVersion -> 556

Wed, Oct 29, 6:50 AM

ashoat committed rCOMM604cb430fc52: [native] Temporary changes for staff release (authored by ashoat).

[native] Temporary changes for staff release

Wed, Oct 29, 6:50 AM

ashoat committed rCOMMd74a5fbaaeb8: [native] codeVersion -> 555 (authored by ashoat).

[native] codeVersion -> 555

Wed, Oct 29, 6:50 AM

ashoat committed rCOMMd20f117880c6: [web][keyserver] codeVersion -> 206 (authored by ashoat).

[web][keyserver] codeVersion -> 206

Wed, Oct 29, 6:50 AM

ashoat committed rCOMMd85be6a99354: [landing] Remove signIn from SIWF effect dep list (authored by ashoat).

[landing] Remove signIn from SIWF effect dep list

Wed, Oct 29, 6:46 AM

Tue, Oct 28

ashoat committed rCOMMdb74eca58aff: [terraform] Bump keyserver image to 1.0.205 (authored by ashoat).

[terraform] Bump keyserver image to 1.0.205

Tue, Oct 28, 7:23 AM

ashoat committed rCOMM35a0026f8acb: Revert "[native] Temporary changes for staff release" (authored by ashoat).

Revert "[native] Temporary changes for staff release"

Tue, Oct 28, 6:52 AM

ashoat added a reverting change for rCOMMe4ea7e652f3f: [native] Temporary changes for staff release: rCOMM35a0026f8acb: Revert "[native] Temporary changes for staff release".

Tue, Oct 28, 6:52 AM

ashoat committed rCOMM471d03b11782: [native] codeVersion -> 554 (authored by ashoat).

[native] codeVersion -> 554

Tue, Oct 28, 6:52 AM

ashoat committed rCOMMe4ea7e652f3f: [native] Temporary changes for staff release (authored by ashoat).

[native] Temporary changes for staff release

Tue, Oct 28, 6:52 AM

ashoat committed rCOMM3b655de52293: [native] codeVersion -> 553 (authored by ashoat).

[native] codeVersion -> 553

Tue, Oct 28, 6:51 AM

ashoat committed rCOMM3d7add3e1229: [web][keyserver] codeVersion -> 205 (authored by ashoat).

[web][keyserver] codeVersion -> 205

Tue, Oct 28, 6:51 AM

Fri, Oct 24

ashoat accepted D15523: [lib] Log an error when pinning messages fails.

Fri, Oct 24, 11:43 AM

ashoat added inline comments to D15522: [lib] Determine thick sidebar title.

Fri, Oct 24, 11:42 AM

ashoat committed rCOMM8a8611d1eeb7: [terraform] Bump keyserver image to 1.0.204 (authored by ashoat).

[terraform] Bump keyserver image to 1.0.204

Fri, Oct 24, 10:52 AM

Thu, Oct 23

ashoat added a reverting change for rCOMMeefd246a1a21: [native] Temporary changes for staff release: rCOMM04770053ca01: Revert "[native] Temporary changes for staff release".

Thu, Oct 23, 2:08 PM

ashoat committed rCOMM04770053ca01: Revert "[native] Temporary changes for staff release" (authored by ashoat).

Revert "[native] Temporary changes for staff release"

Thu, Oct 23, 2:08 PM

ashoat committed rCOMM0fd1f4da8b3d: [native] codeVersion -> 552 (authored by ashoat).

[native] codeVersion -> 552

Thu, Oct 23, 2:08 PM

ashoat committed rCOMMeefd246a1a21: [native] Temporary changes for staff release (authored by ashoat).

[native] Temporary changes for staff release

Thu, Oct 23, 2:08 PM

ashoat committed rCOMM0292b51d9858: [native] codeVersion -> 551 (authored by ashoat).

[native] codeVersion -> 551

Thu, Oct 23, 2:08 PM

ashoat committed rCOMM9bb3f15da06e: [web][keyserver] codeVersion -> 204 (authored by ashoat).

[web][keyserver] codeVersion -> 204

Thu, Oct 23, 2:08 PM

ashoat committed rCOMMab6ec57d1bb9: [lib] Unbreak pending threads (authored by ashoat).

[lib] Unbreak pending threads

Thu, Oct 23, 2:08 PM

ashoat committed rCOMMd7ae0aa2dafc: [terraform] Bump keyserver image to 1.0.203 (authored by ashoat).

[terraform] Bump keyserver image to 1.0.203

Thu, Oct 23, 12:20 PM

ashoat added a reverting change for rCOMM52a2a28c0127: [native] Temporary changes for staff release: rCOMM9c55ceed845e: Revert "[native] Temporary changes for staff release".

Thu, Oct 23, 9:32 AM

ashoat committed rCOMM9c55ceed845e: Revert "[native] Temporary changes for staff release" (authored by ashoat).

Revert "[native] Temporary changes for staff release"

Thu, Oct 23, 9:32 AM

ashoat committed rCOMM7e5280e72ebc: [native] codeVersion -> 550 (authored by ashoat).

[native] codeVersion -> 550

Thu, Oct 23, 9:32 AM

ashoat committed rCOMM52a2a28c0127: [native] Temporary changes for staff release (authored by ashoat).

[native] Temporary changes for staff release

Thu, Oct 23, 9:32 AM

ashoat committed rCOMMb62ce70b8434: [native] codeVersion -> 549 (authored by ashoat).

[native] codeVersion -> 549

Thu, Oct 23, 9:32 AM

ashoat committed rCOMM53a804bfc5d4: [web][keyserver] codeVersion -> 203 (authored by ashoat).

[web][keyserver] codeVersion -> 203

Thu, Oct 23, 9:32 AM

ashoat closed D15516: [lib] Fix extractIDsFromPayload for tShapeInexact.

Thu, Oct 23, 8:18 AM

ashoat committed rCOMM9957c5e7a2c8: [lib] Fix extractIDsFromPayload for tShapeInexact (authored by ashoat).

[lib] Fix extractIDsFromPayload for tShapeInexact

Thu, Oct 23, 8:18 AM

ashoat added a comment to D15512: Revert "[lib] Remove unnecessary Farcaster props".

Makes sense!

Thu, Oct 23, 8:08 AM

ashoat added a comment to D15512: Revert "[lib] Remove unnecessary Farcaster props".

D15516 fixes the issue I was referring to.

Thu, Oct 23, 7:35 AM

ashoat published D15516: [lib] Fix extractIDsFromPayload for tShapeInexact for review.

Thu, Oct 23, 7:34 AM

ashoat added a comment to D15512: Revert "[lib] Remove unnecessary Farcaster props".

Here's a failing unit test: https://linear.app/comm/issue/ENG-11509/messages-appear-as-if-from-wrong-user#comment-94575408

Thu, Oct 23, 7:22 AM

ashoat requested changes to D15512: Revert "[lib] Remove unnecessary Farcaster props".

We have an object that looks like this:

Thu, Oct 23, 7:14 AM

ashoat added a comment to D15504: [native][web] Improve the pin modals.

These buttons not having a loading status was a pet peeve of mine. Thanks for fixing!

Thu, Oct 23, 7:12 AM

ashoat requested changes to D15512: Revert "[lib] Remove unnecessary Farcaster props".

I am skeptical of this approach. The core issue is that our FID extraction breaks when unexpected object fields are encountered. What happens if Farcaster introducing a new object field? Won’t the same issue occur? I think we need to fix the core issue instead of reverting this. Let me know if I’m missing something.

Thu, Oct 23, 5:16 AM

Wed, Oct 22

ashoat committed rCOMM94f8f6158d74: [terraform] Bump keyserver image to 1.0.202 (authored by ashoat).

[terraform] Bump keyserver image to 1.0.202

Wed, Oct 22, 9:15 AM

ashoat added a reverting change for rCOMM47e1b163459f: [native] Temporary changes for staff release: rCOMMdd9a512bb045: Revert "[native] Temporary changes for staff release".

Wed, Oct 22, 8:20 AM

ashoat committed rCOMMdd9a512bb045: Revert "[native] Temporary changes for staff release" (authored by ashoat).

Revert "[native] Temporary changes for staff release"

Wed, Oct 22, 8:20 AM

ashoat committed rCOMM21757f813957: [native] codeVersion -> 548 (authored by ashoat).

[native] codeVersion -> 548

Wed, Oct 22, 8:20 AM

ashoat committed rCOMM47e1b163459f: [native] Temporary changes for staff release (authored by ashoat).

[native] Temporary changes for staff release

Wed, Oct 22, 8:20 AM

ashoat committed rCOMMa7f2cd42f40c: [native] codeVersion -> 547 (authored by ashoat).

[native] codeVersion -> 547

Wed, Oct 22, 8:20 AM

ashoat committed rCOMM1ffeeb5df389: [web][keyserver] codeVersion -> 202 (authored by ashoat).

[web][keyserver] codeVersion -> 202

Wed, Oct 22, 8:20 AM

ashoat committed rCOMM36bee0d6222a: [native] Fix ThemeHandler overwriting theme data from client DB on app start (authored by ashoat).

[native] Fix ThemeHandler overwriting theme data from client DB on app start

Wed, Oct 22, 8:16 AM

Tue, Oct 21

ashoat committed rCOMM4a76f3308fbb: [native] Fix TextInput positioning in Entry and focus jitter on iOS (authored by ashoat).

[native] Fix TextInput positioning in Entry and focus jitter on iOS

Tue, Oct 21, 11:08 PM

Mon, Oct 20

ashoat committed rCOMMf6d32a1d8dd6: [native] Fix double-tap-to-zoom in FullScreenViewModal (authored by ashoat).

[native] Fix double-tap-to-zoom in FullScreenViewModal

Mon, Oct 20, 10:19 PM

ashoat committed rCOMM503cc7c68b83: [landing][lib][native] Update Farcaster logos (authored by ashoat).

[landing][lib][native] Update Farcaster logos

Mon, Oct 20, 10:19 PM

ashoat added a comment to D15494: [terraform] fix gRPC on web with Fargate instance.

We need this for CORS requests

Mon, Oct 20, 7:42 AM

ashoat accepted D15495: [terraform] route network to Fargate services.

Mon, Oct 20, 7:20 AM

ashoat accepted D15494: [terraform] fix gRPC on web with Fargate instance.

Mon, Oct 20, 6:03 AM

Sun, Oct 19

ashoat committed rCOMM6b54aaf1e8b6: [terraform] Bump keyserver image to 1.0.201 (authored by ashoat).

[terraform] Bump keyserver image to 1.0.201

Sun, Oct 19, 8:31 PM

ashoat committed rCOMM55650025d3b1: Revert "[native] Temporary changes for staff release" (authored by ashoat).

Revert "[native] Temporary changes for staff release"

Sun, Oct 19, 7:50 PM

ashoat added a reverting change for rCOMM74474a470d43: [native] Temporary changes for staff release: rCOMM55650025d3b1: Revert "[native] Temporary changes for staff release".

Sun, Oct 19, 7:50 PM

ashoat committed rCOMM957670973030: [native] codeVersion -> 546 (authored by ashoat).

[native] codeVersion -> 546

Sun, Oct 19, 7:50 PM

ashoat committed rCOMM74474a470d43: [native] Temporary changes for staff release (authored by ashoat).

[native] Temporary changes for staff release

Sun, Oct 19, 7:50 PM

ashoat committed rCOMM5a2f33142e34: [native] codeVersion -> 545 (authored by ashoat).

[native] codeVersion -> 545

Sun, Oct 19, 7:50 PM

ashoat committed rCOMM77a8ce97c638: [web][keyserver] codeVersion -> 201 (authored by ashoat).

[web][keyserver] codeVersion -> 201

Sun, Oct 19, 7:50 PM

ashoat closed D15493: [native] Fix GestureTouchableOpacity reset.

Sun, Oct 19, 7:42 PM

ashoat closed D15492: [native] Fix SwipeableMessage reset.

Sun, Oct 19, 7:42 PM

ashoat committed rCOMM98d163cdbfac: [native] Fix GestureTouchableOpacity reset (authored by ashoat).

[native] Fix GestureTouchableOpacity reset

Sun, Oct 19, 7:42 PM

ashoat committed rCOMM5519725140a6: [native] Fix SwipeableMessage reset (authored by ashoat).

[native] Fix SwipeableMessage reset

Sun, Oct 19, 7:42 PM

ashoat closed D15491: [native] Imperatively refresh lifecycleState.

Sun, Oct 19, 7:42 PM

ashoat committed rCOMM5c2ffc6d9ff7: [native] Imperatively refresh lifecycleState (authored by ashoat).

[native] Imperatively refresh lifecycleState

Sun, Oct 19, 7:42 PM

ashoat requested review of D15493: [native] Fix GestureTouchableOpacity reset.

Sun, Oct 19, 7:40 PM

ashoat requested review of D15492: [native] Fix SwipeableMessage reset.

Sun, Oct 19, 7:38 PM

Sat, Oct 18

ashoat requested review of D15491: [native] Imperatively refresh lifecycleState.

Sat, Oct 18, 4:02 PM

ashoat committed rCOMMf17242243bb0: [lib] Avoid simultaneous runs of handleFarcasterMutuals (authored by ashoat).

[lib] Avoid simultaneous runs of handleFarcasterMutuals

Sat, Oct 18, 3:38 PM

Fri, Oct 17

ashoat closed D15486: [native] Prevent race condition where UserData is missing in full backup.

Fri, Oct 17, 9:40 AM

ashoat committed rCOMM9411bedb0184: [native] Prevent race condition where UserData is missing in full backup (authored by ashoat).

[native] Prevent race condition where UserData is missing in full backup

Fri, Oct 17, 9:40 AM

ashoat added a comment to D15486: [native] Prevent race condition where UserData is missing in full backup.

Going to land this as-is, but would appreciate a re-review from @kamil on Monday to make sure the changes address his concern

Fri, Oct 17, 9:38 AM

ashoat updated the diff for D15486: [native] Prevent race condition where UserData is missing in full backup.

Good call! I asked Codex to address the concern, and it added an early exit to compaction.upload_files when the user_data is present but the user_keys is missing

Fri, Oct 17, 9:29 AM