Page MenuHomePhabricator

ashoat (Ashoat)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jul 20 2020, 9:28 AM (209 w, 4 d)
Roles
Administrator

Recent Activity

Tue, Jul 23

ashoat closed D12839: [lib][native][web] Introduce threadTypeIsSidebar.
Tue, Jul 23, 4:37 AM
ashoat committed rCOMMde39c3067550: [lib][native][web] Introduce threadTypeIsSidebar (authored by ashoat).
[lib][native][web] Introduce threadTypeIsSidebar
Tue, Jul 23, 4:37 AM
ashoat added inline comments to D12839: [lib][native][web] Introduce threadTypeIsSidebar.
Tue, Jul 23, 4:36 AM

Mon, Jul 22

ashoat accepted D12849: [terraform] Avoid including Terraform *.tfstate.backup in keyserver docker images.
Mon, Jul 22, 5:56 PM
ashoat published D12849: [terraform] Avoid including Terraform *.tfstate.backup in keyserver docker images for review.
Mon, Jul 22, 5:56 PM
ashoat committed rCOMM6ddf2218c2cf: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
Mon, Jul 22, 5:06 PM
ashoat added a reverting change for rCOMMe84ede4cf70e: [native] Temporary changes for staff release: rCOMM6ddf2218c2cf: Revert "[native] Temporary changes for staff release".
Mon, Jul 22, 5:06 PM
ashoat committed rCOMM9a04a3c5ac2b: [native] codeVersion -> 380 (authored by ashoat).
[native] codeVersion -> 380
Mon, Jul 22, 5:06 PM
ashoat committed rCOMMa0dc0a17254d: Revert "[lib] Temporarily flip usingCommServicesAccessToken to false" (authored by ashoat).
Revert "[lib] Temporarily flip usingCommServicesAccessToken to false"
Mon, Jul 22, 5:06 PM
ashoat added a reverting change for rCOMMf1b5e30a202d: [lib] Temporarily flip usingCommServicesAccessToken to false: rCOMMa0dc0a17254d: Revert "[lib] Temporarily flip usingCommServicesAccessToken to false".
Mon, Jul 22, 5:06 PM
ashoat committed rCOMMe84ede4cf70e: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
Mon, Jul 22, 5:06 PM
ashoat committed rCOMM2d71750bfac3: [native] codeVersion -> 379 (authored by ashoat).
[native] codeVersion -> 379
Mon, Jul 22, 5:06 PM
ashoat committed rCOMM07c81348f4ed: [web][keyserver] codeVersion -> 102 (authored by ashoat).
[web][keyserver] codeVersion -> 102
Mon, Jul 22, 5:06 PM
ashoat committed rCOMMf1b5e30a202d: [lib] Temporarily flip usingCommServicesAccessToken to false (authored by ashoat).
[lib] Temporarily flip usingCommServicesAccessToken to false
Mon, Jul 22, 5:06 PM
ashoat committed rCOMM5c7f994b92c1: [keyserver] Update NEXT_CODE_VERSION (authored by ashoat).
[keyserver] Update NEXT_CODE_VERSION
Mon, Jul 22, 5:06 PM
ashoat closed D12823: [terraform] Avoid including Terraform state and secrets in keyserver Docker images.
Mon, Jul 22, 1:55 PM
ashoat committed rCOMMf1d9ec893762: [terraform] Avoid including Terraform state and secrets in keyserver Docker… (authored by ashoat).
[terraform] Avoid including Terraform state and secrets in keyserver Docker…
Mon, Jul 22, 1:55 PM
ashoat added inline comments to D12694: [native](web) Add message_search fts5 table.
Mon, Jul 22, 1:53 PM
ashoat added inline comments to D12778: [native] Add SQLiteQueryExecutor code for inserting into the search table.
Mon, Jul 22, 1:52 PM
ashoat accepted D12847: [keyserver] only run keyserver cron jobs if primary node besides geoip cron job.
Mon, Jul 22, 1:51 PM
ashoat accepted D12846: [keyserver] move `isPrimaryNode` to keyserver utils.
Mon, Jul 22, 1:51 PM
ashoat accepted D12848: [nix] revert nix watchman to use brew.

Before we land this, let's see if we can solve it for @marcin some other way

Mon, Jul 22, 1:49 PM
ashoat added a comment to D12836: Patch localforage to support transactional multiple items retrieval/persistence.

Even if we don't use localforage in our code outside of web, this patch probably affects some transitive dependencies for other projects. It looks like it's backwards-compatible, so it should be safe. But we face some trouble at a later point if a transitive dependency upgrades it version, depending on which package Yarn hoists to the workspace root, and how patch-package handles it when multiple versions of a package are present (does it patch all of them, or only the one at the workspace root?)

Mon, Jul 22, 11:01 AM
ashoat added inline comments to D12835: [lib] DMOperationSpec for add members operation.
Mon, Jul 22, 10:58 AM
ashoat added a comment to D12806: [lib] DMOperationSpec for reaction operation.

I wonder if we should have a separate task for updating the replies count. I don't think I contemplated it in sendTextMessageSpec

Mon, Jul 22, 10:56 AM
ashoat added a reviewer for D12823: [terraform] Avoid including Terraform state and secrets in keyserver Docker images: varun.
Mon, Jul 22, 10:49 AM
ashoat requested review of D12823: [terraform] Avoid including Terraform state and secrets in keyserver Docker images.

Looks like CommTest passes – would love to get another accept from either reviewer before landing, to confirm that this new strategy seems safe

Mon, Jul 22, 10:49 AM
ashoat updated the diff for D12823: [terraform] Avoid including Terraform state and secrets in keyserver Docker images.

Try ignoring all *.tfstate and *.tfvars files

Mon, Jul 22, 10:31 AM
ashoat closed D12829: [lib] Specify messageID in sendTextMessageSpec.
Mon, Jul 22, 9:29 AM
ashoat closed D12828: [lib] Make sure thick threads starts out with startReached.
Mon, Jul 22, 9:29 AM
ashoat committed rCOMM3980d47ad71f: [lib] Specify messageID in sendTextMessageSpec (authored by ashoat).
[lib] Specify messageID in sendTextMessageSpec
Mon, Jul 22, 9:29 AM
ashoat committed rCOMMa41c34b166ba: [lib] Make sure thick threads starts out with startReached (authored by ashoat).
[lib] Make sure thick threads starts out with startReached
Mon, Jul 22, 9:29 AM
ashoat closed D12827: [lib] Reduce duplication in message-types.js.
Mon, Jul 22, 9:29 AM
ashoat committed rCOMMfa1d5228f1a2: [lib] Reduce duplication in message-types.js (authored by ashoat).
[lib] Reduce duplication in message-types.js
Mon, Jul 22, 9:29 AM
ashoat closed D12826: [native][web] Allow sending custom encrypted message via Tunnelbroker test interface.
Mon, Jul 22, 9:29 AM
ashoat committed rCOMMaab11d8c5bd0: [native][web] Allow sending custom encrypted message via Tunnelbroker test… (authored by ashoat).
[native][web] Allow sending custom encrypted message via Tunnelbroker test…
Mon, Jul 22, 9:29 AM
ashoat closed D12825: [lib] Turn on notifs by default for thick threads.
Mon, Jul 22, 9:29 AM
ashoat closed D12824: [keyserver][lib] Factor out joinThreadSubscription.
Mon, Jul 22, 9:29 AM
ashoat committed rCOMM154a1437e81b: [lib] Turn on notifs by default for thick threads (authored by ashoat).
[lib] Turn on notifs by default for thick threads
Mon, Jul 22, 9:29 AM
ashoat committed rCOMM82b5866a1c9a: [keyserver][lib] Factor out joinThreadSubscription (authored by ashoat).
[keyserver][lib] Factor out joinThreadSubscription
Mon, Jul 22, 9:29 AM
ashoat closed D12781: [lib] Reduce new PROCESS_DM_OPS action.
Mon, Jul 22, 9:29 AM
ashoat committed rCOMM918067cb29cc: [lib] Reduce new PROCESS_DM_OPS action (authored by ashoat).
[lib] Reduce new PROCESS_DM_OPS action
Mon, Jul 22, 9:29 AM
ashoat closed D12780: [lib] Introduce new PROCESS_DM_OPS action and dispatch from useProcessDMOperation.
Mon, Jul 22, 9:29 AM
ashoat committed rCOMM3c47a8d7ae20: [lib] Introduce new PROCESS_DM_OPS action and dispatch from… (authored by ashoat).
[lib] Introduce new PROCESS_DM_OPS action and dispatch from…
Mon, Jul 22, 9:29 AM
ashoat closed D12741: [lib] Process DMOperations when received from peers via Tunnelbroker.
Mon, Jul 22, 9:29 AM
ashoat committed rCOMM2549b6da2a11: [lib] Process DMOperations when received from peers via Tunnelbroker (authored by ashoat).
[lib] Process DMOperations when received from peers via Tunnelbroker
Mon, Jul 22, 9:29 AM
ashoat closed D12764: [lib] Introduce useGetLatestMessageEdit.
Mon, Jul 22, 9:29 AM
ashoat committed rCOMMb3bca293c632: [lib] Introduce useGetLatestMessageEdit (authored by ashoat).
[lib] Introduce useGetLatestMessageEdit
Mon, Jul 22, 9:29 AM
ashoat added inline comments to D12823: [terraform] Avoid including Terraform state and secrets in keyserver Docker images.
Mon, Jul 22, 9:25 AM
ashoat requested review of D12839: [lib][native][web] Introduce threadTypeIsSidebar.
Mon, Jul 22, 8:21 AM
ashoat added inline comments to D12655: [lib] DMOperationSpec for SEND_TEXT_MESSAGE operation.
Mon, Jul 22, 8:04 AM
ashoat added a comment to D12764: [lib] Introduce useGetLatestMessageEdit.

It makes sense for the sidebar creation use case that I designed for, which is where this hook will be used. I don't think you'll want to use this particular hook, but I can see how for the search use case, it might make sense to replace getRelatedMessages with an API that can query a batch of message IDs at once. I haven't considered the performance implications here – would be good for you and @kamil to consider this, and make a decision on whether the API needs to be replaced

Mon, Jul 22, 8:03 AM

Sun, Jul 21

ashoat added inline comments to D12781: [lib] Reduce new PROCESS_DM_OPS action.
Sun, Jul 21, 10:19 PM
ashoat updated the test plan for D12781: [lib] Reduce new PROCESS_DM_OPS action.
Sun, Jul 21, 10:16 PM
ashoat updated the test plan for D12780: [lib] Introduce new PROCESS_DM_OPS action and dispatch from useProcessDMOperation.
Sun, Jul 21, 10:16 PM
ashoat updated the test plan for D12741: [lib] Process DMOperations when received from peers via Tunnelbroker.
Sun, Jul 21, 10:16 PM
ashoat resigned from D12819: [identity] redact_sensitive_data config.

Looks good but would prefer somebody with Terraform / Rust experience reviewed

Sun, Jul 21, 10:15 PM
ashoat accepted D12822: [terraform] bump staging identity to 0.32-staging.
Sun, Jul 21, 10:10 PM
ashoat resigned from D12820: [identity] use redact_sensitive_data config to redact sensitive data in logs.

Generally makes sense to me, but would be good for one of the Rust people to review

Sun, Jul 21, 10:09 PM
ashoat requested review of D12825: [lib] Turn on notifs by default for thick threads.
Sun, Jul 21, 12:54 AM

Sat, Jul 20

ashoat requested review of D12826: [native][web] Allow sending custom encrypted message via Tunnelbroker test interface.
Sat, Jul 20, 11:08 PM
ashoat requested review of D12828: [lib] Make sure thick threads starts out with startReached.
Sat, Jul 20, 10:20 PM
ashoat requested review of D12829: [lib] Specify messageID in sendTextMessageSpec.
Sat, Jul 20, 10:20 PM
ashoat requested review of D12827: [lib] Reduce duplication in message-types.js.
Sat, Jul 20, 9:58 PM
ashoat requested review of D12824: [keyserver][lib] Factor out joinThreadSubscription.
Sat, Jul 20, 9:36 PM
ashoat requested review of D12823: [terraform] Avoid including Terraform state and secrets in keyserver Docker images.
Sat, Jul 20, 7:27 PM
ashoat accepted D12811: [native] Flip the switch to strip member permissions from `native`.
Sat, Jul 20, 9:58 AM
ashoat accepted D12821: [terraform] make allowed_ip a list of valid ips.
Sat, Jul 20, 12:00 AM

Fri, Jul 19

ashoat accepted D12818: [identity] remove user ID from "no device list" log.
Fri, Jul 19, 10:58 PM
ashoat accepted D12817: [terraform] upgrade self host image to 1.0.101.
Fri, Jul 19, 10:20 PM
ashoat accepted D12813: [terraform] add webapp, landing domains and rename keyserver domain variables.
Fri, Jul 19, 10:10 PM
ashoat accepted D12815: [terraform] landing terraform config.

Same feedback as D12814

Fri, Jul 19, 10:10 PM
ashoat updated subscribers of D12814: [terraform] webapp terraform config.

Don't love all the copy-paste here. Let's create a follow-up task to ask @bartek if there's a way to reduce it

Fri, Jul 19, 10:10 PM
ashoat accepted D12814: [terraform] webapp terraform config.
Fri, Jul 19, 10:01 PM
ashoat added a reverting change for rCOMM4f446cdf622e: [native] Temporary changes for staff release: rCOMMef01f2fbdb73: Revert "[native] Temporary changes for staff release".
Fri, Jul 19, 9:03 PM
ashoat committed rCOMMef01f2fbdb73: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
Fri, Jul 19, 9:03 PM
ashoat committed rCOMM787710c803b4: [native] codeVersion -> 378 (authored by ashoat).
[native] codeVersion -> 378
Fri, Jul 19, 9:03 PM
ashoat added a reverting change for rCOMM280b22427100: [lib] Temporarily flip usingCommServicesAccessToken to false: rCOMM07d73f8177c9: Revert "[lib] Temporarily flip usingCommServicesAccessToken to false".
Fri, Jul 19, 9:03 PM
ashoat committed rCOMM4f446cdf622e: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
Fri, Jul 19, 9:03 PM
ashoat committed rCOMM07d73f8177c9: Revert "[lib] Temporarily flip usingCommServicesAccessToken to false" (authored by ashoat).
Revert "[lib] Temporarily flip usingCommServicesAccessToken to false"
Fri, Jul 19, 9:03 PM
ashoat committed rCOMM2b6fd5af1171: [native] codeVersion -> 377 (authored by ashoat).
[native] codeVersion -> 377
Fri, Jul 19, 9:03 PM
ashoat committed rCOMM1828c38a9e66: [web][keyserver] codeVersion -> 101 (authored by ashoat).
[web][keyserver] codeVersion -> 101
Fri, Jul 19, 9:03 PM
ashoat committed rCOMM280b22427100: [lib] Temporarily flip usingCommServicesAccessToken to false (authored by ashoat).
[lib] Temporarily flip usingCommServicesAccessToken to false
Fri, Jul 19, 9:03 PM
ashoat closed D12816: Don't include .env files from self-host directory in Docker images.
Fri, Jul 19, 8:58 PM
ashoat committed rCOMMd5936957548b: Don't include .env files from self-host directory in Docker images (authored by ashoat).
Don't include .env files from self-host directory in Docker images
Fri, Jul 19, 8:58 PM
ashoat published D12816: Don't include .env files from self-host directory in Docker images for review.
Fri, Jul 19, 8:56 PM
ashoat accepted D12810: [keyserver] run webapp, landing, and keyserver conditionally.
Fri, Jul 19, 8:32 PM
ashoat accepted D12812: [terraform] run keyserver isolated from webapp and landing.
Fri, Jul 19, 8:30 PM
ashoat accepted D12808: [keyserver] remove unnecessary inviteResponder line in keyserver.js.

Looks like some context in D8255... web doesn't really need this route, landing definitely does, and it's not clear if it's needed at the root either. I think it's fine to remove given we'll be running landing on the apex domain

Fri, Jul 19, 8:30 PM
ashoat added a reviewer for D12808: [keyserver] remove unnecessary inviteResponder line in keyserver.js: tomek.
Fri, Jul 19, 8:27 PM
ashoat added inline comments to D12734: [lib] add device type to qr code URL.
Fri, Jul 19, 10:14 AM
ashoat added a comment to D12795: [native] Add message search store.

Don't forget to add to CMake!

Fri, Jul 19, 10:08 AM
ashoat added inline comments to D12778: [native] Add SQLiteQueryExecutor code for inserting into the search table.
Fri, Jul 19, 7:28 AM
ashoat added a comment to D12694: [native](web) Add message_search fts5 table.

Could you update the spacing to match the rest of the file?

Fri, Jul 19, 7:26 AM

Thu, Jul 18

ashoat added a comment to D12800: [terraform] use `.env` in self-host folder for keyserver config variables instead of specifying values in terraform.tfvars or terraform.tfvars.json.

Lovely! Forgot that we don't use COMM_JSONCONFIG for the MariaDB config in the Docker configuration. I think we initially made this decision because it made it easier to access them from our Docker Compose config. Seems like there's a similar benefit for making it easy to access from the Terraform config.

Thu, Jul 18, 6:16 PM
ashoat added a reverting change for rCOMMf8e6de8d80e5: [native] Temporary changes for staff release: rCOMMb19af1b35ef7: Revert "[native] Temporary changes for staff release".
Thu, Jul 18, 6:12 PM
ashoat committed rCOMMb19af1b35ef7: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
Thu, Jul 18, 6:12 PM
ashoat committed rCOMM7b565b0d66b5: [native] codeVersion -> 376 (authored by ashoat).
[native] codeVersion -> 376
Thu, Jul 18, 6:12 PM
ashoat added a reverting change for rCOMMb09298a6156a: [lib] Temporarily flip usingCommServicesAccessToken to false: rCOMM4c677f9c4c16: Revert "[lib] Temporarily flip usingCommServicesAccessToken to false".
Thu, Jul 18, 6:12 PM
ashoat committed rCOMM4c677f9c4c16: Revert "[lib] Temporarily flip usingCommServicesAccessToken to false" (authored by ashoat).
Revert "[lib] Temporarily flip usingCommServicesAccessToken to false"
Thu, Jul 18, 6:12 PM