User Details
- User Since
- Jul 20 2020, 9:28 AM (150 w, 3 d)
- Roles
- Administrator
Today
Yesterday
Add failing test case
I think we need some way to authenticate this request. We can't use the access token until keyservers are able to register with the identity service, which is still several weeks away. In yesterday's 1:1, you and I had talked about using a signed message for this, similar to how RegisterReservedPasswordUserStart works. To make that work we'd have to change the .proto here, though. What do you think?
Tue, Jun 6
(should we "singularize" "Members" and "Admins" so it appears as "Member" and "Admin"?)
This is cool – our first HostObject!
Okay, cool. I'm a bit worried that in the future we might introduce an "admin" role for a channel in a community, and in that scenario this code would break ThreadSettingsLeaveThread's usage of otherUsersButNoOtherAdmins. But I guess we can address that when we get there...
Ping on this review
Mon, Jun 5
@inka heads-up, your upload doesn't appear to have attached
Sun, Jun 4
Fri, Jun 2
This diff makes sense, but from a code search it looks like it might impact ThreadSettingsLeaveThread and its use of otherUsersButNoOtherAdmins.
Thu, Jun 1
Back to you with questions: