Page MenuHomePhabricator

ashoat (Ashoat)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jul 20 2020, 9:28 AM (150 w, 3 d)
Roles
Administrator

Recent Activity

Today

ashoat requested review of D8154: [native] Add cached user selection state into RegistrationContext.
Thu, Jun 8, 1:37 PM
ashoat committed rCOMM446c6f2697f5: [web] `codeVersion` -> 2 (authored by ashoat).
[web] `codeVersion` -> 2
Thu, Jun 8, 1:24 PM
ashoat requested review of D8152: [native] Set user avatar after registering in registration flow.
Thu, Jun 8, 7:27 AM
ashoat requested review of D8149: [native] Introduce code to call keyserver for registration in new flow.
Thu, Jun 8, 7:25 AM
ashoat requested review of D8153: [native] Update registrationMode from state to ref.
Thu, Jun 8, 7:17 AM
ashoat requested review of D8151: [native] Don't show loading spinner during avatar server call in registration screen.
Thu, Jun 8, 7:12 AM
ashoat requested review of D8150: [native] Make callback param optional in useUploadSelectedMedia avatar hook.
Thu, Jun 8, 7:12 AM
ashoat requested review of D8148: [native] Introduce RegistrationContext.
Thu, Jun 8, 7:10 AM
ashoat added inline comments to D8067: [web] Refactor the members modal to support any variety of role labels.
Thu, Jun 8, 6:33 AM
ashoat added inline comments to D8136: [web] Implement a custom dropdown menu component.
Thu, Jun 8, 6:27 AM

Yesterday

ashoat accepted D8142: [lib] Update robotext for role changes.
Wed, Jun 7, 2:18 PM
ashoat added inline comments to D8141: [web] Prevent changing the only admin role in a community.
Wed, Jun 7, 2:17 PM
ashoat added inline comments to D8140: [web] Add functionality on save to actually change a member's role.
Wed, Jun 7, 2:16 PM
ashoat added inline comments to D8136: [web] Implement a custom dropdown menu component.
Wed, Jun 7, 2:13 PM
ashoat added inline comments to D8118: [web-db] add `extractable` param while creating crypto key.
Wed, Jun 7, 2:07 PM
ashoat closed D8147: [lib] Unify duplicated avatar tcomb validators.
Wed, Jun 7, 2:05 PM
ashoat closed D8146: [lib] Use RegExp.source instead of RegExp.toString() in emojis.js.
Wed, Jun 7, 2:05 PM
ashoat committed rCOMM375f45edc017: [lib] Unify duplicated avatar tcomb validators (authored by ashoat).
[lib] Unify duplicated avatar tcomb validators
Wed, Jun 7, 2:05 PM
ashoat committed rCOMM5423a97b4deb: [lib] Use RegExp.source instead of RegExp.toString() in emojis.js (authored by ashoat).
[lib] Use RegExp.source instead of RegExp.toString() in emojis.js
Wed, Jun 7, 2:05 PM
ashoat closed D8145: [lib] Make sure all default emojis pass onlyOneEmojiRegex.
Wed, Jun 7, 2:05 PM
ashoat committed rCOMM746427b642ba: [lib] Make sure all default emojis pass onlyOneEmojiRegex (authored by ashoat).
[lib] Make sure all default emojis pass onlyOneEmojiRegex
Wed, Jun 7, 2:05 PM
ashoat updated the diff for D8145: [lib] Make sure all default emojis pass onlyOneEmojiRegex.

Add failing test case

Wed, Jun 7, 2:03 PM
ashoat updated the summary of D8145: [lib] Make sure all default emojis pass onlyOneEmojiRegex.
Wed, Jun 7, 2:00 PM
ashoat requested review of D8147: [lib] Unify duplicated avatar tcomb validators.
Wed, Jun 7, 12:51 PM
ashoat requested review of D8146: [lib] Use RegExp.source instead of RegExp.toString() in emojis.js.
Wed, Jun 7, 12:51 PM
ashoat requested review of D8145: [lib] Make sure all default emojis pass onlyOneEmojiRegex.
Wed, Jun 7, 12:51 PM
ashoat requested changes to D8133: [identity] introduce RPC to update reserved usernames list.

I think we need some way to authenticate this request. We can't use the access token until keyservers are able to register with the identity service, which is still several weeks away. In yesterday's 1:1, you and I had talked about using a signed message for this, similar to how RegisterReservedPasswordUserStart works. To make that work we'd have to change the .proto here, though. What do you think?

Wed, Jun 7, 12:46 PM
ashoat accepted D8131: Flip the switch to enable community creation.
Wed, Jun 7, 12:40 PM
ashoat requested changes to D8126: [Protos] Update uploadOneTimeKeys to include device info and both sets of keys.
Wed, Jun 7, 12:40 PM
ashoat accepted D8130: [native] Navigate to newly created community after successful creation.
Wed, Jun 7, 12:36 PM
ashoat accepted D8129: [native] Introduce `addSelectedUsersToCommunity` to `CommunityCreationMembers`.
Wed, Jun 7, 12:35 PM
ashoat accepted D8122: [native] Pass `threadID` of newly created community to `CommunityCreationMembers`.
Wed, Jun 7, 12:33 PM
ashoat closed D8111: [lib] Stop setting dataLoaded from register / siweAuth actions.
Wed, Jun 7, 12:31 PM
ashoat closed D8110: [native] Dispatch SET_DATA_LOADED action after registration completes.
Wed, Jun 7, 12:31 PM
ashoat committed rCOMM8d9e6fd35d0c: [lib] Stop setting dataLoaded from register / siweAuth actions (authored by ashoat).
[lib] Stop setting dataLoaded from register / siweAuth actions
Wed, Jun 7, 12:31 PM
ashoat committed rCOMM1cc8fe1aedbf: [native] Dispatch SET_DATA_LOADED action after registration completes (authored by ashoat).
[native] Dispatch SET_DATA_LOADED action after registration completes
Wed, Jun 7, 12:31 PM
ashoat closed D8109: [native] Dispatch SET_DATA_LOADED action after SIWE completes.
Wed, Jun 7, 12:31 PM
ashoat closed D8108: [web] Dispatch SET_DATA_LOADED action after SIWE completes.
Wed, Jun 7, 12:31 PM
ashoat committed rCOMMad384a05380c: [native] Dispatch SET_DATA_LOADED action after SIWE completes (authored by ashoat).
[native] Dispatch SET_DATA_LOADED action after SIWE completes
Wed, Jun 7, 12:31 PM
ashoat committed rCOMM8fdf7bae1900: [web] Dispatch SET_DATA_LOADED action after SIWE completes (authored by ashoat).
[web] Dispatch SET_DATA_LOADED action after SIWE completes
Wed, Jun 7, 12:31 PM
ashoat closed D8107: [lib] Introduce new SET_DATA_LOADED action.
Wed, Jun 7, 12:30 PM
ashoat committed rCOMMe2afd44c93a1: [lib] Introduce new SET_DATA_LOADED action (authored by ashoat).
[lib] Introduce new SET_DATA_LOADED action
Wed, Jun 7, 12:30 PM

Tue, Jun 6

ashoat accepted D8115: [native] Display "Skip"/"Done" button to exit community creation flow.
Tue, Jun 6, 10:26 AM
ashoat added inline comments to D8098: [native] Block TimeStamp from rendering in the pinned messages screen.
Tue, Jun 6, 8:57 AM
ashoat added inline comments to D8104: [native] Add drawer utils for flattening items structure.
Tue, Jun 6, 8:56 AM
ashoat added a comment to D8068: [native] Refactor the members list to support any variety of role labels.

(should we "singularize" "Members" and "Admins" so it appears as "Member" and "Admin"?)

Tue, Jun 6, 8:55 AM
ashoat added a comment to D8070: Implement CommConstants HostObject with `NATIVE_MESSAGE_TYPES` property in C++.

This is cool – our first HostObject!

Tue, Jun 6, 8:51 AM
ashoat accepted D8072: [lib] Remove parent admin from members list if they are not part of the thread.

Okay, cool. I'm a bit worried that in the future we might introduce an "admin" role for a channel in a community, and in that scenario this code would break ThreadSettingsLeaveThread's usage of otherUsersButNoOtherAdmins. But I guess we can address that when we get there...

Tue, Jun 6, 8:50 AM
ashoat requested review of D8111: [lib] Stop setting dataLoaded from register / siweAuth actions.
Tue, Jun 6, 8:50 AM
ashoat added inline comments to D7943: [landing] introduce logo svg assets for competitor comparison.
Tue, Jun 6, 8:46 AM
ashoat requested review of D8110: [native] Dispatch SET_DATA_LOADED action after registration completes.
Tue, Jun 6, 8:40 AM
ashoat requested review of D8109: [native] Dispatch SET_DATA_LOADED action after SIWE completes.
Tue, Jun 6, 8:37 AM
ashoat requested review of D8108: [web] Dispatch SET_DATA_LOADED action after SIWE completes.
Tue, Jun 6, 8:37 AM
ashoat requested review of D8107: [lib] Introduce new SET_DATA_LOADED action.
Tue, Jun 6, 8:37 AM
ashoat closed D8089: [native] Rename accountSelections to accountSelection.
Tue, Jun 6, 8:18 AM
ashoat closed D8088: [native] Move some types from avatar-selection.react.js to registration-types.js.
Tue, Jun 6, 8:18 AM
ashoat committed rCOMMfb4cfe1c45fb: [native] Rename accountSelections to accountSelection (authored by ashoat).
[native] Rename accountSelections to accountSelection
Tue, Jun 6, 8:18 AM
ashoat committed rCOMM1e9601c6fc0b: [native] Move some types from avatar-selection.react.js to registration-types.js (authored by ashoat).
[native] Move some types from avatar-selection.react.js to registration-types.js
Tue, Jun 6, 8:18 AM
ashoat closed D8085: [native] Change AvatarSelection button to say "Submit" instead of "Next".
Tue, Jun 6, 8:18 AM
ashoat closed D8087: [native] Fix userInfo calculation in UserAvatar.
Tue, Jun 6, 8:18 AM
ashoat committed rCOMMf2e840061476: [native] Fix userInfo calculation in UserAvatar (authored by ashoat).
[native] Fix userInfo calculation in UserAvatar
Tue, Jun 6, 8:18 AM
ashoat committed rCOMMaef077c76767: [native] Change AvatarSelection button to say "Submit" instead of "Next" (authored by ashoat).
[native] Change AvatarSelection button to say "Submit" instead of "Next"
Tue, Jun 6, 8:18 AM
ashoat closed D8084: [native] Disable PasswordSelection "next" button when passwords are empty.
Tue, Jun 6, 8:18 AM
ashoat committed rCOMM804d8f146721: [native] Disable PasswordSelection "next" button when passwords are empty (authored by ashoat).
[native] Disable PasswordSelection "next" button when passwords are empty
Tue, Jun 6, 8:18 AM
ashoat added a comment to D8087: [native] Fix userInfo calculation in UserAvatar.

Ping on this review

Tue, Jun 6, 5:28 AM

Mon, Jun 5

ashoat added inline comments to D8095: [landing] animate the keyserver faq section.
Mon, Jun 5, 3:04 PM
ashoat added a comment to D8074: [native] Fetch latest messages in chat list.

@inka heads-up, your upload doesn't appear to have attached

Mon, Jun 5, 5:51 AM
ashoat added inline comments to D8052: [Keyserver] Use olm identity key for tunnelbroker connection.
Mon, Jun 5, 5:09 AM
ashoat accepted D8090: [Protos] Use outbound key bundle for keyserver information.
Mon, Jun 5, 5:07 AM
ashoat added inline comments to D8067: [web] Refactor the members modal to support any variety of role labels.
Mon, Jun 5, 5:04 AM

Sun, Jun 4

ashoat requested review of D8089: [native] Rename accountSelections to accountSelection.
Sun, Jun 4, 3:01 PM
ashoat requested review of D8088: [native] Move some types from avatar-selection.react.js to registration-types.js.
Sun, Jun 4, 3:01 PM
ashoat requested review of D8087: [native] Fix userInfo calculation in UserAvatar.
Sun, Jun 4, 3:01 PM
ashoat requested review of D8084: [native] Disable PasswordSelection "next" button when passwords are empty.
Sun, Jun 4, 10:18 AM
ashoat requested review of D8085: [native] Change AvatarSelection button to say "Submit" instead of "Next".
Sun, Jun 4, 10:18 AM

Fri, Jun 2

ashoat added inline comments to D8073: [keyserver] Add fetch latest messages endpoint.
Fri, Jun 2, 8:52 AM
ashoat requested changes to D8072: [lib] Remove parent admin from members list if they are not part of the thread.

This diff makes sense, but from a code search it looks like it might impact ThreadSettingsLeaveThread and its use of otherUsersButNoOtherAdmins.

Fri, Jun 2, 8:48 AM
ashoat added inline comments to D8067: [web] Refactor the members modal to support any variety of role labels.
Fri, Jun 2, 8:44 AM
ashoat closed D8064: [web] Include stateVersion in web PlatformDetails.
Fri, Jun 2, 7:46 AM
ashoat committed rCOMMc014a677a83a: [web] Include stateVersion in web PlatformDetails (authored by ashoat).
[web] Include stateVersion in web PlatformDetails
Fri, Jun 2, 7:46 AM
ashoat closed D8063: [web] Separate out redux-persist logic from web/root.js.
Fri, Jun 2, 7:46 AM
ashoat committed rCOMMad982f2b375e: [web] Separate out redux-persist logic from web/root.js (authored by ashoat).
[web] Separate out redux-persist logic from web/root.js
Fri, Jun 2, 7:46 AM

Thu, Jun 1

ashoat closed D8065: [native] Rename avatar action sheet actions.
Thu, Jun 1, 3:45 PM
ashoat committed rCOMM575b39a70f57: [native] Rename avatar action sheet actions (authored by ashoat).
[native] Rename avatar action sheet actions
Thu, Jun 1, 3:45 PM
ashoat requested review of D8065: [native] Rename avatar action sheet actions.
Thu, Jun 1, 2:15 PM
ashoat requested review of D8064: [web] Include stateVersion in web PlatformDetails.
Thu, Jun 1, 2:13 PM
ashoat requested review of D8063: [web] Separate out redux-persist logic from web/root.js.
Thu, Jun 1, 2:09 PM
ashoat accepted D8058: [native] Pass whether created community is `ANNOUNCEMENT` to `CommunityCreationMembers`.
Thu, Jun 1, 2:00 PM
ashoat accepted D8056: [native] Barebones user selection in `CommunityCreationMembers`.
In D8056#239034, @atul wrote:

I can try to pull something generic out of CommunityCreationMembers and see if it can be used in other components where we have TagInput and UserList (ComposeSubchannel, AddUsersModal, etc) later in this stack.

Thu, Jun 1, 1:59 PM
ashoat accepted D8057: [native] Introduce `CommunityCreationContentContainer` component.
Thu, Jun 1, 1:41 PM
ashoat requested changes to D8056: [native] Barebones user selection in `CommunityCreationMembers`.

Back to you with questions:

Thu, Jun 1, 1:35 PM
ashoat committed rCOMM0b5392afb400: [web] `codeVersion` -> 1 (authored by ashoat).
[web] `codeVersion` -> 1
Thu, Jun 1, 12:12 PM
ashoat closed D8049: [native] Default to ENS avatar for users that have one.
Thu, Jun 1, 11:52 AM
ashoat closed D8048: [native] Introduce avatarData state to hold pending avatar in AvatarSelection.
Thu, Jun 1, 11:52 AM
ashoat closed D8047: [native] Make EditUserAvatar component conditionally navigate to registration screens.
Thu, Jun 1, 11:52 AM
ashoat committed rCOMMfd1cec1c4e0a: [native] Default to ENS avatar for users that have one (authored by ashoat).
[native] Default to ENS avatar for users that have one
Thu, Jun 1, 11:52 AM
ashoat committed rCOMM408cea282dc6: [native] Introduce avatarData state to hold pending avatar in AvatarSelection (authored by ashoat).
[native] Introduce avatarData state to hold pending avatar in AvatarSelection
Thu, Jun 1, 11:52 AM
ashoat closed D8046: [native] Construct synthetic UserInfo to pass to EditUserAvatar.
Thu, Jun 1, 11:52 AM
ashoat committed rCOMM27ebf48a0caa: [native] Make EditUserAvatar component conditionally navigate to registration… (authored by ashoat).
[native] Make EditUserAvatar component conditionally navigate to registration…
Thu, Jun 1, 11:52 AM
ashoat committed rCOMM58b5465af053: [native] Construct synthetic UserInfo to pass to EditUserAvatar (authored by ashoat).
[native] Construct synthetic UserInfo to pass to EditUserAvatar
Thu, Jun 1, 11:52 AM