Page MenuHomePhabricator

ashoat (Ashoat)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jul 20 2020, 9:28 AM (204 w, 6 d)
Roles
Administrator

Recent Activity

Thu, Jun 20

ashoat accepted D12503: [keyserver/lib/native] flip the switch for farcaster channel tagging.
Thu, Jun 20, 4:23 AM

Wed, Jun 19

ashoat accepted D12500: [native/web] fix manage farcaster channel tag permission migration.

I didn’t have much time to review, but this looks simple and safe. Can you update your test plan to include testing migrating from build 354 to master + your stack, in a process similar to what I described on the Linear task?

Wed, Jun 19, 6:58 PM
ashoat accepted D12499: [lib] remove updateThreadStoreThreadInfos util function.
Wed, Jun 19, 6:56 PM
ashoat accepted D12498: [lib/native] lift createUpdateDBOpsForThreadStoreThreadInfos into lib.
Wed, Jun 19, 6:55 PM
ashoat accepted D12497: [web/native] make redux persist migration 77 no-op.
Wed, Jun 19, 6:54 PM
ashoat requested review of D12496: [lib] Fix up client ThreadStore validation.
Wed, Jun 19, 6:32 PM
ashoat requested review of D12495: [lib] Introduce RawThickThreadInfo type.
Wed, Jun 19, 6:28 PM
ashoat requested review of D12494: [lib] Factor out defaultSubscription in createPendingThread.
Wed, Jun 19, 6:21 PM
ashoat requested review of D12493: [lib] Simplify threadOtherMembers.
Wed, Jun 19, 6:17 PM
ashoat requested review of D12492: [web] Update InitialReduxStateGate to remove reference to LegacyRawThreadInfo.
Wed, Jun 19, 6:12 PM
ashoat requested review of D12491: [lib] Introduce usingOlmViaTunnelbrokerForDMs to get DM creation.
Wed, Jun 19, 6:06 PM
ashoat requested review of D12490: [lib] Add support for thick threads to baseCreatePendingSidebar.
Wed, Jun 19, 6:01 PM
ashoat requested review of D12489: [keyserver][lib] Update thread type assertion functions for thick/thread distinction.
Wed, Jun 19, 5:56 PM
ashoat requested review of D12488: [lib] Introduce thickThreadTypes and ThickThreadType.
Wed, Jun 19, 5:52 PM
ashoat requested review of D12487: [lib] Temporarily switch LOCAL to COMMUNITY_SECRET_SUBTHREAD for pending threads.
Wed, Jun 19, 5:45 PM
ashoat requested review of D12486: [keyserver][lib][native][web] NewThreadRequest -> NewThinThreadRequest.
Wed, Jun 19, 5:40 PM
ashoat requested review of D12485: [lib][native][web] useNewThread -> useNewThinThread.
Wed, Jun 19, 5:36 PM
ashoat requested review of D12484: [lib][native][web] createNewThread -> createNewThinThread.
Wed, Jun 19, 5:32 PM
ashoat requested review of D12483: [keyserver] Remove threadTypes.LOCAL from newThreadRequestInputValidator.
Wed, Jun 19, 5:24 PM
ashoat requested review of D12482: [keyserver][lib][native][web] Rename PERSONAL and PRIVATE threadTypes.
Wed, Jun 19, 5:22 PM
ashoat requested review of D12481: [lib] Replace threadTypes.LOCAL in tests.
Wed, Jun 19, 5:20 PM
ashoat requested review of D12480: [lib] Rename threadTypes to thinThreadTypes.
Wed, Jun 19, 5:20 PM
ashoat accepted D12475: [keyserver] upgrade redis to version 7 on docker based keyserver.

Can you extend the test plan to describe what you did to test Redis? Eg. log in as two users at once, send a message, confirm it’s instantaneously delivered

Wed, Jun 19, 1:30 PM
ashoat accepted D12474: [terraform] bump staging identity to 0.25-staging.
Wed, Jun 19, 7:32 AM
ashoat accepted D12473: [lib] introduce DISABLE_CONNECT_FARCASTER_ALERT gate.
Wed, Jun 19, 5:26 AM
ashoat accepted D12471: [web] fix uncaught exception bug.
Wed, Jun 19, 5:25 AM
ashoat accepted D12468: [web] allow password users registered with identity to change their password from web.
Wed, Jun 19, 5:23 AM

Tue, Jun 18

ashoat added a reverting change for rCOMM532912ce2de6: [native] Temporary changes for staff release: rCOMMe08aa7269b46: Revert "[native] Temporary changes for staff release".
Tue, Jun 18, 6:57 PM
ashoat committed rCOMMe08aa7269b46: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
Tue, Jun 18, 6:57 PM
ashoat committed rCOMM76192091b2e0: [native] codeVersion -> 356 (authored by ashoat).
[native] codeVersion -> 356
Tue, Jun 18, 6:56 PM
ashoat committed rCOMM532912ce2de6: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
Tue, Jun 18, 6:56 PM
ashoat committed rCOMMa268708e7cc6: [native] codeVersion -> 355 (authored by ashoat).
[native] codeVersion -> 355
Tue, Jun 18, 6:56 PM
ashoat committed rCOMM581056a42db7: [web][keyserver] codeVersion -> 88 (authored by ashoat).
[web][keyserver] codeVersion -> 88
Tue, Jun 18, 6:56 PM
ashoat committed rCOMM50fd93bf05b1: [keyserver] Update NEXT_CODE_VERSION (authored by ashoat).
[keyserver] Update NEXT_CODE_VERSION
Tue, Jun 18, 6:56 PM
ashoat committed rCOMM79d722eb3c54: [web] Bump @commapp/opaque-ke-wasm to 0.0.4 (authored by ashoat).
[web] Bump @commapp/opaque-ke-wasm to 0.0.4
Tue, Jun 18, 6:50 PM
ashoat added inline comments to D12465: [identity] update change password RPCs to match whitepaper.
Tue, Jun 18, 2:20 PM
ashoat requested changes to D12469: [lib] Change type of `RawThreadInfo.members` from `MemberInfoWithPermissions` to `MemberInfoSansPermissions`.

Flow errors

Tue, Jun 18, 2:18 PM
ashoat resigned from D12467: [web] mark otks as published before attempting to upload keys to identity.

This looks good to me, but to be honest I'm not very familiar with this code, so would be great if either @kamil or @marcin could take a look as well

Tue, Jun 18, 12:05 PM
ashoat accepted D12466: [keyserver] mark OTKs as published before calling registerUser RPC.
Tue, Jun 18, 12:03 PM
ashoat added inline comments to D12065: [native] introduce AutoJoinCommunityHandler.
Tue, Jun 18, 12:02 PM
ashoat accepted D12065: [native] introduce AutoJoinCommunityHandler.
Tue, Jun 18, 11:18 AM
ashoat accepted D10623: [native] use useChangeIdentityUserPassword.
Tue, Jun 18, 10:10 AM
ashoat accepted D10616: [lib][native][web] add new changeIdentityUserPassword action.
Tue, Jun 18, 10:09 AM
ashoat accepted D12465: [identity] update change password RPCs to match whitepaper.
Tue, Jun 18, 10:07 AM
ashoat added inline comments to D12454: [lib] avoid listening to Tunnelbroker messages in `QRAuthProvider` when QR auth is finished.
Tue, Jun 18, 10:04 AM
ashoat accepted D12454: [lib] avoid listening to Tunnelbroker messages in `QRAuthProvider` when QR auth is finished.

Please remove the unnecessary effect before landing, or re-request review if you think I'm missing something

Tue, Jun 18, 10:04 AM
ashoat added inline comments to D12464: Implement notification texts generation on the client.
Tue, Jun 18, 10:00 AM
ashoat requested changes to D12459: [keysever/lib/native] extend joinThread to handle auto join functionality.

This diff allows anybody to join any thread they want, regardless of permissions!!

Tue, Jun 18, 9:57 AM
ashoat added a comment to D12457: [terraform] Upgrade AWS Terraform provider to 5.32.0.

Why not the latest version?

Tue, Jun 18, 9:51 AM
ashoat requested changes to D12065: [native] introduce AutoJoinCommunityHandler.

A couple more async improvements. I should be able to give this a final review either today or tomorrow, but if not feel free to remove me from the review so you can land it while I'm out.

Tue, Jun 18, 9:51 AM
ashoat accepted D12444: [keyserver] introduce setSubcriptionToDefault option in changeRole.

Please undo the rename before landing

Tue, Jun 18, 9:46 AM

Mon, Jun 17

ashoat accepted D12456: [terraform] bump staging identity to 0.24-staging.
Mon, Jun 17, 10:26 AM
ashoat requested changes to D12454: [lib] avoid listening to Tunnelbroker messages in `QRAuthProvider` when QR auth is finished.

What happens if the user logs in via QR code, then logs out, and then tries again? It seems like qrAuthFinished is never set to false after being set to true, which makes me suspect that things will be broken in this case.

Mon, Jun 17, 10:22 AM
ashoat accepted D12453: [native] remove `useQRAuth` hook.
Mon, Jun 17, 10:20 AM
ashoat accepted D12452: [native] update QR login flow to use `QRAuthContext`.
Mon, Jun 17, 10:08 AM
ashoat accepted D12450: [web] update QR login flow to use `QRAuthContext`.
Mon, Jun 17, 10:07 AM
ashoat accepted D12449: [lib] implement `QRAuthContext`.
Mon, Jun 17, 10:07 AM
ashoat added a comment to D12441: Rename new_content_prekeys and new_notif_prekeys.

we will also need to do a new keyserver release when we do the next identity prod release

Mon, Jun 17, 9:56 AM
ashoat added inline comments to D12395: Enable encrypted notifications to have keyservevrID or senderDeviceID.
Mon, Jun 17, 8:40 AM
ashoat accepted D12445: [web][native] extract QR code login functions to separate files.
Mon, Jun 17, 8:26 AM
ashoat added inline comments to D12327: [lib][native] Send backup keys in QR auth only if requested.
Mon, Jun 17, 5:34 AM

Fri, Jun 14

ashoat requested changes to D12444: [keyserver] introduce setSubcriptionToDefault option in changeRole.
Fri, Jun 14, 5:15 PM
ashoat accepted D12065: [native] introduce AutoJoinCommunityHandler.

Accepting, but making @bartek blocking for one specific question about blob service auth

Fri, Jun 14, 3:07 PM
ashoat accepted D12443: [keyserver] move mark_prekey_as_published calls inside of publishPrekeysToIdentity.
Fri, Jun 14, 2:55 PM
ashoat accepted D12442: [keyserver] check if there are any unpublished prekeys and publish them during rotation.
Fri, Jun 14, 2:53 PM
ashoat accepted D12441: Rename new_content_prekeys and new_notif_prekeys.

Proto changes won't break compatibility, right?

Fri, Jun 14, 2:39 PM
ashoat accepted D12407: [web] check if version is supported by identity service.
Fri, Jun 14, 2:38 PM
ashoat updated subscribers of D12437: [lib][web][native] Send CSAT in getKeyserverOverrideForAnInviteLink.

cc @ginsu, as I know the Farcaster channel work is closely modeled after the invite link work, and might have the same problem

Fri, Jun 14, 2:30 PM
ashoat added inline comments to D12414: [comm-lib] Verify CSAT in HTTP middleware.
Fri, Jun 14, 2:28 PM
ashoat added inline comments to D12380: [lib] broadcast updates when becoming aware of new device existence.
Fri, Jun 14, 5:44 AM

Thu, Jun 13

ashoat accepted D12062: [keyserver/lib] introduce MANAGE_FARCASTER_CHANNEL_TAGS permission.

Thanks, my bad on that

Thu, Jun 13, 11:46 AM
ashoat added inline comments to D12429: Implement notification types, creation and encryption for APNs notifications.
Thu, Jun 13, 11:44 AM
ashoat accepted D12428: Bump minimal native code version to 149.
Thu, Jun 13, 11:41 AM
ashoat added inline comments to D12380: [lib] broadcast updates when becoming aware of new device existence.
Thu, Jun 13, 11:36 AM
ashoat added a comment to D12427: Move android rescinds and badge updates to lib.

I strongly encourage you to rethink the amount of type spreads you're doing, especially when they're nested within other types

Thu, Jun 13, 11:31 AM
ashoat added inline comments to D12395: Enable encrypted notifications to have keyservevrID or senderDeviceID.
Thu, Jun 13, 11:27 AM
ashoat accepted D12422: [web][native] Display both thread and community names in the modal.

How does it look if the names are really long?

Thu, Jun 13, 11:17 AM
ashoat added a comment to D12375: [lib] add `IdentityDeviceListUpdated` P2P message type.

Yes, if a device receives IdentityDeviceListUpdated, it must broadcast standardized DeviceListUpdated to all its peers because only the receiving device knows the peer list.

Thu, Jun 13, 8:28 AM
ashoat added a comment to D12416: [reports] Require auth for viewing reports.

Heads-up, there are no reviewers specified here

Thu, Jun 13, 8:23 AM
ashoat retitled D12415: [blob] Hide endpoints behind auth middleware from [blob] Hide edpoints behind auth middleware to [blob] Hide endpoints behind auth middleware.
Thu, Jun 13, 8:23 AM
ashoat added inline comments to D12414: [comm-lib] Verify CSAT in HTTP middleware.
Thu, Jun 13, 8:21 AM
ashoat accepted D12063: [keyserver/lib] update farcaster channel tag blob payload to include keyserver id.
Thu, Jun 13, 8:18 AM
ashoat removed a reviewer for D12062: [keyserver/lib] introduce MANAGE_FARCASTER_CHANNEL_TAGS permission: inka.
Thu, Jun 13, 8:00 AM
ashoat accepted D12062: [keyserver/lib] introduce MANAGE_FARCASTER_CHANNEL_TAGS permission.
Thu, Jun 13, 8:00 AM

Wed, Jun 12

ashoat accepted D12408: [web] remove ping component.
Wed, Jun 12, 12:50 PM
ashoat requested changes to D12407: [web] check if version is supported by identity service.
Wed, Jun 12, 12:50 PM
ashoat accepted D12405: [native][web][lib] add versionSupported method to IdentityServiceClient.
Wed, Jun 12, 12:40 PM
ashoat accepted D12406: [lib][native] add useVersionSupportedByIdentity hook and use it on native.
Wed, Jun 12, 9:49 AM
ashoat requested changes to D12405: [native][web][lib] add versionSupported method to IdentityServiceClient.
Wed, Jun 12, 9:45 AM
ashoat added inline comments to D12405: [native][web][lib] add versionSupported method to IdentityServiceClient.
Wed, Jun 12, 9:44 AM
ashoat accepted D12287: [lib] Introduce `useThreadFrozenDueToViewersBlock`.
Wed, Jun 12, 8:56 AM
ashoat accepted D12158: [lib] Remove `getCurrentUser`.
Wed, Jun 12, 8:50 AM
ashoat accepted D12265: [lib] Remove `permissions` field from `ThreadInfo.members[memberID].permissions`.

Please make sure to consider your "note to self" above before landing:

Wed, Jun 12, 8:49 AM
ashoat added inline comments to D12396: Introduce EncryptedNotifUtilsAPI and implement it on the keyserver.
Wed, Jun 12, 8:45 AM

Tue, Jun 11

ashoat closed D12391: [keyserver] Make sanitizeInput work even if validation fails.
Tue, Jun 11, 9:25 AM
ashoat committed rCOMMff04951e9757: [keyserver] Make sanitizeInput work even if validation fails (authored by ashoat).
[keyserver] Make sanitizeInput work even if validation fails
Tue, Jun 11, 9:25 AM
ashoat added a comment to D12391: [keyserver] Make sanitizeInput work even if validation fails.

I think this solution has an issue: some sensitive data could be placed in a prop that fails the validation and we probably won't be able to sanitize it properly.

Tue, Jun 11, 9:22 AM
ashoat updated the diff for D12391: [keyserver] Make sanitizeInput work even if validation fails.

Add some test cases

Tue, Jun 11, 9:15 AM
ashoat requested review of D12391: [keyserver] Make sanitizeInput work even if validation fails.
Tue, Jun 11, 7:02 AM
ashoat added inline comments to D12387: [keyserver] Improve logging in checkInputValidator.
Tue, Jun 11, 6:46 AM