[lib] Reduce new PROCESS_DM_OPS action
ClosedPublic
Actions

Authored by ashoat on Jul 16 2024, 8:18 PM.

Details

Reviewers

tomek
kamil
marcin

Commits

rCOMM918067cb29cc: [lib] Reduce new PROCESS_DM_OPS action

Summary

I compiled a list of reducers I should update by searching for existing reducers of PROCESS_MESSAGES and PROCESS_UPDATES. The former is only reduced in message-reducer.js, while the latter is reduced in all of the below reducers.

I excluded three reducers that currently reduce PROCESS_UPDATES:

reduceKeyserverStore, which keeps track of updatesCurrentAsOf for keyserver updates. We're using a different mechanism to verify and track DM ops.
reduceCurrentUserInfo, which should not be possible to affect with DM ops.
reduceUserInfos, which should not be possible to affect with DM ops. The UserInfosHandler should handle populating the UserStore when new users are encountered via DM ops. Tracking this in a new task: ENG-8829.

Submitting this now so @tomek can see the code, as his work relates to this code.

Depends on D12780

Test Plan

Test plan described here

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jul 16 2024, 8:18 PM

ashoat added inline comments.Jul 16 2024, 8:20 PM

lib/reducers/message-reducer.js
1827 ↗	(On Diff #42375)	By leaving `truncationStatuses` empty, we're saying that the truncation status should be `UNCHANGED` for all of the threads

Harbormaster completed remote builds in B30404: Diff 42375.Jul 16 2024, 8:34 PM

ashoat requested review of this revision.Jul 16 2024, 8:34 PM

ashoat added a child revision: D12824: [keyserver][lib] Factor out joinThreadSubscription.Jul 20 2024, 9:19 PM

ashoat edited the test plan for this revision. (Show Details)Jul 21 2024, 10:16 PM

ashoat added inline comments.Jul 21 2024, 10:19 PM

lib/reducers/message-reducer.js
1827 ↗	(On Diff #42375)	Note that this third parameter is for the `rawMessageInfos`, but the `updateInfos` can have their own `RawMessageInfo`s with their own `truncationStatuses` (see D12828) While we might want `MessageTruncationStatus`es other than `UNCHANGED` for the `RawMessageInfo`s that come with the `updateInfos`, we'll always want `UNCHANGED` for the `rawMessageInfos` that aren't associated with `updateInfo`s