Page MenuHomePhabricator

kamil (Kamil Kurowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2022, 1:56 AM (57 w, 1 d)

Recent Activity

Yesterday

kamil accepted D9224: [native] commCoreModule methods for getting, setting, and clearing the commServicesAccessToken.

Accepting to unblock, but please look at my comment about moving clearance code to DatabaseManager::clearSensitiveData()

Fri, Sep 22, 7:27 AM

Fri, Sep 15

kamil accepted D9178: Enhance error check in CryptoModule decrypt. Add encrypted message hash to error message..
Fri, Sep 15, 3:41 AM
kamil accepted D9145: [web] Remove intial redux state from website responders.
Fri, Sep 15, 3:27 AM
kamil accepted D9141: [web] Use new intial redux state.

Looks good but please add the dependency array

Fri, Sep 15, 3:19 AM
kamil accepted D9216: [terraform] Deploy Tunnelbroker DynamoDB table.
Fri, Sep 15, 2:47 AM
kamil accepted D9140: [web] Add setInitialReduxState action.

Different convention than useDispatchActionPromise, but the reason sounds convincing.

Fri, Sep 15, 2:47 AM
kamil accepted D9109: [web] Enable db for all users.

Database stuff LGTM, but after ENG-4930 I think @inka should also take a look at migrating code.

Fri, Sep 15, 2:07 AM

Thu, Sep 14

kamil closed D9200: [Tunnelbroker] add authentication tests.
Thu, Sep 14, 5:23 AM
kamil committed rCOMMb3c4cff3502d: [Tunnelbroker] add authentication tests (authored by kamil).
[Tunnelbroker] add authentication tests
Thu, Sep 14, 5:23 AM
kamil closed D8918: [Tunnelbroker] Authenticate connecting devices.
Thu, Sep 14, 5:23 AM
kamil committed rCOMM178a0a7f14a2: [Tunnelbroker] Authenticate connecting devices (authored by kamil).
[Tunnelbroker] Authenticate connecting devices
Thu, Sep 14, 5:23 AM
kamil closed D9197: [CommCoreModule] capture primitive parameter by value.
Thu, Sep 14, 5:19 AM
kamil committed rCOMM798e3599316a: [CommCoreModule] capture primitive parameter by value (authored by kamil).
[CommCoreModule] capture primitive parameter by value
Thu, Sep 14, 5:19 AM
kamil updated the diff for D9200: [Tunnelbroker] add authentication tests.

unwrap -> expect

Thu, Sep 14, 3:57 AM
kamil added a comment to D8918: [Tunnelbroker] Authenticate connecting devices.

thanks @michal and @bartek for feedback!

Thu, Sep 14, 3:47 AM
kamil updated the diff for D8918: [Tunnelbroker] Authenticate connecting devices.

use error!

Thu, Sep 14, 3:43 AM
kamil updated the diff for D8918: [Tunnelbroker] Authenticate connecting devices.

address review

Thu, Sep 14, 3:40 AM
kamil published D9200: [Tunnelbroker] add authentication tests for review.
Thu, Sep 14, 3:20 AM
kamil updated the diff for D8918: [Tunnelbroker] Authenticate connecting devices.

rebase before landing

Thu, Sep 14, 3:13 AM
kamil closed D9182: [Tunnelbroker] update integration tests to handle auth device.
Thu, Sep 14, 2:04 AM
kamil committed rCOMMd583b31f6863: [Tunnelbroker] update integration tests to handle auth device (authored by kamil).
[Tunnelbroker] update integration tests to handle auth device
Thu, Sep 14, 2:04 AM
kamil published D9197: [CommCoreModule] capture primitive parameter by value for review.
Thu, Sep 14, 1:20 AM

Wed, Sep 13

kamil accepted D9156: [tunnelbroker] Make WebSocketSession generic.
Wed, Sep 13, 9:24 AM
kamil accepted D9155: [tunnelbroker] Don't listen on localhost only.
Wed, Sep 13, 9:22 AM
kamil accepted D9153: [tunnelbroker] Allow configuring AMQP credentials.
Wed, Sep 13, 9:21 AM
kamil published D9182: [Tunnelbroker] update integration tests to handle auth device for review.
Wed, Sep 13, 9:18 AM
kamil closed D9106: [keyserver] add missing `napi` annotation.
Wed, Sep 13, 9:09 AM
kamil committed rCOMM90b2d6d04eaa: [keyserver] add missing `napi` annotation (authored by kamil).
[keyserver] add missing `napi` annotation
Wed, Sep 13, 9:09 AM
kamil closed D9125: [keyserver] fix fetching identity info.
Wed, Sep 13, 8:40 AM
kamil committed rCOMM0f3c646bca2a: [keyserver] fix fetching identity info (authored by kamil).
[keyserver] fix fetching identity info
Wed, Sep 13, 8:40 AM
kamil closed D9128: [Tunnelbroker] match JS naming convention.
Wed, Sep 13, 8:37 AM
kamil committed rCOMMa5fbda1c676b: [Tunnelbroker] match JS naming convention (authored by kamil).
[Tunnelbroker] match JS naming convention
Wed, Sep 13, 8:37 AM
kamil closed D8957: [Keyserver] Use getCommConfig for tunnelbroker connection.
Wed, Sep 13, 7:21 AM
kamil committed rCOMMc62d949459d0: [Keyserver] Use getCommConfig for tunnelbroker connection (authored by kamil).
[Keyserver] Use getCommConfig for tunnelbroker connection
Wed, Sep 13, 7:21 AM
kamil updated the diff for D8957: [Keyserver] Use getCommConfig for tunnelbroker connection.
  • address review
  • review before landing
Wed, Sep 13, 7:02 AM
kamil closed D8956: [Keyserver] Validate incoming tunnelbroker messages.
Wed, Sep 13, 6:43 AM
kamil committed rCOMM2cdd7e923a4a: [Keyserver] Validate incoming tunnelbroker messages (authored by jon).
[Keyserver] Validate incoming tunnelbroker messages
Wed, Sep 13, 6:43 AM
kamil closed D8751: [Keyserver] Refactor getOneTimeKeyValues.
Wed, Sep 13, 6:43 AM
kamil closed D8752: [Keyserver] Upload new onetime keys to identity service when requested.
Wed, Sep 13, 6:43 AM
kamil committed rCOMM074761606d14: [Keyserver] Upload new onetime keys to identity service when requested (authored by jon).
[Keyserver] Upload new onetime keys to identity service when requested
Wed, Sep 13, 6:43 AM
kamil committed rCOMM0d30bbfc847b: [Keyserver] Refactor getOneTimeKeyValues (authored by jon).
[Keyserver] Refactor getOneTimeKeyValues
Wed, Sep 13, 6:43 AM
kamil closed D8750: [Keyserver/rust] Implement upload_one_time_keys to identity service.
Wed, Sep 13, 6:43 AM
kamil closed D7691: [Keyserver] Open websocket connection with tunnelbroker.
Wed, Sep 13, 6:43 AM
kamil committed rCOMMd1359c5f69df: [Keyserver/rust] Implement upload_one_time_keys to identity service (authored by jon).
[Keyserver/rust] Implement upload_one_time_keys to identity service
Wed, Sep 13, 6:43 AM
kamil committed rCOMM8f42e5423993: [Keyserver] Open websocket connection with tunnelbroker (authored by jon).
[Keyserver] Open websocket connection with tunnelbroker
Wed, Sep 13, 6:43 AM
kamil added inline comments to D8752: [Keyserver] Upload new onetime keys to identity service when requested.
Wed, Sep 13, 6:24 AM
kamil added inline comments to D8956: [Keyserver] Validate incoming tunnelbroker messages.
Wed, Sep 13, 6:18 AM
kamil updated the diff for D8956: [Keyserver] Validate incoming tunnelbroker messages.

rebase before landing

Wed, Sep 13, 6:12 AM
kamil added inline comments to D8752: [Keyserver] Upload new onetime keys to identity service when requested.
Wed, Sep 13, 6:10 AM
kamil updated the diff for D8752: [Keyserver] Upload new onetime keys to identity service when requested.

address review

Wed, Sep 13, 6:09 AM
kamil updated the diff for D8751: [Keyserver] Refactor getOneTimeKeyValues.

rebase before landing

Wed, Sep 13, 6:00 AM
kamil updated the diff for D8750: [Keyserver/rust] Implement upload_one_time_keys to identity service.

rebase before landing

Wed, Sep 13, 5:58 AM
kamil added inline comments to D7691: [Keyserver] Open websocket connection with tunnelbroker.
Wed, Sep 13, 5:57 AM
kamil updated the diff for D7691: [Keyserver] Open websocket connection with tunnelbroker.

rebase before landing

Wed, Sep 13, 5:57 AM

Tue, Sep 12

kamil added reviewers for D7691: [Keyserver] Open websocket connection with tunnelbroker: bartek, michal.

@bartek, @michal could you take a brief look at Rust?

Tue, Sep 12, 6:03 AM
kamil closed D9142: [Tunnelbroker] Fix integration tests.
Tue, Sep 12, 4:44 AM
kamil committed rCOMM08a58fec2081: [Tunnelbroker] Fix integration tests (authored by kamil).
[Tunnelbroker] Fix integration tests
Tue, Sep 12, 4:44 AM
kamil published D9142: [Tunnelbroker] Fix integration tests for review.
Tue, Sep 12, 4:17 AM
kamil added inline comments to D8752: [Keyserver] Upload new onetime keys to identity service when requested.
Tue, Sep 12, 4:08 AM
kamil updated the diff for D7691: [Keyserver] Open websocket connection with tunnelbroker.

CI

Tue, Sep 12, 4:06 AM
kamil updated the diff for D8750: [Keyserver/rust] Implement upload_one_time_keys to identity service.

rebase

Tue, Sep 12, 3:17 AM
kamil added inline comments to D7691: [Keyserver] Open websocket connection with tunnelbroker.
Tue, Sep 12, 3:16 AM
kamil updated the diff for D7691: [Keyserver] Open websocket connection with tunnelbroker.
  • curve25519 -> ed25519
  • deviceID -> userID
  • remove auto-establishing session
Tue, Sep 12, 3:05 AM
kamil added a comment to D8993: [client-backup] implement API call to upload backup.

At some point we'll probably want to think about how uploads might work in the background. If the backup is large, I could imagine that the client would need background upload in order to complete the upload. Is there a task to track this?

Tue, Sep 12, 2:28 AM
kamil planned changes to D9033: [Tunnelbroker] Add readme.
Tue, Sep 12, 1:50 AM
kamil commandeered D9033: [Tunnelbroker] Add readme.

@kamil, would you be interested in commandeering this revision?

Tue, Sep 12, 1:50 AM
kamil added inline comments to D9109: [web] Enable db for all users.
Tue, Sep 12, 1:32 AM
kamil accepted D9124: [keyserver] Implement `getInitialReduxStateResponder`.

Looks like a straightforward change

Tue, Sep 12, 1:28 AM
kamil accepted D9122: [keyserver] Introduce getInitialReduxStateResponder.
Tue, Sep 12, 1:11 AM
kamil accepted D9109: [web] Enable db for all users.

Could you add to the test plan case, when you first apply this diff and then log in? (I remember this was a tricky case when implementing the first version)

Tue, Sep 12, 12:53 AM
kamil accepted D9127: [native] rename fields in JSON serialized string to camelCase from snake_case.
Tue, Sep 12, 12:30 AM

Mon, Sep 11

kamil published D9128: [Tunnelbroker] match JS naming convention for review.
Mon, Sep 11, 8:30 AM
kamil published D9125: [keyserver] fix fetching identity info for review.
Mon, Sep 11, 6:43 AM
kamil added a comment to D7691: [Keyserver] Open websocket connection with tunnelbroker.

Some more bugs I found while testing D8918, I will address them later

Mon, Sep 11, 3:50 AM
kamil resigned from D9111: [keyserver] Remove old current user info.

LGTM but letting other reviewers take a look

Mon, Sep 11, 12:40 AM
kamil accepted D9110: [web] Migrate drafts to db for everyone.
Mon, Sep 11, 12:33 AM
kamil requested changes to D9109: [web] Enable db for all users.

Looks good! Only some questions inline

Mon, Sep 11, 12:30 AM
kamil added inline comments to D9108: [web] Initialize database at startup on safari.
Mon, Sep 11, 12:02 AM

Sun, Sep 10

kamil accepted D9108: [web] Initialize database at startup on safari.

Thanks for this!

Sun, Sep 10, 11:50 PM
kamil accepted D9107: [web] Move safari db key init to database module.
Sun, Sep 10, 11:41 PM
kamil accepted D9105: [web] Hide databaseModule behind a function.
Sun, Sep 10, 11:35 PM
kamil accepted D9097: [web] fix message action tooltip placement for messages with inline engagement.

Hey no worries, this is a good shout. The reason that the tooltip is positioned like that is because the tooltip has 3 parts the label, the action buttons, and the timestamp and we center align based on all three of those elements

Screenshot 2023-09-08 at 9.23.05 AM.png (344×1 px, 56 KB)

I can see that the placement is still bit wonky when the label is missing, but I feel like this might be outside the scope of this diff. I created a follow up linear task to eventually address this

https://linear.app/comm/issue/ENG-4879/make-the-message-action-tooltip-more-aligned-with-the-message

Sun, Sep 10, 11:30 PM

Fri, Sep 8

kamil commandeered D8918: [Tunnelbroker] Authenticate connecting devices.
Fri, Sep 8, 10:35 AM
kamil added a comment to D8957: [Keyserver] Use getCommConfig for tunnelbroker connection.

@kamil, would you mind taking over this diff, addressing my inline comment, and landing it?

Fri, Sep 8, 10:32 AM
kamil added a comment to D8956: [Keyserver] Validate incoming tunnelbroker messages.

Tested with real keyserver:

  • send the correct message and check if it passes validation
  • send a malformed message and check if an error is thrown
Fri, Sep 8, 10:19 AM
kamil updated the diff for D8956: [Keyserver] Validate incoming tunnelbroker messages.

rebase

Fri, Sep 8, 10:16 AM
kamil commandeered D8956: [Keyserver] Validate incoming tunnelbroker messages.
Fri, Sep 8, 10:15 AM
kamil added inline comments to D8752: [Keyserver] Upload new onetime keys to identity service when requested.
Fri, Sep 8, 9:17 AM
kamil updated the diff for D8752: [Keyserver] Upload new onetime keys to identity service when requested.
  • updated event type
  • update message type value to reflect value defined in Rust
  • test with real keyserver, tests are not accurate
Fri, Sep 8, 9:16 AM
kamil commandeered D8752: [Keyserver] Upload new onetime keys to identity service when requested.
Fri, Sep 8, 8:26 AM
kamil commandeered D8751: [Keyserver] Refactor getOneTimeKeyValues.
Fri, Sep 8, 7:32 AM
kamil updated the diff for D8750: [Keyserver/rust] Implement upload_one_time_keys to identity service.
  • rebase
  • update comment
Fri, Sep 8, 7:29 AM
kamil commandeered D8750: [Keyserver/rust] Implement upload_one_time_keys to identity service.
Fri, Sep 8, 7:28 AM
kamil added inline comments to D7691: [Keyserver] Open websocket connection with tunnelbroker.
Fri, Sep 8, 7:15 AM
kamil added inline comments to D7691: [Keyserver] Open websocket connection with tunnelbroker.
Fri, Sep 8, 7:13 AM
kamil updated the diff for D7691: [Keyserver] Open websocket connection with tunnelbroker.
  • update comment
  • deviceId -> deviceID
Fri, Sep 8, 7:06 AM
kamil removed a reviewer for D7691: [Keyserver] Open websocket connection with tunnelbroker: jon.
Fri, Sep 8, 5:49 AM
kamil removed a reviewer for D7691: [Keyserver] Open websocket connection with tunnelbroker: jon.
Fri, Sep 8, 5:48 AM
kamil commandeered D7691: [Keyserver] Open websocket connection with tunnelbroker.
Fri, Sep 8, 5:47 AM
kamil added inline comments to D8476: [Keyserver] Publish prekeys to identity service for cron job.
Fri, Sep 8, 4:34 AM