Page MenuHomePhabricator

kamil (Kamil Kurowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2022, 1:56 AM (31 w, 2 d)

Recent Activity

Yesterday

kamil closed D7119: [web-db] add unit tests to function for parsing SQLite query.
Sat, Mar 25, 5:52 AM
kamil committed rCOMM1abf9fd998af: [web-db] add unit tests to function for parsing SQLite query (authored by kamil).
[web-db] add unit tests to function for parsing SQLite query
Sat, Mar 25, 5:52 AM
kamil closed D7118: [web-db] add function for parsing SQLite query.
Sat, Mar 25, 5:52 AM
kamil committed rCOMMbd523b2a5403: [web-db] add function for parsing SQLite query (authored by kamil).
[web-db] add function for parsing SQLite query
Sat, Mar 25, 5:52 AM
kamil added inline comments to D7123: [web-db] implement function get all drafts from SQLite.
Sat, Mar 25, 5:46 AM
kamil updated the diff for D7119: [web-db] add unit tests to function for parsing SQLite query.

rebase

Sat, Mar 25, 5:35 AM
kamil updated the diff for D7118: [web-db] add function for parsing SQLite query.

address review

Sat, Mar 25, 5:33 AM
kamil closed D7104: [web-db] add unit tests for worker crypto utils.
Sat, Mar 25, 5:01 AM
kamil committed rCOMM83b3550cd01b: [web-db] add unit tests for worker crypto utils (authored by kamil).
[web-db] add unit tests for worker crypto utils
Sat, Mar 25, 5:01 AM
kamil closed D6996: [web-db] generate `CryptoKey` and persist.
Sat, Mar 25, 5:01 AM
kamil committed rCOMMc6ea9a5a2f99: [web-db] generate `CryptoKey` and persist (authored by kamil).
[web-db] generate `CryptoKey` and persist
Sat, Mar 25, 5:01 AM
kamil closed D6995: [web-db] implement crypto functions.
Sat, Mar 25, 5:01 AM
kamil committed rCOMM7096eb583d29: [web-db] implement crypto functions (authored by kamil).
[web-db] implement crypto functions
Sat, Mar 25, 5:01 AM
kamil added a comment to D7104: [web-db] add unit tests for worker crypto utils.

FYI By mistake, two diffs had different order in the stack than in my branch on git - that's why I needed to fix parent/child revisions because arcanist didn't allow me to arc diff but this has no influence on the code itself

Sat, Mar 25, 4:51 AM
kamil updated the diff for D7104: [web-db] add unit tests for worker crypto utils.

rebase before landing

Sat, Mar 25, 4:44 AM
kamil updated the diff for D6996: [web-db] generate `CryptoKey` and persist.

rebase before landing

Sat, Mar 25, 4:41 AM
kamil updated the diff for D6995: [web-db] implement crypto functions.

rebase before landing

Sat, Mar 25, 4:10 AM
kamil closed D7102: [web-db] implement function to get database version.
Sat, Mar 25, 4:02 AM
kamil closed D7103: [web-db] add unit tests for `sql.js`.
Sat, Mar 25, 4:02 AM
kamil committed rCOMM9943cf1dd98c: [web-db] implement function to get database version (authored by kamil).
[web-db] implement function to get database version
Sat, Mar 25, 4:02 AM
kamil committed rCOMMb191d4bc8962: [web-db] add unit tests for `sql.js` (authored by kamil).
[web-db] add unit tests for `sql.js`
Sat, Mar 25, 4:02 AM
kamil closed D7101: [web-db] add `sql.js` types.
Sat, Mar 25, 4:02 AM
kamil committed rCOMM3f1a02bb68b0: [web-db] add `sql.js` types (authored by kamil).
[web-db] add `sql.js` types
Sat, Mar 25, 4:02 AM
kamil updated the diff for D7103: [web-db] add unit tests for `sql.js`.

rebase before landing

Sat, Mar 25, 3:37 AM
kamil updated the diff for D7102: [web-db] implement function to get database version.

rebase before landing

Sat, Mar 25, 3:36 AM
kamil updated the diff for D7101: [web-db] add `sql.js` types.

reabse before landing

Sat, Mar 25, 3:34 AM

Fri, Mar 24

kamil added inline comments to D7101: [web-db] add `sql.js` types.
Fri, Mar 24, 8:03 AM
kamil updated the diff for D7101: [web-db] add `sql.js` types.

address review

Fri, Mar 24, 8:02 AM

Thu, Mar 23

kamil published D7154: [web-db] get client database store from SQLite for review.
Thu, Mar 23, 6:28 AM
kamil published D7153: [web-db] process Draft Store Operations on worker for review.
Thu, Mar 23, 6:23 AM
kamil published D7124: [web-db] add unit tests for draft store queries for review.
Thu, Mar 23, 6:19 AM
kamil published D7123: [web-db] implement function get all drafts from SQLite for review.
Thu, Mar 23, 6:14 AM
kamil added inline comments to D7122: [web-db] implement Draft Store Operations.
Thu, Mar 23, 6:00 AM
kamil updated the diff for D7122: [web-db] implement Draft Store Operations.

add import, improve query format

Thu, Mar 23, 6:00 AM
kamil requested review of D7121: [web-db] create drafts table in SQLite database.
Thu, Mar 23, 5:24 AM
kamil added a comment to D7118: [web-db] add function for parsing SQLite query.

We should not be polluting the global namespace in D7101. You should not be able to use QueryExecResult without importing it unless it's in the Flow lib.

Thu, Mar 23, 5:18 AM
kamil updated the diff for D7118: [web-db] add function for parsing SQLite query.

add import

Thu, Mar 23, 5:16 AM
kamil updated the diff for D7102: [web-db] implement function to get database version.

rebase

Thu, Mar 23, 5:11 AM
kamil added inline comments to D7101: [web-db] add `sql.js` types.
Thu, Mar 23, 5:10 AM
kamil updated the diff for D7101: [web-db] add `sql.js` types.

address code review

Thu, Mar 23, 5:04 AM

Wed, Mar 22

kamil published D7122: [web-db] implement Draft Store Operations for review.
Wed, Mar 22, 5:34 AM
kamil published D7121: [web-db] create drafts table in SQLite database for review.
Wed, Mar 22, 5:34 AM
kamil added inline comments to D7118: [web-db] add function for parsing SQLite query.
Wed, Mar 22, 5:32 AM
kamil updated the diff for D7118: [web-db] add function for parsing SQLite query.

update type

Wed, Mar 22, 5:30 AM
kamil updated the diff for D7118: [web-db] add function for parsing SQLite query.

update type

Wed, Mar 22, 5:28 AM

Tue, Mar 21

kamil added inline comments to D7104: [web-db] add unit tests for worker crypto utils.
Tue, Mar 21, 9:51 AM
kamil updated the diff for D7103: [web-db] add unit tests for `sql.js`.

fix typo

Tue, Mar 21, 4:18 AM
kamil updated the diff for D7102: [web-db] implement function to get database version.

rename function to be more detailed

Tue, Mar 21, 4:16 AM
kamil published D7119: [web-db] add unit tests to function for parsing SQLite query for review.
Tue, Mar 21, 4:12 AM
kamil published D7118: [web-db] add function for parsing SQLite query for review.
Tue, Mar 21, 4:11 AM

Mon, Mar 20

kamil published D7104: [web-db] add unit tests for worker crypto utils for review.
Mon, Mar 20, 9:26 AM
kamil published D7103: [web-db] add unit tests for `sql.js` for review.
Mon, Mar 20, 9:26 AM
kamil published D7102: [web-db] implement function to get database version for review.
Mon, Mar 20, 9:25 AM
kamil published D7101: [web-db] add `sql.js` types for review.
Mon, Mar 20, 9:25 AM
kamil added a comment to D6995: [web-db] implement crypto functions.

I haven't seen all call sites yet (only the key generation diff is up) so I can't really tell but maybe it's worth revisiting the types and function arguments to have this as clean and consistent as possible.

Mon, Mar 20, 9:21 AM
kamil updated the diff for D6996: [web-db] generate `CryptoKey` and persist.

rebase

Mon, Mar 20, 9:05 AM
kamil updated the diff for D6995: [web-db] implement crypto functions.

update types

Mon, Mar 20, 9:04 AM
kamil closed D6993: [web-db] initialize SQLite database.
Mon, Mar 20, 3:40 AM
kamil committed rCOMM2b354c58f0f6: [web-db] initialize SQLite database (authored by kamil).
[web-db] initialize SQLite database
Mon, Mar 20, 3:40 AM
kamil closed D7092: [web-db] Use unique filename for each prod `sql-wasm.wasm` asset.
Mon, Mar 20, 3:40 AM
kamil committed rCOMM88db3ac63232: [web-db] Use unique filename for each prod `sql-wasm.wasm` asset (authored by kamil).
[web-db] Use unique filename for each prod `sql-wasm.wasm` asset
Mon, Mar 20, 3:40 AM
kamil added a comment to D6993: [web-db] initialize SQLite database.
In D6993#209859, @tomek wrote:

Do we know how this diff corresponds to https://linear.app/comm/issue/ENG-3322/fix-stale-cache-error-for-olmwasm#comment-d1aabe3d? Maybe this will somehow improve the experience about the path's configuration?

Mon, Mar 20, 3:38 AM
kamil closed D6992: [web-db] implement proxy for promise-based connection with worker.
Mon, Mar 20, 2:51 AM
kamil closed D6991: [web-db] implement basic app-worker connection types.
Mon, Mar 20, 2:51 AM
kamil committed rCOMM3de89fd327d0: [web-db] implement proxy for promise-based connection with worker (authored by kamil).
[web-db] implement proxy for promise-based connection with worker
Mon, Mar 20, 2:51 AM
kamil committed rCOMM661a2b6b9ccd: [web-db] implement basic app-worker connection types (authored by kamil).
[web-db] implement basic app-worker connection types
Mon, Mar 20, 2:51 AM
kamil closed D6990: [web-db] add indexedDB config.
Mon, Mar 20, 2:51 AM
kamil committed rCOMMe8645d4fe752: [web-db] add indexedDB config (authored by kamil).
[web-db] add indexedDB config
Mon, Mar 20, 2:51 AM
kamil added inline comments to D6991: [web-db] implement basic app-worker connection types.
Mon, Mar 20, 2:40 AM
kamil updated the test plan for D6991: [web-db] implement basic app-worker connection types.
Mon, Mar 20, 2:24 AM

Fri, Mar 17

kamil added inline comments to D7092: [web-db] Use unique filename for each prod `sql-wasm.wasm` asset.
Fri, Mar 17, 6:46 AM
kamil published D7092: [web-db] Use unique filename for each prod `sql-wasm.wasm` asset for review.
Fri, Mar 17, 4:29 AM
kamil added a comment to D6993: [web-db] initialize SQLite database.

Example usage is in the test plan, unfortunately, it can not be done as elegantly as in olm case - where both web and .wasm file is hosted from the same place.

Fri, Mar 17, 4:23 AM
kamil updated the test plan for D6993: [web-db] initialize SQLite database.
Fri, Mar 17, 4:19 AM
kamil updated the diff for D6993: [web-db] initialize SQLite database.

Reflect changes caused by D7092

Fri, Mar 17, 4:18 AM
kamil closed D6988: [web-db] not include `crypto`, `fs`, and `path` polyfills for workers.
Fri, Mar 17, 3:47 AM
kamil committed rCOMMc768b34b0417: [web-db] not include `crypto`, `fs`, and `path` polyfills for workers (authored by kamil).
[web-db] not include `crypto`, `fs`, and `path` polyfills for workers
Fri, Mar 17, 3:47 AM
kamil closed D6987: [web-db] add Shared Worker config.
Fri, Mar 17, 3:47 AM
kamil committed rCOMM5e8770bd0377: [web-db] add Shared Worker config (authored by kamil).
[web-db] add Shared Worker config
Fri, Mar 17, 3:47 AM

Wed, Mar 15

kamil added inline comments to D6987: [web-db] add Shared Worker config.
Wed, Mar 15, 4:14 AM

Mon, Mar 13

kamil updated the diff for D6996: [web-db] generate `CryptoKey` and persist.

reabase

Mon, Mar 13, 8:48 AM
kamil added a reviewer for D6995: [web-db] implement crypto functions: bartek.
Mon, Mar 13, 8:47 AM
kamil updated the diff for D6995: [web-db] implement crypto functions.

there is more crypto-relatud stuff, making names more exact to easily distinguish

Mon, Mar 13, 8:47 AM
kamil added inline comments to D6993: [web-db] initialize SQLite database.
Mon, Mar 13, 8:45 AM
kamil updated the diff for D6993: [web-db] initialize SQLite database.

Check if database result is not empty

Mon, Mar 13, 8:43 AM
kamil added inline comments to D6992: [web-db] implement proxy for promise-based connection with worker.
Mon, Mar 13, 8:42 AM
kamil updated the diff for D6992: [web-db] implement proxy for promise-based connection with worker.
  • update type
  • add message type to error message
Mon, Mar 13, 8:40 AM
kamil added inline comments to D6991: [web-db] implement basic app-worker connection types.
Mon, Mar 13, 8:39 AM
kamil added inline comments to D6990: [web-db] add indexedDB config.
Mon, Mar 13, 8:38 AM
kamil added inline comments to D6987: [web-db] add Shared Worker config.
Mon, Mar 13, 8:37 AM
kamil updated the diff for D6987: [web-db] add Shared Worker config.
  • update type
  • update worker path
  • add check
Mon, Mar 13, 8:36 AM
kamil accepted D7032: [desktop] Handle autoUpdate errors.
Mon, Mar 13, 7:23 AM
kamil added inline comments to D7032: [desktop] Handle autoUpdate errors.
Mon, Mar 13, 5:54 AM
kamil accepted D6845: [web] Style navigation state info in the top bar.
Mon, Mar 13, 2:37 AM
kamil closed D6994: [web-db] implement types for `SubtleCrypto` module.
Mon, Mar 13, 1:13 AM
kamil committed rCOMM498483793f2e: [web-db] implement types for `SubtleCrypto` module (authored by kamil).
[web-db] implement types for `SubtleCrypto` module
Mon, Mar 13, 1:13 AM

Fri, Mar 10

kamil added inline comments to D6996: [web-db] generate `CryptoKey` and persist.
Fri, Mar 10, 7:19 AM
kamil updated the diff for D6996: [web-db] generate `CryptoKey` and persist.

rebase, update const

Fri, Mar 10, 7:18 AM
kamil added inline comments to D6995: [web-db] implement crypto functions.
Fri, Mar 10, 7:15 AM
kamil updated the diff for D6995: [web-db] implement crypto functions.

rebase, make type read-only

Fri, Mar 10, 7:14 AM