Page MenuHomePhabricator

kamil (Kamil Kurowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2022, 1:56 AM (86 w, 2 d)

Recent Activity

Thu, Apr 11

kamil closed D11596: [lib] handle race condition when creating `olm` session.
Thu, Apr 11, 4:47 AM
kamil committed rCOMMc5fb96765cbb: [lib] handle race condition when creating `olm` session (authored by kamil).
[lib] handle race condition when creating `olm` session
Thu, Apr 11, 4:47 AM
kamil closed D11595: [web/native] make `overwrite` param for inbound session mandatory and unify web & native.
Thu, Apr 11, 4:47 AM
kamil closed D11594: [lib] errors utils to distinguish between session creation issues.
Thu, Apr 11, 4:47 AM
kamil closed D11591: [native] update session creation code to handle versioning.
Thu, Apr 11, 4:47 AM
kamil committed rCOMMf4b392ccb485: [lib] errors utils to distinguish between session creation issues (authored by kamil).
[lib] errors utils to distinguish between session creation issues
Thu, Apr 11, 4:47 AM
kamil committed rCOMM497a5f739b62: [web/native] make `overwrite` param for inbound session mandatory and unify web… (authored by kamil).
[web/native] make `overwrite` param for inbound session mandatory and unify web…
Thu, Apr 11, 4:47 AM
kamil committed rCOMM7ca1e329cccc: [native] update session creation code to handle versioning (authored by kamil).
[native] update session creation code to handle versioning
Thu, Apr 11, 4:47 AM
kamil closed D11586: [web] update session creation code to handle versioning.
Thu, Apr 11, 4:47 AM
kamil closed D11583: [web] update `WorkerCryptoStore` to handle session version.
Thu, Apr 11, 4:47 AM
kamil committed rCOMMd860ace3c1f6: [web] update session creation code to handle versioning (authored by kamil).
[web] update session creation code to handle versioning
Thu, Apr 11, 4:47 AM
kamil closed D11582: [native] update C++ crypto module to handle session version.
Thu, Apr 11, 4:47 AM
kamil committed rCOMMcab25122c49c: [web] update `WorkerCryptoStore` to handle session version (authored by kamil).
[web] update `WorkerCryptoStore` to handle session version
Thu, Apr 11, 4:47 AM
kamil committed rCOMMf380159b7402: [native] update C++ crypto module to handle session version (authored by kamil).
[native] update C++ crypto module to handle session version
Thu, Apr 11, 4:47 AM
kamil closed D11580: [SQLite] update `OlmPersistSession` entity.
Thu, Apr 11, 4:47 AM
kamil committed rCOMM0cd2c0f5cc2a: [SQLite] update `OlmPersistSession` entity (authored by kamil).
[SQLite] update `OlmPersistSession` entity
Thu, Apr 11, 4:47 AM
kamil closed D11577: [SQLite] add version column to session table & rename to `target_device`.
Thu, Apr 11, 4:47 AM
kamil committed rCOMMc2ec64740555: [SQLite] add version column to session table & rename to `target_device` (authored by kamil).
[SQLite] add version column to session table & rename to `target_device`
Thu, Apr 11, 4:47 AM
kamil updated the diff for D11596: [lib] handle race condition when creating `olm` session.

lint

Thu, Apr 11, 4:17 AM
kamil updated the diff for D11596: [lib] handle race condition when creating `olm` session.

rebase before landing

Thu, Apr 11, 4:01 AM
kamil added inline comments to D11595: [web/native] make `overwrite` param for inbound session mandatory and unify web & native.
Thu, Apr 11, 4:01 AM
kamil updated the diff for D11595: [web/native] make `overwrite` param for inbound session mandatory and unify web & native.

use olmSessionErrors instead of hardcoded string

Thu, Apr 11, 4:00 AM
kamil updated the diff for D11594: [lib] errors utils to distinguish between session creation issues.

move olmSessionErrors from errors.js to olm-utils.js

Thu, Apr 11, 3:59 AM
kamil updated the diff for D11591: [native] update session creation code to handle versioning.

rebase

Thu, Apr 11, 3:57 AM
kamil updated the diff for D11582: [native] update C++ crypto module to handle session version.

introduce setter & getter

Thu, Apr 11, 3:55 AM
kamil updated the diff for D11580: [SQLite] update `OlmPersistSession` entity.

rebase

Thu, Apr 11, 3:54 AM
kamil added inline comments to D11580: [SQLite] update `OlmPersistSession` entity.
Thu, Apr 11, 3:53 AM
kamil added a comment to D11577: [SQLite] add version column to session table & rename to `target_device`.

We should implement it for notifs while working on DMs - now there is no need to I guess.

Is there a task for this?

I think it is https://linear.app/comm/issue/ENG-7658/add-olm-session-versioning-for-notifs - is that correct @kamil ?

Thu, Apr 11, 3:52 AM
kamil updated the diff for D11577: [SQLite] add version column to session table & rename to `target_device`.

rename to add_version_column_to_olm_persist_sessions_table

Thu, Apr 11, 3:52 AM

Wed, Apr 10

kamil added inline comments to D11582: [native] update C++ crypto module to handle session version.
Wed, Apr 10, 6:07 AM
kamil closed D11574: [web/native] improve rendering Tunnelbroker messages.
Wed, Apr 10, 6:05 AM
kamil committed rCOMM454ad49758a2: [web/native] improve rendering Tunnelbroker messages (authored by kamil).
[web/native] improve rendering Tunnelbroker messages
Wed, Apr 10, 6:05 AM
kamil closed D11572: [web/native] display `userID` & `deviceID` in devtools.
Wed, Apr 10, 6:05 AM
kamil committed rCOMM0e7881604a04: [web/native] display `userID` & `deviceID` in devtools (authored by kamil).
[web/native] display `userID` & `deviceID` in devtools
Wed, Apr 10, 6:05 AM
kamil added a comment to D11577: [SQLite] add version column to session table & rename to `target_device`.
Wed, Apr 10, 6:04 AM
kamil resigned from D11601: [native/web] introduce migration to update notifPermissionAlertInfo to alertStore in redux.

Not familiar with this project so letting others review, persistWhitelist looks good

Wed, Apr 10, 5:54 AM
kamil accepted D11617: [native][web] Start processing thread activity store with sqlite operations.
Wed, Apr 10, 5:48 AM
kamil accepted D11615: [sqlite] Implement processing thread activity on web worker.
Wed, Apr 10, 5:42 AM
kamil accepted D11614: [sqlite] Implement C++ code for native to get sqlite thread activity entries.
Wed, Apr 10, 5:40 AM
kamil accepted D11584: [sqlite/native] Make C++ thread activity sqlite ops available to native.
Wed, Apr 10, 5:38 AM
kamil accepted D11570: [protos][identity] Add RPC for fetching multiple device lists.
Wed, Apr 10, 3:46 AM

Tue, Apr 9

kamil published D11596: [lib] handle race condition when creating `olm` session for review.
Tue, Apr 9, 6:03 AM
kamil published D11595: [web/native] make `overwrite` param for inbound session mandatory and unify web & native for review.
Tue, Apr 9, 6:03 AM
kamil published D11594: [lib] errors utils to distinguish between session creation issues for review.
Tue, Apr 9, 6:03 AM
kamil published D11591: [native] update session creation code to handle versioning for review.
Tue, Apr 9, 6:03 AM
kamil published D11586: [web] update session creation code to handle versioning for review.
Tue, Apr 9, 6:02 AM
kamil published D11583: [web] update `WorkerCryptoStore` to handle session version for review.
Tue, Apr 9, 6:01 AM
kamil published D11582: [native] update C++ crypto module to handle session version for review.
Tue, Apr 9, 6:01 AM
kamil published D11580: [SQLite] update `OlmPersistSession` entity for review.
Tue, Apr 9, 6:01 AM
kamil published D11577: [SQLite] add version column to session table & rename to `target_device` for review.
Tue, Apr 9, 6:00 AM
kamil published D11574: [web/native] improve rendering Tunnelbroker messages for review.
Tue, Apr 9, 6:00 AM
kamil published D11572: [web/native] display `userID` & `deviceID` in devtools for review.
Tue, Apr 9, 6:00 AM

Fri, Apr 5

kamil accepted D11563: [web] Fix user not getting logged out on ops failure.
Fri, Apr 5, 9:39 AM
kamil accepted D11539: [web] Persist messageStore in db.
Fri, Apr 5, 3:50 AM
kamil accepted D11538: [web] Persist userStore in db.

Could you extend the test plan to

  1. Add an unknown user to the friend list
  2. Block user
  3. Using two clients change the avatar on one and check if it gets synced on the other

Refreshing app multiple time between steps

Fri, Apr 5, 3:44 AM
kamil accepted D11545: [web/native/lib] Use message pruner on web.
Fri, Apr 5, 3:42 AM
kamil accepted D11544: [web] Clear database on non-threadStore ops fail.
Fri, Apr 5, 3:40 AM

Thu, Apr 4

kamil accepted D11537: [native] Move MessageStoreTransform to lib.
Thu, Apr 4, 9:06 AM
kamil accepted D11536: [web] Update type field in DB Media struct.
Thu, Apr 4, 9:04 AM
kamil accepted D11535: [lib] Use userStore ops in reducer.
Thu, Apr 4, 9:02 AM
kamil accepted D11541: Introduce fallback mechanism for notifications decryption if MMKV initialization hasn't been executed yet..

Looks good

Thu, Apr 4, 5:11 AM
kamil accepted D11468: [commtest] Add test for LogInExistingDevice RPC.
Thu, Apr 4, 1:59 AM

Wed, Apr 3

kamil added inline comments to D11531: Reorder project.pbxproj after yarn cleaninstall.
Wed, Apr 3, 5:20 AM
kamil resigned from D11530: [scripts] Improve prompt.

LGTM but leaving final review to native speaker

Wed, Apr 3, 5:17 AM
kamil accepted D11526: [keyserver] Update console.warn about default Tunnelbroker instance.
Wed, Apr 3, 5:10 AM

Tue, Apr 2

kamil accepted D11482: [web/native] Migrate keyserverStore to new tables.
Tue, Apr 2, 5:49 AM
kamil accepted D11481: [sqlite/lib] Split keyserver ops for backed and non-backed up data.

Accepting but I am of strong opinion that it would be better to create two new structs: NonSyncedKeyserverInfo and SyncedKeyserverInfo that would look exactly the same as original KeyserverInfo. In SQLiteQueryExecutor methods we would just create instances of each class and could rely on simple SQL queries without named parameters. The code would be easier to understand and maintain. It would be two small classes doing simple logic instead of one bigger doing complex logic.

Tue, Apr 2, 5:41 AM
kamil closed D11451: [native] update `olm` session creation code use `EncryptedData`.
Tue, Apr 2, 4:50 AM
kamil closed D11450: [web] update `olm` session creation code use `EncryptedData`.
Tue, Apr 2, 4:50 AM
kamil closed D11449: [native/web/lib] update Tunnelbroker code to use `EncryptedData`.
Tue, Apr 2, 4:50 AM
kamil committed rCOMM934defb418ba: [native] update `olm` session creation code use `EncryptedData` (authored by kamil).
[native] update `olm` session creation code use `EncryptedData`
Tue, Apr 2, 4:50 AM
kamil committed rCOMM8b91ec580024: [web] update `olm` session creation code use `EncryptedData` (authored by kamil).
[web] update `olm` session creation code use `EncryptedData`
Tue, Apr 2, 4:50 AM
kamil closed D11448: [native] update `decrypt` method use `EncryptedData`.
Tue, Apr 2, 4:50 AM
kamil committed rCOMMcf2726c82cb3: [native/web/lib] update Tunnelbroker code to use `EncryptedData` (authored by kamil).
[native/web/lib] update Tunnelbroker code to use `EncryptedData`
Tue, Apr 2, 4:50 AM
kamil committed rCOMMe82bd482bca4: [native] update `decrypt` method use `EncryptedData` (authored by kamil).
[native] update `decrypt` method use `EncryptedData`
Tue, Apr 2, 4:50 AM
kamil closed D11446: [native] update `encrypt` method to return `EncryptedData`.
Tue, Apr 2, 4:50 AM
kamil closed D11447: [web] update `decrypt` method use `EncryptedData`.
Tue, Apr 2, 4:50 AM
kamil committed rCOMM6fb9738f9734: [web] update `decrypt` method use `EncryptedData` (authored by kamil).
[web] update `decrypt` method use `EncryptedData`
Tue, Apr 2, 4:50 AM
kamil committed rCOMM8e305bc4b8fd: [native] update `encrypt` method to return `EncryptedData` (authored by kamil).
[native] update `encrypt` method to return `EncryptedData`
Tue, Apr 2, 4:50 AM
kamil closed D11445: [web] update `encrypt` method to return `EncryptedData`.
Tue, Apr 2, 4:50 AM
kamil committed rCOMM4d7b6ae221a1: [web] update `encrypt` method to return `EncryptedData` (authored by kamil).
[web] update `encrypt` method to return `EncryptedData`
Tue, Apr 2, 4:50 AM
kamil updated the diff for D11451: [native] update `olm` session creation code use `EncryptedData`.

rebase before landing

Tue, Apr 2, 3:20 AM
kamil updated the diff for D11448: [native] update `decrypt` method use `EncryptedData`.

remove const

Tue, Apr 2, 3:18 AM
kamil accepted D11473: [sqlite] Add keyservers_synced_data table.

Just for clarity - could you link diff where keyservers is added to the backup blacklist?

Tue, Apr 2, 3:11 AM
kamil added inline comments to D11472: [native] Blocklist for backed up tables.
Tue, Apr 2, 3:08 AM
kamil accepted D11467: [commtest] Add helpers for ED25519 signing messages.
Tue, Apr 2, 1:38 AM
kamil accepted D11511: [sqlite] implement processing aux user store ops on worker.
Tue, Apr 2, 1:35 AM
kamil accepted D11422: [lib/native/web] introduce synced metadata reducer.
Tue, Apr 2, 1:34 AM
kamil accepted D11415: [lib] introduce SyncedMetadata store spec.
Tue, Apr 2, 1:30 AM

Fri, Mar 29

kamil published D11451: [native] update `olm` session creation code use `EncryptedData` for review.
Fri, Mar 29, 5:46 AM
kamil published D11450: [web] update `olm` session creation code use `EncryptedData` for review.
Fri, Mar 29, 5:46 AM
kamil published D11449: [native/web/lib] update Tunnelbroker code to use `EncryptedData` for review.
Fri, Mar 29, 5:46 AM
kamil published D11448: [native] update `decrypt` method use `EncryptedData` for review.
Fri, Mar 29, 5:45 AM
kamil published D11447: [web] update `decrypt` method use `EncryptedData` for review.
Fri, Mar 29, 5:45 AM
kamil published D11446: [native] update `encrypt` method to return `EncryptedData` for review.
Fri, Mar 29, 5:45 AM
kamil published D11445: [web] update `encrypt` method to return `EncryptedData` for review.
Fri, Mar 29, 5:45 AM

Thu, Mar 28

kamil accepted D11424: [native][web] read synced metadata on app startup.
Thu, Mar 28, 5:06 AM
kamil requested changes to D11422: [lib/native/web] introduce synced metadata reducer.

LGTM - requesting changes to address this blacklist comment because this is important

Thu, Mar 28, 5:04 AM
kamil accepted D11421: [lib] introduce sync metadata add and remove action types.
Thu, Mar 28, 4:55 AM
kamil accepted D11420: [sqlite] implement processing synced metadata store ops on worker.
Thu, Mar 28, 4:53 AM