Page MenuHomePhabricator

kamil (Kamil Kurowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2022, 1:56 AM (100 w, 4 d)

Recent Activity

Today

kamil closed D12855: [SQLite] rename all QueryExecutor params to `camelCase`.
Tue, Jul 23, 8:18 AM
kamil committed rCOMMdd5c4d502382: [SQLite] rename all QueryExecutor params to `camelCase` (authored by kamil).
[SQLite] rename all QueryExecutor params to `camelCase`
Tue, Jul 23, 8:18 AM
kamil closed D12853: [native] introduce message searching to `CommCoreModule`.
Tue, Jul 23, 8:18 AM
kamil closed D12854: [lib] introduce message searching to `SQLiteAPI`.
Tue, Jul 23, 8:18 AM
kamil committed rCOMM5d535a143135: [lib] introduce message searching to `SQLiteAPI` (authored by kamil).
[lib] introduce message searching to `SQLiteAPI`
Tue, Jul 23, 8:18 AM
kamil committed rCOMM12032bbfe1af: [native] introduce message searching to `CommCoreModule` (authored by kamil).
[native] introduce message searching to `CommCoreModule`
Tue, Jul 23, 8:18 AM
kamil closed D12852: [web] introduce message searching to shared worker.
Tue, Jul 23, 8:18 AM
kamil committed rCOMM81fc7466f203: [web] introduce message searching to shared worker (authored by kamil).
[web] introduce message searching to shared worker
Tue, Jul 23, 8:18 AM
kamil closed D12851: [SQLite] implement tests for messages search.
Tue, Jul 23, 8:18 AM
kamil committed rCOMM7085908cc6d2: [SQLite] implement tests for messages search (authored by kamil).
[SQLite] implement tests for messages search
Tue, Jul 23, 8:18 AM
kamil closed D12850: [SQLite] add Emscripten bindings for message search.
Tue, Jul 23, 8:18 AM
kamil closed D12844: [SQLite] implement query for searching messages.
Tue, Jul 23, 8:18 AM
kamil committed rCOMMffb88c4a6c6d: [SQLite] add Emscripten bindings for message search (authored by kamil).
[SQLite] add Emscripten bindings for message search
Tue, Jul 23, 8:18 AM
kamil committed rCOMM3b9546b1e346: [SQLite] implement query for searching messages (authored by kamil).
[SQLite] implement query for searching messages
Tue, Jul 23, 8:18 AM
kamil closed D12843: [SQLite] add method for message search to SQLiteQueryExecutor for both web and native.
Tue, Jul 23, 8:18 AM
kamil committed rCOMMb290620829de: [SQLite] add method for message search to SQLiteQueryExecutor for both web and… (authored by kamil).
[SQLite] add method for message search to SQLiteQueryExecutor for both web and…
Tue, Jul 23, 8:18 AM
kamil added inline comments to D12670: Implement notification encryption on native.
Tue, Jul 23, 8:10 AM
kamil updated the test plan for D12855: [SQLite] rename all QueryExecutor params to `camelCase`.
Tue, Jul 23, 8:06 AM
kamil added inline comments to D12853: [native] introduce message searching to `CommCoreModule`.
Tue, Jul 23, 8:05 AM
kamil updated the diff for D12852: [web] introduce message searching to shared worker.

merge types

Tue, Jul 23, 7:58 AM
kamil updated the diff for D12851: [SQLite] implement tests for messages search.

address review

Tue, Jul 23, 7:55 AM
kamil added inline comments to D12843: [SQLite] add method for message search to SQLiteQueryExecutor for both web and native.
Tue, Jul 23, 7:16 AM
kamil updated the diff for D12843: [SQLite] add method for message search to SQLiteQueryExecutor for both web and native.

rename

Tue, Jul 23, 7:16 AM
kamil published D12858: [lib] improve naming in Tunnelbroker socket for review.
Tue, Jul 23, 7:06 AM
kamil published D12857: [lib] remove unused Tunnelbroker message validators for review.
Tue, Jul 23, 6:41 AM
kamil published D12856: [Tunnelbroker][lib] cleanup Device <-> Tunnelbroker message types for review.
Tue, Jul 23, 6:20 AM
kamil closed D12842: [Tunnelbroker] implement creating Web Push client.
Tue, Jul 23, 5:17 AM
kamil closed D12841: [Tunnelbroker] implement Web Push config.
Tue, Jul 23, 5:17 AM
kamil committed rCOMM83db0123852e: [Tunnelbroker] implement creating Web Push client (authored by kamil).
[Tunnelbroker] implement creating Web Push client
Tue, Jul 23, 5:17 AM
kamil committed rCOMM303b131d2eff: [Tunnelbroker] implement Web Push config (authored by kamil).
[Tunnelbroker] implement Web Push config
Tue, Jul 23, 5:17 AM
kamil closed D12840: [terraform] add Web Push secrets config.
Tue, Jul 23, 5:17 AM
kamil committed rCOMM4cbf5c9763c4: [terraform] add Web Push secrets config (authored by kamil).
[terraform] add Web Push secrets config
Tue, Jul 23, 5:17 AM
kamil published D12855: [SQLite] rename all QueryExecutor params to `camelCase` for review.
Tue, Jul 23, 5:04 AM
kamil published D12854: [lib] introduce message searching to `SQLiteAPI` for review.
Tue, Jul 23, 5:04 AM
kamil published D12853: [native] introduce message searching to `CommCoreModule` for review.
Tue, Jul 23, 5:04 AM
kamil published D12852: [web] introduce message searching to shared worker for review.
Tue, Jul 23, 5:04 AM
kamil published D12851: [SQLite] implement tests for messages search for review.
Tue, Jul 23, 5:03 AM
kamil published D12850: [SQLite] add Emscripten bindings for message search for review.
Tue, Jul 23, 5:03 AM
kamil published D12844: [SQLite] implement query for searching messages for review.
Tue, Jul 23, 5:03 AM
kamil published D12843: [SQLite] add method for message search to SQLiteQueryExecutor for both web and native for review.
Tue, Jul 23, 5:03 AM
kamil accepted D12837: Bump olm version.
Tue, Jul 23, 1:21 AM

Yesterday

kamil published D12842: [Tunnelbroker] implement creating Web Push client for review.
Mon, Jul 22, 10:16 AM
kamil published D12841: [Tunnelbroker] implement Web Push config for review.
Mon, Jul 22, 10:15 AM
kamil published D12840: [terraform] add Web Push secrets config for review.
Mon, Jul 22, 10:15 AM
kamil closed D12803: [Tunnelbroker] reduce logging spam.
Mon, Jul 22, 3:02 AM
kamil committed rCOMMa470d67e8f52: [Tunnelbroker] reduce logging spam (authored by kamil).
[Tunnelbroker] reduce logging spam
Mon, Jul 22, 3:02 AM
kamil accepted D12804: [native][web] Rename P2P messages methods.
Mon, Jul 22, 2:57 AM

Fri, Jul 19

kamil published D12803: [Tunnelbroker] reduce logging spam for review.
Fri, Jul 19, 7:26 AM
kamil closed D12802: [terraform] Deploy Tunnelbroker 0.11 to staging.
Fri, Jul 19, 7:24 AM
kamil committed rCOMM00abc2d7371f: [terraform] Deploy Tunnelbroker 0.11 to staging (authored by kamil).
[terraform] Deploy Tunnelbroker 0.11 to staging
Fri, Jul 19, 7:24 AM
kamil published D12802: [terraform] Deploy Tunnelbroker 0.11 to staging for review.
Fri, Jul 19, 7:10 AM
kamil closed D12773: [Tunnelbroker] simplify retrieving device token.
Fri, Jul 19, 5:45 AM
kamil committed rCOMM277b5d3e7ec5: [Tunnelbroker] simplify retrieving device token (authored by kamil).
[Tunnelbroker] simplify retrieving device token
Fri, Jul 19, 5:45 AM
kamil closed D12771: [Tunnelbroker] implement sending FCM notifs by client.
Fri, Jul 19, 5:45 AM
kamil closed D12772: [lib] implement sending FCM notifs using Tunnelbroker.
Fri, Jul 19, 5:45 AM
kamil committed rCOMM0026f1d14eae: [lib] implement sending FCM notifs using Tunnelbroker (authored by kamil).
[lib] implement sending FCM notifs using Tunnelbroker
Fri, Jul 19, 5:45 AM
kamil committed rCOMM781cf567e424: [Tunnelbroker] implement sending FCM notifs by client (authored by kamil).
[Tunnelbroker] implement sending FCM notifs by client
Fri, Jul 19, 5:45 AM
kamil closed D12770: [Tunnelbroker][lib] add FCM notif message type.
Fri, Jul 19, 5:44 AM
kamil committed rCOMMf614a5cf3713: [Tunnelbroker][lib] add FCM notif message type (authored by kamil).
[Tunnelbroker][lib] add FCM notif message type
Fri, Jul 19, 5:44 AM
kamil updated the diff for D12770: [Tunnelbroker][lib] add FCM notif message type.

improve type

Fri, Jul 19, 5:32 AM
kamil accepted D12748: Expose function to get notifs inbound keys to C++.
Fri, Jul 19, 5:31 AM
kamil accepted D12728: Implement Android HTTP call to identity to get notifs inbound keys.
Fri, Jul 19, 5:26 AM
kamil accepted D12801: [lib][web] Add worker logic for adding search messages.
Fri, Jul 19, 5:20 AM
kamil accepted D12796: [native] Add CommCoreModule code for inserting into the search table.
Fri, Jul 19, 5:16 AM
kamil accepted D12795: [native] Add message search store.

You need to add this to Cmake - example in D11509

Fri, Jul 19, 5:15 AM
kamil closed D12768: [Tunnelbroker] implement errors from FCM service.
Fri, Jul 19, 5:05 AM
kamil closed D12769: [Tunnelbroker] implement sending FCM message.
Fri, Jul 19, 5:05 AM
kamil committed rCOMM666c07b51945: [Tunnelbroker] implement sending FCM message (authored by kamil).
[Tunnelbroker] implement sending FCM message
Fri, Jul 19, 5:05 AM
kamil committed rCOMM46548e0657dd: [Tunnelbroker] implement errors from FCM service (authored by kamil).
[Tunnelbroker] implement errors from FCM service
Fri, Jul 19, 5:05 AM
kamil closed D12767: [Tunnelbroker] implement messages types to FCM service.
Fri, Jul 19, 5:05 AM
kamil closed D12766: [Tunnelbroker] implement FCM Access Token lifetime.
Fri, Jul 19, 5:05 AM
kamil committed rCOMM211db5e62aaf: [Tunnelbroker] implement messages types to FCM service (authored by kamil).
[Tunnelbroker] implement messages types to FCM service
Fri, Jul 19, 5:05 AM
kamil closed D12765: [Tunnelbroker] implement requesting FCM access token using OAuth 2.0.
Fri, Jul 19, 5:05 AM
kamil committed rCOMMcb4ca298599a: [Tunnelbroker] implement FCM Access Token lifetime (authored by kamil).
[Tunnelbroker] implement FCM Access Token lifetime
Fri, Jul 19, 5:05 AM
kamil committed rCOMM61a0eb1ab64f: [Tunnelbroker] implement requesting FCM access token using OAuth 2.0 (authored by kamil).
[Tunnelbroker] implement requesting FCM access token using OAuth 2.0
Fri, Jul 19, 5:05 AM
kamil closed D12754: [Tunnelbroker] implement OAuth 2.0 JWT token encoding.
Fri, Jul 19, 5:05 AM
kamil committed rCOMM4a7e8b46ea8b: [Tunnelbroker] implement OAuth 2.0 JWT token encoding (authored by kamil).
[Tunnelbroker] implement OAuth 2.0 JWT token encoding
Fri, Jul 19, 5:05 AM
kamil closed D12753: [Tunnelbroker] implement creating FCM client.
Fri, Jul 19, 5:05 AM
kamil committed rCOMM3fffc98ab522: [Tunnelbroker] implement creating FCM client (authored by kamil).
[Tunnelbroker] implement creating FCM client
Fri, Jul 19, 5:05 AM
kamil closed D12752: [Tunnelbroker] implement FCM config.
Fri, Jul 19, 5:05 AM
kamil committed rCOMMf7ebad858026: [Tunnelbroker] implement FCM config (authored by kamil).
[Tunnelbroker] implement FCM config
Fri, Jul 19, 5:05 AM
kamil closed D12751: [terraform] add FCM secrets config.
Fri, Jul 19, 5:02 AM
kamil accepted D12794: [native] Add MessageSearchStoreOperations.
Fri, Jul 19, 5:02 AM
kamil committed rCOMM8cebb5402ed4: [terraform] add FCM secrets config (authored by kamil).
[terraform] add FCM secrets config
Fri, Jul 19, 5:02 AM
kamil accepted D12783: [web] Add bindings for inserting into the search table.
Fri, Jul 19, 4:57 AM
kamil accepted D12778: [native] Add SQLiteQueryExecutor code for inserting into the search table.
Fri, Jul 19, 4:57 AM
kamil accepted D12694: [native](web) Add message_search fts5 table.

Could you update the spacing to match the rest of the file?

Fri, Jul 19, 4:05 AM
kamil accepted D12693: [native][web] Add fts5 extension to SQLite.
Fri, Jul 19, 3:55 AM
kamil added inline comments to D12769: [Tunnelbroker] implement sending FCM message.
Fri, Jul 19, 3:35 AM
kamil updated the diff for D12769: [Tunnelbroker] implement sending FCM message.

address review

Fri, Jul 19, 2:54 AM
kamil added inline comments to D12767: [Tunnelbroker] implement messages types to FCM service.
Fri, Jul 19, 2:19 AM
kamil updated the diff for D12766: [Tunnelbroker] implement FCM Access Token lifetime.

rename

Fri, Jul 19, 2:18 AM
kamil updated the diff for D12754: [Tunnelbroker] implement OAuth 2.0 JWT token encoding.

add code comment

Fri, Jul 19, 2:13 AM
kamil updated the diff for D12753: [Tunnelbroker] implement creating FCM client.

rename

Fri, Jul 19, 2:11 AM

Thu, Jul 18

kamil added inline comments to D12770: [Tunnelbroker][lib] add FCM notif message type.
Thu, Jul 18, 8:18 AM
kamil accepted D12786: [lib] Track progress of message processing.

I think the usage of if and dmOpID can be improved and more descriptive, this might look confusing as we have plenty IDs all over the codebase - but I don't have idea about better ones

Thu, Jul 18, 7:18 AM
kamil accepted D12776: [lib] Generate P2P messages based on actions.
Thu, Jul 18, 7:04 AM
kamil accepted D12775: [lib] Fix an invalid condition.

🤦‍♂️🙄
Thanks for fixing

Thu, Jul 18, 6:44 AM
kamil requested changes to D12749: [lib] Stop requiring sequential messages.

I think this should be done at different level:

  1. Use decrypt here: https://github.com/CommE2E/comm/blob/8b786f1788c01edce880256d4f5318ce54342f29/native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp#L1619
  2. Rename decryptSequentialAndPersist -> decryptAndPersist
Thu, Jul 18, 6:41 AM
kamil accepted D12747: [lib] Enable automatic retries for some messages.
Thu, Jul 18, 6:36 AM