User Details
User Details
- User Since
- Aug 19 2022, 1:56 AM (113 w, 6 d)
Yesterday
Yesterday
Mon, Oct 21
Mon, Oct 21
Thu, Oct 17
Thu, Oct 17
According to this comment worth adding this to encryption related errors:
kamil committed rCOMM0e7e02b9796f: [lib] update `processDMOpsActionType` action to return all ops (authored by kamil).
[lib] update `processDMOpsActionType` action to return all ops
kamil published D13739: [lib] update `processDMOpsActionType` action to return all ops for review.
Tue, Oct 15
Tue, Oct 15
nit: worth adding a link to the Linear issue in diff summary, this always gives a reviewer a bit more context
Mon, Oct 14
Mon, Oct 14
kamil committed rCOMM0ea97c431b17: [lib] extract code responsible for confirming P2P message to a hook (authored by kamil).
[lib] extract code responsible for confirming P2P message to a hook
[lib] send confirmation for ignored DM ops
kamil committed rCOMMac6468e24614: [lib] move calling `getThreadUpdatesForNewMessages` to `reduceThreadInfos` (authored by kamil).
[lib] move calling `getThreadUpdatesForNewMessages` to `reduceThreadInfos`
kamil added a comment to D13661: [lib] move calling `getThreadUpdatesForNewMessages` to `reduceThreadInfos`.
I'm going to land it now to fix it - but if the comment is still not okay, I can update this later as a follow-up.
kamil updated the diff for D13661: [lib] move calling `getThreadUpdatesForNewMessages` to `reduceThreadInfos`.
update comment
kamil updated the diff for D13663: [lib] send confirmation for ignored DM ops.
use await
kamil updated the diff for D13662: [lib] extract code responsible for confirming P2P message to a hook.
add await
Fri, Oct 11
Fri, Oct 11
kamil added inline comments to D13661: [lib] move calling `getThreadUpdatesForNewMessages` to `reduceThreadInfos`.
Thu, Oct 10
Thu, Oct 10
kamil added inline comments to D13655: [lib] Add types for Blob Service requests and responses.
- I don't think we need validators for requests, those won't be used
- Can you reference the Rust file here, and This file in Rust codebase? Similar to code here.
kamil requested changes to D13647: [blob] Add support for removing holders by tags.
kamil added inline comments to D13661: [lib] move calling `getThreadUpdatesForNewMessages` to `reduceThreadInfos`.
Wed, Oct 9
Wed, Oct 9
kamil published D13663: [lib] send confirmation for ignored DM ops for review.
kamil published D13662: [lib] extract code responsible for confirming P2P message to a hook for review.
kamil published D13661: [lib] move calling `getThreadUpdatesForNewMessages` to `reduceThreadInfos` for review.
kamil committed rCOMM3be5aa38370e: [terraform] Bump staging Tunnelbroker to 0.18.1 (authored by bartek).
[terraform] Bump staging Tunnelbroker to 0.18.1
kamil committed rCOMM6f0c5fa2a405: [Tunnelbroker] deprecate errors about invalidating device token (authored by kamil).
[Tunnelbroker] deprecate errors about invalidating device token
kamil published D13659: [Tunnelbroker] deprecate errors about invalidating device token for review.
kamil requested changes to D13623: [lib] Use queue when processing inbound messages from the DB.
I feel like we duplicating logic here now, having two queues, the best solution here will be to use only useActionsQueue and get rid off
const [messagesQueue, setMessagesQueue] = React.useState< $ReadOnlyArray<{ +peerToPeerMessage: PeerToPeerMessage, +messageID: string, +localSocketSessionCounter: number, }>, >([]);
Mon, Oct 7
Mon, Oct 7
kamil committed rCOMMacfc1987fde6: [Tunnelbroker] retry FCM notif after receiving `401 Unauthorized` (authored by kamil).
[Tunnelbroker] retry FCM notif after receiving `401 Unauthorized`
kamil added inline comments to D13606: [tunnelbroker] Recover AMQP consumers.
Looks a lot more cleaner now
Nice work with locks
Sun, Oct 6
Sun, Oct 6
Thu, Oct 3
Thu, Oct 3
kamil updated the summary of D13586: [Tunnelbroker] retry FCM notif after receiving `401 Unauthorized`.
kamil published D13586: [Tunnelbroker] retry FCM notif after receiving `401 Unauthorized` for review.
Wed, Oct 2
Wed, Oct 2
kamil published D13576: [lib] fix `PushHandler` to support DMs for review.
kamil committed rCOMMfb674c2f263b: [lib] remove checking for message IDs collision (authored by kamil).
[lib] remove checking for message IDs collision
kamil published D13573: [lib] remove checking for message IDs collision for review.
kamil added a comment to D13563: [lib] Stop processOutboundMessages loop when it becomes outdated.
(sorry for the confusing naming in the code above, this is just a draft to describe the idea)
kamil added a comment to D13563: [lib] Stop processOutboundMessages loop when it becomes outdated.
Good find, and the fix looks good.
Tue, Oct 1
Tue, Oct 1
Mon, Sep 30
Mon, Sep 30
kamil committed rCOMM1fe84ce2c20f: [lib] implement checking if user supports thick thread (authored by kamil).
[lib] implement checking if user supports thick thread
kamil committed rCOMM27f1759c2c3c: [lib] factor out `useFindUserIdentities` to a separate file (authored by kamil).
[lib] factor out `useFindUserIdentities` to a separate file