User Details
- User Since
- Aug 19 2022, 1:56 AM (57 w, 1 d)
Yesterday
Accepting to unblock, but please look at my comment about moving clearance code to DatabaseManager::clearSensitiveData()
Fri, Sep 15
Looks good but please add the dependency array
Different convention than useDispatchActionPromise, but the reason sounds convincing.
Thu, Sep 14
unwrap -> expect
use error!
address review
rebase before landing
Wed, Sep 13
- address review
- review before landing
rebase before landing
address review
rebase before landing
rebase before landing
rebase before landing
Tue, Sep 12
CI
rebase
- curve25519 -> ed25519
- deviceID -> userID
- remove auto-establishing session
Looks like a straightforward change
Could you add to the test plan case, when you first apply this diff and then log in? (I remember this was a tricky case when implementing the first version)
Mon, Sep 11
Some more bugs I found while testing D8918, I will address them later
LGTM but letting other reviewers take a look
Looks good! Only some questions inline
Sun, Sep 10
Thanks for this!
Hey no worries, this is a good shout. The reason that the tooltip is positioned like that is because the tooltip has 3 parts the label, the action buttons, and the timestamp and we center align based on all three of those elements
I can see that the placement is still bit wonky when the label is missing, but I feel like this might be outside the scope of this diff. I created a follow up linear task to eventually address this
https://linear.app/comm/issue/ENG-4879/make-the-message-action-tooltip-more-aligned-with-the-message
Fri, Sep 8
Tested with real keyserver:
- send the correct message and check if it passes validation
- send a malformed message and check if an error is thrown
rebase
- updated event type
- update message type value to reflect value defined in Rust
- test with real keyserver, tests are not accurate
- rebase
- update comment
- update comment
- deviceId -> deviceID