Page MenuHomePhabricator

kamil (Kamil Kurowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2022, 1:56 AM (113 w, 6 d)

Recent Activity

Yesterday

kamil accepted D13757: [lib] Restart session when any Olm error is thrown.
Wed, Oct 23, 6:41 AM

Mon, Oct 21

kamil accepted D13729: [lib] Update usages of userHasDeviceList to acknowledge accountMissingStatus.
Mon, Oct 21, 3:26 AM

Thu, Oct 17

kamil accepted D13725: [lib] Show staff alerts when an operation isn't processed.

According to this comment worth adding this to encryption related errors:

Thu, Oct 17, 7:32 AM
kamil accepted D13724: [lib] Add an alert to the lib config.
Thu, Oct 17, 7:26 AM
kamil closed D13739: [lib] update `processDMOpsActionType` action to return all ops.
Thu, Oct 17, 2:01 AM
kamil committed rCOMM0e7e02b9796f: [lib] update `processDMOpsActionType` action to return all ops (authored by kamil).
[lib] update `processDMOpsActionType` action to return all ops
Thu, Oct 17, 2:01 AM
kamil published D13739: [lib] update `processDMOpsActionType` action to return all ops for review.
Thu, Oct 17, 1:35 AM

Tue, Oct 15

kamil accepted D13706: [web] Add ellipsis on longer thread names.

nit: worth adding a link to the Linear issue in diff summary, this always gives a reviewer a bit more context

Tue, Oct 15, 11:38 PM
kamil accepted D13711: [terraform] Staging: deploy Blob 1.2.1, Identity 0.42.
Tue, Oct 15, 4:29 AM
kamil accepted D13709: [native] Fix reacting to robotext when sidebar is disabled.
Tue, Oct 15, 1:12 AM
kamil accepted D13708: [web] Fix reacting to robotext.
Tue, Oct 15, 1:10 AM
kamil accepted D13707: [native][web] Fix robotext thread creation.
Tue, Oct 15, 1:10 AM
kamil accepted D13704: [commtest] Add test for removing holders on logout.
Tue, Oct 15, 1:06 AM

Mon, Oct 14

kamil accepted D13705: [terraform] Deploy Tunnelbroker 0.18.1 to prod.
Mon, Oct 14, 6:43 AM
kamil closed D13663: [lib] send confirmation for ignored DM ops.
Mon, Oct 14, 4:07 AM
kamil closed D13662: [lib] extract code responsible for confirming P2P message to a hook.
Mon, Oct 14, 4:07 AM
kamil committed rCOMM0ea97c431b17: [lib] extract code responsible for confirming P2P message to a hook (authored by kamil).
[lib] extract code responsible for confirming P2P message to a hook
Mon, Oct 14, 4:07 AM
kamil committed rCOMMeed6217c4364: [lib] send confirmation for ignored DM ops (authored by kamil).
[lib] send confirmation for ignored DM ops
Mon, Oct 14, 4:07 AM
kamil closed D13661: [lib] move calling `getThreadUpdatesForNewMessages` to `reduceThreadInfos`.
Mon, Oct 14, 4:07 AM
kamil committed rCOMMac6468e24614: [lib] move calling `getThreadUpdatesForNewMessages` to `reduceThreadInfos` (authored by kamil).
[lib] move calling `getThreadUpdatesForNewMessages` to `reduceThreadInfos`
Mon, Oct 14, 4:06 AM
kamil added a comment to D13661: [lib] move calling `getThreadUpdatesForNewMessages` to `reduceThreadInfos`.

I'm going to land it now to fix it - but if the comment is still not okay, I can update this later as a follow-up.

Mon, Oct 14, 3:41 AM
kamil updated the diff for D13661: [lib] move calling `getThreadUpdatesForNewMessages` to `reduceThreadInfos`.

update comment

Mon, Oct 14, 3:37 AM
kamil updated the diff for D13663: [lib] send confirmation for ignored DM ops.

use await

Mon, Oct 14, 3:29 AM
kamil updated the diff for D13662: [lib] extract code responsible for confirming P2P message to a hook.

add await

Mon, Oct 14, 3:28 AM
kamil accepted D13623: [lib] Use queue when processing inbound messages from the DB.
Mon, Oct 14, 3:21 AM
kamil accepted D13703: [tunnelbroker] Ignore CONNECTIONFORCED error message.
Mon, Oct 14, 2:56 AM

Fri, Oct 11

kamil added inline comments to D13661: [lib] move calling `getThreadUpdatesForNewMessages` to `reduceThreadInfos`.
Fri, Oct 11, 1:07 AM

Thu, Oct 10

kamil accepted D13647: [blob] Add support for removing holders by tags.
Thu, Oct 10, 7:40 AM
kamil accepted D13657: [lib] Use batch Blob service endpoints in processHolders action.
Thu, Oct 10, 3:14 AM
kamil accepted D13656: [lib] Use response validators in multiple-holder calls.
Thu, Oct 10, 2:50 AM
kamil added inline comments to D13655: [lib] Add types for Blob Service requests and responses.
Thu, Oct 10, 2:49 AM
kamil accepted D13655: [lib] Add types for Blob Service requests and responses.
  1. I don't think we need validators for requests, those won't be used
  2. Can you reference the Rust file here, and This file in Rust codebase? Similar to code here.
Thu, Oct 10, 2:47 AM
kamil accepted D13652: [identity] Remove blob holders on logout and account deletion.
Thu, Oct 10, 2:37 AM
kamil accepted D13651: [identity] Pass Blob client to AuthenticatedService.
Thu, Oct 10, 2:35 AM
kamil accepted D13650: [identity] Add function to remove holders for devices.
Thu, Oct 10, 2:34 AM
kamil accepted D13649: [comm-lib] Add missing feature dependency to Cargo.toml.
Thu, Oct 10, 2:28 AM
kamil accepted D13643: [identity] Move backup and tunnelbroker mods to a submodule.
Thu, Oct 10, 2:27 AM
kamil accepted D13642: [terraform] Provide Blob service addr to Identity env.
Thu, Oct 10, 2:26 AM
kamil accepted D13641: [identity] Add config for Blob service URL.
Thu, Oct 10, 2:25 AM
kamil accepted D13648: [comm-lib][blob-client] Add support for removing holders by tags.
Thu, Oct 10, 2:23 AM
kamil requested changes to D13647: [blob] Add support for removing holders by tags.
Thu, Oct 10, 2:16 AM
kamil accepted D13646: [comm-lib][blob] Add tags support to remove holders request payload.
Thu, Oct 10, 2:11 AM
kamil accepted D13645: [comm-lib][blob-client] Extract error handling logic.
Thu, Oct 10, 2:05 AM
kamil accepted D13644: [comm-lib] Add remove_multiple_holders to Blob client.
Thu, Oct 10, 2:02 AM
kamil accepted D13618: [blob] Add DB method to query holders by prefix.
Thu, Oct 10, 1:58 AM
kamil accepted D13615: [blob] Store indexable tag in DDB for holders.
Thu, Oct 10, 1:53 AM
kamil accepted D13617: [blob] Move HTTP request/response types to comm-lib.
Thu, Oct 10, 1:16 AM
kamil added inline comments to D13661: [lib] move calling `getThreadUpdatesForNewMessages` to `reduceThreadInfos`.
Thu, Oct 10, 1:07 AM

Wed, Oct 9

kamil published D13663: [lib] send confirmation for ignored DM ops for review.
Wed, Oct 9, 7:52 AM
kamil published D13662: [lib] extract code responsible for confirming P2P message to a hook for review.
Wed, Oct 9, 7:51 AM
kamil published D13661: [lib] move calling `getThreadUpdatesForNewMessages` to `reduceThreadInfos` for review.
Wed, Oct 9, 7:11 AM
kamil closed D13660: [terraform] Bump staging Tunnelbroker to 0.18.1.
Wed, Oct 9, 5:23 AM
kamil committed rCOMM3be5aa38370e: [terraform] Bump staging Tunnelbroker to 0.18.1 (authored by bartek).
[terraform] Bump staging Tunnelbroker to 0.18.1
Wed, Oct 9, 5:23 AM
kamil commandeered D13660: [terraform] Bump staging Tunnelbroker to 0.18.1.
Wed, Oct 9, 5:18 AM
kamil accepted D13660: [terraform] Bump staging Tunnelbroker to 0.18.1.
Wed, Oct 9, 5:17 AM
kamil closed D13659: [Tunnelbroker] deprecate errors about invalidating device token.
Wed, Oct 9, 4:03 AM
kamil committed rCOMM6f0c5fa2a405: [Tunnelbroker] deprecate errors about invalidating device token (authored by kamil).
[Tunnelbroker] deprecate errors about invalidating device token
Wed, Oct 9, 4:03 AM
kamil accepted D13654: [lib] Make types consistent for assignMultipleHolders.
Wed, Oct 9, 3:41 AM
kamil published D13659: [Tunnelbroker] deprecate errors about invalidating device token for review.
Wed, Oct 9, 3:38 AM
kamil requested changes to D13623: [lib] Use queue when processing inbound messages from the DB.

I feel like we duplicating logic here now, having two queues, the best solution here will be to use only useActionsQueue and get rid off

const [messagesQueue, setMessagesQueue] = React.useState<
  $ReadOnlyArray<{
    +peerToPeerMessage: PeerToPeerMessage,
    +messageID: string,
    +localSocketSessionCounter: number,
  }>,
>([]);
Wed, Oct 9, 1:51 AM

Mon, Oct 7

kamil accepted D13622: [tunnelbroker] Enable Auto-ACK for AMQP consumers.
Mon, Oct 7, 4:38 AM
kamil closed D13586: [Tunnelbroker] retry FCM notif after receiving `401 Unauthorized`.
Mon, Oct 7, 2:57 AM
kamil committed rCOMMacfc1987fde6: [Tunnelbroker] retry FCM notif after receiving `401 Unauthorized` (authored by kamil).
[Tunnelbroker] retry FCM notif after receiving `401 Unauthorized`
Mon, Oct 7, 2:57 AM
kamil accepted D13608: [tunnelbroker] Ignore connection error messages handled elsewhere.
Mon, Oct 7, 2:50 AM
kamil accepted D13606: [tunnelbroker] Recover AMQP consumers.
Mon, Oct 7, 2:37 AM
kamil accepted D13621: [tunnelbroker] Implement lazy AMQP channel wrapper.
Mon, Oct 7, 2:33 AM
kamil accepted D13611: [tunnelbroker] Recover AMQP before publishing messages.
Mon, Oct 7, 2:25 AM
kamil accepted D13609: [tunnelbroker] Remove legacy AMQP connect function.
Mon, Oct 7, 2:24 AM
kamil accepted D13607: [tunnelbroker] Trigger AMQP reconnect when closing session.
Mon, Oct 7, 2:22 AM
kamil added inline comments to D13606: [tunnelbroker] Recover AMQP consumers.
Mon, Oct 7, 2:15 AM
kamil accepted D13605: [tunnelbroker] Refactor Websocket session init.

Looks a lot more cleaner now

Mon, Oct 7, 2:04 AM
kamil accepted D13604: [tunnelbroker] Use AMQP wrapper in servers.
Mon, Oct 7, 1:52 AM
kamil accepted D13603: [tunnelbroker] Implement AMQP reconnect on channel access.

Nice work with locks

Mon, Oct 7, 1:47 AM
kamil accepted D13601: [tunnelbroker] Create thread-safe wrapper over AMQP connection.
Mon, Oct 7, 1:42 AM
kamil accepted D13600: [tunnelbroker] Split AMQP connect function.
Mon, Oct 7, 1:35 AM
kamil accepted D13594: [tunnelbroker] Add exponential backoff to AMQP connection.
Mon, Oct 7, 1:34 AM
kamil accepted D13593: [tunnelbroker] Add error listener for AMQP.
Mon, Oct 7, 1:29 AM
kamil accepted D13592: [tunnelbroker] Run AMQP on Tokio runtime.
Mon, Oct 7, 12:51 AM
kamil accepted D13591: [tunnelbroker] Disable CSAT verification if env var is set.
Mon, Oct 7, 12:51 AM

Sun, Oct 6

kamil accepted D13612: [tunnelbroker] Fix error handling in main.
Sun, Oct 6, 11:41 PM

Thu, Oct 3

kamil accepted D13589: [lib] Update the dev invite link URL.
Thu, Oct 3, 6:10 AM
kamil accepted D13588: [keyserver] Handle null browser detection result.
Thu, Oct 3, 6:10 AM
kamil accepted D13587: [lib] Bump detect-browser version.
Thu, Oct 3, 6:08 AM
kamil updated the summary of D13586: [Tunnelbroker] retry FCM notif after receiving `401 Unauthorized`.
Thu, Oct 3, 3:39 AM
kamil published D13586: [Tunnelbroker] retry FCM notif after receiving `401 Unauthorized` for review.
Thu, Oct 3, 3:26 AM

Wed, Oct 2

kamil published D13576: [lib] fix `PushHandler` to support DMs for review.
Wed, Oct 2, 8:59 AM
kamil closed D13573: [lib] remove checking for message IDs collision.
Wed, Oct 2, 6:52 AM
kamil committed rCOMMfb674c2f263b: [lib] remove checking for message IDs collision (authored by kamil).
[lib] remove checking for message IDs collision
Wed, Oct 2, 6:52 AM
kamil published D13573: [lib] remove checking for message IDs collision for review.
Wed, Oct 2, 6:27 AM
kamil added a comment to D13563: [lib] Stop processOutboundMessages loop when it becomes outdated.

(sorry for the confusing naming in the code above, this is just a draft to describe the idea)

Wed, Oct 2, 3:24 AM
kamil added a comment to D13563: [lib] Stop processOutboundMessages loop when it becomes outdated.

Good find, and the fix looks good.

Wed, Oct 2, 3:20 AM
kamil accepted D13517: [lib] Don't prefix keyserver-owned holders with device ID.
Wed, Oct 2, 1:43 AM
kamil accepted D13511: [keyserver][lib] Blob client function to remove multiple holders.
Wed, Oct 2, 12:56 AM

Tue, Oct 1

kamil accepted D13522: [lib] Make NotificationsCreationData read-only.
Tue, Oct 1, 1:37 AM

Mon, Sep 30

kamil accepted D13519: [lib] Update pending thread type based on selected members.
Mon, Sep 30, 6:40 AM
kamil accepted D13516: [blob] Don't log request payload in tracing span.
Mon, Sep 30, 6:35 AM
kamil closed D13489: [lib] implement checking if user supports thick thread.
Mon, Sep 30, 5:34 AM
kamil committed rCOMM1fe84ce2c20f: [lib] implement checking if user supports thick thread (authored by kamil).
[lib] implement checking if user supports thick thread
Mon, Sep 30, 5:34 AM
kamil closed D13518: [lib] factor out `useFindUserIdentities` to a separate file.
Mon, Sep 30, 5:34 AM
kamil committed rCOMM27f1759c2c3c: [lib] factor out `useFindUserIdentities` to a separate file (authored by kamil).
[lib] factor out `useFindUserIdentities` to a separate file
Mon, Sep 30, 5:34 AM