User Details
User Details
- User Since
- Aug 19 2022, 1:56 AM (88 w, 23 h)
Yesterday
Yesterday
kamil added inline comments to D11715: Update native backup code to handle siwe backup message.
I think you should rename the generic backup_message to siwe_backup_message
kamil added a comment to D11714: Introduce function to get path to a file to temporarily save backup message.
Two questions:
- Could you explain why we need backupID? The message to sign seems generic and wondering if we need a separate file for each backupID
- Is there an easy way to somehow unify getSIWEBackupMessagePath with getBackupUserKeysFilePath which is basically doing the same?
Thu, Apr 25
Thu, Apr 25
kamil added inline comments to D11723: [SQLite] add queries to decrypted messages table.
kamil added inline comments to D11722: [SQLite] add table to persist decrypted messages.
Tue, Apr 23
Tue, Apr 23
kamil published D11737: [lib] confirm Tunnelbroker messages after processing for review.
kamil published D11732: [lib] handle Tunnelbroker messages sequentially for review.
kamil published D11739: [web] render `DBOpsHandler` in `TunnelbrokerProvider` for review.
kamil published D11731: [lib/web/native] implement sending confirmation of processed message for review.
kamil published D11730: [lib/web/native] update `MessageID` in ops handling for review.
kamil published D11729: [native/web] rename `decryptSequential` -> `decryptSequentialAndPersist` for review.
kamil published D11728: [web] decrypt and persist plaintext in SQL transaction for review.
kamil published D11727: [CommCoreModule] decrypt and persist plaintext in SQL transaction for review.
kamil published D11726: [SQLite/lib] implement shared SQLite interface for review.
kamil published D11725: [SQLite/native] implement received message to device API for review.
kamil published D11724: [SQLite/web] implement received message to device API for review.
kamil published D11723: [SQLite] add queries to decrypted messages table for review.
kamil published D11722: [SQLite] add table to persist decrypted messages for review.
kamil published D11721: [native/web] add SQL transaction to persisting crypto module for review.
kamil published D11720: [lib] update P2P message handler to use sequential decrypt for review.
kamil published D11719: [web/lib] add sequential decrypt to `olmAPI` for review.
kamil published D11718: [CommCoreModule] add sequential decrypt to crypto API for review.
kamil published D11717: [CryptoModule] add sequential decrypt to crypto API for review.
Mon, Apr 22
Mon, Apr 22
kamil added inline comments to D11583: [web] update `WorkerCryptoStore` to handle session version.
Thu, Apr 18
Thu, Apr 18
Thu, Apr 11
Thu, Apr 11
kamil committed rCOMMc5fb96765cbb: [lib] handle race condition when creating `olm` session (authored by kamil).
[lib] handle race condition when creating `olm` session
kamil committed rCOMMf4b392ccb485: [lib] errors utils to distinguish between session creation issues (authored by kamil).
[lib] errors utils to distinguish between session creation issues
kamil committed rCOMM497a5f739b62: [web/native] make `overwrite` param for inbound session mandatory and unify web… (authored by kamil).
[web/native] make `overwrite` param for inbound session mandatory and unify web…
kamil committed rCOMM7ca1e329cccc: [native] update session creation code to handle versioning (authored by kamil).
[native] update session creation code to handle versioning
kamil committed rCOMMd860ace3c1f6: [web] update session creation code to handle versioning (authored by kamil).
[web] update session creation code to handle versioning
kamil committed rCOMMcab25122c49c: [web] update `WorkerCryptoStore` to handle session version (authored by kamil).
[web] update `WorkerCryptoStore` to handle session version
kamil committed rCOMMf380159b7402: [native] update C++ crypto module to handle session version (authored by kamil).
[native] update C++ crypto module to handle session version
[SQLite] update `OlmPersistSession` entity
kamil committed rCOMMc2ec64740555: [SQLite] add version column to session table & rename to `target_device` (authored by kamil).
[SQLite] add version column to session table & rename to `target_device`
kamil updated the diff for D11596: [lib] handle race condition when creating `olm` session.
lint
kamil updated the diff for D11596: [lib] handle race condition when creating `olm` session.
rebase before landing
kamil added inline comments to D11595: [web/native] make `overwrite` param for inbound session mandatory and unify web & native.
kamil updated the diff for D11595: [web/native] make `overwrite` param for inbound session mandatory and unify web & native.
use olmSessionErrors instead of hardcoded string
kamil updated the diff for D11594: [lib] errors utils to distinguish between session creation issues.
move olmSessionErrors from errors.js to olm-utils.js
kamil updated the diff for D11591: [native] update session creation code to handle versioning.
rebase
kamil updated the diff for D11582: [native] update C++ crypto module to handle session version.
introduce setter & getter
kamil updated the diff for D11580: [SQLite] update `OlmPersistSession` entity.
rebase
kamil added inline comments to D11580: [SQLite] update `OlmPersistSession` entity.
kamil added a comment to D11577: [SQLite] add version column to session table & rename to `target_device`.
kamil updated the diff for D11577: [SQLite] add version column to session table & rename to `target_device`.
rename to add_version_column_to_olm_persist_sessions_table
Wed, Apr 10
Wed, Apr 10
kamil added inline comments to D11582: [native] update C++ crypto module to handle session version.
kamil committed rCOMM454ad49758a2: [web/native] improve rendering Tunnelbroker messages (authored by kamil).
[web/native] improve rendering Tunnelbroker messages
kamil committed rCOMM0e7881604a04: [web/native] display `userID` & `deviceID` in devtools (authored by kamil).
[web/native] display `userID` & `deviceID` in devtools
kamil added a comment to D11577: [SQLite] add version column to session table & rename to `target_device`.
kamil resigned from D11601: [native/web] introduce migration to update notifPermissionAlertInfo to alertStore in redux.
Not familiar with this project so letting others review, persistWhitelist looks good
Tue, Apr 9
Tue, Apr 9
kamil published D11596: [lib] handle race condition when creating `olm` session for review.
kamil published D11594: [lib] errors utils to distinguish between session creation issues for review.
kamil published D11591: [native] update session creation code to handle versioning for review.
kamil published D11586: [web] update session creation code to handle versioning for review.
kamil published D11583: [web] update `WorkerCryptoStore` to handle session version for review.
kamil published D11582: [native] update C++ crypto module to handle session version for review.
kamil published D11580: [SQLite] update `OlmPersistSession` entity for review.
kamil published D11577: [SQLite] add version column to session table & rename to `target_device` for review.
kamil published D11574: [web/native] improve rendering Tunnelbroker messages for review.
kamil published D11572: [web/native] display `userID` & `deviceID` in devtools for review.
Fri, Apr 5
Fri, Apr 5
kamil accepted D11538: [web] Persist userStore in db.
Could you extend the test plan to
- Add an unknown user to the friend list
- Block user
- Using two clients change the avatar on one and check if it gets synced on the other
Refreshing app multiple time between steps
Thu, Apr 4
Thu, Apr 4
kamil accepted D11541: Introduce fallback mechanism for notifications decryption if MMKV initialization hasn't been executed yet..
Looks good
Wed, Apr 3
Wed, Apr 3
kamil added inline comments to D11531: Reorder project.pbxproj after yarn cleaninstall.
kamil resigned from D11530: [scripts] Improve prompt.
LGTM but leaving final review to native speaker
Tue, Apr 2
Tue, Apr 2
kamil committed rCOMM934defb418ba: [native] update `olm` session creation code use `EncryptedData` (authored by kamil).
[native] update `olm` session creation code use `EncryptedData`
kamil committed rCOMM8b91ec580024: [web] update `olm` session creation code use `EncryptedData` (authored by kamil).
[web] update `olm` session creation code use `EncryptedData`