Paths

Table of Contentst

-
shared/comm-lib/
-
comm-lib/
-
Cargo.toml

Differential D13649

[comm-lib] Add missing feature dependency to Cargo.toml
ClosedPublic
Actions

Authored by bartek on Oct 9 2024, 1:28 AM.

Tags

None

Referenced Files

	F6081886: D13649.diff
	Sun, Apr 20, 9:29 PM

	Unknown Object (File)
	Sun, Apr 6, 9:08 AM

	Unknown Object (File)
	Mar 15 2025, 3:18 AM

	Unknown Object (File)
	Mar 12 2025, 1:42 PM

	Unknown Object (File)
	Mar 12 2025, 8:09 AM

	Unknown Object (File)
	Mar 12 2025, 3:18 AM

	Unknown Object (File)
	Mar 7 2025, 3:36 AM

	Unknown Object (File)
	Mar 5 2025, 8:30 PM

View All 51 Files

Subscribers

Details

Reviewers

varun
will
kamil

Commits

rCOMM4dd91d929b9c: [comm-lib] Add missing feature dependency to Cargo.toml

Summary

Noticed that this was missing and compilation failed for services with enabled blob-client feature, but disabled http feature.

Test Plan

cargo build -p comm-lib --all-features

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Oct 9 2024, 1:28 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 9 2024, 1:28 AM

bartek added a child revision: D13650: [identity] Add function to remove holders for devices.Oct 9 2024, 1:34 AM

Harbormaster completed remote builds in B32129: Diff 44999.Oct 9 2024, 2:02 AM

bartek published this revision for review.Oct 9 2024, 2:23 AM

kamil accepted this revision.Oct 10 2024, 2:28 AM

This revision is now accepted and ready to land.Oct 10 2024, 2:28 AM

Closed by commit rCOMM4dd91d929b9c: [comm-lib] Add missing feature dependency to Cargo.toml (authored by bartek). · Explain WhyOct 14 2024, 7:20 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM4dd91d929b9c: [comm-lib] Add missing feature dependency to Cargo.toml.

Revision Contents
Changeset List

Path

Size

shared/

comm-lib/

1 line

Diff 45163

shared/comm-lib/Cargo.toml

Loading...